Re: [libvirt] [PATCH 4/5] Publish the new Interface config API beginning with 0.6.4.

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 12:51:26PM -0400, Laine Stump wrote: > --- > src/libvirt_public.syms | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(-) ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind

Re: [libvirt] [PATCH 5/5] Use pkg_config in configure.in to detect presence of libnetcf and

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 12:51:27PM -0400, Laine Stump wrote: > From: Laine Stump > Looks fine, ACK ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization

Re: [libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 12:51:24PM -0400, Laine Stump wrote: > From: Laine Stump Okay, looks fine too, ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtuali

Re: [libvirt] [PATCH 1/5] Public API for new virInterface* functions, which facilitate

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 12:51:23PM -0400, Laine Stump wrote: > From: Laine Stump > > --- > include/libvirt/libvirt.h| 50 > ++ > include/libvirt/libvirt.h.in | 50 > ++ Looks just fine now, ACK, Daniel

[libvirt] [PATCH] lxc: use new error code in lxcDomainUndefine

2009-05-19 Thread Amy Griffis
Update lxcDomainUndefine() to use VIR_ERR_INVALID_OPERATION instead of VIR_ERR_INTERNAL_ERROR. Signed-off-by: Amy Griffis diff --git a/src/lxc_driver.c b/src/lxc_driver.c index 5392af1..64c735d 100644 --- a/src/lxc_driver.c +++ b/src/lxc_driver.c @@ -329,13 +329,13 @@ static int lxcDomainUndefi

Re: [libvirt] kvm migration

2009-05-19 Thread Łukasz Mierzwa
Dnia wtorek 19 maj 2009 o 22:20:06 Daniel P. Berrange napisał(a): > On Tue, May 19, 2009 at 09:29:15PM +0200, ??ukasz Mierzwa wrote: > > Hi, > > > > can someone explain me how migration works in libvirt? I got 2 machines > > with ubuntu 9.04 (libvirt 0.6.1 and kvm 84), disk images are stored on > >

Re: [libvirt] VMware ESX driver announcement

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 04:52:04PM +0200, Matthias Bolte wrote: > Hello, Hello Matthias, > I'm participate in a project of the Paderborn Center for Parallel > Computing, an institute of the University of Paderborn: > http://pc2.uni-paderborn.de > > The project's goal is to use virtualization i

Re: [libvirt] kvm migration

2009-05-19 Thread Daniel P. Berrange
On Tue, May 19, 2009 at 09:29:15PM +0200, ??ukasz Mierzwa wrote: > Hi, > > can someone explain me how migration works in libvirt? I got 2 machines with > ubuntu 9.04 (libvirt 0.6.1 and kvm 84), disk images are stored on nfs share > so > both machines can access them. When I run live migration (

Re: [libvirt] Re: virStorageVolLookupByPath fails with "libvir: Storage error : invalid storage volume pointer in no storage vol with matching path"

2009-05-19 Thread Daniel P. Berrange
On Tue, May 19, 2009 at 07:49:04PM +0200, Francesco Latino wrote: > Solved by myself -> I forget to define a storage pool ! Glad you figured it out [snip] > > > > conn = virConnectOpenReadOnly(NULL); > > path = "/guests/mydisk.img"; > > virStorageVolLookupByPath(conn,path); > > > > I got the err

[libvirt] kvm migration

2009-05-19 Thread Łukasz Mierzwa
Hi, can someone explain me how migration works in libvirt? I got 2 machines with ubuntu 9.04 (libvirt 0.6.1 and kvm 84), disk images are stored on nfs share so both machines can access them. When I run live migration (virsh migrate --live domain uri) my domain is migrated to second host but: 1.

[libvirt] Re: virStorageVolLookupByPath fails with "libvir: Storage error : invalid storage volume pointer in no storage vol with matching path"

2009-05-19 Thread Francesco Latino
Solved by myself -> I forget to define a storage pool ! Thanks a lot anyway ! On Tue, May 19, 2009 at 6:31 PM, Francesco Latino < francesco.lat...@gmail.com> wrote: > Hello, > > I have a running KVM virtual guest "demo1" with a defined disk at path > /guests/mydisk.img. > > But when I run > > co

[libvirt] PATCH: Test the QEMU argv -> XML convertor

2009-05-19 Thread Daniel P. Berrange
This patch adds a test case which validates the argv -> XML convertor for QEMU. This re-uses the existing XML data files from the XML -> argv test. This has a few complications though because we can't roundtrip all the data. So I have a couple really seriously evil regexes which splice out the XML

Re: [libvirt] PATCH: 4/5: The hard QEMU implementation

2009-05-19 Thread Daniel P. Berrange
On Wed, May 13, 2009 at 06:53:44PM +0200, Daniel Veillard wrote: > On Wed, May 13, 2009 at 03:40:54PM +0100, Daniel P. Berrange wrote: > > This provides the QEMU driver implementation which is able to convert > > from QEMU argv into domain XML. This is alot of hard code, because we > > have to pars

[libvirt] [PATCH 5/5] Use pkg_config in configure.in to detect presence of libnetcf and

2009-05-19 Thread Laine Stump
From: Laine Stump --- configure.in| 35 --- src/Makefile.am |5 + 2 files changed, 37 insertions(+), 3 deletions(-) diff --git a/configure.in b/configure.in index 8116fc8..420232a 100644 --- a/configure.in +++ b/configure.in @@ -28,6 +28,7 @@ GNUTLS

[libvirt] [PATCH 3/5] Implement RPC part of interface config API.

2009-05-19 Thread Laine Stump
--- qemud/remote.c | 235 qemud/remote_dispatch_args.h |8 + qemud/remote_dispatch_prototypes.h | 63 +++ qemud/remote_dispatch_ret.h|6 + qemud/remote_dispatch_table.h | 45 + qemud/remote_protocol.c|

[libvirt] [PATCH 2/5] First level of plumbing for virInterface*.

2009-05-19 Thread Laine Stump
From: Laine Stump --- include/libvirt/virterror.h |4 + src/datatypes.h | 25 ++ src/driver.h| 60 + src/libvirt.c | 607 +++ src/virterror.c | 21 ++ 5 files changed, 717 insertions(+),

[libvirt] [PATCH 4/5] Publish the new Interface config API beginning with 0.6.4.

2009-05-19 Thread Laine Stump
--- src/libvirt_public.syms | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms index 0ea130f..9ad73f3 100644 --- a/src/libvirt_public.syms +++ b/src/libvirt_public.syms @@ -264,6 +264,24 @@ LIBVIRT_0.6.3 {

[libvirt] [PATCH 1/5] Public API for new virInterface* functions, which facilitate

2009-05-19 Thread Laine Stump
From: Laine Stump --- include/libvirt/libvirt.h| 50 ++ include/libvirt/libvirt.h.in | 50 ++ 2 files changed, 100 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvi

[libvirt] [PATH 0/5] CORRECTED - Interface Config Public APIs and remote stubs, with MAC addresses in string format

2009-05-19 Thread Laine Stump
MY APOLOGIES! Yesterday I accidentally sent the old patchset rather than the corrected set. This time it's right. These patches are based on those I sent last week (the public virInterface*() API definition, the local plumbing, and the RPC glue), but with suggestions incorporated: 1) MAC address

[libvirt] virStorageVolLookupByPath fails with "libvir: Storage error : invalid storage volume pointer in no storage vol with matching path"

2009-05-19 Thread Francesco Latino
Hello, I have a running KVM virtual guest "demo1" with a defined disk at path /guests/mydisk.img. But when I run conn = virConnectOpenReadOnly(NULL); path = "/guests/mydisk.img"; virStorageVolLookupByPath(conn,path); I got the error " ibvir: Storage error : invalid storage volume pointer in no

[libvirt] [PATCH] cleanup of direct stderr logging

2009-05-19 Thread Daniel Veillard
In a number of places we still had direct output of logs, warnings or errors, instead of using the existing error and logging infrastructure. This patches tries to clean this up, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-19 Thread Ryota Ozaki
Apologies for not responding. I've come down with a cold (not flu) for several days... On Tue, May 19, 2009 at 10:34 PM, Daniel Veillard wrote: > On Mon, May 11, 2009 at 06:01:07PM +0900, Ryota Ozaki wrote: >> Hi, >> I've updated the patch. The change includes support for multiple mount >> points

[libvirt] Hyper-V driver advise request

2009-05-19 Thread Matthias Bolte
Hello, I mentioned Hyper-V in my last mail. We are currently investigating Hyper-V support for libvirt. Basically there seem to be two options: - use the DCE/RPC library from the Samba project for Hyper-V's WMI protocol - write a Windows based Hyper-V driver and use it from a Windows based libvir

Re: [libvirt] [PATCH] python: Better error reporting if 'import libvirtmod' fails

2009-05-19 Thread Cole Robinson
Daniel Veillard wrote: > On Mon, May 18, 2009 at 01:57:47PM -0400, Cole Robinson wrote: >> Don't squash a possibly legitimate libvirtmod error (e.g. some from >> clashing libvirt.so versions) with 'Cannot import cygvirtmod' > > Ah, right ! ACK ! > > Daniel > Thanks, I've pushed this along wit

Re: [libvirt] [PATCH v2 0/2] FS backend VolCreateXMLFrom implementation.

2009-05-19 Thread Cole Robinson
Daniel Veillard wrote: > On Mon, May 18, 2009 at 01:30:31PM -0400, Cole Robinson wrote: >> The following 2 patches implement virStorageVolCreateXMLFrom for the >> storage driver and the FS storage backend. >> >> Changes from v1: >> - Mark origvol as building in driver implementation >> - Make sure

Re: [libvirt] [RFC][PATCH] lxc: fix for ns cgroups subsystem

2009-05-19 Thread Daniel Veillard
On Mon, May 11, 2009 at 06:01:07PM +0900, Ryota Ozaki wrote: > Hi, > I've updated the patch. The change includes support for multiple mount > points of cgroups that I didn't cope with in the previous patch. > > Through the work, I found a bit messy problem. Current lxc controller writes > pid in a

Re: [libvirt] libvirt API to write sectors on a device

2009-05-19 Thread Francesco Latino
Great ! Thanks a lot ! On Tue, May 19, 2009 at 2:50 PM, Daniel Veillard wrote: > On Tue, May 19, 2009 at 02:39:04PM +0200, Francesco Latino wrote: > > Hello,***I am able to compile libvirt samples on my KVM hypervisor. (I > > edited and recompiled info.c code) > > *I am creating a sample code to

Re: [libvirt] libvirt API to write sectors on a device

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 02:39:04PM +0200, Francesco Latino wrote: > Hello,***I am able to compile libvirt samples on my KVM hypervisor. (I > edited and recompiled info.c code) > *I am creating a sample code to read/write disk devices. > With method *virDomainBlockPeek I can** read sectors from a gi

Re: [libvirt] PATCH: Work in progress suport for video device config

2009-05-19 Thread Pritesh Kothari
On Tuesday 19 May 2009 11:35:40 Daniel P. Berrange wrote: > We discussed adding a new XML element for representing video devices a > few weeks back. This is my work in progress patch for the XML parsing > routines supporting > > > > > > > For compatability, if an existing guest has a

Re: [libvirt] [PATCH] Fix rpm build: add 'mylibtool' to EXTRADIST.

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 01:57:54PM -0400, Cole Robinson wrote: > --- > Makefile.am |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 7a3438e..681034a 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -19,7 +19,8 @@ EXTRA_DIST = \ >

Re: [libvirt] [PATCH] Generate some config files at build time, not install time.

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 01:57:53PM -0400, Cole Robinson wrote: > Generating at install time breaks 'make && sudo make install' if root > can't access the users home directory (NFS w/ norootsquash for example). ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft

Re: [libvirt] [PATCH] Fix a possible deadlock in HAL nodedev driver.

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 01:57:51PM -0400, Cole Robinson wrote: > The cap_lost and prop_modified callbacks could deadlock if an existing > device needed to be refreshed, since dev_create expects the driver to > be unlocked. Looks fine, ACK, thanks ! Daniel -- Daniel Veillard | libxml Gnom

[libvirt] libvirt API to write sectors on a device

2009-05-19 Thread Francesco Latino
Hello,***I am able to compile libvirt samples on my KVM hypervisor. (I edited and recompiled info.c code) *I am creating a sample code to read/write disk devices. With method *virDomainBlockPeek I can** read sectors from a given device attached to a KVM virtual guest.**I am not able to* find an API

Re: [libvirt] [PATCH] Add documentation for device XML format.

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 01:57:50PM -0400, Cole Robinson wrote: > --- > docs/formatdomain.html| 20 > docs/formatdomain.html.in | 24 > 2 files changed, 44 insertions(+), 0 deletions(-) Excellent, thanks ! Daniel -- Daniel Veillard |

Re: [libvirt] [PATCH] Use virAsprintf, rather than VIR_ALLOC + strcpy + strcat

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 01:57:49PM -0400, Cole Robinson wrote: > --- > qemud/remote.c|9 - > src/remote_internal.c |7 ++- > src/storage_backend.c |9 +++-- > src/storage_backend_fs.c | 29 + > src/stora

Re: [libvirt] [PATCH] Don't validate disk type in virsh attach-disk

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 08:04:18PM +0100, Daniel P. Berrange wrote: > On Mon, May 18, 2009 at 01:57:48PM -0400, Cole Robinson wrote: > > Let the underlying driver tell us what it supports. At the moment > > we are at least erroneously denying floppy eject/insert. > > > > Last time I posted this, i

Re: [libvirt] [PATCH] python: Better error reporting if 'import libvirtmod' fails

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 01:57:47PM -0400, Cole Robinson wrote: > Don't squash a possibly legitimate libvirtmod error (e.g. some from > clashing libvirt.so versions) with 'Cannot import cygvirtmod' Ah, right ! ACK ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft

Re: [libvirt] [PATCH v2 0/2] FS backend VolCreateXMLFrom implementation.

2009-05-19 Thread Daniel Veillard
On Mon, May 18, 2009 at 01:30:31PM -0400, Cole Robinson wrote: > The following 2 patches implement virStorageVolCreateXMLFrom for the > storage driver and the FS storage backend. > > Changes from v1: > - Mark origvol as building in driver implementation > - Make sure driver is locked when relockin

Re: [libvirt] PATCH: Work in progress suport for video device config

2009-05-19 Thread Daniel Veillard
On Tue, May 19, 2009 at 10:35:40AM +0100, Daniel P. Berrange wrote: > We discussed adding a new XML element for representing video devices a > few weeks back. This is my work in progress patch for the XML parsing > routines supporting > > > > > > > For compatability, if an existing

[libvirt] PATCH: Work in progress suport for video device config

2009-05-19 Thread Daniel P. Berrange
We discussed adding a new XML element for representing video devices a few weeks back. This is my work in progress patch for the XML parsing routines supporting For compatability, if an existing guest has a tag, but no tag, then the parser automatically adds a tag for type=cirru

Re: [libvirt] [PATCH v2 2/2] VolumeCreateXMLFrom FS storage backend implementation.

2009-05-19 Thread Daniel P. Berrange
On Mon, May 18, 2009 at 01:30:33PM -0400, Cole Robinson wrote: > Add an extra 'inputvol' parameter to the file volume building routines. This > allows us to easily reuse the duplicate functionality. ACK Now you just have to implement it for LVM, and disk partitions too ;-P Daniel -- |: Red Hat,

Re: [libvirt] [PATCH v2 1/2] Storage driver implementation for CreateXMLFrom

2009-05-19 Thread Daniel P. Berrange
On Mon, May 18, 2009 at 01:30:32PM -0400, Cole Robinson wrote: > There is some funkiness here, since we are either dealing with 2 different > pools (which means validation x 2) or the same pool, where we have to be > careful not to deadlock. ACK, this looks good now. Daniel -- |: Red Hat, Engin