Re: [libvirt] [PATCH] Fix FS volume creation with backing stores.

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 06:11:08PM -0400, Cole Robinson wrote: This regressed when CreateXMLFrom was added: we should only perform the backing store comparison if an input volume was passed. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/storage_backend_fs.c |5 +++-- 1

Re: [libvirt] [PATCH] Add virCapabilities*EmulatorRequired.

2009-06-16 Thread Daniel Veillard
On Mon, Jun 15, 2009 at 06:11:06PM -0400, Cole Robinson wrote: Certain drivers always need an 'emulator' specified in the XML (qemu and lxc at least). Store this info in capabilities. yes this makes sense ! We will eventually use this to move default emulator handling out of drivers and

Re: [libvirt] [PATCH] Allow USB hostdev product to be 0x0000

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 06:11:09PM -0400, Cole Robinson wrote: Product = 0 is a valid value based on this bug report: https://www.redhat.com/archives/libvir-list/2009-May/msg00368.html Signed-off-by: Cole Robinson crobi...@redhat.com --- src/domain_conf.c

Re: [libvirt] [PATCH] Set default emulator in domain_conf.*, rather than the driver.

2009-06-16 Thread Daniel Veillard
On Mon, Jun 15, 2009 at 06:11:07PM -0400, Cole Robinson wrote: Rather than numerous instances of: emulator = vm-def-emulator; if (!emulator) emulator = virDomainDefDefaultEmulator(conn, vm-def, driver-caps); if (!emulator) return -1; Set this value at XML parse time in the

Re: [libvirt] virDomainDefineXML forbidden for read only access

2009-06-16 Thread Kenneth Nagin
Daniel P. Berrange berra...@redhat.com wrote on 15/06/2009 22:27:20: On Mon, Jun 15, 2009 at 11:56:04AM +0300, Kenneth Nagin wrote: I am running an application that invokes the java method virDomainDefineXML. But virDomainDefineXML is throwing the exception forbidden for read only

Re: [libvirt] [PATCH] Allow USB hostdev product to be 0x0000

2009-06-16 Thread Daniel Veillard
On Mon, Jun 15, 2009 at 06:11:09PM -0400, Cole Robinson wrote: Product = 0 is a valid value based on this bug report: https://www.redhat.com/archives/libvir-list/2009-May/msg00368.html Looks fine, ACK. I was wondering about the vendor ID but apparently nobody uses 0

Re: [libvirt] [PATCH] Fix FS volume creation with backing stores.

2009-06-16 Thread Daniel Veillard
On Mon, Jun 15, 2009 at 06:11:08PM -0400, Cole Robinson wrote: This regressed when CreateXMLFrom was added: we should only perform the backing store comparison if an input volume was passed. ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/

[libvirt] Xen: How to describe bridged network adapter in libvirt-XML?

2009-06-16 Thread Andreas Sommer
Hi, I'm looking for a solution to convert the Xen configuration line vif = [bridge=eth0] to the libvirt XML description format which can be used by the createLinux() function (using Python). I tried several things like interface type=bridge source bridge=eth0 / target dev=eth0 /

Re: [libvirt] [PATCH] Add qemuhelptest to .gitignore

2009-06-16 Thread Cole Robinson
On 06/16/2009 05:33 AM, Daniel P. Berrange wrote: On Mon, Jun 15, 2009 at 06:11:04PM -0400, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) ACK, but don't modify .gitignore files

[libvirt] Future release schedule

2009-06-16 Thread Daniel Veillard
I realize I forgot to post any plan on the topic, oops ! I guess we should shoot for another release around the end of the month, Friday is a good day for release and freezes, and since I didn't gave any heads-up, the best is to shoot for a July 3rd release, which mean we would enter the freeze

Re: [libvirt] Xen: How to describe bridged network adapter in libvirt-XML?

2009-06-16 Thread Andreas Sommer
Fortunately I found the problem myself. Maybe I should use schema checking from now on, because I put the interface element outside devices by mistake... A small tip: virsh dumpxml is very good for finding out the configuration of Xen domains. Regards Andreas Hi, I'm looking for a

Re: [libvirt] Xen: How to describe bridged network adapter in libvirt-XML?

2009-06-16 Thread Daniel P. Berrange
On Tue, Jun 16, 2009 at 03:29:48PM +0100, Andreas Sommer wrote: Fortunately I found the problem myself. Maybe I should use schema checking from now on, because I put the interface element outside devices by mistake... A small tip: virsh dumpxml is very good for finding out the

[libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Amy Griffis
The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I added a new function to the internal API, virLogParseDefaultPriority() along the lines of the other parse functions. Signed-off-by: Amy Griffis

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Cole Robinson
On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I added a new function to the internal API, virLogParseDefaultPriority() along the lines of the other

Re: [libvirt] [PATCH] Allow USB hostdev product to be 0x0000

2009-06-16 Thread Cole Robinson
On 06/16/2009 05:54 AM, Daniel Veillard wrote: On Mon, Jun 15, 2009 at 06:11:09PM -0400, Cole Robinson wrote: Product = 0 is a valid value based on this bug report: https://www.redhat.com/archives/libvir-list/2009-May/msg00368.html Looks fine, ACK. I was wondering about the vendor ID but

Re: [libvirt] [PATCH] Fix qemu command flags fetching

2009-06-16 Thread Cole Robinson
On 06/16/2009 05:38 AM, Daniel Veillard wrote: On Mon, Jun 15, 2009 at 06:11:03PM -0400, Cole Robinson wrote: New function qemudParseHelpStr was being called with arguments in the wrong order, so command flags == kvm_version :/ Urgh ! ACK ! Daniel Thanks, I've pushed this, and the

[libvirt] [RFC] Reporting host interface status/statistics via netcf/libvirt, and listing active vs. inactive interfaces

2009-06-16 Thread Laine Stump
I've already been working on incorporating physical host interface configuration into libvirt by way of using libnetcf on the backend. It's becoming apparent that, in addition to modifying and reporting the current configuration of interfaces, libvirt users also want to query current status of

[libvirt] Re: Future release schedule

2009-06-16 Thread Matthias Bolte
2009/6/16 Daniel Veillard veill...@redhat.com:  One thing I wonder is about progresses on the ESX driver front, it was looking fairly close to be commiteable, basically only XML import/export was needed but I didnt see any news recently, Matthias do you have a schedule for that missing part ?

[libvirt] Re: Future release schedule

2009-06-16 Thread Daniel Veillard
On Tue, Jun 16, 2009 at 09:18:40PM +0200, Matthias Bolte wrote: 2009/6/16 Daniel Veillard veill...@redhat.com:  One thing I wonder is about progresses on the ESX driver front, it was looking fairly close to be commiteable, basically only XML import/export was needed but I didnt see any news

[libvirt] Undefined symbol: virNodeDeviceWaitForDevices

2009-06-16 Thread Matthias Bolte
Hi, GIT commit f7b12afc7b67b6727151f74683e7cb9d6fc2b36f adds a new function: virNodeDeviceWaitForDevices In storage_backend.c virStorageBackendWaitForDevices was changed to call virNodeDeviceWaitForDevices, but the code for virNodeDeviceWaitForDevices is only compiled and linked into libvirtd if

Re: [libvirt] Undefined symbol: virNodeDeviceWaitForDevices

2009-06-16 Thread Dave Allan
Matthias Bolte wrote: Hi, GIT commit f7b12afc7b67b6727151f74683e7cb9d6fc2b36f adds a new function: virNodeDeviceWaitForDevices In storage_backend.c virStorageBackendWaitForDevices was changed to call virNodeDeviceWaitForDevices, but the code for virNodeDeviceWaitForDevices is only compiled and

Re: [libvirt] Undefined symbol: virNodeDeviceWaitForDevices

2009-06-16 Thread Matthias Bolte
2009/6/16 Dave Allan dal...@redhat.com: Matthias Bolte wrote: Hi, GIT commit f7b12afc7b67b6727151f74683e7cb9d6fc2b36f adds a new function: virNodeDeviceWaitForDevices In storage_backend.c virStorageBackendWaitForDevices was changed to call virNodeDeviceWaitForDevices, but the code for

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Amy Griffis
Cole Robinson wrote: [Tue Jun 16 2009, 02:44:28PM EDT] On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I added a new function to the internal API,

Re: [libvirt] [PATCH] Fix logging in libvirt_lxc controller

2009-06-16 Thread Cole Robinson
On 06/16/2009 06:12 PM, Amy Griffis wrote: Cole Robinson wrote: [Tue Jun 16 2009, 02:44:28PM EDT] On 06/16/2009 01:35 PM, Amy Griffis wrote: The lxc controller can't see libvirtd's log level setting so it needs to re-query it from the environment. The parsing code has a few users now, so I

Re: [libvirt] [PATCH] Add virsh commands for virInterface* functions.

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 10:56:41PM -0400, Laine Stump wrote: +vshPrintExtra(ctl, %-20s %-30s\n, _(Name), _(MAC Address)); +vshPrintExtra(ctl, --\n); + +for (i = 0; i ifCount; i++) { +virInterfacePtr iface =

Re: [libvirt] [PATCH] Fix qemu command flags fetching

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 06:11:03PM -0400, Cole Robinson wrote: New function qemudParseHelpStr was being called with arguments in the wrong order, so command flags == kvm_version :/ Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu_conf.c |2 +- 1 files changed, 1

Re: [libvirt] [PATCH] Add qemuhelptest to .gitignore

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 06:11:04PM -0400, Cole Robinson wrote: Signed-off-by: Cole Robinson crobi...@redhat.com --- tests/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) ACK, but don't modify .gitignore files yourself. Change the .cvsignore file and then run 'make

Re: [libvirt] [PATCH] Check that '-drive format=' is supported before adding to qemu cmdline.

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 06:11:05PM -0400, Cole Robinson wrote: Qemu 0.10.0 did not support it, and virt-* tools now try to add this by default, so it's extra important we ensure the option exists. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu_conf.c |5 -

Re: [libvirt] [PATCH] Add virCapabilities*EmulatorRequired.

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 06:11:06PM -0400, Cole Robinson wrote: Certain drivers always need an 'emulator' specified in the XML (qemu and lxc at least). Store this info in capabilities. We will eventually use this to move default emulator handling out of drivers and into domain_conf.*

Re: [libvirt] [PATCH] Set default emulator in domain_conf.*, rather than the driver.

2009-06-16 Thread Daniel P. Berrange
On Mon, Jun 15, 2009 at 06:11:07PM -0400, Cole Robinson wrote: Rather than numerous instances of: emulator = vm-def-emulator; if (!emulator) emulator = virDomainDefDefaultEmulator(conn, vm-def, driver-caps); if (!emulator) return -1; Set this value at XML parse time in the