Re: [libvirt] [PATCH] avoid dumpXML segfault with recent Xen (3.4.0)

2009-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2009 at 08:21:39PM +0200, Daniel Veillard wrote: > This is basically the patch by Sascha at > https://bugzilla.redhat.com/show_bug.cgi?id=503254 > with a couple of cleanups. I think it's low risk, and avoid a crash so I > commited it. > Basically ths SXPR syntax changed from (

Re: [libvirt] [PATCH 3/5] disk geometry

2009-06-26 Thread Daniel Veillard
On Fri, Jun 26, 2009 at 08:23:02PM +0200, Matthias Bolte wrote: > 2009/6/25 Daniel P. Berrange : > > On Wed, Jun 24, 2009 at 11:17:49AM +0200, Henrik Persson wrote: > >> Reads the disk geometry to be able to align disk partitions on cylinder > >> boundries. > >> Msdos partition tables really like

[libvirt] [PATCH] don't break on libnuma failures

2009-06-26 Thread Daniel Veillard
Another patch hanging in bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=506590 sometimes libnuma can't handle some topologies, but those failures should not completely break libvirt, patch by Dan Berrange. Look sane to me, fixes the main problem for the reporter, so I applied and commi

Re: [libvirt] [PATCH 3/5] disk geometry

2009-06-26 Thread Matthias Bolte
2009/6/25 Daniel P. Berrange : > On Wed, Jun 24, 2009 at 11:17:49AM +0200, Henrik Persson wrote: >> Reads the disk geometry to be able to align disk partitions on cylinder >> boundries. >> Msdos partition tables really like this stuff. >> +    /* return the geometry of the disk and then exit */ >

[libvirt] [PATCH] avoid dumpXML segfault with recent Xen (3.4.0)

2009-06-26 Thread Daniel Veillard
This is basically the patch by Sascha at https://bugzilla.redhat.com/show_bug.cgi?id=503254 with a couple of cleanups. I think it's low risk, and avoid a crash so I commited it. Basically ths SXPR syntax changed from (type vnc) to (vnc 1) for VNC vfb devices, and assuming something similar fo

Re: [libvirt] [PATCH 0/5] Create storage volumes with disk backend

2009-06-26 Thread Daniel Veillard
On Wed, Jun 24, 2009 at 11:10:18AM +0200, Henrik Persson wrote: > Hi, > > These patches make it possible to create storage volumes when having a disk > as backend. > As sent in earlier mail, it does not handle LVM and RAID partition currently. Okay, with the updated patch 5 the series looks c

[libvirt] unchecked malloc+syscall uses

2009-06-26 Thread Jim Meyering
I was looking through recent changes and spotted two potential NULL-dereferences in this change set: http://git.et.redhat.com/?p=libvirt.git;a=commitdiff;h=70c01b4c1adea75e9 In src/opennebula/one_client.c: +one_client.url=(char *)malloc(64); +snprintf(one_client.url, 63, "http://loca

Re: [libvirt] [PATCH] Don't disable all logging with --disable-debug

2009-06-26 Thread Daniel Veillard
On Thu, Jun 25, 2009 at 04:13:28PM -0400, Amy Griffis wrote: > This patch changes the automake conditional for debugging to > disable only the debug output, not the entire logging module. > Since the logging symbols are always visible now, I moved them to > libvirt_private.syms and got rid of libvi

Re: [libvirt] [PATCH 1/1] Fix bogus WWNs

2009-06-26 Thread Daniel Veillard
On Fri, Jun 26, 2009 at 10:55:16AM +0100, Daniel P. Berrange wrote: > On Thu, Jun 25, 2009 at 11:20:24AM -0400, David Allan wrote: > > --- > > src/node_device.c | 34 +++ > > src/node_device_hal.h |4 + > > src/node_device_hal_linux.c | 134 > > +

Re: [libvirt] virStorageVolCreateXMLFrom

2009-06-26 Thread Cole Robinson
Kenneth Nagin wrote: > >> "Daniel P. Berrange" wrote on 22/06/2009 12:08:39: > >> On Mon, Jun 22, 2009 at 09:59:00AM +0300, Kenneth Nagin wrote: >>> I'd like to get a better understanding of the > virStorageVolCreateXMLFrom >>> api Its name and signature imply that it is a cloning operation that

[libvirt] [PATCH 5/5] create storage volumes, take 2

2009-06-26 Thread Henrik Persson
Here is a updated patch that defines a enum for mapping parition code to parted's fs-type. /Henrik --- libvirt-0.6.4.patches/src/storage_conf.h 2009-06-23 18:05:39.054877000 +0200 +++ libvirt-0.6.4/src/storage_conf.h 2009-06-25 18:24:46.374696000 +0200 @@ -460,4 +460,22 @@ enum virStorageVolTypeD

Re: [libvirt] [PATCH] For comment/critique only - netcf backend for virInterface*.

2009-06-26 Thread Daniel P. Berrange
On Tue, Jun 23, 2009 at 02:08:29PM -0400, Laine Stump wrote: > This is the backend for the interface driver (virInterface*()) that > uses netcf. There are a few issues with it: > > 1) It doesn't yet implement the backend for >virConnectListDefinedInterfaces() and >virConnectNumOfDefinedInt

RE: [libvirt] [PATCH] Do a correct format mapping of partitions 2

2009-06-26 Thread Henrik Persson E
I checked the SLES package and it is a patch that they have added themselves :( I will look into it to see if parted provides a better way to get the same information. /Henrik > -Original Message- > From: Daniel Veillard [mailto:veill...@redhat.com] > Sent: den 25 juni 2009 16:31 > To:

Re: [libvirt] VMware ESX driver status update

2009-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 05:26:45PM +0200, Daniel Veillard wrote: > > One problem here is the essential guestOS field of the VMX config, see > > http://sanbarrow.com/vmx/vmx-guestos.html . For a first try I would > > set it to 'other' by default, because there is currently no field > > available in

Re: [libvirt] VMware ESX driver status update

2009-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 12:11:26PM +0200, Matthias Bolte wrote: > I claimed before that I would need to read most information needed for > dump XML from the VMX config file. That's not true. Possibly all > information can be retrieved via VI API, but the information is > scattered in various places

Re: [libvirt] [PATCH] Don't disable all logging with --disable-debug

2009-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 04:13:28PM -0400, Amy Griffis wrote: > This patch changes the automake conditional for debugging to > disable only the debug output, not the entire logging module. > Since the logging symbols are always visible now, I moved them to > libvirt_private.syms and got rid of libvi

Re: [libvirt] [PATCH 1/1] Fix bogus WWNs

2009-06-26 Thread Daniel P. Berrange
On Thu, Jun 25, 2009 at 11:20:24AM -0400, David Allan wrote: > --- > src/node_device.c | 34 +++ > src/node_device_hal.h |4 + > src/node_device_hal_linux.c | 134 > +-- > 3 files changed, 104 insertions(+), 68 deletions(-) A

Re: [libvirt] vTPM support in libvirt

2009-06-26 Thread Daniel P. Berrange
On Fri, Jun 26, 2009 at 09:30:53AM +0100, Andreas Sommer wrote: > I made some changes to the code and would like to try it out by > installing libvirt. As you said, there's an example on how to build and > install it, but how do I need to configure it in order to get it > installed on my system

Re: [libvirt] vTPM support in libvirt

2009-06-26 Thread Andreas Sommer
I made some changes to the code and would like to try it out by installing libvirt. As you said, there's an example on how to build and install it, but how do I need to configure it in order to get it installed on my system and not in some $HOME directory?? Yesterday I tried ./configure make m