Re: [libvirt] [PATCH 1/1] Fix pool create when pool already exists.

2009-07-01 Thread Daniel Veillard
On Tue, Jun 30, 2009 at 10:32:45PM +0100, Daniel P. Berrange wrote: On Tue, Jun 30, 2009 at 04:22:38PM -0400, David Allan wrote: * src/storage_driver.c: don't call virStoragePoolObjRemove when a pool create call fails because the pool already exists. --- src/storage_driver.c |2 ++

Re: [libvirt] [PATCH 0/1] Fix pool create when pool already exists

2009-07-01 Thread Daniel Veillard
On Tue, Jun 30, 2009 at 04:22:37PM -0400, David Allan wrote: When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys the existing pool. This patch fixes the problem. Hum, I tried to assert the level of damage this bug generates and I have been

Re: [libvirt] [PATCH] logging: remove unused level 0

2009-07-01 Thread Daniel Veillard
On Tue, Jun 30, 2009 at 05:49:03PM -0400, Amy Griffis wrote: Some more logging cleanup. Remove all references to log level 0, and replace with VIR_LOG_DEBUG where appropriate. Also change any hard numbers to the corresponding VirLogPriority and add VIR_LOG_DEFAULT for the starting log level.

Re: [libvirt] [PATCH 0/1] Fix pool create when pool already exists

2009-07-01 Thread Daniel P. Berrange
On Wed, Jul 01, 2009 at 11:02:08AM +0200, Daniel Veillard wrote: On Tue, Jun 30, 2009 at 04:22:37PM -0400, David Allan wrote: When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys the existing pool. This patch fixes the problem. Hum, I tried to

Re: [libvirt] [PATCH] logging: remove unused level 0

2009-07-01 Thread Daniel P. Berrange
On Tue, Jun 30, 2009 at 05:49:03PM -0400, Amy Griffis wrote: Some more logging cleanup. Remove all references to log level 0, and replace with VIR_LOG_DEBUG where appropriate. Also change any hard numbers to the corresponding VirLogPriority and add VIR_LOG_DEFAULT for the starting log level.

Re: [libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages

2009-07-01 Thread Daniel P. Berrange
On Tue, Jun 30, 2009 at 03:28:45PM +0200, Abel M?guez Rodr?guez wrote: Hi, this patch uses OPERATION_INVALID error instead OPERATION_FAILED error where should be used, also adds a missing capability, defining Xen i686 domains. Thanks for the patches, --- one_driver.c.bak   

[libvirt] Upcoming 0.6.5 release and switching the main SCM engine (to git)

2009-07-01 Thread Daniel Veillard
A couple of things I wanted to raise. - First we have a release 0.6.5 at the end of the week, so we are in bug fix mode, it would be good if people could make a round of testing of the latest CVS/git version or the snapshot at ftp://libvirt.org/libvirt/libvirt-cvs-snapshot.tar.gz The

Re: [libvirt] [PATCH] Power Hypervisor Support for libvirt - minimum set of features

2009-07-01 Thread Daniel P. Berrange
On Mon, Jun 29, 2009 at 04:11:20PM -0300, Eduardo Otubo wrote: Hello Daniel, I might be missing something, but this database doesn't appear to be persistent at all - it just lives for the duration of the virConnectPtr object's lifetime. So if you create two connections you'd get two

Re: [libvirt] Upcoming 0.6.5 release and switching the main SCM engine (to git)

2009-07-01 Thread Garry Dolley
On Wed, Jul 01, 2009 at 11:54:38AM +0200, Daniel Veillard wrote: Feedback and opinions welcome, I hope git is not too uncontroversial :-) +1 on the move to git, awesome :) I was using the git mirror previously, and would worry a bit whether it is 100% up-to-date. Now I won't have to

Re: [libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages

2009-07-01 Thread Daniel Veillard
On Tue, Jun 30, 2009 at 03:28:45PM +0200, Abel Míguez Rodríguez wrote: Hi, this patch uses OPERATION_INVALID error instead OPERATION_FAILED error where should be used, also adds a missing capability, defining Xen i686 domains. Tha patch makes sense, but I don't know what combination

Re: [libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages

2009-07-01 Thread Daniel Veillard
On Wed, Jul 01, 2009 at 12:42:15PM +0200, Daniel Veillard wrote: On Tue, Jun 30, 2009 at 03:28:45PM +0200, Abel Míguez Rodríguez wrote: Hi, this patch uses OPERATION_INVALID error instead OPERATION_FAILED error where should be used, also adds a missing capability, defining Xen i686

Re: [libvirt] [PATCH] logging: remove unused level 0

2009-07-01 Thread Daniel Veillard
On Wed, Jul 01, 2009 at 10:45:26AM +0100, Daniel P. Berrange wrote: On Tue, Jun 30, 2009 at 05:49:03PM -0400, Amy Griffis wrote: Some more logging cleanup. Remove all references to log level 0, and replace with VIR_LOG_DEBUG where appropriate. Also change any hard numbers to the

Re: [libvirt] [PATCH 0/1] Fix pool create when pool already exists

2009-07-01 Thread Daniel Veillard
On Wed, Jul 01, 2009 at 10:23:45AM +0100, Daniel P. Berrange wrote: On Wed, Jul 01, 2009 at 11:02:08AM +0200, Daniel Veillard wrote: On Tue, Jun 30, 2009 at 04:22:37PM -0400, David Allan wrote: When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys

Re: [libvirt] PATCH : Opennebula, adding xen i686 domain capability and updating some error messages

2009-07-01 Thread Abel Míguez Rodríguez
On Wed, Jul 01, 2009 at 12:42:15PM +0200, Daniel Veillard wrote: On Tue, Jun 30, 2009 at 03:28:45PM +0200, Abel Míguez Rodríguez wrote: Hi, this patch uses OPERATION_INVALID error instead OPERATION_FAILED error where should be used, also adds a missing capability, defining Xen

[libvirt] While connecting through xen+ssh, virConnectClose doesn't close the connection

2009-07-01 Thread Alexandru Nedelcu
Hi, I'm trying to create a Perl script with Sys::Virt (perl bindings). I'm also using Virsh for testing / experimenting, so this is in no way related to my Perl script (I mentioned it because there might be a sollution that I could use / implement). When connecting to libvirtd using a xen+ssh//

[libvirt] PATCH : Opennebula documentation

2009-07-01 Thread Abel Míguez Rodríguez
Hi, Attached is the OpenNebula driver documentation and a patch. The main Documentation file is drvone.html.in along with it a patch that includes: the API supported by the driver, an entry at DocumentationDrivers and a link to the documentation at drivers.hmtl.in Thanks ---

Re: [libvirt] [PATCH 0/1] Fix pool create when pool already exists

2009-07-01 Thread Dave Allan
Daniel P. Berrange wrote: On Wed, Jul 01, 2009 at 11:02:08AM +0200, Daniel Veillard wrote: On Tue, Jun 30, 2009 at 04:22:37PM -0400, David Allan wrote: When storagePoolCreate is called to define a pool that already exists, it mistakenly destroys the existing pool. This patch fixes the problem.

Re: [libvirt] PATCH : Opennebula documentation

2009-07-01 Thread Daniel Veillard
On Wed, Jul 01, 2009 at 03:10:23PM +0200, Abel Míguez Rodríguez wrote: Hi, Attached is the OpenNebula driver documentation and a patch. The main Documentation file is drvone.html.in along with it a patch that includes: the API supported by the driver, an entry at DocumentationDrivers and a

[libvirt] fix for crash in NPIV code

2009-07-01 Thread Dave Allan
DV found a place in the NPIV code that was freeing the wrong thing in the error case causing a segfault. The patch to fix it follows. Dave diff --git a/src/node_device.c b/src/node_device.c index cd9f0ef..c5b839b 100644 --- a/src/node_device.c +++ b/src/node_device.c @@ -489,8 +489,8 @@

[libvirt] libvirt 0.6.4: Confusing error message during virDomainRestore() if network not started

2009-07-01 Thread Charles Duffy
Howdy, 'yall -- I found myself scratching my head for a few minutes trying to start a VM image via virDomainRestore(). Looking through the header definition in the XML, it read as follows: interface type=network mac address=00:15:3d:49:ec:0e/ source network=fvte-MIXED-DEFAULT/

Re: [libvirt] PATCH : Opennebula documentation

2009-07-01 Thread Ruben S. Montero
Hi Thanks for the comments!!!. Regarding EC2: (Short Background). In OpenNebula, a domain can be defined with a local set of images (DISKS) and with their EC2 counterparts (AMIs). So depending on your requirements and the status of your cluster the OpenNebula scheduler may decide to deploy the

[libvirt] PATCH: Opennebula Documentation updates

2009-07-01 Thread Abel Míguez Rodríguez
Hi, here are some changes to apply at the ONE Documentation, Thanks Abel Miguez Rodriguez Distributed System Architecture Group  (http://dsa-research.org) GridWay, http://www.gridway.org OpenNEbula, http://www.opennebula.org --- drvone.html.in.bak 2009-07-01 20:01:45.0

[libvirt] [PATCH] Fix node dumpxml infinite loop

2009-07-01 Thread Cole Robinson
With current git, doing: 'virsh nodedev-dumpxml computer' locks up the daemon. The list iteration in update_caps was only happening conditionally: if that condition wasn't met, we loop forever. - Cole diff --git a/src/node_device.c b/src/node_device.c index cd9f0ef..e0aaefc 100644 ---

Re: [libvirt] [PATCH] Fix node dumpxml infinite loop

2009-07-01 Thread Dave Allan
Cole Robinson wrote: With current git, doing: 'virsh nodedev-dumpxml computer' locks up the daemon. The list iteration in update_caps was only happening conditionally: if that condition wasn't met, we loop forever. Thanks for catching that. ACK. Dave -- Libvir-list mailing list

Re: [libvirt] fix for crash in NPIV code

2009-07-01 Thread Daniel Veillard
On Wed, Jul 01, 2009 at 11:23:53AM -0400, Dave Allan wrote: DV found a place in the NPIV code that was freeing the wrong thing in the error case causing a segfault. The patch to fix it follows. ACK from me of course, it really solved a daemon crash for me. Daniel -- Daniel Veillard

Re: [libvirt] PATCH: Opennebula Documentation updates

2009-07-01 Thread Daniel Veillard
On Wed, Jul 01, 2009 at 08:08:11PM +0200, Abel Míguez Rodríguez wrote: Hi, here are some changes to apply at the ONE Documentation, Thanks I suggest you install the xhtml1-dtds package (or equivalent this is on Fedora), after applying the patch rebuilding brings the following set of errors:

Re: [libvirt] [PATCH] Fix node dumpxml infinite loop

2009-07-01 Thread Daniel Veillard
On Wed, Jul 01, 2009 at 04:19:09PM -0400, Cole Robinson wrote: With current git, doing: 'virsh nodedev-dumpxml computer' locks up the daemon. The list iteration in update_caps was only happening conditionally: if that condition wasn't met, we loop forever. Ouch, right, clearly a bug !

[libvirt] Patch to include arm variants in virsh capabilities

2009-07-01 Thread C.J. Adams-Collier
Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes.

[libvirt] Patch to include arm variants in virsh capabilities

2009-07-01 Thread C.J. Adams-Collier
Hey folks, I got an android and wanted to set up an armel debian vm to test out some code. I had to launch it directly with qemu-system-arm, though, since virsh didn't have an arm option to select. This is a patch against the debian version of the source after applying debian-specific changes.

Re: [libvirt] vTPM support in libvirt

2009-07-01 Thread Andreas Sommer
I'm still experimenting around with the vTPM patch, and I want to install my version of libvirt on a Debian system - not in my $HOME directory but on the default paths. I followed the autogen command below and also did make install, but now virsh for example searches for the certificates in

Re: [libvirt] vTPM support in libvirt

2009-07-01 Thread C.J. Adams-Collier
Hey Andreas, $ apt-get source libvirt0 $ cd libvirt-* Copy your patch to debian/patches/foo.patch (no, not literally foo) and then run $ sudo apt-get build-dep libvirt0 debuild -uc -us when it's done there will be a few .deb files in ../ Cheers, C.J. On Wed, 2009-07-01 at 22:58 +0100,