On Tue, Aug 18, 2009 at 04:39:32PM +0100, Daniel P. Berrange wrote:
> On Tue, Aug 18, 2009 at 11:03:44AM +0200, Daniel Veillard wrote:
> > On Mon, Aug 17, 2009 at 06:12:55PM +0100, Daniel P. Berrange wrote:
> > [...]
> > > +if (disk->serial)
> > > +virBufferVSprintf(&opt
On Tue, Aug 18, 2009 at 11:03:44AM +0200, Daniel Veillard wrote:
> On Mon, Aug 17, 2009 at 06:12:55PM +0100, Daniel P. Berrange wrote:
> [...]
> > +if (disk->serial)
> > +virBufferVSprintf(&opt, ",serial=%s", disk->serial);
>
>Sounds fine, just that if the content i
On Tue, Aug 18, 2009 at 03:16:30PM +0100, Mark McLoughlin wrote:
> On Tue, 2009-08-18 at 16:00 +0200, Daniel Veillard wrote:
> > On Tue, Aug 18, 2009 at 02:17:46PM +0100, Mark McLoughlin wrote:
> > [...]
> > > +virReportSystemError(conn, err,
> >
> > just add "%s", on that line :-)
>
On Tue, 2009-08-18 at 16:00 +0200, Daniel Veillard wrote:
> On Tue, Aug 18, 2009 at 02:17:46PM +0100, Mark McLoughlin wrote:
> [...]
> > +virReportSystemError(conn, err,
>
> just add "%s", on that line :-)
>
> > + _("Failed to add tap interface to bri
On Tue, Aug 18, 2009 at 02:17:46PM +0100, Mark McLoughlin wrote:
[...]
> +virReportSystemError(conn, err,
just add "%s", on that line :-)
> + _("Failed to add tap interface to bridge
> '%s'"),
> + bridge);
ACK,
Dan
* src/qemu_conf.c, src/uml_conf.c: use virReportSystemError() to report
system errors
---
src/qemu_conf.c | 19 ---
src/uml_conf.c | 21 -
2 files changed, 16 insertions(+), 24 deletions(-)
diff --git a/src/qemu_conf.c b/src/qemu_conf.c
index bcdab11..22
On Tue, Aug 18, 2009 at 01:38:35PM +0100, Mark McLoughlin wrote:
> https://bugzilla.redhat.com/517371
>
> Matt Booth points out that if you use a non-existent bridge name when
> start a guest you get a weird error message:
>
> Failed to add tap interface 'vnet%d' to bridge 'virbr0'
>
> and dev
https://bugzilla.redhat.com/517371
Matt Booth points out that if you use a non-existent bridge name when
start a guest you get a weird error message:
Failed to add tap interface 'vnet%d' to bridge 'virbr0'
and dev='vnet%d' appears in the dumpxml output.
Fix that by not including 'vnet%d' in t
On Tue, 2009-08-18 at 12:23 +0200, Mirko Raasch wrote:
> Mark McLoughlin schrieb:
> > On Sun, 2009-08-16 at 22:13 +0200, Mirko Raasch wrote:
> >
> >> ==8823== Invalid read of size 8
> >> ==8823==at 0x420C04: qemuCheckPciHostDevice (qemu_driver.c:1337)
> >> ==8823==by 0x4E48CA7: pciResetD
Mark McLoughlin schrieb:
On Sun, 2009-08-16 at 22:13 +0200, Mirko Raasch wrote:
==8823== Invalid read of size 8
==8823==at 0x420C04: qemuCheckPciHostDevice (qemu_driver.c:1337)
==8823==by 0x4E48CA7: pciResetDevice (pci.c:606)
==8823==by 0x4229D5: qemudShutdownVMDaemon (qemu_driver
On Mon, Aug 17, 2009 at 06:12:55PM +0100, Daniel P. Berrange wrote:
[...]
> +if (disk->serial)
> +virBufferVSprintf(&opt, ",serial=%s", disk->serial);
Sounds fine, just that if the content is free form maybe one need
to quote that argument
",serial='%s'"
to avo
On Mon, 2009-08-17 at 18:12 +0100, Daniel P. Berrange wrote:
> +if (disk->serial)
> +virBufferVSprintf(&opt, ",serial=%s", disk->serial);
qemu-0.9.1 didn't support serial=, qemu-0.10.0 and kvm-83 were the first
versions to add it
Looks fine apart from that
Cheers,
Ma
> I recall you said there might be other options /settings related
> to 3d acceleration in virtualbox in the future. If so I think it
> might be worth making that element all of its own
>
>
>
> <3daccel />
>
>
>
true, will add a element called cause there are some feature
Daniel P. Berrange wrote:
>
> ACK
>
During testing of this patch, I actually found a small bug, so the final version
that I committed is attached.
--
Chris Lalancette
commit f5cc4a5a696680577eb6b2daaf7521bc5fcfbc5e
Author: Chris Lalancette
Date: Tue Aug 11 15:48:59 2009 +0200
Fix up co
14 matches
Mail list logo
