Lastly added OOM checks in few places which were missed earlier.
Okay applied thanks !
I would concur with Chris, I think the current practice in most
of libvirt code when there is a complex routine is to handle
OOM with a goto to an error label.
Thanks Chris and Daniel for the review, i
2009/9/7 Anton Protopopov asp...@gmail.com
2009/9/7 Mark McLoughlin mar...@redhat.com
On Mon, 2009-09-07 at 14:40 +0400, Anton Protopopov wrote:
Also, what is the output of 'virsh capabilities' ?
guest
os_typehvm/os_type
arch name='x86_64'
wordsize64/wordsize
On Mon, Sep 07, 2009 at 06:33:13PM +0200, Jim Meyering wrote:
Daniel Veillard wrote:
On Mon, Sep 07, 2009 at 05:37:24PM +0200, Jim Meyering wrote:
From 74f57af2010f9cbe2315d625c6502a0b259e6802 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 7 Sep 2009 10:03:22
On Mon, Sep 07, 2009 at 04:12:36PM +0200, Miloslav Trmač wrote:
* docs/formatsecret.html.in, docs/formatsecret.html: Document usage
type='volume', replacing stand-alone volume.
* docs/schemas/secret.rng: Update schema to require usage
type='volume'
Okay, sounds fine and if we need to
On Mon, Sep 07, 2009 at 04:12:37PM +0200, Miloslav Trmač wrote:
Add a VIR_SECRET_GET_VALUE_INTERNAL_CALL flag value, replacing the
originally separate libvirt_internal_call parameter. The flag is used
to differentiate external virSecretGetValue() calls from internal calls
by libvirt drivers
Daniel Veillard wrote:
Man index is a bit confusing as it uses NULL to designate the '\0'
character at the end of the string and the NULL pointer. Maybe this led
to some confusion,
Your patch sounds right, and Dan probably don't remember the obscure
details of that patch 2.5 years ago
On Mon, Sep 07, 2009 at 04:12:38PM +0200, Miloslav Trmač wrote:
Add a secret XML handling API, separate from the local driver, to
avoid manually generating XML in other parts of libvirt.
* src/secret_conf.c, src/secret_conf.h: New files.
* po/POTFILES.in, src/Makefile.am: Add secret_conf.
I may separate this into two commits.
Currently we can't use the part that adds the strchrnul use,
since gnulib's module lists its license as LGPL, which
means LGPLv3+, and that conflicts with libvirt's LGPLv2+ requirement.
However, since strchrnul is derived from glibc, it should be easy
to
On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote:
This implementation stores the secrets in an unencrypted text file,
for simplicity in implementation and debugging.
(Symmetric encryption, e.g. using gpgme, will not be difficult to add.
Because the TLS private key used by
- Daniel Veillard veill...@redhat.com wrote:
+/* Make sure ... INTERNAL_CALL can not be set by the caller */
+verify((VIR_SECRET_GET_VALUE_INTERNAL_CALL
+VIR_SECRET_GET_VALUE_FLAGS_MASK) == 0);
??? what's that ? an assert at compile time ? I don't know that construct
I
Hi,
I'm having a problem with starting a HVM virtual machine on Xen-3.4 with
python-libvirt. This is the XML:
?xml version=1.0 encoding=utf-8?
domain type=xen
nameb07d6538-60f5-44a9-90e7-761304968e17/name
uuidb07d6538-60f5-44a9-90e7-761304968e17/uuid
on_poweroffdestroy/on_poweroff
Anno domini 2009 Maximilian Wilhelm scripsit:
Hi!
My buildbot spotted a problem with the latest changes to Phyp, as the
function libssh2_session_block_directions() only is available with
libssh2 version 1.0 and later.
At least on Debian Lenny there is an older one which prevents libVirt
Daniel Veillard wrote:
On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote:
This implementation stores the secrets in an unencrypted text file,
for simplicity in implementation and debugging.
(Symmetric encryption, e.g. using gpgme, will not be difficult to add.
Because the TLS
On Tue, Sep 08, 2009 at 12:39:44PM +0200, Jim Meyering wrote:
Daniel Veillard wrote:
On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote:
This implementation stores the secrets in an unencrypted text file,
for simplicity in implementation and debugging.
(Symmetric encryption,
On Mon, Sep 07, 2009 at 04:12:40PM +0200, Miloslav Trmač wrote:
* src/virsh.c: Add virsh commands.
* docs/virsh.pod, virsh.1: Update documentation.
---
docs/virsh.pod | 43
src/virsh.c| 323
virsh.1| 34
On Mon, Sep 07, 2009 at 04:12:41PM +0200, Miloslav Trmač wrote:
* storage_encryption_conf.c: Fix a pasto in comment.
---
src/storage_encryption_conf.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/storage_encryption_conf.c b/src/storage_encryption_conf.c
On Mon, Sep 07, 2009 at 04:12:45PM +0200, Miloslav Trmač wrote:
... to be more consistent with other sections.
* src/libvirt_private.syms: Add a missing comment.
Trivial, applied too, thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
- Daniel Veillard veill...@redhat.com wrote:
+default:
+VIR_ERROR(_(unexpected secret usage type %d), def-usage_type);
+break;
Hum, since the virSecretDefPtr is allocated by our own code, it's
probably better to remove the default so that the compiler can
- Daniel Veillard veill...@redhat.com wrote:
On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote:
+if ((size_t)st.st_size != st.st_size) {
shouldn't we chaeck against SECRET_MAX_XML_FILE instead ?
No, this code reads the secret value, not the XML, and there's little
Subject says it all.
Matthias
diff --git a/src/xend_internal.c b/src/xend_internal.c
index 2fa08f1..ed6fcac 100644
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -3723,7 +3723,7 @@ xenDaemonLookupByID(virConnectPtr conn, int id) {
}
ret = virGetDomain(conn, name, uuid);
-
On Tue, Sep 08, 2009 at 02:35:40PM +0200, Matthias Bolte wrote:
Subject says it all.
Matthias
diff --git a/src/xend_internal.c b/src/xend_internal.c
index 2fa08f1..ed6fcac 100644
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -3723,7 +3723,7 @@ xenDaemonLookupByID(virConnectPtr
On Tue, Sep 08, 2009 at 12:24:08PM +0200, Maximilian Wilhelm wrote:
Anno domini 2009 Maximilian Wilhelm scripsit:
Hi!
My buildbot spotted a problem with the latest changes to Phyp, as the
function libssh2_session_block_directions() only is available with
libssh2 version 1.0 and later.
2009/9/8 Daniel Veillard veill...@redhat.com:
On Tue, Sep 08, 2009 at 02:35:40PM +0200, Matthias Bolte wrote:
Subject says it all.
Matthias
diff --git a/src/xend_internal.c b/src/xend_internal.c
index 2fa08f1..ed6fcac 100644
--- a/src/xend_internal.c
+++ b/src/xend_internal.c
@@ -3723,7
I'm trying to get a feel of the python binding and the esx driver
Trying to get the number of interfaces hit(as anticipated) a non-support wall:
Traceback (most recent call last):
File test.py, line 362, in ?
vmm.refresh()
File test.py, line 189, in refresh
print
On Thu, Sep 03, 2009 at 06:03:00PM +0100, Daniel P. Berrange wrote:
On Wed, Sep 02, 2009 at 11:28:27AM -0400, Dave Allan wrote:
@@ -1177,6 +1180,26 @@ if test $with_storage_scsi = check; then
fi
AM_CONDITIONAL([WITH_STORAGE_SCSI], [test $with_storage_scsi = yes])
+if test
Gerd Hoffmann wrote:
On 09/08/09 15:47, Jan Kiszka wrote:
Before setting this definitely useful feature in stone, I have two
questions though:
- -drive ...,boot=on is logically in conflict with -boot. Yes, -boot
for x86 currently cannot differentiate between multiple disks, only
On Wed, Sep 02, 2009 at 02:11:50PM +0100, Daniel P. Berrange wrote:
Fix all thread locking bugs reported by object-locking test
case.
NB, some of the driver locking is getting too coarse. Driver
mutexes really need to be turned into RW locks instead to
significantly increase concurrency.
-drive if=virtio,id=sys,file=/path/to/disk.img
-cdrom /path/to/install.iso
-boot order=[sys],once=d,menu=off
Yes, this looks powerful and clean. One could even still define probe
orders like -boot order=[sys][backup]d.
Well, except that boot orders with two hard drives in there
On Tue, Sep 08, 2009 at 03:04:38PM +0200, Matthias Bolte wrote:
2009/9/8 Daniel Veillard veill...@redhat.com:
Thanks for chasing and for the patch mime-type :-)
Daniel
For some reason the Google Mail web client detects patches with .patch
extension as application/mbox now. If I rename
On Thu, Sep 03, 2009 at 06:03:00PM +0100, Daniel P. Berrange wrote:
On Wed, Sep 02, 2009 at 11:28:27AM -0400, Dave Allan wrote:
@@ -1177,6 +1180,26 @@ if test $with_storage_scsi = check; then
fi
AM_CONDITIONAL([WITH_STORAGE_SCSI], [test $with_storage_scsi = yes])
+if test
On Tue, Sep 08, 2009 at 06:56:10AM -0700, Shahar Klein wrote:
I'm trying to get a feel of the python binding and the esx driver
Trying to get the number of interfaces hit(as anticipated) a non-support wall:
Traceback (most recent call last):
File test.py, line 362, in ?
mmm
I would like to get host(i.e. node) interface info
as well as domain(guest) network/interface info
I will probably would like to set/manipulate the node and domains as well
but it is simpler to start with the get functions - isn't it?
Did I totally misunderstood the architecture?
shahar
Jan Kiszka wrote:
- This is just an implementation detail: Do we really need to implement
booting from virtio and scsi via an extension rom? Isn't it possible
to merge the corresponding support into the main bios?
Well. There are quite a few. bochs pcbios, seabios,
Gerd Hoffmann wrote:
-drive if=virtio,id=sys,file=/path/to/disk.img
-cdrom /path/to/install.iso
-boot order=[sys],once=d,menu=off
Yes, this looks powerful and clean. One could even still define probe
orders like -boot order=[sys][backup]d.
Well, except that boot orders with two
On 09/08/09 19:12, Anthony Liguori wrote:
I'm still not convinced we need extboot for all bioses on the long term.
And I think we should define new interfaces in a way that finally makes
it obsolete, at least for our home bios (whatever it will be).
What we won't need long term is the extboot
Daniel Veillard wrote:
On Tue, Sep 08, 2009 at 12:24:08PM +0200, Maximilian Wilhelm wrote:
Anno domini 2009 Maximilian Wilhelm scripsit:
Hi!
My buildbot spotted a problem with the latest changes to Phyp, as the
function libssh2_session_block_directions() only is available with
libssh2
While this patch stays minimal by simply adding XZ/xz to the list,
I think it would be better to remove lzma, since it uses
an inferior format (which lacks an integrity check), and
has been effectively subsumed by xz.
Let me know if you'd like that, and I'll prepare the slightly
more invasive
These changes affect only make syntax-check.
The first patch is clearing out now-useless or unnecessary exclusions.
The second enables one more test and fixes the few small
violations it spotted.
From e4719bd092b03ef666d196ebc4b97086a7ecae98 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Jim Meyering wrote:
I may separate this into two commits.
Currently we can't use the part that adds the strchrnul use,
since gnulib's module lists its license as LGPL, which
means LGPLv3+, and that conflicts with libvirt's LGPLv2+ requirement.
However, since strchrnul is derived from glibc,
On Tue, 08 Sep 2009, Jamie Strandboge wrote:
[PATCH 1*]
patch_1a_reenable-nonfile-labels.patch:
When James Morris originally submitted his sVirt patches (as seen in
libvirt 0.6.1), he did not require on disk labelling for
virSecurityDomainRestoreImageLabel. A later commit[2] changed
On Tue, 08 Sep 2009, Jamie Strandboge wrote:
[PATCH 6]
patch_6_autoconf.patch:
Updates Makefile.am and configure.in for AppArmor. It is based on and
should operate the same as the SELinux configuration.
--
Jamie Strandboge | http://www.canonical.com
diff -Nurp
On Tue, 08 Sep 2009, Jamie Strandboge wrote:
[PATCH 4]
patch_4_tests.patch:
Adds tests for virt-aa-helper and the security driver. secaatest.c is
identical to seclabeltest.c except it initializes the 'apparmor' driver
instead of 'selinux'. These tests are integrated into 'make check'
On Tue, 08 Sep 2009, Jamie Strandboge wrote:
[PATCH 3]
patch_3_security_apparmor.patch:
Adds security_apparmor.c, security_apparmor.h, virt-aa-helper.c and
updates po/POTFILES.in. virt-aa-helper.c is a new binary which is used
exclusively by the AppArmor security driver to manipulate
Gerd Hoffmann wrote:
On 09/08/09 19:12, Anthony Liguori wrote:
I'm still not convinced we need extboot for all bioses on the long
term.
And I think we should define new interfaces in a way that finally makes
it obsolete, at least for our home bios (whatever it will be).
What we won't need
44 matches
Mail list logo
