[libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Chris Lalancette
Jim Meyering wrote: While this patch stays minimal by simply adding XZ/xz to the list, I think it would be better to remove lzma, since it uses an inferior format (which lacks an integrity check), and has been effectively subsumed by xz. Let me know if you'd like that, and I'll prepare the

[libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Jim Meyering
Chris Lalancette wrote: Jim Meyering wrote: While this patch stays minimal by simply adding XZ/xz to the list, I think it would be better to remove lzma, since it uses an inferior format (which lacks an integrity check), and has been effectively subsumed by xz. Let me know if you'd like

Re: [libvirt] Interface driver and ESX support

2009-09-09 Thread Shahar Klein
Let me rephrase my question : ) In the current libvirt infrastructure I can do a lot of things with libvirt and a remote ESX node I can list all the guests I can suspend a guest I can get a lot of node info and much more can I (for example) 1. add NIC to a guest domain 2. list all the

Re: [libvirt] Interface driver and ESX support

2009-09-09 Thread Chris Lalancette
Shahar Klein wrote: Let me rephrase my question : ) In the current libvirt infrastructure I can do a lot of things with libvirt and a remote ESX node I can list all the guests I can suspend a guest I can get a lot of node info and much more can I (for example) 1. add NIC to a

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Jim Meyering
Jim Meyering wrote: Chris Lalancette wrote: Jim Meyering wrote: While this patch stays minimal by simply adding XZ/xz to the list, I think it would be better to remove lzma, since it uses an inferior format (which lacks an integrity check), and has been effectively subsumed by xz. Let me

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Chris Lalancette
Jim Meyering wrote: At Chris' suggestion, I've added a comment warning not to do what I did ;-) To make it even more obvious that these numbers matter, I've assigned explicit constants in the enum: +QEMUD_SAVE_FORMAT_RAW = 0, +QEMUD_SAVE_FORMAT_GZIP = 1, +

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Jim Meyering
Jim Meyering wrote: ... At Chris' suggestion, I've added a comment warning not to do what I did ;-) To make it even more obvious that these numbers matter, I've assigned explicit constants in the enum: +QEMUD_SAVE_FORMAT_RAW = 0, +QEMUD_SAVE_FORMAT_GZIP = 1, +

Re: [libvirt] Interface driver and ESX support

2009-09-09 Thread Shahar Klein
thanks Chris I'll try to write somthing and see how it goes shahar From: Chris Lalancette clala...@redhat.com To: Shahar Klein shaharkl...@yahoo.com Cc: veill...@redhat.com; libvir-list@redhat.com Sent: Wednesday, September 9, 2009 10:18:39 AM Subject: Re:

Re: [libvirt] Interface driver and ESX support

2009-09-09 Thread Matthias Bolte
2009/9/9 Shahar Klein shaharkl...@yahoo.com: Let me rephrase my question : ) In the current libvirt infrastructure I can do a lot of things with libvirt and a remote ESX node I can list all the guests I can suspend a guest I can get a lot of node info and much more can I (for example)

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Daniel Veillard
On Wed, Sep 09, 2009 at 09:24:17AM +0200, Jim Meyering wrote: Jim Meyering wrote: Chris Lalancette wrote: Jim Meyering wrote: While this patch stays minimal by simply adding XZ/xz to the list, I think it would be better to remove lzma, since it uses an inferior format (which lacks an

Re: [libvirt] Resubmission: [PATCH 0/6] sVirt AppArmor security driver

2009-09-09 Thread Daniel Veillard
On Tue, Sep 08, 2009 at 04:17:26PM -0500, Jamie Strandboge wrote: Resubmitting based on feedback from this list. Notably, *alloc calls have been removed and syntax-check completes without error for all files. Thanks ! I think this is an item for post 0.7.1, so most likely you won't get much

Re: [libvirt] Interface driver and ESX support

2009-09-09 Thread Shahar Klein
I think I understand the mechanism of the VI API and the way esx_vi.c is using it the surounding is a bit more complex for me so can you provide the framework? I mean can you put in the esx_interface_driver.c and h and the registration etc... and also putting it all into the auto make

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Daniel Veillard
On Wed, Sep 09, 2009 at 10:49:46AM +0200, Daniel Veillard wrote: On Wed, Sep 09, 2009 at 09:24:17AM +0200, Jim Meyering wrote: diff --git a/src/qemu_driver.c b/src/qemu_driver.c index f64d70b..7b64712 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -3622,7 +3622,8 @@ enum

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Daniel Veillard
On Wed, Sep 09, 2009 at 11:57:40AM +0200, Jim Meyering wrote: Daniel Veillard wrote: Hum, I realize that support of LZOP was added after 0.7.0, so we never made a release with it (well except for git snapshot which may have been pushed). I wonder if the best is not to just drop the

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Daniel Veillard
On Wed, Sep 09, 2009 at 10:17:48AM +0200, Jim Meyering wrote: Jim Meyering wrote: ... At Chris' suggestion, I've added a comment warning not to do what I did ;-) To make it even more obvious that these numbers matter, I've assigned explicit constants in the enum: +

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Jim Meyering
Daniel Veillard wrote: On Wed, Sep 09, 2009 at 11:57:40AM +0200, Jim Meyering wrote: Daniel Veillard wrote: Hum, I realize that support of LZOP was added after 0.7.0, so we never made a release with it (well except for git snapshot which may have been pushed). I wonder if the best

Re: [libvirt] Interface driver and ESX support

2009-09-09 Thread Matthias Bolte
2009/9/9 Shahar Klein shaharkl...@yahoo.com: I think I understand the mechanism of the VI API and the way esx_vi.c is using it the surounding is a bit more complex for me so can you provide the framework? I mean can you put in the esx_interface_driver.c and h and the registration etc...

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Jim Meyering
Daniel Veillard wrote: On Wed, Sep 09, 2009 at 10:17:48AM +0200, Jim Meyering wrote: Jim Meyering wrote: ... At Chris' suggestion, I've added a comment warning not to do what I did ;-) To make it even more obvious that these numbers matter, I've assigned explicit constants in the enum:

Re: [libvirt] HVM startup problemunknown root elementi for storage pool

2009-09-09 Thread Andreas Sommer
Okay I found out what the problem was. I stumbled over the bug in the creation of the Python interface that I filed some weeks ago (https://bugzilla.redhat.com/show_bug.cgi?id=518029). Andreas Sommer wrote: Hi, I'm having a problem with starting a HVM virtual machine on Xen-3.4 with

Re: [libvirt] Interface driver and ESX support

2009-09-09 Thread Shahar Klein
Thank you very much : ) From: Matthias Bolte matthias.bo...@googlemail.com To: Shahar Klein shaharkl...@yahoo.com Cc: Chris Lalancette clala...@redhat.com; libvir-list@redhat.com Sent: Wednesday, September 9, 2009 1:11:47 PM Subject: Re: [libvirt] Interface

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Daniel Veillard
On Wed, Sep 09, 2009 at 12:08:13PM +0200, Jim Meyering wrote: Daniel Veillard wrote: On Wed, Sep 09, 2009 at 11:57:40AM +0200, Jim Meyering wrote: Daniel Veillard wrote: Hum, I realize that support of LZOP was added after 0.7.0, so we never made a release with it (well except for

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Jim Meyering
Daniel Veillard wrote: On Wed, Sep 09, 2009 at 12:08:13PM +0200, Jim Meyering wrote: Daniel Veillard wrote: On Wed, Sep 09, 2009 at 11:57:40AM +0200, Jim Meyering wrote: Daniel Veillard wrote: Hum, I realize that support of LZOP was added after 0.7.0, so we never made a release with

Re: [libvirt] [PATCH] Automagically check if libssh2 is new enough for Phyp-support to be build

2009-09-09 Thread Daniel Veillard
On Fri, Sep 04, 2009 at 02:45:57PM +0200, Maximilian Wilhelm wrote: Hi! My buildbot spotted a problem with the latest changes to Phyp, as the function libssh2_session_block_directions() only is available with libssh2 version 1.0 and later. At least on Debian Lenny there is an older one

Re: [libvirt] [PATCH] Automagically check if libssh2 is new enough for Phyp-support to be build

2009-09-09 Thread Dave Allan
Daniel Veillard wrote: On Fri, Sep 04, 2009 at 02:45:57PM +0200, Maximilian Wilhelm wrote: Hi! My buildbot spotted a problem with the latest changes to Phyp, as the function libssh2_session_block_directions() only is available with libssh2 version 1.0 and later. At least on Debian Lenny there

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Daniel Veillard
On Wed, Sep 09, 2009 at 04:16:59PM +0200, Jim Meyering wrote: Daniel Veillard wrote: Okay, I suggest the following patch removing the 2 extra compressors and making sure the package including the daemon, if compiled with qemu has the proper dependancies. xz package dependancy is IMHO

Re: [libvirt] [PATCH 02/11] Avoid polling on FDs with no events enabled

2009-09-09 Thread Chris Lalancette
Daniel Veillard wrote: On Mon, Aug 24, 2009 at 09:51:05PM +0100, Daniel P. Berrange wrote: If a file descriptor with events=0 was added to the libvirtd event loop, it would still be added to the poll() fds' array. While it wouldn't see any POLLIN/OUT events, it'd still get triggered for

Re: [libvirt] [PATCH] Automagically check if libssh2 is new enough for Phyp-support to be build

2009-09-09 Thread Maximilian Wilhelm
Anno domini 2009 Daniel Veillard scripsit: On Fri, Sep 04, 2009 at 02:45:57PM +0200, Maximilian Wilhelm wrote: Hi! My buildbot spotted a problem with the latest changes to Phyp, as the function libssh2_session_block_directions() only is available with libssh2 version 1.0 and later.

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Jim Meyering
Charles Duffy wrote: Jim Meyering wrote: Daniel Veillard wrote: Hum, I realize that support of LZOP was added after 0.7.0, so we never made a release with it (well except for git snapshot which may have been pushed). I wonder if the best is not to just drop the lzop option altogether

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Charles Duffy
Jim Meyering wrote: Good point about it being one of the fastest. I shouldn't have mentioned the subjective popular. Usefulness trumps that. I suppose Daniel, Cc'd, will decide. Per off-list discussion with DV, I'm providing some numbers. Sort order is space used on disk, lowest to highest,

Re: [libvirt] Re: [PATCH] also allow use of XZ for Qemu image compression

2009-09-09 Thread Charles Duffy
[Pardon the repost -- fixed the table formatting in this version] Jim Meyering wrote: Good point about it being one of the fastest. I shouldn't have mentioned the subjective popular. Usefulness trumps that. I suppose Daniel, Cc'd, will decide. Per off-list discussion with DV, I'm providing

[libvirt] [PATCH] Reintroduce lzop compression

2009-09-09 Thread Charles Duffy
From 3c4f6568623ed420a9e71da33b9ce74abda289a8 Mon Sep 17 00:00:00 2001 From: Charles Duffy charles_du...@dell.com Date: Wed, 9 Sep 2009 15:53:25 -0500 Subject: [PATCH] Reintroduce support for lzop compression lzop was removed due to some confusion over whether it provided functional advantages

[libvirt] [PATCH] Close logfile fd after spawning qemu

2009-09-09 Thread Ryota Ozaki
Hi, This patch closes logfile fd after spawing qemu in qemudStartVMDaemon. The fd seems to be closed in the error path, but not in the normal path. The fd is passed to virExecDaemonize though, but looks not being closed inside it. Eventually, the fd is never closed during libvirtd lifetime.