Re: [libvirt] [PATCH 1/4] Fix UUID handling in secrets/storage encryption APIs

2009-09-11 Thread Miloslav Trmac
- "Daniel P. Berrange" wrote: > @@ -635,49 +620,25 @@ secretLookupByUUIDString(virConnectPtr conn, > const char *uuid) > > pptr = secretFind(driver, uuid); > if (pptr == NULL) { > +char uuidstr[VIR_UUID_STRING_BUFLEN]; > +virUUIDFormat(uuid, uuidstr); > vi

Re: [libvirt] [PATCH 2/4] Add usage type/id as a public API property of virSecret

2009-09-11 Thread Daniel P. Berrange
On Fri, Sep 11, 2009 at 06:17:40PM +0200, Daniel Veillard wrote: > On Fri, Sep 11, 2009 at 03:19:18PM +0100, Daniel P. Berrange wrote: > > > > +/** > > + * virSecretGetUsageType: > > + * @secret: a secret object > > + * > > + * Get the type of object which uses this secret > > + * > > + * Returns

Re: [libvirt] [PATCH 1/4] Fix UUID handling in secrets/storage encryption APIs

2009-09-11 Thread Daniel P. Berrange
On Fri, Sep 11, 2009 at 06:00:07PM +0200, Daniel Veillard wrote: > On Fri, Sep 11, 2009 at 03:19:17PM +0100, Daniel P. Berrange wrote: > > Convert all the secret/storage encryption APIs / wire format to > > handle UUIDs in raw format instead of non-canonical printable > > format. Guarentees data fo

Re: [libvirt] [PATCH 4/4] Make secrets RNG more strict

2009-09-11 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 03:19:20PM +0100, Daniel P. Berrange wrote: > * docs/schemas/secret.rng: Require volume element to be an absolute > path. Fix whitespace indentation > --- > docs/schemas/secret.rng | 68 +- > 1 files changed, 37 insertions(+),

Re: [libvirt] [PATCH 3/4] Fill in secret UUID for qcow encryption

2009-09-11 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 03:19:19PM +0100, Daniel P. Berrange wrote: > * src/storage_backend_fs.c: Lookup & fill in secret passphrase UUID > for storage volumes using encryption > --- > src/storage_backend_fs.c | 41 - > 1 files changed, 40 insertions(+),

Re: [libvirt] [PATCH 2/4] Add usage type/id as a public API property of virSecret

2009-09-11 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 03:19:18PM +0100, Daniel P. Berrange wrote: > * include/libvirt/libvirt.h, include/libvirt/libvirt.h.in: Add > virSecretGetUsageType, virSecretGetUsageID and virLookupSecretByUsage > * python/generator.py: Mark virSecretGetUsageType, virSecretGetUsageID > as not throwing

Re: [libvirt] [PATCH 1/4] Fix UUID handling in secrets/storage encryption APIs

2009-09-11 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 03:19:17PM +0100, Daniel P. Berrange wrote: > Convert all the secret/storage encryption APIs / wire format to > handle UUIDs in raw format instead of non-canonical printable > format. Guarentees data format correctness. [...] > +++ b/include/libvirt/libvirt.h > @@ -1467,12 +

Re: [libvirt] [PATCH] Save vcpuinfo in status file

2009-09-11 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 04:27:48PM +0100, Daniel P. Berrange wrote: > * src/qemu_driver.c: Don't trust monitor for vcpu PID info on > restart > * src/domain_conf.c: Save and load vCPU PID info from domain > status file > --- > src/domain_conf.c | 35 +++ > src

[libvirt] [PATCH] Save vcpuinfo in status file

2009-09-11 Thread Daniel P. Berrange
* src/qemu_driver.c: Don't trust monitor for vcpu PID info on restart * src/domain_conf.c: Save and load vCPU PID info from domain status file --- src/domain_conf.c | 35 +++ src/qemu_driver.c |5 + 2 files changed, 36 insertions(+), 4 deletions(-) di

[libvirt] Postponing 0.7.1 release by a couple of days

2009-09-11 Thread Daniel Veillard
We still commited quite a bit in the last few days and I think taking a couple of extra days for testing is a bit safer, so I suggest to make the release only on Tuesday. So we have today and this week end for testing, push fixes if needed on Monday and I would make the release early on tuesday,

[libvirt] [PATCH 4/4] Make secrets RNG more strict

2009-09-11 Thread Daniel P. Berrange
* docs/schemas/secret.rng: Require volume element to be an absolute path. Fix whitespace indentation --- docs/schemas/secret.rng | 68 +- 1 files changed, 37 insertions(+), 31 deletions(-) diff --git a/docs/schemas/secret.rng b/docs/schemas/secret.r

[libvirt] [PATCH 3/4] Fill in secret UUID for qcow encryption

2009-09-11 Thread Daniel P. Berrange
* src/storage_backend_fs.c: Lookup & fill in secret passphrase UUID for storage volumes using encryption --- src/storage_backend_fs.c | 41 - 1 files changed, 40 insertions(+), 1 deletions(-) diff --git a/src/storage_backend_fs.c b/src/storage_backend_f

[libvirt] [PATCH 2/4] Add usage type/id as a public API property of virSecret

2009-09-11 Thread Daniel P. Berrange
* include/libvirt/libvirt.h, include/libvirt/libvirt.h.in: Add virSecretGetUsageType, virSecretGetUsageID and virLookupSecretByUsage * python/generator.py: Mark virSecretGetUsageType, virSecretGetUsageID as not throwing exceptions * qemud/remote.c: Implement dispatch for virLookupSecretByUsage

[libvirt] [PATCH 0/4] Changes to API/ABI for secrets handling

2009-09-11 Thread Daniel P. Berrange
This series makes two changes to the public API and wire protocol ABI for the secrets handling support recently committed. As such this is a must fix before we do the release, since we can't break compatability once released. The first patch changes all the code to store UUIDs in raw format inste

Re: [libvirt] [PATCH] Restart libvirtd upon RPM upgrade

2009-09-11 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 03:04:36PM +0100, Daniel P. Berrange wrote: > * libvirt.spec.in: Restart libvirtd in %post > --- > libvirt.spec.in |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) Makes sense, ACK Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xm

[libvirt] [PATCH] Restart libvirtd upon RPM upgrade

2009-09-11 Thread Daniel P. Berrange
* libvirt.spec.in: Restart libvirtd in %post --- libvirt.spec.in |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0157eee..8d4c8cc 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -471,6 +471,9 @@ fi %endif /sbin/chkconfig

Re: gPXE (was Re: [libvirt] [RFC,PATCH] network: add 'netboot' option to dhcp config)

2009-09-11 Thread Mark McLoughlin
On Fri, 2009-09-11 at 09:44 +0100, Tom Hughes wrote: > > I very much like this idea - e.g. I'd really like to have this to give > > people simple instructions for testing gPXE in next week's Fedora Test > > Day. > > On the subject of gPXE has anybody else found that it doesn't seem to be > workin

Re: [libvirt][qemu] unable to start guest under kvm

2009-09-11 Thread Anton Protopopov
2009/9/10 Mark McLoughlin > > Hi, >Okay, I've got this fixed for certain now. Definitely. I think. > >The problem turned out to be that qemudCanonicalizeMachine() > was using the alias in the default machine types if the domain's machine > types didn't have an alias that matched.

gPXE (was Re: [libvirt] [RFC,PATCH] network: add 'netboot' option to dhcp config)

2009-09-11 Thread Tom Hughes
I very much like this idea - e.g. I'd really like to have this to give people simple instructions for testing gPXE in next week's Fedora Test Day. On the subject of gPXE has anybody else found that it doesn't seem to be working at all? I'm using the virt-preview packages on F11 and ever sin

Re: [libvirt] [RFC,PATCH] network: add 'netboot' option to dhcp config

2009-09-11 Thread Daniel Veillard
On Fri, Sep 11, 2009 at 09:22:09AM +0100, Mark McLoughlin wrote: > On Fri, 2009-09-11 at 14:47 +1000, Jeremy Kerr wrote: > > Currently, libvirtd will start a dnsmasq process for the virtual > > network, but (aside from killing the dnsmasq process and replacing it), > > there's no way to define tftp

Re: [libvirt] [RFC,PATCH] network: add 'netboot' option to dhcp config

2009-09-11 Thread Mark McLoughlin
On Fri, 2009-09-11 at 09:22 +0100, Mark McLoughlin wrote: > On Fri, 2009-09-11 at 14:47 +1000, Jeremy Kerr wrote: > > Currently, libvirtd will start a dnsmasq process for the virtual > > network, but (aside from killing the dnsmasq process and replacing it), > > there's no way to define tftp boot o

Re: [libvirt] [RFC,PATCH] network: add 'netboot' option to dhcp config

2009-09-11 Thread Mark McLoughlin
On Fri, 2009-09-11 at 14:47 +1000, Jeremy Kerr wrote: > Currently, libvirtd will start a dnsmasq process for the virtual > network, but (aside from killing the dnsmasq process and replacing it), > there's no way to define tftp boot options. > > This change introduces a 'netboot' tag to the dhcp co