Re: [libvirt] [PATCH 0/6] correctly migrate paused VMs (and a bunch of bugfixes)

2009-10-02 Thread Chris Lalancette
Paolo Bonzini wrote: Currently, the QEMU driver tries to migrate paused VMs, but the effect is that the migrated virtual machine will always run on the destination. Furthermore, the state is erroneously stored as paused, so that the driver is left confused and it is not possible to re-pause

Re: [libvirt] [PATCH 0/6] correctly migrate paused VMs (and a bunch of bugfixes)

2009-10-02 Thread Paolo Bonzini
I haven't reviewed the actual code yet, but I like the idea. Unfortunately this patch series is going to clash horribly with the tunnelled migration code that I'm going to commit today, so I'd suggest waiting until I commit, rebasing, and then reposting. Yes, that's fine. In the meanwhile

[libvirt] Safe? /etc/libvirt/qemu on shared storage?

2009-10-02 Thread James Brackinshaw
Hello, I have a directory /mnt/shared-storage where the disk files for kvm live. Live migration works well, but I have a problem: after a migration I see two guests, one on the original host shutoff and one on the new host running. I'd like to see the guest only on the host it is running on.

Re: [libvirt] [PATCH] in vbox driver, interface type bridge should really be type ethernet

2009-10-02 Thread Pritesh Kothari
Hi Florian, On Wednesday 30 September 2009 20:08:36 Florian Vichot wrote: If I understand correctly, the bridge type for an interface means libvirt is in charge of creating a tun device and adding it to the specified bridge in the source bridge=.. attribute.This is not what the (badly named

Re: [libvirt] Safe? /etc/libvirt/qemu on shared storage?

2009-10-02 Thread Chris Lalancette
James Brackinshaw wrote: Hello, I have a directory /mnt/shared-storage where the disk files for kvm live. Live migration works well, but I have a problem: after a migration I see two guests, one on the original host shutoff and one on the new host running. I'd like to see the guest only

Re: [libvirt] Safe? /etc/libvirt/qemu on shared storage?

2009-10-02 Thread James Brackinshaw
On Fri, Oct 2, 2009 at 11:22 AM, Chris Lalancette clala...@redhat.com wrote: James Brackinshaw wrote: Hello, I have a directory /mnt/shared-storage where the disk files for kvm live. Live migration works well, but I have a problem: after a migration I see two guests, one on the original host

Re: [libvirt] Safe? /etc/libvirt/qemu on shared storage?

2009-10-02 Thread Daniel P. Berrange
On Fri, Oct 02, 2009 at 10:15:09AM +0200, James Brackinshaw wrote: Hello, I have a directory /mnt/shared-storage where the disk files for kvm live. Live migration works well, but I have a problem: after a migration I see two guests, one on the original host shutoff and one on the new host

Re: [libvirt] [PATCH] Tunnelled migration.

2009-10-02 Thread Chris Lalancette
Daniel P. Berrange wrote: On Wed, Sep 30, 2009 at 03:38:46PM +0200, Chris Lalancette wrote: Implementation of tunnelled migration, using a Unix Domain Socket on the qemu backend. Note that this requires very new versions of qemu (0.10.7 at least) in order to get the appropriate bugfixes.

Re: [libvirt] [PATCH 1/6] unbreak migration

2009-10-02 Thread Chris Lalancette
Paolo Bonzini wrote: Fix migration, broken in two different ways by the QEMU monitor abstraction. Note that the QEMU console emits a \r\n as the line-ending. * src/qemu/qemu_monitor_text.c (qemuMonitorGetMigrationStatus): Fix info migrate command and its output's parsing. Pushed, thanks.

Re: [libvirt] [PATCH 2/6] unbreak `make rpcgen'

2009-10-02 Thread Chris Lalancette
Paolo Bonzini wrote: Fix make rpcgen, broken by the directory reorganization. * src/Makefile.am (rpcgen): Fix path to rpcgen_fix.pl. --- src/Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index de7765c..f3d4559

Re: [libvirt] Safe? /etc/libvirt/qemu on shared storage?

2009-10-02 Thread James Brackinshaw
If you're going to have a cluster of hosts between which you can move guests, you should really aim to store all your master configs elsewhere in shared storage, and either use transient guests (which have no config in /etc/libvirt), or persistent guests and only have configs in /etc/libvirt

Re: [libvirt] Safe? /etc/libvirt/qemu on shared storage?

2009-10-02 Thread Paolo Bonzini
On 10/02/2009 12:00 PM, James Brackinshaw wrote: If you're going to have a cluster of hosts between which you can move guests, you should really aim to store all your master configs elsewhere in shared storage, and either use transient guests (which have no config in /etc/libvirt), or persistent

Re: [libvirt] [PATCH 3/6] fix migration of paused vms upon failure

2009-10-02 Thread Chris Lalancette
Paolo Bonzini wrote: This makes a small change on the failed-migration path. Up to now, all VMs that failed non-live migration after the stop command were restarted. This must not be done when the VM was paused in the first place. OK, yes, after thinking about this, I agree with this

Re: [libvirt] [PATCH] in vbox driver, interface type bridge should really be type ethernet

2009-10-02 Thread Florian Vichot
Hey Pritesh, If you check http://libvirt.org/formatdomain.html#elementsNICS then it is not much clear if the type bridged is more suitable or ethernet cause the bridged section says: This assumes there is a bridge device on the host which has one or more of the hosts physical NICs

Re: [libvirt] [PATCH 3/6] fix migration of paused vms upon failure

2009-10-02 Thread Paolo Bonzini
If your domain is already paused, then you'll be issuing a qemuMonitorStopCPUs command unnecessarily. That by itself isn't a huge deal; it will essentially be a no-op. But you will also generate an event of VIR_DOMAIN_EVENT_SUSPENDED, which is wrong; you didn't really suspend the domain, an

Re: [libvirt] Update libvirt API and refs XML files

2009-10-02 Thread Daniel P. Berrange
On Thu, Oct 01, 2009 at 01:33:50PM +0200, Daniel Veillard wrote: On Thu, Oct 01, 2009 at 12:32:51PM +0200, Chris Lalancette wrote: Matthias Bolte wrote: Commit 47c8709564ac3f2ec5b4a3830ac213e69b4a44d5 Fix up a few typos in the tree triggered changes in docs/libvirt-api.xml and

[libvirt] [PATCH 1/2] Fix ordering of exports in API description file

2009-10-02 Thread Daniel P. Berrange
* docs/apibuild.py: Make uniq() function sort keys before returning them to ensure consitent ordering of exports in XML file --- docs/apibuild.py |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index b00619f..c5257f3 100755 ---

[libvirt] [PATCH 2/2] Fix rebuilding of devhelp files

2009-10-02 Thread Daniel P. Berrange
The devhelp/ directory files depend on libvirt-api.xml being uptodate, but automake always processes SUBDIRS before the current directory. So devhelp would be built and then the libvirt-api.xml re-build, invalidating the devhelp data again. To fix this all the rules for devhelp are moved directly

Re: [libvirt] Update libvirt API and refs XML files

2009-10-02 Thread Daniel Veillard
On Fri, Oct 02, 2009 at 12:16:36PM +0100, Daniel P. Berrange wrote: On Thu, Oct 01, 2009 at 01:33:50PM +0200, Daniel Veillard wrote: On Thu, Oct 01, 2009 at 12:32:51PM +0200, Chris Lalancette wrote: Matthias Bolte wrote: Commit 47c8709564ac3f2ec5b4a3830ac213e69b4a44d5 Fix up a few typos

Re: [libvirt] [PATCH 1/2] Fix ordering of exports in API description file

2009-10-02 Thread Daniel Veillard
On Fri, Oct 02, 2009 at 12:31:38PM +0100, Daniel P. Berrange wrote: * docs/apibuild.py: Make uniq() function sort keys before returning them to ensure consitent ordering of exports in XML file ACK, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit

Re: [libvirt] Update libvirt API and refs XML files

2009-10-02 Thread Daniel P. Berrange
On Fri, Oct 02, 2009 at 12:16:36PM +0100, Daniel P. Berrange wrote: On Thu, Oct 01, 2009 at 01:33:50PM +0200, Daniel Veillard wrote: On Thu, Oct 01, 2009 at 12:32:51PM +0200, Chris Lalancette wrote: Matthias Bolte wrote: Commit 47c8709564ac3f2ec5b4a3830ac213e69b4a44d5 Fix up a few typos

Re: [libvirt] [PATCH 2/2] Fix rebuilding of devhelp files

2009-10-02 Thread Daniel Veillard
On Fri, Oct 02, 2009 at 12:31:39PM +0100, Daniel P. Berrange wrote: The devhelp/ directory files depend on libvirt-api.xml being uptodate, but automake always processes SUBDIRS before the current directory. So devhelp would be built and then the libvirt-api.xml re-build, invalidating the

Re: [libvirt] [PATCH] Support a new peer-to-peer migration mode public API

2009-10-02 Thread Daniel P. Berrange
On Thu, Oct 01, 2009 at 03:57:13PM +0200, Paolo Bonzini wrote: On 09/17/2009 07:25 PM, Daniel P. Berrange wrote: +if (flags VIR_MIGRATE_PEER2PEER) { +if (VIR_DRV_SUPPORTS_FEATURE (domain-conn-driver, domain-conn, +

Re: [libvirt] [PATCH 1/1] Support a new peer-to-peer migration mode

2009-10-02 Thread Daniel P. Berrange
On Thu, Oct 01, 2009 at 11:43:17PM +0200, Paolo Bonzini wrote: + +if (dconn) +ddomain = virDomainLookupByName (dconn, dname ? dname : domain-name); +else { +ddomain = domain; +virDomainRef (domain); +} This bit of code is

Re: [libvirt] [PATCH 1/1] Support a new peer-to-peer migration mode

2009-10-02 Thread Paolo Bonzini
On 10/02/2009 01:53 PM, Daniel P. Berrange wrote: This bit of code is exactly why we need a new API - the return value is declared to be a virDomainPtr on the destination host, not just a copy of the original source domain which no longer even exists on the source host if it was a transient

Re: [libvirt] Update libvirt API and refs XML files

2009-10-02 Thread Daniel Veillard
On Fri, Oct 02, 2009 at 12:38:05PM +0100, Daniel P. Berrange wrote: On Fri, Oct 02, 2009 at 12:16:36PM +0100, Daniel P. Berrange wrote: On Thu, Oct 01, 2009 at 01:33:50PM +0200, Daniel Veillard wrote: On Thu, Oct 01, 2009 at 12:32:51PM +0200, Chris Lalancette wrote: Matthias Bolte wrote:

Re: [libvirt] Performance statistics

2009-10-02 Thread Daniel Veillard
On Fri, Oct 02, 2009 at 02:01:02PM +0200, James Brackinshaw wrote: Hello, Is it possible to get at the (historical) performance data provided by libvirtd? Is it stored for a period of time, or only available to clients polling it? Libvirtd doesn't store any, you really need to poll at the

Re: [libvirt] Performance statistics

2009-10-02 Thread Daniel P. Berrange
On Fri, Oct 02, 2009 at 02:31:29PM +0200, Daniel Veillard wrote: On Fri, Oct 02, 2009 at 02:01:02PM +0200, James Brackinshaw wrote: Hello, Is it possible to get at the (historical) performance data provided by libvirtd? Is it stored for a period of time, or only available to clients

Re: [libvirt] Performance statistics

2009-10-02 Thread James Brackinshaw
On Fri, Oct 2, 2009 at 2:41 PM, Daniel P. Berrange berra...@redhat.com wrote: On Fri, Oct 02, 2009 at 02:31:29PM +0200, Daniel Veillard wrote: On Fri, Oct 02, 2009 at 02:01:02PM +0200, James Brackinshaw wrote: Hello, Is it possible to get at the (historical) performance data provided by

[libvirt] [RFC PATCH 1/6] add ebtables wrapper

2009-10-02 Thread Gerhard Stenzel
This patch adds the files which implement the ebtables wrapper. Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com --- src/util/ebtables.c | 964 +++ src/util/ebtables.h | 136 +++ 2 files changed, 1100 insertions(+), 0 deletions(-)

[libvirt] [RFC PATCH 2/6] add build support for ebtables wrapper

2009-10-02 Thread Gerhard Stenzel
This patch adds build support for the ebtables wrapper. Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com --- configure.in|3 +++ src/Makefile.am |1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.in b/configure.in index cb5ce55..9e9aa3a 100644

[libvirt] [RFC PATCH 3/6] add the ebtables wrapper to network driver

2009-10-02 Thread Gerhard Stenzel
This patch adds the ebtables wrapper to the network driver. Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com --- src/conf/network_conf.h | 10 ++ src/libvirt_private.syms| 26 ++ src/network/bridge_driver.c | 179 +++ 3 files

[libvirt] [RFC PATCH 4/6] add MAC address based port filtering to libvirt

2009-10-02 Thread Gerhard Stenzel
This patch adds MAC address based port filtering support to libvirt. Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com --- include/libvirt/libvirt.h.in | 16 ++ src/driver.h | 16 ++ src/libvirt.c| 121

[libvirt] [RFC PATCH 5/6] add MAC address based port filtering to qemu

2009-10-02 Thread Gerhard Stenzel
This patch adds MAC address based port filtering to the qemu driver. Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com --- src/qemu/qemu.conf |3 +++ src/qemu/qemu_conf.c | 14 ++ src/qemu/qemu_conf.h |2 ++ src/qemu/qemu_driver.c | 23

[libvirt] [RFC PATCH 6/6] remove currently unused parameter to pass make check test

2009-10-02 Thread Gerhard Stenzel
This patch removes the currently unused network parameter to pass make check Signed-off-by: Gerhard Stenzel gerhard.sten...@de.ibm.com --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -890,12 +890,10 @@ int virNetworkSetAutostart (virNetworkPtr

Re: [libvirt] Update libvirt API and refs XML files

2009-10-02 Thread Laine Stump
On 10/02/2009 07:16 AM, Daniel P. Berrange wrote: Even without that bug we constantly see changes which cause the re-generation of this file - eg when commiting new APIs like Chris' migration ones people always forget to manually re-generate the XML file before commiting. Or when fixing typos in

[libvirt] [PATCH 0/5] test: Add node device driver

2009-10-02 Thread Cole Robinson
The following patches implement a basic node device driver for the test hypervisor driver. This is useful for unit tests in libvirt users (particularly virtinst). Cole Robinson (5): nodedev: Add locking in nodeNumOfDevices nodedev: Break out virNodeDeviceHasCap to node_conf test: Implement

[libvirt] [PATCH 1/5] nodedev: Add locking in nodeNumOfDevices

2009-10-02 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/node_device/node_device_driver.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index 93ca28c..c902e7d 100644 ---

[libvirt] [PATCH 2/5] nodedev: Break out virNodeDeviceHasCap to node_conf

2009-10-02 Thread Cole Robinson
Will be used by test driver node device implementation. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/node_device_conf.c | 10 ++ src/conf/node_device_conf.h |2 ++ src/libvirt_private.syms |1 + src/node_device/node_device_driver.c

[libvirt] [PATCH 3/5] test: Implement node device driver.

2009-10-02 Thread Cole Robinson
Add a simple 'computer' device for the default driver. Only implement the basic calls, no creation or destroy happening. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/test/test_driver.c | 253 1 files changed, 253 insertions(+), 0

[libvirt] [PATCH 4/5] node conf: Make parsing routines consistent with other drivers

2009-10-02 Thread Cole Robinson
Add virNodeDeviceParseFile, and make virNodeDeviceParseNode non-static. These will be used by the test driver. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/node_device_conf.c | 47 -- src/conf/node_device_conf.h |9 2 files

[libvirt] [PATCH 5/5] test: Support loading node device info from file/XML

2009-10-02 Thread Cole Robinson
Also add some XML examples. Signed-off-by: Cole Robinson crobi...@redhat.com --- examples/xml/test/testdev.xml| 16 + examples/xml/test/testnode.xml |1 + examples/xml/test/testnodeinline.xml | 19 src/test/test_driver.c | 40

[libvirt] [PATCH] 526769 change logrotate config default to weekly

2009-10-02 Thread Daniel Veillard
https://bugzilla.redhat.com/show_bug.cgi?id=526769 Current setup is daily with 7 backups so one week worth of logs per domain in /var/log/libvirt/qemu/*.log First a week worth of backup is a bit short, second for most domains the logs are really small, and with 7 backup files this directory

[libvirt] [PATCHv2 0/8] Python related fixes

2009-10-02 Thread Cole Robinson
The following series fixes various issues related to the python bindings. Cole Robinson (8): configure: Add explict --with-python option. python: Remove FastParser from generator. python: Remove use of xmllib in generator.py python: Don't generate conflicting conn.createXML functions.

[libvirt] [PATCHv2 1/8] configure: Add explict --with-python option.

2009-10-02 Thread Cole Robinson
--with-python currently already works for enabling/disabling the python bindings, but doesn't show up in the help output. Signed-off-by: Cole Robinson crobi...@redhat.com --- configure.in |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/configure.in b/configure.in

[libvirt] [PATCHv2 2/8] python: Remove FastParser from generator.

2009-10-02 Thread Cole Robinson
FastParser uses sgmlop, a non-standard python module meant as a replacement for xmllib (which is deprecated since python 2.0). Fedora doesn't even carry this module, and the generator doesn't have high performance requirements, so just rip the code out. Signed-off-by: Cole Robinson

[libvirt] [PATCHv2 3/8] python: Remove use of xmllib in generator.py

2009-10-02 Thread Cole Robinson
xmllib has been deprecated since python 2.0, and running the generator throws a warning. Move to using xml.sax Signed-off-by: Cole Robinson crobi...@redhat.com --- python/generator.py | 23 +-- 1 files changed, 9 insertions(+), 14 deletions(-) diff --git

[libvirt] [PATCHv2 4/8] python: Don't generate conflicting conn.createXML functions.

2009-10-02 Thread Cole Robinson
A special case in the generator wasn't doing its job, and duplicate conn.createXML functions were being generated. The bindings diff is: @@ -1079,14 +1079,6 @@ class virConnect: return __tmp def createXML(self, xmlDesc, flags): -Create a new device on the VM host machine,

[libvirt] [PATCHv2 5/8] python: Don't generate bindings for vir*Ref

2009-10-02 Thread Cole Robinson
They are only for use in implementing the bindings, so shouldn't be exposed to regular API users. Signed-off-by: Cole Robinson crobi...@redhat.com --- python/generator.py | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/python/generator.py b/python/generator.py

[libvirt] [PATCHv2 6/8] python: Use a pure python implementation of 'vir*GetConnect'

2009-10-02 Thread Cole Robinson
The API docs explictly warn that we shouldn't use the C vir*GetConnect calls in bindings: doing so can close the internal connection pointer and cause things to get screwy. Implement these calls in python. Signed-off-by: Cole Robinson crobi...@redhat.com --- python/generator.py | 21

[libvirt] [PATCHv2 8/8] python: Add a newline after custom classes

2009-10-02 Thread Cole Robinson
In the generated bindings, custom classes are squashed against the following class, which hurts readability. Signed-off-by: Cole Robinson crobi...@redhat.com --- python/generator.py |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/python/generator.py b/python/generator.py

[libvirt] Application using libvirt crashes when having concurrent TLS connections (gnutls problem)

2009-10-02 Thread Thomas Treutner
Hi list, I was wondering about the status of this bug: https://bugzilla.redhat.com/show_bug.cgi?id=512367 Is it correct that this is a bug in the libvirt client? I ran into this today, as I've written a kind of a VM scheduler (ressource requirements, placement etc.) in Java