On Fri, Oct 23, 2009 at 03:13:17PM -0400, Laine Stump wrote:
> If ncf_init() fails, it takes responsibility to call ncf_close() when
> appropriate. Having libvirt call it results in a double close, which
> ends up segv'ing.
Hmm, it would be good if ncf_init set the passed in pointer to NULL
when
On Fri, Oct 23, 2009 at 01:31:19PM -0400, Laine Stump wrote:
> (How's this?)
>
> This patch updates the xml parsing and formatting, and the associated
> virInterfaceDef data structure to support IPv6, along the way adding
> support for multiple protocols per interface, and multiple IP
> addresses
If ncf_init() fails, it takes responsibility to call ncf_close() when
appropriate. Having libvirt call it results in a double close, which
ends up segv'ing.
---
src/interface/netcf_driver.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/src/interface/netcf_driver.c b/s
(How's this?)
This patch updates the xml parsing and formatting, and the associated
virInterfaceDef data structure to support IPv6, along the way adding
support for multiple protocols per interface, and multiple IP
addresses per protocol.
---
src/conf/interface_conf.c | 295 +
On Fri, Oct 16, 2009 at 10:56:19AM -0400, la...@laine.org wrote:
> static int
> -virInterfaceDefParseProtoIPv4(virConnectPtr conn, virInterfaceDefPtr def,
> +virInterfaceDefParseProtoIPv4(virConnectPtr conn, virInterfaceProtocolDefPtr
> def,
>xmlXPathContextPtr ctx
On Fri, Oct 16, 2009 at 10:56:18AM -0400, la...@laine.org wrote:
> From: Laine Stump
>
> This patch adds the flag VIR_INTERFACE_XML_INACTIVE to
> virInterfaceGetXMLDesc's flags. When it is*not* set (the default), the
> live interface info will be returned in the XML (in particular, the IP
> addre
On Fri, Oct 16, 2009 at 10:56:17AM -0400, la...@laine.org wrote:
> From: Laine Stump
>
> The minimal XML returned from ncf_if_xml_state() doesn't contain this
> attribute (which makes no sense in the case of reporting current
> status of the interface), and it was preventing it from passing
> thr
On Fri, Oct 23, 2009 at 05:20:34PM +0200, Stefan wrote:
> Richard W.M. Jones schrieb:
> > On Fri, Oct 23, 2009 at 12:42:20PM +0200, Stefan wrote:
> >> my log files are filled with (5 times per second):
> >> error : invalid domain pointer in no domain with matching id -1
> >
> > "5 times per second
Richard W.M. Jones schrieb:
> On Fri, Oct 23, 2009 at 12:42:20PM +0200, Stefan wrote:
>> my log files are filled with (5 times per second):
>> error : invalid domain pointer in no domain with matching id -1
>
> "5 times per second" is a bit suspicious. Are you running some sort
> of monitoring so
On Fri, Oct 23, 2009 at 04:04:23PM +0100, Richard W.M. Jones wrote:
> On Thu, Oct 22, 2009 at 02:09:01PM +0530, Gandhiraj Natarajan wrote:
> > 2. We need to know how to get the proper operating system like
> > Windows XP or 2000 or 2003?
>
> virt-inspector can tell you it is Windows, and with a bi
On Fri, Oct 23, 2009 at 12:42:20PM +0200, Stefan wrote:
> my log files are filled with (5 times per second):
> error : invalid domain pointer in no domain with matching id -1
"5 times per second" is a bit suspicious. Are you running some sort
of monitoring software or some software which queries
On Thu, Oct 22, 2009 at 02:09:01PM +0530, Gandhiraj Natarajan wrote:
> 1. We need to know how to get the IP addresses of virtual machines running
> in Novel Xen Server?
There's not really a good way to do this. One possibility is to run
'/sbin/arp -an' but it's not a reliable method.
> 2. We
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> We should always be using virGetHostname in place of
> gethostname; thus add in a new syntax-check rule to make
> sure no new uses creep in.
>
> Signed-off-by: Chris Lalancette
> ---
> .x-sc_prohibit_gethostname |2 ++
> Makefile.am
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> Make a pass over the syntax-check files, tightening up regex's,
> un-ignoring certain files, and cleaning things up.
>
> Signed-off-by: Chris Lalancette
> ---
> .x-sc_prohibit_VIR_ERR_NO_MEMORY | 13 +
> .x-sc_prohibit_gethostby
Cole Robinson wrote:
> On 10/23/2009 10:21 AM, Cole Robinson wrote:
>> On 10/23/2009 07:01 AM, Chris Lalancette wrote:
>>> Signed-off-by: Chris Lalancette
>>> ---
>>> src/qemu/qemu_driver.c |4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/src/qemu/qemu_driver
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> We can slightly tighten up the regex's used to detect the use of
> nonreentrant functions. We can also check src/util/virterror.c
> by modifying a comment; I think it's worth it to get the additional
> coverage.
>
> Signed-off-by: Chris Lalancette
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette
> ---
> daemon/libvirtd.c | 10 +++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> index 4eb33bc..02bd287 100644
> --- a/daemon/libvirtd.c
> +++
On 10/23/2009 10:21 AM, Cole Robinson wrote:
> On 10/23/2009 07:01 AM, Chris Lalancette wrote:
>> Signed-off-by: Chris Lalancette
>> ---
>> src/qemu/qemu_driver.c |4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>>
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette
> ---
> src/qemu/qemu_driver.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4cd235d..da7dda7 100644
> --- a/src/qemu/qemu_
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> ---
> src/xen/xend_internal.c | 11 +--
> 1 files changed, 1 insertions(+), 10 deletions(-)
>
> diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
> index 27d215e..d3ab019 100644
> --- a/src/xen/xend_internal.c
> +++ b/src/xe
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette
> ---
> src/libvirt.c | 41 ++---
> 1 files changed, 22 insertions(+), 19 deletions(-)
>
> diff --git a/src/libvirt.c b/src/libvirt.c
> index 9e87900..5787f22 100644
> --- a/sr
Cole Robinson wrote:
> On 10/23/2009 07:01 AM, Chris Lalancette wrote:
>> virFileDeletePID() is unnecessarily called in qemudRemoveDomainStatus().
>> The only caller of qemudRemoveDomainStatus() is qemudShutdownVMDaemon(),
>> and that already calls virFileDeletePID (with a better error message).
>>
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> xenUnifiedDomainEventRegister() calls out to
> virDomainEventCallbackListAdd(), which increments the reference
> count on the connection. That is fine, but then
> xenUnifiedDomainEventRegister() increments the usage count again,
> leading to a usag
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> (original patch from Charles Duffy)
>
> Signed-off-by: Chris Lalancette
> ---
> daemon/libvirtd.c | 11 +++
> 1 files changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> index 03bc1b4..4eb3
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette
> ---
> daemon/libvirtd.c |4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
> index 78dfb2d..03bc1b4 100644
> --- a/daemon/libvirtd.c
> +++ b/dae
On 10/23/2009 07:01 AM, Chris Lalancette wrote:
> virFileDeletePID() is unnecessarily called in qemudRemoveDomainStatus().
> The only caller of qemudRemoveDomainStatus() is qemudShutdownVMDaemon(),
> and that already calls virFileDeletePID (with a better error message).
> Remove the redundant call
On 10/23/2009 07:22 AM, Jon Nordby wrote:
> The problem is due to libvirt using mount.nfs instead of mount.nfs4 for
> NFSv4 shares.
>
> virt-manager tries the following command (see attached file):
> [...@jon-laptop ~]$ sudo /bin/mount 10.0.0.2:/libvirt_install
> /var/lib/libvirt/images/server-ins
Start for on detecting & dispatching async events fed into the
QEMU monitor.
In RHEL-5 fork of QEMU, the 'notify' command turns on events,
and events are prefixed with a leading '#' character.
* src/qemu/qemu_monitor_text.h, src/qemu/qemu_monitor_text.c:
Detect and filter any async events
---
* src/conf/storage_encryption_conf.c: Fix missing VIR_FREE
---
src/conf/storage_encryption_conf.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/conf/storage_encryption_conf.c
b/src/conf/storage_encryption_conf.c
index b97b989..f46e750 100644
--- a/src/conf/storage_e
Change the QEMU monitor file handle watch to poll for both
read & write events, as well as EOF. All I/O to/from the
QEMU monitor FD is now done in the event callback thread.
When the QEMU driver needs to send a command, it puts the
data to be sent into a qemuMonitorMessagePtr object instance,
queu
Add reference counting on the virDomainObjPtr objects. With the
forthcoming asynchronous QEMU monitor, it will be neccessary to
release the lock on virDomainObjPtr while waiting for a monitor
command response. It is neccessary to ensure one thread can't
delete a virDomainObjPtr while another is wai
In preparation of the monitor I/O process becoming fully asynchronous,
it is neccessary to ensure all access to internals of the qemuMonitorPtr
object is protected by a mutex lock.
* src/qemu/qemu_monitor.c: Acquire & release a lock for all monitor
commands
---
src/qemu/qemu_monitor.c | 222 ++
Decouple the monitor code from the virDomainDefPtr structure
by moving the disk encryption lookup code back into the
qemu_driver.c file. Instead provide a function callback to
the monitor code which can be invoked to retrieve encryption
data as required.
* src/qemu/qemu_driver.c: Add findDomainDis
Introduce a new qemuDomainObjPrivate object which is used to store
the private QEMU specific data associated with each virDomainObjPtr
instance. This contains a single member, an instance of the new
qemuMonitorPtr object which encapsulates the QEMU monitor state.
The internals of the latter are pri
The qemu_driver.c code should not contain any code that interacts
with the QEMU monitor at a low level. A previous commit moved all
the command invocations out. This change moves out the code which
actually opens the monitor device.
* src/qemu/qemu_driver.c: Remove qemudOpenMonitor & methods calle
The virStateInitialize() call for starting up stateful drivers
may require that the event loop is running already. This it is
neccessary to start the event loop before this call. At the
same time, network clients must not be processed until afte
virStateInitialize has completed.
The qemudListenUni
The daemonizing code lets the parent exit almost immediately. This
means that it may think it has successfully started even when
important failures occur like not being able to acquire the PID
file. It also means network sockets are not yet open.
To address this when daemonizing the parent passes
* daemon/libvirtd.c: Introduce a daemonSetupSignals() method
and put all signal handling code there
* daemon/libvirtd.h: Add sigread/sigwrite to qemud_server type
---
daemon/libvirtd.c | 128 +++-
daemon/libvirtd.h |1 +
2 files changed, 77 in
The libvirt default error handling callback will print all errors
to stderr. The libvirtd default logging callback will do the same.
Set a no-op error handling callback in libvirtd to prevent this
duplication
* daemon/libvirtd.c: Register a no-op error handling function
---
daemon/libvirtd.c |
A number of driver API methods which acquire the driver mutex
only ever used the driver object in a read-only fashion. All
these uses are converted to call qemuDriverLockRO() allowing
for greater concurrency.
* src/qemu/qemu_conf.h: s/Mutex/RWLock/
* src/qemu/qemu_driver.c: Add a qemuDriverLockRO(
* daemon/libvirtd.c: Change qemudNetworkInit() so that it doesn't try
to free its argument, leaving the caller todo cleanup as is normal
practice. Add missing policykit cleanup to qemudCleanup, and remove
server watch if set. Remove duplicated call to listen() on TCP sockets
---
daemon/libvirtd.c
virInitialize must be the first libvirt function called to ensure
threads, error handling & random number generator are all setup.
Move UNIX socket directory permissions change to place of use
---
daemon/libvirtd.c | 21 ++---
1 files changed, 10 insertions(+), 11 deletions(-)
Nearly all of the methods in src/util/util.h have error codes that
must be checked by the caller to correct detect & report failure.
Add ATTRIBUTE_RETURN_CHECK to ensure compile time validation of
this
* daemon/libvirtd.c: Add explicit check on return value of virAsprintf
* src/conf/domain_conf.c:
The virDomainObjPtr object stores state about a running domain.
This object is shared across all drivers so it is not appropriate
to include driver specific state here. This patch adds the ability
to request a blob of private data per domain object instance. The
driver must provide a allocator & de
This implements a thin wrapper around the pthread_rwlock
primitives. No impl is provided for Win32 at this time
since it is rather hard, and none of our code yet requires
it on Win32
* src/util/threads.h: Add virRWLockInit, virRWLockDestroy,
virRWLockRead, virRWLockWrite, virRWLockUnlock APIs
*
This patch series rewrites the QEMU monitor handling almost completely.
The key theme here is to move from a totally synchronous way of
interacting with the monitor, to a totally asynchronous way. This
allows us to handle receipt & dispatch of asychronous events from
QEMU. For example a notificati
Daniel Berteaud wrote:
[...]
>> > I just want libvirt to attach the guest's tap devices to this existing
>> > bridge. I don't want libvirt to manage the network.
>> >
>> > Is there any chance to realize this set-up?
>> > It should work with virt-manager using the graphical wizard.
>>
>> Yes, jus
We should always be using virGetHostname in place of
gethostname; thus add in a new syntax-check rule to make
sure no new uses creep in.
Signed-off-by: Chris Lalancette
---
.x-sc_prohibit_gethostname |2 ++
Makefile.am|1 +
cfg.mk |5 +
src/lib
Make a pass over the syntax-check files, tightening up regex's,
un-ignoring certain files, and cleaning things up.
Signed-off-by: Chris Lalancette
---
.x-sc_prohibit_VIR_ERR_NO_MEMORY | 13 +
.x-sc_prohibit_gethostby |5 ++---
.x-sc_prohibit_strcmp_and_strncmp |7
Signed-off-by: Chris Lalancette
---
daemon/libvirtd.c | 10 +++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 4eb33bc..02bd287 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -937,15 +937,19 @@ static struct qemud_ser
We can slightly tighten up the regex's used to detect the use of
nonreentrant functions. We can also check src/util/virterror.c
by modifying a comment; I think it's worth it to get the additional
coverage.
Signed-off-by: Chris Lalancette
---
.x-sc_prohibit_nonreentrant |8
src/util
Signed-off-by: Chris Lalancette
---
src/qemu/qemu_driver.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 4cd235d..da7dda7 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4142,7 +4142,7 @@ qemu
---
src/xen/xend_internal.c | 11 +--
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c
index 27d215e..d3ab019 100644
--- a/src/xen/xend_internal.c
+++ b/src/xen/xend_internal.c
@@ -4342,21 +4342,12 @@ xenDaemonDomainMigrate
Signed-off-by: Chris Lalancette
---
src/libvirt.c | 41 ++---
1 files changed, 22 insertions(+), 19 deletions(-)
diff --git a/src/libvirt.c b/src/libvirt.c
index 9e87900..5787f22 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -3154,7 +3154,7 @@ virDomainM
xenUnifiedDomainEventRegister() calls out to
virDomainEventCallbackListAdd(), which increments the reference
count on the connection. That is fine, but then
xenUnifiedDomainEventRegister() increments the usage count again,
leading to a usage count leak. Remove the increment in the xen
register, a
(original patch from Charles Duffy)
Signed-off-by: Chris Lalancette
---
daemon/libvirtd.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 03bc1b4..4eb33bc 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -250
Signed-off-by: Chris Lalancette
---
daemon/libvirtd.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 78dfb2d..03bc1b4 100644
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -2972,7 +2972,9 @@ int main(int argc, char **arg
When working with the TLS transport, I noticed that every single time
a remote stream was closed, I would get a message like:
09:09:40.793: error : remoteIOReadBuffer:7328 : failed to read from TLS socket
A TLS packet with unexpected length was received.
libvir: QEMU error : failed to read from T
virFileDeletePID() is unnecessarily called in qemudRemoveDomainStatus().
The only caller of qemudRemoveDomainStatus() is qemudShutdownVMDaemon(),
and that already calls virFileDeletePID (with a better error message).
Remove the redundant call here.
Signed-off-by: Chris Lalancette
---
src/qemu/qe
Hello,
my log files are filled with (5 times per second):
error : invalid domain pointer in no domain with matching id -1
My system:
libvirt 0.6.1, Ubuntu 9.04, 2.6.28-15-server #52-Ubuntu x86_64
Any ideas ?
Thanks
Stefan
--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redh
60 matches
Mail list logo
