[libvirt] [PATCH 9/9] phyp: Use actual error code instead 0

2009-11-05 Thread Matthias Bolte
--- src/phyp/phyp_driver.c | 71 +++- 1 files changed, 28 insertions(+), 43 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 6263fd2..a92046a 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -61,6 +61,

[libvirt] [PATCH 8/9] phyp: Don't use VIR_ALLOC if a stack variable is good enough

2009-11-05 Thread Matthias Bolte
--- src/phyp/phyp_driver.c | 47 ++- 1 files changed, 14 insertions(+), 33 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 43430a9..6263fd2 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1131,29 +1

[libvirt] [PATCH 7/9] phyp: Fix several UUID table related problems

2009-11-05 Thread Matthias Bolte
- Make reading ID from file working for IDs > 127 - Fix inverse error check for writing ID to file - Use feof() to distinguish EOF from real error of fread() - Don't interpret libssh2 error codes as number of bytes --- src/phyp/phyp_driver.c | 19 --- 1 files changed, 12 insertio

[libvirt] [PATCH 6/9] phyp: Check for exit_status < 0 before parsing the result

2009-11-05 Thread Matthias Bolte
--- src/phyp/phyp_driver.c | 35 --- 1 files changed, 12 insertions(+), 23 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index ab5af17..1529c24 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -508,7 +508,7 @@ phypGe

[libvirt] [PATCH 5/9] phyp: memcpy/memmove/memset can't fail, so don't check for error

2009-11-05 Thread Matthias Bolte
Also reset UUID to all 0 instead of all 48 (== '0') in phypUUIDTable_RemLpar() --- src/phyp/phyp_driver.c | 20 1 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 8d54ae7..ab5af17 100644 --- a/src/phyp/phyp_d

[libvirt] [PATCH 4/9] phyp: Make generic domain listing functions return -1 in case of error

2009-11-05 Thread Matthias Bolte
phypNumDomainsGeneric() and phypListDomainsGeneric() return 0 in case of an error. This makes it impossible to distinguish between an actual error and no domains being defined on the hypervisor. It also turn the no domains situation into an error. Return -1 in case of an error to fix this problem.

[libvirt] [PATCH 1/9] Fix configure check for libssh2

2009-11-05 Thread Matthias Bolte
* configure.in: add -L$libssh2_path to LIBS for the AC_TRY_LINK check --- configure.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.in b/configure.in index 7afbc7c..7ad1a90 100644 --- a/configure.in +++ b/configure.in @@ -977,7 +977,7 @@ if test "$with_phyp"

[libvirt] [PATCH 2/9] phyp: Fix memory/session leaks and potential invalid frees

2009-11-05 Thread Matthias Bolte
--- src/phyp/phyp_driver.c | 285 --- src/phyp/phyp_driver.h |2 + 2 files changed, 172 insertions(+), 115 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 8e199ee..5379cd3 100644 --- a/src/phyp/phyp_driver.c +++ b/sr

[libvirt] [PATCH 3/9] phyp: Break potential infinite loops

2009-11-05 Thread Matthias Bolte
--- src/phyp/phyp_driver.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 5379cd3..b94d0fa 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1040,9 +1040,13 @@ phypListDomainsGeneric(virC

[libvirt] [PATCH 0/9] Several bug fixes for the Power Hypervisor driver

2009-11-05 Thread Matthias Bolte
After the last large patch has been applied I reviewed the whole driver code and found several bugs and issues. Most important memory leaks and two potential infinite loops. I've no Power Hypervisor at hand, so I can't test this changes with an actual system. Eduardo could you test this patches to

[libvirt] [PATCH] LXC implement missing lxcDomainInterfaceStats (domifstat)

2009-11-05 Thread Ryota Ozaki
Most part of code is just copied from qemu_driver.c. * src/lxc/lxc_driver.c: add lxcDomainInterfaceStats --- src/lxc/lxc_driver.c | 62 +- 1 files changed, 61 insertions(+), 1 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c

Re: [libvirt] Remote access and libvirtd

2009-11-05 Thread Matthias Bolte
2009/11/5 Dave Bryson : > Max, > > Essentially I want to be able to access ESX remotely using the libvirt > python binding to mainly control a VM (start,stop,suspend,snapshot).  My > concern was that I needed to install and run libvirtd on ESX to do that. >  But it sounds like the libvirt ESX suppo

[libvirt] [PATCH] only remove masquerade rules in NAT mode

2009-11-05 Thread Guido Günther
Hi, attached patch makes sure we only remove the masquerade rules if forwardType == VIR_NETWORK_FORWARD_NAT and not if forwardType == VIR_NETWORK_FORWARD_ROUTE since we don't use them there. This fixes: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=549949 O.k. to apply? -- Guido >From 8

Re: [libvirt] Remote access and libvirtd

2009-11-05 Thread Dave Bryson
Max, Essentially I want to be able to access ESX remotely using the libvirt python binding to mainly control a VM (start,stop,suspend,snapshot). My concern was that I needed to install and run libvirtd on ESX to do that. But it sounds like the libvirt ESX support essentially uses the SO