[libvirt] [PATCH] Whitespace cleanup for pre-tags on the website

2009-11-13 Thread Matthias Bolte
--- docs/drvlxc.html.in | 80 +- docs/drvone.html.in | 89 +++-- docs/drvopenvz.html.in| 22 +++--- docs/drvqemu.html.in | 48 ++-- docs/drvtest.html.in | 16 ++-- docs/drvuml.html.in | 22 +++--- docs/drvvbox.html

[libvirt] [PATCH] Change DTD references to use public instead of system identifier

2009-11-13 Thread Matthias Bolte
Debian's /etc/xml/catalog doesn't contain system identifiers, so use public identifiers instead. * docs/Makefile.am: use public instead of system identifier * docs/site.xsl: use matching public identifier --- docs/Makefile.am |6 +++--- docs/site.xsl|2 +- 2 files changed, 4 insertion

[libvirt] [PATCH] esx: Handle 'vmxnet3' in esxVMX_FormatEthernet()

2009-11-13 Thread Matthias Bolte
In commit 3c80fac2588cbc9e5ee7e7069e1ca4468f2359d3 'vmxnet3' handling was added to esxVMX_ParseEthernet(), but not to the inverse function esxVMX_FormatEthernet(). --- src/esx/esx_vmx.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/esx/esx_vmx.c b/src/esx/esx_

[libvirt] [PATCH] esx: Add documentation to the website

2009-11-13 Thread Matthias Bolte
* docs/drivers.html.in: list the ESX driver * docs/drvesx.html.in: the new ESX driver documentation * docs/hvsupport.html.in: add the ESX driver to the matrix * docs/index.html.in, docs/sitemap.html.in: list the ESX driver * src/esx/esx_driver.c: fix and cleanup some comments --- docs/drivers.html

[libvirt] [PATCH] fix detach-disk for inactive xen domains

2009-11-13 Thread Jim Fehlig
detach-disk was not working for inactive xen domains due to lookup of device ID from xenstore. When detaching disks there is no need to use device id as device name can be used directly. Unfortunately that same is not true for network devices. In fact, AFAICT, there is no way to "hot unplug" a n

Re: [libvirt] make install fails, missing HTML files

2009-11-13 Thread Matthias Bolte
2009/11/13 Thomas Treutner : > On Friday 13 November 2009 16:41:02 Matthias Bolte wrote: >> Ah, I can reproduce your pastebin'ed output if I uninstall xsltproc. >> So I assume you're missing the xsltproc package. The Makefile output >> is not very helpful in this situation, it tries to validate fil

[libvirt] [PATCH] Fix compilation of libvirt against xen-unstable

2009-11-13 Thread Jim Fehlig
libvirt fails to compile against current xen-unstable. This patch fixes it. Regards, Jim commit d08067f04248c7f1bd797f4401308ea9a8971f1b Author: Jim Fehlig Date: Fri Nov 13 14:44:56 2009 -0700 xen-unstable changeset 19788 removed MAX_VIRT_CPUS from public headers, breaking compilatio

Re: [libvirt] make install fails, missing HTML files

2009-11-13 Thread Thomas Treutner
On Friday 13 November 2009 16:41:02 Matthias Bolte wrote: > Ah, I can reproduce your pastebin'ed output if I uninstall xsltproc. > So I assume you're missing the xsltproc package. The Makefile output > is not very helpful in this situation, it tries to validate files that > have not been generated,

Re: [libvirt] [PATCH] only remove masquerade rules in NAT mode

2009-11-13 Thread Guido Günther
On Thu, Nov 05, 2009 at 08:35:20PM +0100, Guido Günther wrote: > Hi, > attached patch makes sure we only remove the masquerade rules if > forwardType == VIR_NETWORK_FORWARD_NAT and not if forwardType == > VIR_NETWORK_FORWARD_ROUTE since we don't use them there. This fixes: > http://bugs.debia

Re: [libvirt] [Patch v0.4] iSCSI Multi-IQN (Libvirt Support)

2009-11-13 Thread Daniel Veillard
On Fri, Nov 13, 2009 at 05:18:54PM +0530, sudhir_bel...@dell.com wrote: > The following patch set realizes the multi-IQN concept discussed in an > earlier thread > http://www.mail-archive.com/libvir-list@redhat.com/msg16706.html > > And here .. > http://www.mail-archive.com/libvir-list@redhat.com/

[libvirt] [PATCH] Make QEMU driver use -chardev everywhere when it's available

2009-11-13 Thread Matthew Booth
Change -monitor, -serial and -parallel output to use -chardev if it is available. * src/qemu/qemu_conf.c: Update qemudBuildCommandLine to use -chardev where available. * tests/qemuxml2argvtest.c tests/qemuxml2argvdata/: Add -chardev equivalents for all current serial and parallel tests. --- s

Re: [libvirt] make install fails, missing HTML files

2009-11-13 Thread Matthias Bolte
2009/11/13 Matthias Bolte : > 2009/11/13 Thomas Treutner : >> On Thursday 12 November 2009 16:01:39 Matthias Bolte wrote: >>> I came across this problem some time ago, too. I'm using Ubuntu, so >>> it's basically Debian. >>> >>> I somewhat solved it by hacking my /etc/xml/catalog. I added this into

Re: [libvirt] make install fails, missing HTML files

2009-11-13 Thread Matthias Bolte
2009/11/13 Thomas Treutner : > On Thursday 12 November 2009 16:01:39 Matthias Bolte wrote: >> I came across this problem some time ago, too. I'm using Ubuntu, so >> it's basically Debian. >> >> I somewhat solved it by hacking my /etc/xml/catalog. I added this into >> the element: >> >> >   systemI

[libvirt] Entering freeze for 0.7.3

2009-11-13 Thread Daniel Veillard
I think that all expected feature patches have been pushed to git head so it's time to enter feature freeze, and just do cleanup and bug fixing patches until next friday. So the plan is to get 0.7.3 out on the 20th and we then have one month before the end of year holliday season to push the fo

Re: [libvirt] [PATCH 2/2] Don't return fatal error in HAL driver init if HAL isn't running

2009-11-13 Thread Daniel P. Berrange
On Fri, Nov 13, 2009 at 10:14:22PM +0900, Ryota Ozaki wrote: > On Fri, Nov 13, 2009 at 9:21 PM, Daniel P. Berrange > wrote: > > The HAL driver returns a fatal error code in the case where HAL > > is not running. This causes the entire libvirtd daemon to quit > > which isn't desirable. Instead it

Re: [libvirt] [PATCH 2/2] guestfwd code tidy up

2009-11-13 Thread Daniel Veillard
On Fri, Nov 13, 2009 at 12:42:12PM +, Matthew Booth wrote: > This patch removes qemudBuildCommandLineChrDevTargetStr and inlines its single > use. It was intended to be generic, but on reflection this can't work. Instead > it just makes the code slightly harder to read. > > * src/qemu/qemu_con

Re: [libvirt] [PATCH 2/2] Don't return fatal error in HAL driver init if HAL isn't running

2009-11-13 Thread Daniel Veillard
On Fri, Nov 13, 2009 at 12:21:11PM +, Daniel P. Berrange wrote: > The HAL driver returns a fatal error code in the case where HAL > is not running. This causes the entire libvirtd daemon to quit > which isn't desirable. Instead it should simply disable the HAL > driver > > * src/node_device/no

Re: [libvirt] [PATCH 1/2] Fix cleanup when state driver init fails

2009-11-13 Thread Daniel Veillard
On Fri, Nov 13, 2009 at 12:21:10PM +, Daniel P. Berrange wrote: > * daemon/libvirtd.c: Fix incorrect goto label causing cleanup to > be missed when state driver init fails > --- > daemon/libvirtd.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/daemon/libvirt

Re: [libvirt] [PATCH 2/2] Fix probing for libpciaccess

2009-11-13 Thread Daniel Veillard
On Fri, Nov 13, 2009 at 12:20:07PM +, Daniel P. Berrange wrote: > If 'with_udev=check' then missing pciaccess should not be a fatal > error. It should merely disable the udev driver. > > * configure.in: Fix pciaccess check to be non-fatal > --- > configure.in | 33 +-

Re: [libvirt] [PATCH 1/2] Remove obsolte devicekit checks

2009-11-13 Thread Daniel Veillard
On Fri, Nov 13, 2009 at 12:20:06PM +, Daniel P. Berrange wrote: > Device kit support was removed, but the configure.ac checks were > left in place. A number of the XXX_REQUIRED=X.Y.Z variables were > not declared in the correct location (ie top of the file) > > * configure.in: Remove device ki

Re: [libvirt] [PATCH 0/4] AppArmor updates

2009-11-13 Thread Daniel Veillard
On Thu, Nov 12, 2009 at 11:47:38AM -0600, Jamie Strandboge wrote: > Hi, > > The following patchset contains various cleanups for the AppArmor > driver. It assumes that the patch contained in the email with the > following subject is already applied: > > [libvirt] [PATCH] fix virt-aa-helper failur

Re: [libvirt] [PATCH 2/2] Don't return fatal error in HAL driver init if HAL isn't running

2009-11-13 Thread Ryota Ozaki
On Fri, Nov 13, 2009 at 9:21 PM, Daniel P. Berrange wrote: > The HAL driver returns a fatal error code in the case where HAL > is not running. This causes the entire libvirtd daemon to quit > which isn't desirable. Instead it should simply disable the HAL > driver I'm not sure what happens on thi

Re: [libvirt] [PATCH] Fix incorrect reference counting logic in qemu monitor open

2009-11-13 Thread Ryota Ozaki
On Fri, Nov 13, 2009 at 8:45 PM, Daniel P. Berrange wrote: > The QEMU monitor open method would not take a reference on > the virDomainObjPtr until it had successfully opened the > monitor. The cleanup code upon failure to open though would > call qemuMonitorClose() which would in turn decrement t

Re: [libvirt] Segmentation fault when shutting down VMs

2009-11-13 Thread Thomas Treutner
On Friday 13 November 2009 12:46:24 Daniel P. Berrange wrote: > I'm still trying to figure out what's going on with the first problem Uhm, it's getting stranger. When trying to do: # export LIBVIRT_DEBUG=1 # strace -o libvirt.log -s 1000 -ff libvirtd -l -v strace crashes with: *** glibc detec

[libvirt] [PATCH 2/2] guestfwd code tidy up

2009-11-13 Thread Matthew Booth
This patch removes qemudBuildCommandLineChrDevTargetStr and inlines its single use. It was intended to be generic, but on reflection this can't work. Instead it just makes the code slightly harder to read. * src/qemu/qemu_conf.c: Remove and inline qemudBuildCommandLineChrDevTargetStr --- src/qemu

[libvirt] [PATCH 1/2] Fix guestfwdTarget indentation in domain.rng

2009-11-13 Thread Matthew Booth
* docs/schemas/domain.rng: Fix up some 4 space indentation --- docs/schemas/domain.rng | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index b75f17e..1bf44fd 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/

Re: [libvirt] [PATCH 1/2] Fix cleanup when state driver init fails

2009-11-13 Thread Ryota Ozaki
On Fri, Nov 13, 2009 at 9:21 PM, Daniel P. Berrange wrote: > * daemon/libvirtd.c: Fix incorrect goto label causing cleanup to >  be missed when state driver init fails > --- >  daemon/libvirtd.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/daemon/libvirtd.c b/daem

[libvirt] [PATCH 2/2] Don't return fatal error in HAL driver init if HAL isn't running

2009-11-13 Thread Daniel P. Berrange
The HAL driver returns a fatal error code in the case where HAL is not running. This causes the entire libvirtd daemon to quit which isn't desirable. Instead it should simply disable the HAL driver * src/node_device/node_device_hal.c: Quietly disable HAL if it is not running --- src/node_device

[libvirt] [PATCH 1/2] Fix cleanup when state driver init fails

2009-11-13 Thread Daniel P. Berrange
* daemon/libvirtd.c: Fix incorrect goto label causing cleanup to be missed when state driver init fails --- daemon/libvirtd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index ef07460..1caa4ce 100644 --- a/daemon/libvirtd.c +++

[libvirt] [PATCH 2/2] Fix probing for libpciaccess

2009-11-13 Thread Daniel P. Berrange
If 'with_udev=check' then missing pciaccess should not be a fatal error. It should merely disable the udev driver. * configure.in: Fix pciaccess check to be non-fatal --- configure.in | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/config

[libvirt] [PATCH 1/2] Remove obsolte devicekit checks

2009-11-13 Thread Daniel P. Berrange
Device kit support was removed, but the configure.ac checks were left in place. A number of the XXX_REQUIRED=X.Y.Z variables were not declared in the correct location (ie top of the file) * configure.in: Remove device kit checks & move mis-placed variables to correct location --- configure.in |

Re: [libvirt] [PATCH 4/5] Fix incorrect variable passed to LXC event callback

2009-11-13 Thread Ryota Ozaki
On Fri, Nov 13, 2009 at 8:49 PM, Daniel P. Berrange wrote: > On Fri, Nov 13, 2009 at 06:01:46AM +0900, Ryota Ozaki wrote: >> On Fri, Nov 13, 2009 at 12:00 AM, Daniel P. Berrange >> wrote: >> > The wrong variable was being passed in with the LXC event callback >> > resulting in a later deadlock or

[libvirt] [Patch v0.4] iSCSI Multi-IQN (Libvirt Support)

2009-11-13 Thread Sudhir_Bellad
The following patch set realizes the multi-IQN concept discussed in an earlier thread http://www.mail-archive.com/libvir-list@redhat.com/msg16706.html And here .. http://www.mail-archive.com/libvir-list@redhat.com/msg17499.html The patch realizes an XML schema like the one below and allows libvir

Re: [libvirt] [PATCH 4/5] Fix incorrect variable passed to LXC event callback

2009-11-13 Thread Daniel P. Berrange
On Fri, Nov 13, 2009 at 06:01:46AM +0900, Ryota Ozaki wrote: > On Fri, Nov 13, 2009 at 12:00 AM, Daniel P. Berrange > wrote: > > The wrong variable was being passed in with the LXC event callback > > resulting in a later deadlock or crash > > > > * src/lxc/lxc_driver.c: Pass 'vm' instead of 'drive

Re: [libvirt] Segmentation fault when shutting down VMs

2009-11-13 Thread Daniel P. Berrange
On Fri, Nov 13, 2009 at 11:42:46AM +0100, Thomas Treutner wrote: > Hi, > > I'm facing another problem with latest git. > > This happens regularly when shutting down VM(s): > > http://pastebin.com/m4ef1d93f > > It doesn't depend on which or how many VM is/are shut down, or if I have a > VNC >

[libvirt] [PATCH] Fix incorrect reference counting logic in qemu monitor open

2009-11-13 Thread Daniel P. Berrange
The QEMU monitor open method would not take a reference on the virDomainObjPtr until it had successfully opened the monitor. The cleanup code upon failure to open though would call qemuMonitorClose() which would in turn decrement the reference count. This caused the virDoaminObjPtr to be mistakenly

[libvirt] Segmentation fault when shutting down VMs

2009-11-13 Thread Thomas Treutner
Hi, I'm facing another problem with latest git. This happens regularly when shutting down VM(s): http://pastebin.com/m4ef1d93f It doesn't depend on which or how many VM is/are shut down, or if I have a VNC connection to a VM that is shutting down. Sometimes after a segv, I get this: http://pa

Re: [libvirt] [PATCH] Fix initscript to check daemon pidfile

2009-11-13 Thread Daniel Veillard
On Thu, Nov 12, 2009 at 07:33:30PM +, Daniel P. Berrange wrote: > The libvirtd initscript could get confused between the system and > session instances of the daemon. To avoid this it is neccessary > to check the pidfile explicitly. > > * daemon/libvirtd.init.in: Always check the pidfile of th

Re: [libvirt] [PATCH] fix virt-aa-helper failure when host arch and os.type arch are different

2009-11-13 Thread Daniel Veillard
On Fri, Oct 16, 2009 at 01:38:23PM +0100, Daniel P. Berrange wrote: > On Wed, Oct 14, 2009 at 05:29:02PM -0500, Jamie Strandboge wrote: > > This is a fix for Ubuntu bug #448671[1]. virt-aa-helper's > > get_definition() now calls the new caps_mockup() function which will > > parse the XML for os.typ

Re: [libvirt] make install fails, missing HTML files

2009-11-13 Thread Thomas Treutner
On Thursday 12 November 2009 16:01:39 Matthias Bolte wrote: > I came across this problem some time ago, too. I'm using Ubuntu, so > it's basically Debian. > > I somewhat solved it by hacking my /etc/xml/catalog. I added this into > the element: > >systemIdStartString="http://www.w3.org/TR/xhtm

Re: [libvirt] [PATCH 5/5] Check that domain is running when starting console

2009-11-13 Thread Daniel Veillard
On Thu, Nov 12, 2009 at 03:00:51PM +, Daniel P. Berrange wrote: > The 'virsh console' command did not check if the domain was > already running before attempting to fetch the XML and extract > the console PTY path. This caused a slightly unhelpful / misleading > error message for the user. The

Re: [libvirt] [PATCH 2/5] Fix race condition in HAL driver startup

2009-11-13 Thread Daniel Veillard
On Thu, Nov 12, 2009 at 03:00:48PM +, Daniel P. Berrange wrote: > There is a race condition in HAL driver startup where the callback > can get triggered before we have finished startup. This then causes > a deadlock in the driver. > > * src/node_device/node_device_hal.c: RElease driver lock be

Re: [libvirt] [PATCH 1/5] Fix formatting of XML for an inactive guest

2009-11-13 Thread Daniel Veillard
On Thu, Nov 12, 2009 at 03:00:47PM +, Daniel P. Berrange wrote: > If the virDomainDefPtr object has an 'id' of -1, then forcably > set the VIR_DOMAIN_XML_INACTIVE flag to ensure generated XML > does not include any cruft from the previously running guest > such as console PTY path, or VNC port.