Re: [libvirt] [PATCH 14/14] Hook up JSON monitor to emit basic lifecycle events

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > * src/qemu/qemu_monitor_json.c: Hook up reset, shutdown, >  poweroff and stop events > --- >  src/qemu/qemu_monitor_json.c |   69 > -- >  1 files changed, 66 insertions(+), 3 deletions(-) > > diff --git a/src/qemu/qemu_monit

Re: [libvirt] [PATCH 13/14] Add QEMU monitor callbacks for basic lifecycle events

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h: Add callbacks >  for reset, shutdown, poweroff and stop events. Add convenience >  methods for emiting those events > --- ACK. Matthias -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/

Re: [libvirt] [PATCH 12/14] Switch over to passing a callback table to QEMU monitor

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > With addition of events there will be alot of callbacks. > To avoid having to add many APIs to register callbacks, > provide them all at once in a big table > > * src/qemu/qemu_driver.c: Pass in a callback table to QEMU >  monitor code > * src/qemu/qemu_monitor.c,

Re: [libvirt] [PATCH 11/14] Support for JSON mode monitor

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > Initial support for the new QEMU monitor protocol  using JSON > as the data encoding format instead of plain text > > * po/POTFILES.in: Add src/qemu/qemu_monitor_json.c > * src/qemu/qemu_conf.c, src/qemu/qemu_conf.h: Hack to turn on QMP >  mode. Replace with a vers

Re: [libvirt] [PATCH 10/14] Introduce callbacks for serializing domain object private data to XML

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > Now that drivers are using a private domain object state blob, > the virDomainObjFormat/Parse methods are no longer able to > directly serialize all neccessary state to/from XML. It is > thus neccessary to introduce a pair of callbacks fo serializing > private stat

Re: [libvirt] [PATCH 09/14] Switch LXC driver to use a private data blob for virDomainObj state

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > * src/lxc/lxc_driver.c: Introduce lxcDomainObjPrivate for storing >  monitor device state > --- >  src/lxc/lxc_driver.c |   84 +++-- >  1 files changed, 67 insertions(+), 17 deletions(-) > > diff --git a/src/lxc/lxc_drive

Re: [libvirt] [PATCH 08/14] Switch UML driver to use a private data blob for virDomainObj state

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > * src/uml/uml_driver.c: Introduce umlDomainObjPrivateData for storing >  monitor device state. Remove unneccessary VIR_FREE on vcpupids > --- ACK. Matthias -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 07/14] Pull code to start CPUs executing out of qemudInitCpuAffinity()

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > The code to start CPUs executing has nothing todo with CPU > affinity masks, so pull it out of the qemudInitCpuAffinity() > method and up into qemudStartVMDaemon() > > * src/qemu/qemu_driver.c: Pull code to start CPUs executing out >  of qemudInitCpuAffinity() > --

Re: [libvirt] [PATCH 06/14] Add a 'format' arg to qemuMonitorChangeMedia() since JSON will support it

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > The current QEMU disk media change does not support setting the > disk format. The new JSON monitor will support this, so add an > extra parameter to pass this info in > > * src/qemu/qemu_driver.c: Pass in disk format when changing media > * src/qemu/qemu_monitor.h

Re: [libvirt] [PATCH 05/14] Fix migration cancellation for QEMU

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > * src/qemu/qemu_monitor_text.c: Add missing underscore in the >  migrate_cancel monitor command impl > --- ACK. Matthias -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 04/14] Move qemuMonitorEscape + migrate status enum into shared monitor code

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > The qemuMonitorEscape() method, and the VIR_ENUM for migration > status will be needed by the JSON monitor too, so move that code > into the shared qemu_monitor.c file instead of qemu_monitor_text.c > > * src/qemu/qemu_monitor.h: Declare qemuMonitorMigrationStatus

Re: [libvirt] [PATCH 03/14] Fix crash when deleting monitor while a command is in progress

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > If QEMU shuts down while we're in the middle of processing a > monitor command, the monitor will be freed, and upon cleaning > up we attempt to do  qemuMonitorUnlock(priv->mon) when priv->mon > is NULL. > > To address this we introduce proper reference counting int

Re: [libvirt] [PATCH 02/14] Add --system flag to autogen.sh to make it easy to build with right prefix

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > Add a --system flag to autogen.sh which gets turned into the args > --prefix=/usr --sysconfdir=/etc --localstatedir=/var to make it > easy to build with settings that match an RPM build > > * autogen.sh: Add --system flag > --- >  autogen.sh |   12 ++-- >  

Re: [libvirt] [PATCH 01/14] Introduce a simple API for handling JSON data

2009-12-02 Thread Matthias Bolte
2009/11/26 Daniel P. Berrange : > This introduces simple API for handling JSON data. There is > an internal data structure 'virJSONValuePtr' which stores a > arbitrary nested JSON value (number, string, array, object, > nul, etc).  There are APIs for constructing/querying objects > and APIs for par

[libvirt] [PATCH] Fix some locking issues

2009-12-02 Thread Matthias Bolte
* src/conf/domain_conf.c: don't call virDomainObjUnlock twice * src/qemu/qemu_driver.c: relock driver lock if an error occurs in qemuDomainObjBeginJobWithDriver, enter/exit monitor with driver in qemudDomainSave --- src/conf/domain_conf.c |1 - src/qemu/qemu_driver.c |9 + 2 fi

Re: [libvirt] [PATCH v2] Disk- and Controller Hotplug

2009-12-02 Thread Wolfgang Mauerer
Hi, Some time ago, Daniel P. Berrange wrote: > On Tue, Nov 24, 2009 at 02:15:58PM +0100, Wolfgang Mauerer wrote: >> Daniel P. Berrange wrote: >>> On Mon, Nov 23, 2009 at 02:15:06PM +0100, Wolfgang Mauerer wrote: Daniel P. Berrange wrote: > Wolfgang Mauerer wrote: >> okay, to avoid floodi

Re: [libvirt] Re: virDomainCreate() response time

2009-12-02 Thread Daniel P. Berrange
On Wed, Dec 02, 2009 at 01:33:58PM -0500, Christopher Pyper wrote: > I am using xen with libvirt and I have very slow response times with > calls to virDomainCreate(). It takes approximately 5-6 seconds to > return. Other calls like virDomainReboot() or virtDomainShutdown() > return immediately

[libvirt] Re: virDomainCreate() response time

2009-12-02 Thread Christopher Pyper
I am using xen with libvirt and I have very slow response times with calls to virDomainCreate(). It takes approximately 5-6 seconds to return. Other calls like virDomainReboot() or virtDomainShutdown() return immediately. Do you know what might be causing this, and how I might speed this up.

[libvirt] About libvirt API Support event notification mechanism problem

2009-12-02 Thread ajia
Dear Daniel, Recently, I am writing test plan about libvirt asynchronous event mechanism, refering to the following bugs from the bugzilla: spice/vnc: https://bugzilla.redhat.com/show_bug.cgi?id=515268 disk error: https://bugzilla.redhat.com/show_bug.cgi?id=515270 I know libvirt can communicate