[libvirt] Re: [PATCH 4/6] remote-driver: Add domainMemoryStats support

2009-12-18 Thread Daniel P. Berrange
On Fri, Dec 18, 2009 at 09:36:11AM -0600, Adam Litke wrote: > On Fri, 2009-12-18 at 10:30 +, Daniel P. Berrange wrote: > > On Thu, Dec 17, 2009 at 05:41:45PM -0500, Adam Litke wrote: > > > Use a dynamically sized xdr_array to pass memory stats on the wire. This > > > supports the addition of f

Re: [libvirt] [PATCH 00/13] esx: Automatic question handling and other improvements

2009-12-18 Thread Matthias Bolte
2009/12/17 Daniel Veillard : > On Sun, Dec 13, 2009 at 12:20:37AM +0100, Matthias Bolte wrote: >> Automatic question handling is the most important part of this series, >> see src/esx/README for more details. >> >> Matthias Bolte (13): >>   esx: Add automatic question handling >>   esx: Improve dom

Re: [libvirt] [PATCH] Fix compilation with gcrypt < 1.4.2

2009-12-18 Thread Matthias Bolte
2009/12/18 Daniel Veillard : > On Fri, Dec 18, 2009 at 12:10:08PM +0100, Matthias Bolte wrote: >> Commit 33a198c1f6a4a1bc7f34d50a31032e03bec10fee increased the gcrypt >> version requirement to 1.4.2 because the GCRY_THREAD_OPTION_VERSION >> define was added in this version. >> >> The configure scri

[libvirt] [PATCH 3/6] qemu-driver: Enable domainMemStats in the qemu driver

2009-12-18 Thread Adam Litke
Support for memory statistics reporting is accepted for qemu inclusion. Statistics are reported via the monitor command 'info balloon' as a comma seprated list: (qemu) info balloon balloon: actual=1024,mem_swapped_in=0,mem_swapped_out=0,major_page_faults=88,minor_page_faults=105535,free_mem=10170

[libvirt] [PATCH 5/6] virsh: Enable virDomainMemoryStats as a new command

2009-12-18 Thread Adam Litke
Define a new command 'dommemstats' to report domain memory statistics. The output format is inspired by 'domblkstat' and 'domifstat' and consists of tag/value pairs, one per line. The command can complete successfully and print no output if virDomainMemoryStats is supported by the driver, but not

[libvirt] [PATCH 6/6] python: Add python bindings for virDomainMemoryStats

2009-12-18 Thread Adam Litke
Enable virDomainMemoryStats in the python API. dom.memoryStats() will return a dictionary containing the supported statistics. A dictionary is required because the meaining of each quantity cannot be inferred from its index in a list. Signed-off-by: Adam Litke To: Daniel Veillard Cc: Daniel P.

[libvirt] [PATCH 4/6] remote-driver: Add domainMemoryStats support

2009-12-18 Thread Adam Litke
Use a dynamically sized xdr_array to pass memory stats on the wire. This supports the addition of future memory stats and reduces the message size since only supported statistics are returned. Signed-off-by: Adam Litke To: Daniel Veillard Cc: Daniel P. Berrange Cc: libvirt list --- daemon/re

[libvirt] [PATCH 2/6] domMemoryStats: Add public symbol to libvirt API

2009-12-18 Thread Adam Litke
Add a new function 'virDomainMemoryStats' to the libvirt API. Export it via libvirt_public.syms Signed-off-by: Adam Litke To: Daniel Veillard Cc: Daniel P. Berrange Cc: libvirt list --- src/libvirt.c | 71 +++ src/libvirt_public.syms |

[libvirt] [PATCH 1/6] domMemoryStats: Add domainMemoryStats method to struct _virDriver

2009-12-18 Thread Adam Litke
Set up the types for the domainMemoryStats function and insert it into the virDriver structure definition. Because of static initializers, update every driver and set the new field to NULL. Note: The changes in python/* are to fix compiler errors. The actual python binding is implemented in a la

Re: [libvirt] [PATCH 2/2] Don't mix LDFLAGS and LIBS in the configure script.

2009-12-18 Thread Daniel Veillard
On Fri, Dec 18, 2009 at 10:48:28AM +, Daniel P. Berrange wrote: > On Thu, Dec 17, 2009 at 10:56:25PM +0100, Diego Elio 'Flameeyes' Petten? > wrote: > > If you pass libraries in the LDFLAGS variable, and then try AC_CHECK_FUNCS > > to find whether a function is present or not, it'll fail badly

Re: [libvirt] [PATCH 6/6] python: Add python bindings for virDomainMemoryStats

2009-12-18 Thread Adam Litke
On Fri, 2009-12-18 at 00:41 +0100, Matthias Bolte wrote: > You're using the old tags (VIR_MEMSTAT_*) and names (free_memory, > total_memory) here. Argh. I forgot to commit my local changes to the python patch :( This is done and will appear in the next series. > You could convert the adjacent

[libvirt] Re: [PATCH 4/6] remote-driver: Add domainMemoryStats support

2009-12-18 Thread Adam Litke
On Fri, 2009-12-18 at 10:30 +, Daniel P. Berrange wrote: > On Thu, Dec 17, 2009 at 05:41:45PM -0500, Adam Litke wrote: > > Use a dynamically sized xdr_array to pass memory stats on the wire. This > > supports the addition of future memory stats and reduces the message size > > since > > only

Re: [libvirt] [PATCH v4 00/11] CPU selection patches

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:34PM +0100, Jiri Denemark wrote: > Hi, > > This is a third version of CPU selection patchset. Okay, so I new commited and pushed the whole iteration with the few changes I noted. I think there is 2 tiny things left to do now: - installation of the CPU map in "ma

Re: [libvirt] [PATCH v4 11/11] Implement virsh commands

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:45PM +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > tools/virsh.c | 65 > + > 1 files changed, 65 insertions(+), 0 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c Okay,

Re: [libvirt] [PATCH v4 10/11] Implement CPU selection in QEMU driver

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:44PM +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > src/qemu/qemu_conf.c | 398 > +--- > src/qemu/qemu_conf.h |7 + > src/qemu/qemu_driver.c | 44 -- > 3 files changed, 419 insertions(

Re: [libvirt] [PATCH v4 09/11] CPU map for models and features

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:43PM +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > src/Makefile.am |2 + > src/cpu/cpu_map.xml | 345 > +++ > 2 files changed, 347 insertions(+), 0 deletions(-) > create mode 100644 sr

Re: [libvirt] [PATCH v4 08/11] CPU selection infrastructure

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:42PM +0100, Jiri Denemark wrote: > Each driver supporting CPU selection must fill in host CPU capabilities. > When filling them, drivers for hypervisors running on the same node as > libvirtd can use cpuNodeData() to obtain raw CPU data. Other drivers, > such as VMware

Re: [libvirt] [PATCH v4 06/11] Wire protocol format and server side dispatcher

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:40PM +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > daemon/remote.c | 22 ++ > src/remote/remote_protocol.x | 13 - > 2 files changed, 34 insertions(+), 1 deletions(-) > > diff --git a/daemon/re

Re: [libvirt] [PATCH 0/12] Standardized device addressing & SCSI controller/disk hotplug

2009-12-18 Thread Daniel P. Berrange
On Fri, Dec 18, 2009 at 02:18:32PM +, Mark McLoughlin wrote: > On Fri, 2009-12-18 at 14:07 +, Daniel P. Berrange wrote: > > > > The thing I'm trying to avoid is having libvirt update the persistent > > config files outside the context of the existing virDefineXML API, > > Remind me why ar

Re: [libvirt] [PATCH 0/12] Standardized device addressing & SCSI controller/disk hotplug

2009-12-18 Thread Mark McLoughlin
On Fri, 2009-12-18 at 14:07 +, Daniel P. Berrange wrote: > On Fri, Dec 18, 2009 at 11:17:59AM +, Mark McLoughlin wrote: > > On Thu, 2009-12-17 at 09:39 +, Daniel P. Berrange wrote: > > > On Thu, Dec 10, 2009 at 10:22:20PM +, Daniel P. Berrange wrote: > > > > The XML for each address

Re: [libvirt] [PATCH 12/12] Detect PCI addresses at QEMU startup

2009-12-18 Thread Daniel P. Berrange
On Fri, Dec 18, 2009 at 02:04:04PM +, Mark McLoughlin wrote: > On Fri, 2009-12-18 at 13:59 +, Daniel P. Berrange wrote: > > > The plan we had to future proof this was that libvirt would assign an id > > > (using -device foo,id=bar) and 'info pci' would include the device id in > > > its out

Re: [libvirt] [PATCH 0/12] Standardized device addressing & SCSI controller/disk hotplug

2009-12-18 Thread Daniel P. Berrange
On Fri, Dec 18, 2009 at 11:17:59AM +, Mark McLoughlin wrote: > On Thu, 2009-12-17 at 09:39 +, Daniel P. Berrange wrote: > > On Thu, Dec 10, 2009 at 10:22:20PM +, Daniel P. Berrange wrote: > > > The XML for each address type looks like > > > > > >> > slot='0x07' function='0x0'/>

Re: [libvirt] [PATCH v4 02/11] XML parsing/formating code for CPU flags

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:36PM +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > include/libvirt/virterror.h |1 + > proxy/Makefile.am |1 + > src/Makefile.am |9 +- > src/conf/capabilities.c | 31 - > src/conf/capabilities.h

Re: [libvirt] [PATCH 12/12] Detect PCI addresses at QEMU startup

2009-12-18 Thread Mark McLoughlin
On Fri, 2009-12-18 at 13:59 +, Daniel P. Berrange wrote: > > The plan we had to future proof this was that libvirt would assign an id > > (using -device foo,id=bar) and 'info pci' would include the device id in > > its output. > > > > Once you have that, you no longer need to make assumptions

Re: [libvirt] [PATCH v4 04/11] Internal driver API

2009-12-18 Thread Daniel Veillard
On Thu, Dec 17, 2009 at 09:21:38PM +0100, Jiri Denemark wrote: > > Signed-off-by: Jiri Denemark > --- > src/driver.h|5 + > src/esx/esx_driver.c|1 + > src/lxc/lxc_driver.c|1 + > src/opennebula/one_driver.c |1 + > src/openvz/openvz_driver.c

Re: [libvirt] [PATCH 12/12] Detect PCI addresses at QEMU startup

2009-12-18 Thread Daniel P. Berrange
On Fri, Dec 18, 2009 at 11:44:54AM +, Mark McLoughlin wrote: > Hey, > > This looks good, except we're encoding a lot more knowledge of how qemu > works than I'd like. > > The plan we had to future proof this was that libvirt would assign an id > (using -device foo,id=bar) and 'info pci' would

[libvirt] Re: Supporting vhost-net and macvtap in libvirt for QEMU

2009-12-18 Thread Arnd Bergmann
On Thursday 17 December 2009, Anthony Liguori wrote: > When invoking qemu directly, for the first go about, I'd expect -net > vhost,dev=eth0 for a raw device and -net vhost,mode=tap,tap-arguments. > > Long term, there are so many possible ways to layer things, that I'd > really like to see: >

Re: [libvirt] [PATCH] Fix compilation with gcrypt < 1.4.2

2009-12-18 Thread Daniel Veillard
On Fri, Dec 18, 2009 at 12:10:08PM +0100, Matthias Bolte wrote: > Commit 33a198c1f6a4a1bc7f34d50a31032e03bec10fee increased the gcrypt > version requirement to 1.4.2 because the GCRY_THREAD_OPTION_VERSION > define was added in this version. > > The configure script doesn't check for the gcrypt ver

Re: [libvirt] [PATCH 12/12] Detect PCI addresses at QEMU startup

2009-12-18 Thread Mark McLoughlin
Hey, This looks good, except we're encoding a lot more knowledge of how qemu works than I'd like. The plan we had to future proof this was that libvirt would assign an id (using -device foo,id=bar) and 'info pci' would include the device id in its output. Once you have that, you no longer need t

Re: [libvirt] [PATCH 0/12] Standardized device addressing & SCSI controller/disk hotplug

2009-12-18 Thread Mark McLoughlin
Hi Dan, Looks great overall On Thu, 2009-12-10 at 22:22 +, Daniel P. Berrange wrote: > I then remembered that for support NIC/VirtIO/hostdev disk unplug > Mark M had previously added PCI address information to the internal > XML state files for , and elements. Note, the devaddr property i

Re: [libvirt] [PATCH 0/12] Standardized device addressing & SCSI controller/disk hotplug

2009-12-18 Thread Mark McLoughlin
On Thu, 2009-12-17 at 09:39 +, Daniel P. Berrange wrote: > On Thu, Dec 10, 2009 at 10:22:20PM +, Daniel P. Berrange wrote: > > The XML for each address type looks like > > > >> slot='0x07' function='0x0'/> > > > > > > > > > > The 'mode' attribute for any of them is

[libvirt] [PATCH] Fix compilation with gcrypt < 1.4.2

2009-12-18 Thread Matthias Bolte
Commit 33a198c1f6a4a1bc7f34d50a31032e03bec10fee increased the gcrypt version requirement to 1.4.2 because the GCRY_THREAD_OPTION_VERSION define was added in this version. The configure script doesn't check for the gcrypt version. To support gcrypt versions < 1.4.2 change the virTLSThreadImpl initi

Re: [libvirt] [PATCH 2/2] Don't mix LDFLAGS and LIBS in the configure script.

2009-12-18 Thread Daniel P. Berrange
On Thu, Dec 17, 2009 at 10:56:25PM +0100, Diego Elio 'Flameeyes' Petten? wrote: > If you pass libraries in the LDFLAGS variable, and then try AC_CHECK_FUNCS > to find whether a function is present or not, it'll fail badly when using > the --as-needed linker flag. > > Instead, pass the libraries th

[libvirt] Re: [PATCH 4/6] remote-driver: Add domainMemoryStats support

2009-12-18 Thread Daniel P. Berrange
On Thu, Dec 17, 2009 at 05:41:45PM -0500, Adam Litke wrote: > Use a dynamically sized xdr_array to pass memory stats on the wire. This > supports the addition of future memory stats and reduces the message size > since > only supported statistics are returned. > > Signed-off-by: Adam Litke > To

Re: [libvirt] [PATCH 1/2] Don't make it possible to define HAVE_HAL but not enable it in automake.

2009-12-18 Thread Daniel P. Berrange
On Thu, Dec 17, 2009 at 10:56:24PM +0100, Diego Elio 'Flameeyes' Petten? wrote: > With the previous logic, if libhal_get_all_devices function was not found, > HAVE_HAL would be defined for the preprocessor but it wouldn't be enabled > in automake conditionals, causing the final link to fail with mi

[libvirt] Re: Supporting vhost-net and macvtap in libvirt for QEMU

2009-12-18 Thread Daniel P. Berrange
On Thu, Dec 17, 2009 at 03:39:05PM -0600, Anthony Liguori wrote: > Chris Wright wrote: > > > >Doesn't sound useful. Low-level, sure worth being able to turn things > >on and off for testing/debugging, but probably not something a user > >should be burdened with in libvirt. > > > >But I dont' under

Re: [libvirt] [PATCH 0/12] Standardized device addressing & SCSI controller/disk hotplug

2009-12-18 Thread Wolfgang Mauerer
Daniel P. Berrange wrote: > On Thu, Dec 10, 2009 at 10:22:20PM +, Daniel P. Berrange wrote: >> The XML for each address type looks like >> >> > slot='0x07' function='0x0'/> >> >> >> >> >> The 'mode' attribute for any of them is allowed to be either >> 'static' or 'dynamic'.