[libvirt] [PATCH] esx: Also allow virtualHW version 4 for ESX 4.0

2010-01-03 Thread Matthias Bolte
A domain with virtualHW version 4 is allowed on an ESX 4.0 server. If a domain is migrated from an ESX 3.5 server to an ESX 4.0 server then the virtualHW version stays the same. So a ESX 4.0 server can host domains with virtualHW version 4. --- src/esx/esx_vmx.c |4 ++-- 1 files changed, 2

[libvirt] [PATCH] Don't free an uninitalized pointer in update_driver_name()

2010-01-03 Thread Matthias Bolte
This invalid free results in heap corruption. Some symptoms I saw because of this were libvirtd crashing and virt-manager hanging while trying to enumerate devices. --- src/node_device/node_device_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[libvirt] [PATCH] esx: Don't warn about an empty URI path

2010-01-03 Thread Matthias Bolte
--- src/esx/esx_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 5cdadfd..30e21e0 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -293,7 +293,8 @@ esxOpen(virConnectPtr conn, virConnectAuthPtr

[libvirt] [PATCH] esx: Fix and improve the libcurl debug callback

2010-01-03 Thread Matthias Bolte
The data passed to the callback is not guaranteed to be zero terminated, take care of that by coping the data and adding a zero terminator. Also dump the data for other types than CURLINFO_TEXT. Set CURLOPT_VERBOSE to 1 so the debug callback is called when enabled. --- src/esx/esx_vi.c | 43

[libvirt] [PATCH] esx: Fix deserialization for VI API calls CancelTask and UnregisterVM

2010-01-03 Thread Matthias Bolte
--- src/esx/esx_vi_methods.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_vi_methods.c b/src/esx/esx_vi_methods.c index be21112..7925f26 100644 --- a/src/esx/esx_vi_methods.c +++ b/src/esx/esx_vi_methods.c @@ -601,7 +601,7 @@

[libvirt] [PATCH] esx: Fix 'vpx' MAC address range and allow arbitrary MAC addresses

2010-01-03 Thread Matthias Bolte
The MAC addresses with 00:50:56 prefix are split into several ranges: 00:50:56:00:00:00 - 00:50:56:3f:ff:ff 'static' range (manually assigned) 00:50:56:80:00:00 - 00:50:56:bf:ff:ff 'vpx' range (assigned by a VI Client) Erroneously the 'vpx' range was assumed to be larger and to occupy the

[libvirt] [PATCH] virsh: Use VIR_FREE instead of free

2010-01-03 Thread Matthias Bolte
virsh uses other parts of the internal API already, so use VIR_FREE also. --- tools/virsh.c | 297 - 1 files changed, 146 insertions(+), 151 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index e2a32b4..2844927 100644 ---

Re: [libvirt] [PATCH] virsh: Add persistent history using libreadline

2010-01-03 Thread Laine Stump
On 01/03/2010 02:42 PM, Matthias Bolte wrote: +if (virAsprintf(ctl-historyfile, %s/histroy, ctl-historydir) 0) { A minor typo in the format string ;-) -- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: Add persistent history using libreadline

2010-01-03 Thread Matthias Bolte
2010/1/3 Laine Stump la...@laine.org: On 01/03/2010 02:42 PM, Matthias Bolte wrote: +    if (virAsprintf(ctl-historyfile, %s/histroy, ctl-historydir)  0) { A minor typo in the format string ;-) Fixed, thanks. Matthias -- Libvir-list mailing list Libvir-list@redhat.com

[libvirt] FIrst approximation of creating volumes directly with desired uid

2010-01-03 Thread Laine Stump
|I've made an attempt to create storage volumes directly with the desired uid/gid (by forking a new process, calling setuid/setgid in that process, and then creating the file). Since it's sure to get ripped apart, I've put it up on gitorious rather than sending patches to the list. The