Re: [libvirt] cannot start a qemu64 model on an Intel host

2010-01-06 Thread Jiri Denemark
If I specify cpu match=exact modelqemu64/model /cpu according to the new cpu schema, I get error: internal error guest CPU is not compatible with host CPU because qemu64 supports svm, and my host does not. However, the error remains when I explicitly ask to disable svm with

Re: [libvirt] [PATCH] [RFC] xen domctl version 6

2010-01-06 Thread Daniel Veillard
On Wed, Dec 23, 2009 at 10:59:09AM -0700, Jim Fehlig wrote: xen-unstable c/s 20685 changed the domctl interface, adding a field to xen_domctl_getdomaininfo structure. This additional field causes stack corruption in libvirt. xen-unstable c/s 20711 rightly bumped the domctl interface version

[libvirt] iptables rules location

2010-01-06 Thread Mihamina Rakotomandimby
Manao ahoana, Hello, Bonjour, When starting libvirt there are some iptables rules setup. I would like to know where are they stored (and the filename, I use ubuntu package, need to 'find' or 'locate'). Misaotra, Thanks, Merci. -- Architecte Informatique chez Blueline/Gulfsat:

Re: [libvirt] iptables rules location

2010-01-06 Thread Daniel P. Berrange
On Wed, Jan 06, 2010 at 01:21:49PM +0300, Mihamina Rakotomandimby wrote: Manao ahoana, Hello, Bonjour, When starting libvirt there are some iptables rules setup. I would like to know where are they stored (and the filename, I use ubuntu package, need to 'find' or 'locate'). They're not

[libvirt] [PATCH] don't test res == NULL after we've already dereferenced it

2010-01-06 Thread Jim Meyering
As the log says, once we've dereferenced it, there's no point in comparing to NULL. From 463eaf1027a154e71839a67eca85b3ada8b817ff Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 6 Jan 2010 12:45:07 +0100 Subject: [PATCH] don't test res == NULL after we've already

[libvirt] [PATCH] xend_internal: don't let invalid input provoke NULL dereference

2010-01-06 Thread Jim Meyering
If there's a good reason to test for NULL conn, then we certainly must not dereference conn before that point. This assumes we do want to retain the NULL test. Note that many other functions perform this same test. From 2c7b628728efcb5a59c1e7aa1cba763f5ef0045a Mon Sep 17 00:00:00 2001 From: Jim

[libvirt] [ PATCH ] fix multiple veth problem for OpenVZ

2010-01-06 Thread Yuji NISHIDA
Dear all This is to fix multiple veth problem. NETIF setting was overwritten after first CT because any CT could not be found by character name. --- src/openvz/openvz_conf.c | 38 ++ src/openvz/openvz_conf.h |1 + src/openvz/openvz_driver.c |2

Re: [libvirt] [virt-tools-list] Questions about virt-manager running on Arch of Itanium 64

2010-01-06 Thread Cole Robinson
On 01/04/2010 08:27 PM, Dustin Xiong wrote: Date: Mon, 4 Jan 2010 11:46:06 -0500 From: crobi...@redhat.com To: x_k_...@hotmail.com CC: berra...@redhat.com; libvirt-l...@redhat.com Subject: Re: [libvirt] [virt-tools-list] Questions about virt-manager running on Arch of Itanium 64

[libvirt] libvirt 0.7.5 vs qemu 0.12.1 imcompatability?

2010-01-06 Thread Tom Hughes
The update from qemu 0.11.0 to qemu 0.12.1 in the virt-preview repository seems to have broken things. Starting a VM now just gives me a blank screen and a log which says: Option 'ipv4': Use 'on' or 'off' Failed to parse yes for dummy.ipv4 I assume libvirt is sending a it a command on the

Re: [libvirt] libvirt 0.7.5 vs qemu 0.12.1 imcompatability?

2010-01-06 Thread Daniel P. Berrange
On Wed, Jan 06, 2010 at 03:38:29PM +, Tom Hughes wrote: The update from qemu 0.11.0 to qemu 0.12.1 in the virt-preview repository seems to have broken things. Starting a VM now just gives me a blank screen and a log which says: Option 'ipv4': Use 'on' or 'off' Failed to parse yes for

Re: [libvirt] [PATCH] Fix parsing of 'info chardev' line endings

2010-01-06 Thread Daniel Veillard
On Tue, Jan 05, 2010 at 11:21:01AM +, Daniel P. Berrange wrote: On Mon, Dec 14, 2009 at 03:31:12PM +, Matthew Booth wrote: This change makes the 'info chardev' parser ignore any trailing whitespace on a line. This fixes a specific problem handling a '\r\n' line ending. *

Re: [libvirt] libvirt 0.7.5 vs qemu 0.12.1 imcompatability?

2010-01-06 Thread Tom Hughes
On 06/01/10 15:53, Daniel P. Berrange wrote: On Wed, Jan 06, 2010 at 03:38:29PM +, Tom Hughes wrote: The update from qemu 0.11.0 to qemu 0.12.1 in the virt-preview repository seems to have broken things. Starting a VM now just gives me a blank screen and a log which says: Option 'ipv4':

Re: [libvirt] [PATCH] Disable building of static Python module.

2010-01-06 Thread Daniel Veillard
On Wed, Dec 23, 2009 at 07:07:48PM +0100, Diego Elio Pettenò wrote: Python modules are loaded at runtime so the static version of it is not really needed, this avoids duplicating the build for the PIC and non-PIC cases. --- python/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1

Re: [libvirt] [PATCH 1/1] Don't update vol details after build

2010-01-06 Thread Daniel Veillard
On Mon, Jan 04, 2010 at 11:46:37AM -0500, Cole Robinson wrote: On 12/23/2009 04:56 PM, David Allan wrote: * This patch removes the call to vol update after the volume build completes. The update call is currently meaningless anyway because the vol build is passed a copy of the

Re: [libvirt] [PATCH] qemu: Update qemuhelpdata test with new flag

2010-01-06 Thread Daniel Veillard
On Tue, Jan 05, 2010 at 08:27:42AM -0600, Adam Litke wrote: The test suite needs a small fixup with the qemu balloon patch applied. This patch applies on top of: qemu: Always enable the virtio balloon driver A small update to the qemuhelpdata test is required. It must be told

Re: [libvirt] [PATCH] Don't free an uninitalized pointer in update_driver_name()

2010-01-06 Thread Daniel Veillard
On Sun, Jan 03, 2010 at 08:33:03PM +0100, Matthias Bolte wrote: This invalid free results in heap corruption. Some symptoms I saw because of this were libvirtd crashing and virt-manager hanging while trying to enumerate devices. --- src/node_device/node_device_driver.c |4 ++-- 1 files

Re: [libvirt] [PATCH] esx: Also allow virtualHW version 4 for ESX 4.0

2010-01-06 Thread Daniel Veillard
On Sun, Jan 03, 2010 at 08:38:17PM +0100, Matthias Bolte wrote: A domain with virtualHW version 4 is allowed on an ESX 4.0 server. If a domain is migrated from an ESX 3.5 server to an ESX 4.0 server then the virtualHW version stays the same. So a ESX 4.0 server can host domains with virtualHW

Re: [libvirt] [PATCH] esx: Don't warn about an empty URI path

2010-01-06 Thread Daniel Veillard
On Sun, Jan 03, 2010 at 08:38:41PM +0100, Matthias Bolte wrote: --- src/esx/esx_driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 5cdadfd..30e21e0 100644 --- a/src/esx/esx_driver.c +++

Re: [libvirt] [PATCH] esx: Fix and improve the libcurl debug callback

2010-01-06 Thread Daniel Veillard
On Sun, Jan 03, 2010 at 08:40:15PM +0100, Matthias Bolte wrote: The data passed to the callback is not guaranteed to be zero terminated, take care of that by coping the data and adding a zero terminator. Also dump the data for other types than CURLINFO_TEXT. Set CURLOPT_VERBOSE to 1 so the

Re: [libvirt] [PATCH] esx: Fix deserialization for VI API calls CancelTask and UnregisterVM

2010-01-06 Thread Daniel Veillard
On Sun, Jan 03, 2010 at 08:40:50PM +0100, Matthias Bolte wrote: --- src/esx/esx_vi_methods.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_vi_methods.c b/src/esx/esx_vi_methods.c index be21112..7925f26 100644 --- a/src/esx/esx_vi_methods.c +++

Re: [libvirt] [PATCH] esx: Fix 'vpx' MAC address range and allow arbitrary MAC addresses

2010-01-06 Thread Daniel Veillard
On Sun, Jan 03, 2010 at 08:42:12PM +0100, Matthias Bolte wrote: The MAC addresses with 00:50:56 prefix are split into several ranges: 00:50:56:00:00:00 - 00:50:56:3f:ff:ff 'static' range (manually assigned) 00:50:56:80:00:00 - 00:50:56:bf:ff:ff 'vpx' range (assigned by a VI Client)

Re: [libvirt] [PATCH] virsh: Use VIR_FREE instead of free

2010-01-06 Thread Daniel Veillard
On Sun, Jan 03, 2010 at 08:43:15PM +0100, Matthias Bolte wrote: virsh uses other parts of the internal API already, so use VIR_FREE also. --- tools/virsh.c | 297 - 1 files changed, 146 insertions(+), 151 deletions(-) I really

Re: [libvirt] [PATCH] virsh: Add persistent history using libreadline

2010-01-06 Thread Daniel Veillard
On Mon, Jan 04, 2010 at 12:06:29AM +0100, Matthias Bolte wrote: 2010/1/3 Laine Stump la...@laine.org: On 01/03/2010 02:42 PM, Matthias Bolte wrote: +    if (virAsprintf(ctl-historyfile, %s/histroy, ctl-historydir)  0) { A minor typo in the format string ;-) Fixed, thanks.

Re: [libvirt] libvirt 0.7.5 vs qemu 0.12.1 imcompatability?

2010-01-06 Thread Thomas Treutner
On Wednesday 06 January 2010 17:11:17 Tom Hughes wrote: On 06/01/10 15:53, Daniel P. Berrange wrote: On Wed, Jan 06, 2010 at 03:38:29PM +, Tom Hughes wrote: The update from qemu 0.11.0 to qemu 0.12.1 in the virt-preview repository seems to have broken things. Starting a VM now just

Re: [libvirt] [PATCH] xend_internal: don't let invalid input provoke NULL dereference

2010-01-06 Thread Daniel Veillard
On Wed, Jan 06, 2010 at 01:02:01PM +0100, Jim Meyering wrote: If there's a good reason to test for NULL conn, then we certainly must not dereference conn before that point. This assumes we do want to retain the NULL test. Note that many other functions perform this same test. From

Re: [libvirt] libvirt 0.7.5 vs qemu 0.12.1 imcompatability?

2010-01-06 Thread Tom Hughes
On 06/01/10 17:32, Thomas Treutner wrote: On Wednesday 06 January 2010 17:11:17 Tom Hughes wrote: Hmm... Well something is wrong because I just get a black screen. I don't even get the BIOS messages since I updated this morning. If you start your VM with -kernel $image, there's a bug in

Re: [libvirt] [PATCH] don't test res == NULL after we've already dereferenced it

2010-01-06 Thread Daniel Veillard
On Wed, Jan 06, 2010 at 12:46:11PM +0100, Jim Meyering wrote: As the log says, once we've dereferenced it, there's no point in comparing to NULL. From 463eaf1027a154e71839a67eca85b3ada8b817ff Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed, 6 Jan 2010 12:45:07

Re: [libvirt] libvirt 0.7.5 vs qemu 0.12.1 imcompatability?

2010-01-06 Thread Nikola Ciprich
Hi Tom, I've had similar trouble with old bios images. Once I replaced them with those built with qemu-kvm, things started working... regards nik On Wed, Jan 06, 2010 at 05:34:57PM +, Tom Hughes wrote: On 06/01/10 17:32, Thomas Treutner wrote: On Wednesday 06 January 2010 17:11:17 Tom

Re: [libvirt] [PATCH] xend_internal: don't let invalid input provoke NULL dereference

2010-01-06 Thread Jim Meyering
Daniel Veillard wrote: Subject: [PATCH] xend_internal: don't let invalid input provoke NULL dereference * src/xen/xend_internal.c (xenDaemonOpen_unix): Do not dereference a NULL conn. Move first deref to follow the conn == NULL test. ACK, clearly an oversight, thanks ! Thanks. Pushing

Re: [libvirt] [PATCH] don't test res == NULL after we've already dereferenced it

2010-01-06 Thread Jim Meyering
Daniel Veillard wrote: On Wed, Jan 06, 2010 at 12:46:11PM +0100, Jim Meyering wrote: As the log says, once we've dereferenced it, there's no point in comparing to NULL. From 463eaf1027a154e71839a67eca85b3ada8b817ff Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Wed,

Re: [libvirt] [PATCH] [RFC] xen domctl version 6

2010-01-06 Thread Jim Fehlig
Daniel Veillard wrote: On Wed, Dec 23, 2009 at 10:59:09AM -0700, Jim Fehlig wrote: xen-unstable c/s 20685 changed the domctl interface, adding a field to xen_domctl_getdomaininfo structure. This additional field causes stack corruption in libvirt. xen-unstable c/s 20711 rightly bumped

[libvirt] [PATCH] Fix free of invalid pointer in node_device_driver

2010-01-06 Thread Jim Fehlig
If device does not have a driver, an uninitialized pointer was being free()'d in node_device_driver. Here's a small patch to fix it. Regards, Jim commit 49d8d703e4ac3253155871f97350bec10a15dfaf Author: Jim Fehlig jfeh...@novell.com Date: Wed Jan 6 17:17:08 2010 -0700 Fix free of invalid

Re: [libvirt] [PATCH] Fix free of invalid pointer in node_device_driver

2010-01-06 Thread Matthias Bolte
2010/1/7 Jim Fehlig jfeh...@novell.com: If device does not have a driver, an uninitialized pointer was being free()'d in node_device_driver.  Here's a small patch to fix it. Regards, Jim I posted the same patch 3 days ago and DV ACKed it today. Haven't pushed it yet, but I'll do so now.

Re: [libvirt] [PATCH] virsh: Use VIR_FREE instead of free

2010-01-06 Thread Matthias Bolte
2010/1/6 Daniel Veillard veill...@redhat.com: On Sun, Jan 03, 2010 at 08:43:15PM +0100, Matthias Bolte wrote: virsh uses other parts of the internal API already, so use VIR_FREE also. ---  tools/virsh.c |  297 -  1 files changed, 146

Re: [libvirt] [PATCH] Fix free of invalid pointer in node_device_driver

2010-01-06 Thread Jim Fehlig
Matthias Bolte wrote: 2010/1/7 Jim Fehlig jfeh...@novell.com: If device does not have a driver, an uninitialized pointer was being free()'d in node_device_driver. Here's a small patch to fix it. Regards, Jim I posted the same patch 3 days ago and DV ACKed it today. Haven't