Re: [libvirt] [PATCH] Only use pseudo-random generator for uuid if using /dev/random fails.

2010-01-11 Thread Daniel Veillard
On Fri, Jan 08, 2010 at 12:51:44PM -0500, Laine Stump wrote: The original code. would only print the warning message if using /dev/random failed, but would still go ahead and call virUUIDGeneratePseudoRandomBytes in all cases anyway. --- src/util/uuid.c |4 ++-- 1 files changed, 2

Re: [libvirt] Just to make sure I understand the API

2010-01-11 Thread Daniel P. Berrange
On Sun, Jan 10, 2010 at 01:20:38PM +0100, Matthias Bolte wrote: 2010/1/9 Bryan Kearney bkear...@redhat.com: To make sure I understand the API. If I have a domain defined, but not started.. it will show up in the list returned by: virConnectListDefinedDomains but not in the list

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2010 at 12:52:26AM +, pspreadboro...@comcast.net wrote: I tried the python version and did have some success, but not 100% since I didn't see events for pausing the VM: Pause/resume events are not available for Xen, since it provides no way to get notified of them. THe

Re: [libvirt] [PATCH] qemu: Fix a memory leak in qemudExtractTTYPath

2010-01-11 Thread Daniel P. Berrange
On Sat, Jan 09, 2010 at 09:26:11PM +0100, Matthias Bolte wrote: qemudWaitForMonitor calls qemudReadLogOutput with qemudFindCharDevicePTYs as callback. qemudFindCharDevicePTYs calls qemudExtractTTYPath to assign a string to chr-data.file.path. Afterwards qemudWaitForMonitor may call

Re: [libvirt] [PATCH] Document the domain XML cache attribute for disk devices

2010-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2010 at 01:22:56AM +0100, Matthias Bolte wrote: --- docs/formatdomain.html.in |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 46ab0ac..af31699 100644 --- a/docs/formatdomain.html.in

Re: [libvirt] [PATCH] look for DMI information in /sys/class too

2010-01-11 Thread Guido Günther
On Fri, Jan 08, 2010 at 11:50:17AM +0100, Daniel Veillard wrote: Looks safe to me, assuming the kernel information are exported in the same way, Yes, it seems to be the same. Pushed now. Cheers, -- Guido -- Libvir-list mailing list Libvir-list@redhat.com

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-01-11 Thread Darryl L. Pierce
On Thu, Dec 17, 2009 at 09:35:55AM -0500, Darryl L. Pierce wrote: The first is just a wiki fix: the wiki says this functionality is available as of 0.7.1 of libvirt. The code though is only in the 0.7.2 tag and later. So the wiki should say 0.7.2 instead. The second regards how I'm using it

[libvirt] LXC: init problem

2010-01-11 Thread Robin Green
I'm trying to install Exherbo Linux in an LXC container using libvirt. I've basically succeeded, in that I can virsh console in and start sshd, but I haven't managed to boot it starting from /sbin/init rather than /bin/bash. If I have the following (I probably should have modified the uuid and

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-01-11 Thread Paolo Bonzini
(mcpie...@mcpierce-desktop:node-image)$ sudo virsh net-dumpxml testbr541 network nametestbr541/name uuidf389317f-8420-7516-df9d-756b7deb3d37/uuid forward mode='nat'/ bridge name='testbr541' stp='on' delay='0' / ip address='192.168.31.1' netmask='255.255.255.0' tftp

Re: [libvirt] Two issues regarding TFTP support in virtual networks...

2010-01-11 Thread Darryl L. Pierce
On Mon, Jan 11, 2010 at 04:48:54PM +0100, Paolo Bonzini wrote: (mcpie...@mcpierce-desktop:node-image)$ sudo virsh net-dumpxml testbr541 network nametestbr541/name uuidf389317f-8420-7516-df9d-756b7deb3d37/uuid forward mode='nat'/ bridge name='testbr541' stp='on' delay='0' /

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread pspreadborough
Daniel, Is the Migrate event supported by Xen? Regards, Pete - Daniel P. Berrange berra...@redhat.com wrote: On Mon, Jan 11, 2010 at 12:52:26AM +, pspreadboro...@comcast.net wrote: I tried the python version and did have some success, but not 100% since I didn't see

Re: [libvirt] [PATCH 1/3] Add virRunWithHook.

2010-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2010 at 12:46:10AM -0500, Laine Stump wrote: Similar to virExecWithHook, but waits for child to exit. Useful for doing things like setuid after the fork but before the exec. --- src/util/util.c | 25 ++--- src/util/util.h |3 +++ 2 files changed, 21

[libvirt] [RFC] Proposal for introduction of network traffic filtering capabilities for filtering of network traffic from and to VMs

2010-01-11 Thread Stefan Berger
Hello! The following is a proposal to introduce network traffic filtering capabilities for the network traffic originating from and destined to virtual machines. Libvirt's capabilities will be extended to allow users to describe what traffic filtering rules are to be applied on a virtual

Re: [libvirt] Just to make sure I understand the API

2010-01-11 Thread Maximilian Wilhelm
Anno domini 2010 Daniel P. Berrange scripsit: Hi! [...] Yes, that's the correct behavior of these functions. virConnectListDefinedDomains list domains that are inactive but defined and virConnectListDomains lists domains that are active. If you combine the output of both functions then

[libvirt] [PATCH 5/5] qemu: Disable errors in qemudShutdownVMDaemon

2010-01-11 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index fc6b9fa..38be88f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c

[libvirt] [PATCH 4/5] libvirt.c: Preserve MigratePerform failure

2010-01-11 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libvirt.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 4308573..b95a8ed 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -3135,6 +3135,7 @@ virDomainMigrateVersion2

[libvirt] [PATCH 3/5] qemu: migrate: Save MigratePerform error in MigrateFinish.

2010-01-11 Thread Cole Robinson
This way we won't squash the original error report in MigratePerform, as is done for P2P and Tunneled migration. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c

[libvirt] [PATCH 0/5] Fix various error squashing issues

2010-01-11 Thread Cole Robinson
The following series adds internal APIs that help prevent legitimate errors from being overwritten by other errors (for example in cleanup routines). The majority of this series is a patch from Dan[1] which makes error callbacks explictly triggered when exiting an API call, rather than when an

[libvirt] [PATCH 2/5] virterror: Add virSetError

2010-01-11 Thread Cole Robinson
Can be used to re-set an old error, which may have been squashed by other functions (like cleanup routines). Will be used in subsequent patches Signed-off-by: Cole Robinson crobi...@redhat.com --- src/libvirt_private.syms |1 + src/util/virterror.c | 22 ++

Re: [libvirt] [PATCH] look for DMI information in /sys/class too

2010-01-11 Thread Dave Allan
On 01/11/2010 06:53 AM, Guido Günther wrote: On Fri, Jan 08, 2010 at 11:50:17AM +0100, Daniel Veillard wrote: Looks safe to me, assuming the kernel information are exported in the same way, Yes, it seems to be the same. Pushed now. Cheers, -- Guido -- Libvir-list mailing list

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread pspreadborough
- Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10 pspreadboro...@comcast.net: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10  pspreadboro...@comcast.net: Hello, I have been trying to use the domain event C code example but

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread Matthias Bolte
2010/1/11 pspreadboro...@comcast.net: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10  pspreadboro...@comcast.net: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10  pspreadboro...@comcast.net: Hello, I have been trying to use the

Re: [libvirt] [PATCH] Document the domain XML cache attribute for disk devices

2010-01-11 Thread Matthias Bolte
2010/1/11 Daniel P. Berrange berra...@redhat.com: On Mon, Jan 11, 2010 at 01:22:56AM +0100, Matthias Bolte wrote: ---  docs/formatdomain.html.in |    6 --  1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index

Re: [libvirt] [PATCH] qemu: Fix a memory leak in qemudExtractTTYPath

2010-01-11 Thread Matthias Bolte
2010/1/11 Daniel P. Berrange berra...@redhat.com: On Sat, Jan 09, 2010 at 09:26:11PM +0100, Matthias Bolte wrote: qemudWaitForMonitor calls qemudReadLogOutput with qemudFindCharDevicePTYs as callback. qemudFindCharDevicePTYs calls qemudExtractTTYPath to assign a string to chr-data.file.path.

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread pspreadborough
- Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/11 pspreadboro...@comcast.net: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10  pspreadboro...@comcast.net: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10  

[libvirt] [PATCH] remote_driver.c: fix a NULL dereference in remoteDomainEventQueueFlush().

2010-01-11 Thread kakuma
Hi, all. There is a case of a NULL dereference in function remoteDomainEventQueueFlush() in remote_driver.c In the case of local connection conn-privateData-domainEvents isn't reserved. In this case it will occurs segment fault. (for example examples/domain-events/events-c/event-test.c) I think

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread pspreadborough
- pspreadboro...@comcast.net wrote: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/11 pspreadboro...@comcast.net: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10  pspreadboro...@comcast.net: - Matthias Bolte

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread kakuma
Hi, I think this is same the bug I reported. https://bugzilla.redhat.com/show_bug.cgi?id=531979 And I attach patch. This patch Isn't available? On Mon, 11 Jan 2010 23:39:47 + (UTC) pspreadboro...@comcast.net wrote: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/11

Re: [libvirt] Segfault in event-test.c example

2010-01-11 Thread Matthias Bolte
2010/1/12 pspreadboro...@comcast.net: - pspreadboro...@comcast.net wrote: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/11  pspreadboro...@comcast.net: - Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/10  pspreadboro...@comcast.net:

Re: [libvirt] [PATCH] remote_driver.c: fix a NULL dereference in remoteDomainEventQueueFlush().

2010-01-11 Thread Matthias Bolte
2010/1/12 kakuma f-...@ksh.biglobe.ne.jp: Hi, all. There is a case of a NULL dereference in function remoteDomainEventQueueFlush() in remote_driver.c In the case of local connection conn-privateData-domainEvents isn't reserved. In this case it will occurs segment fault. (for example

Re: [libvirt] [PATCH] remote_driver.c: fix a NULL dereference in remoteDomainEventQueueFlush().

2010-01-11 Thread kakuma
On Tue, 12 Jan 2010 02:39:58 +0100 Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/1/12 kakuma f-...@ksh.biglobe.ne.jp: Hi, all. There is a case of a NULL dereference in function remoteDomainEventQueueFlush() in remote_driver.c In the case of local connection