[libvirt] root-squash NFS and qemu domain save

2010-02-04 Thread Laine Stump
On 01/24/2010 11:57 AM, Dan Kenigsberg wrote: On Wed, Jan 20, 2010 at 03:14:57PM +, Daniel P. Berrange wrote: This patch series does some work on te security drivers, and the QEMU code for managing DAC permissions on files. The core goal is to turn the QEMU driver DAC file management co

[libvirt] [PATCH 7/9] Remove conn parameter from PCI functions

2010-02-04 Thread Matthias Bolte
It was used for error reporting only. --- src/qemu/qemu_driver.c | 123 +- src/qemu/qemu_security_dac.c| 10 +-- src/security/security_selinux.c | 10 +-- src/util/pci.c | 113 src/util/pci

[libvirt] [PATCH 8/9] Remove conn parameter from JSON error macro

2010-02-04 Thread Matthias Bolte
--- src/util/json.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/util/json.c b/src/util/json.c index 62bf8e2..3abff58 100644 --- a/src/util/json.c +++ b/src/util/json.c @@ -36,8 +36,8 @@ /* XXX fixme */ #define VIR_FROM_THIS VIR_FROM_NONE -#defi

[libvirt] [PATCH 9/9] Remove conn parameter from USB functions

2010-02-04 Thread Matthias Bolte
It was used for error reporting only. --- src/qemu/qemu_security_dac.c| 10 -- src/security/security_selinux.c | 10 -- src/security/virt-aa-helper.c | 15 +++ src/util/hostusb.c | 29 + src/util/hostusb.h

[libvirt] [PATCH 5/9] Remove conn parameter from storage file functions

2010-02-04 Thread Matthias Bolte
It was used for error reporting only. --- src/qemu/qemu_security_dac.c |4 ++-- src/security/security_selinux.c |4 ++-- src/storage/storage_backend_fs.c | 13 + src/util/storage_file.c | 31 +++ src/util/storage_file.h |

[libvirt] [PATCH 6/9] Remove conn parameter from Linux stats functions

2010-02-04 Thread Matthias Bolte
It was used for error reporting only. --- po/POTFILES.in |1 + src/lxc/lxc_driver.c |2 +- src/qemu/qemu_driver.c |2 +- src/util/stats_linux.c | 44 +--- src/util/stats_linux.h |4 ++-- src/xen/xen_hypervisor.c |2 +

[libvirt] [PATCH 0/9] Remove conn parameter from several functions

2010-02-04 Thread Matthias Bolte
This set of patches removes the conn parameter from several internal functions where it was used of error reporting only. Since errors are reported to an error object in thread local storage the conn parameter is not necessary for this anymore. Matthias -- libvir-list mailing list libvir-list@red

Re: [libvirt] [PATCH] absolutePathFromBaseFile: don't leak when first arg contains no "/"

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 05:14:40PM +0100, Jim Meyering wrote: > Not only did this function leak(p), but it would also over-allocate > (by the length of basename(base_file)), and then later, re-alloc > to compensate, so I rewrote it: > > >From 1dc52930daa000b407d8a8f18588a19cf4e8b7f5 Mon Sep 17 00:

Re: [libvirt] [PATCH] docs: Refer to virReportOOMError in the HACKING file

2010-02-04 Thread Matthias Bolte
2010/2/4 Daniel Veillard : > On Thu, Feb 04, 2010 at 04:43:02PM +0100, Matthias Bolte wrote: >> Instead of refering to __virRaiseError(VIR_ERROR_NO_MEMORY). >> --- > >  ACK, thanks for the cleanup ! > > Daniel > Thanks, pushed. Matthias -- libvir-list mailing list libvir-list@redhat.com https:/

Re: [libvirt] [PATCH] website: Add a 1em right margin

2010-02-04 Thread Matthias Bolte
2010/2/4 Daniel Veillard : > On Thu, Feb 04, 2010 at 04:45:03PM +0100, Matthias Bolte wrote: >> This stops the text and pre-boxes from touching the right border. >> --- >>  docs/libvirt.css |    1 + >>  1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/docs/libvirt.css b/docs/libv

Re: [libvirt] [PATCH] docs: Emphasize that devices have to be inside the element

2010-02-04 Thread Matthias Bolte
2010/2/4 Daniel Veillard : > On Thu, Feb 04, 2010 at 04:42:27PM +0100, Matthias Bolte wrote: >> Also cleanup indentation of domain XML examples. >> --- >>  docs/drvxen.html.in       |   12 +- >>  docs/formatdomain.html.in |  776 >> + >>  2 files changed,

Re: [libvirt] [PATCH] storage: Replace storageLog with VIR_ERROR

2010-02-04 Thread Matthias Bolte
2010/2/4 Daniel Veillard : > On Thu, Feb 04, 2010 at 04:44:29PM +0100, Matthias Bolte wrote: >> --- >>  src/storage/storage_driver.c |   23 ++- >>  1 files changed, 10 insertions(+), 13 deletions(-) >> >> diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c >

Re: [libvirt] [PATCH] opennebula: Remove unnecessary casts

2010-02-04 Thread Matthias Bolte
2010/2/4 Daniel Veillard : > On Thu, Feb 04, 2010 at 04:44:13PM +0100, Matthias Bolte wrote: >> --- >>  src/opennebula/one_driver.c |   36 ++-- >>  1 files changed, 18 insertions(+), 18 deletions(-) > >  ACK, > > Daniel > Thanks, pushed. Matthias -- libvir-list ma

Re: [libvirt] [PATCH] esx: Cleanup preprocessing structure in esxVI_EnsureSession

2010-02-04 Thread Matthias Bolte
2010/2/4 Daniel Veillard : > On Thu, Feb 04, 2010 at 04:42:45PM +0100, Matthias Bolte wrote: >> --- >>  src/esx/esx_vi.c |   14 ++ >>  1 files changed, 6 insertions(+), 8 deletions(-) > >  ACK, > > Daniel > Thanks, pushed. Matthias -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] cpu conf: Use virBufferFreeAndReset instead of virBufferContentAndReset and VIR_FREE

2010-02-04 Thread Matthias Bolte
2010/2/4 Daniel Veillard : > On Thu, Feb 04, 2010 at 04:43:26PM +0100, Matthias Bolte wrote: >> --- > >  ACK, > > Daniel > Thanks, pushed. Matthias -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] storage: Replace storageLog with VIR_ERROR

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 05:28:33PM +, Daniel P. Berrange wrote: > On Thu, Feb 04, 2010 at 06:09:07PM +0100, Daniel Veillard wrote: > > On Thu, Feb 04, 2010 at 04:44:29PM +0100, Matthias Bolte wrote: > > > --- > > > src/storage/storage_driver.c | 23 ++- > > > 1 files chan

Re: [libvirt] [PATCH] absolutePathFromBaseFile: don't leak when first arg contains no "/"

2010-02-04 Thread Jim Meyering
Daniel Veillard wrote: >> absolutePathFromBaseFile(const char *base_file, const char *path) >> { >> -size_t base_size, path_size; >> -char *res, *p; >> +char *res; >> +size_t d_len = dir_len (base_file); >> >> -if (*path == '/') >> +/* If path is already absolute, or if di

[libvirt] [PATCH 7/9] Remote driver implementation for the virDomainAbortJob APi

2010-02-04 Thread Daniel P. Berrange
This defines the wire protocol for the new API * src/remote/remote_protocol.x: Wire protocol definition * src/remote/remote_driver.c,daemon/remote.c: Client and server side implementation * daemon/remote_dispatch_args.h, daemon/remote_dispatch_prototypes.h, daemon/remote_dispatch_table.h, src/

[libvirt] [PATCH 3/9] Remote driver implmentation of job info API

2010-02-04 Thread Daniel P. Berrange
* src/remote/remote_protocol.x: Define wire protocol format for virDomainGetJobInfo API * src/remote/remote_driver.c, daemon/remote.c: Implement client and server marshalling code for virDomainGetJobInfo() * daemon/remote_dispatch_args.h, daemon/remote_dispatch_prototypes.h daemon/remote_disp

[libvirt] [PATCH 8/9] Support job cancellation in QEMU driver

2010-02-04 Thread Daniel P. Berrange
This supports cancellation of jobs for the QEMU driver against the virDomainMigrate, virDomainSave and virDomainCoreDump APIs. It is not yet supported for the virDomainRestore API, although it is desirable. * src/qemu/qemu_driver.c: Issue 'migrate_cancel' command if virDomainAbortJob is issued d

[libvirt] [PATCH 1/9] Introduce public API for domain async job handling

2010-02-04 Thread Daniel P. Berrange
Introduce a new public API that provides a way to get progress info on currently running jobs on a virDomainpPtr. APIs that are initially within scope of this idea are virDomainMigrate virDomainMigrateToURI virDomainSave virDomainRestore virDomainCoreDump These all take a potentially long ti

[libvirt] [PATCH 2/9] Stub out internal driver entry points for job processing

2010-02-04 Thread Daniel P. Berrange
The internal glue layer for the new pubic API * src/driver.h: Define internal driver API contract * src/libvirt.c, src/libvirt_public.syms: Wire up public API to internal driver API * src/esx/esx_driver.c, src/lxc/lxc_driver.c, src/opennebula/one_driver.c, src/openvz/openvz_driver.c, src/phyp/

[libvirt] [PATCH 6/9] Wire up internal entry points for virDomainAbortJob API

2010-02-04 Thread Daniel P. Berrange
This provides the internal glue for the driver API * src/driver.h: Internal API contract * src/libvirt.c, src/libvirt_public.syms: Connect public API to driver API * src/esx/esx_driver.c, src/lxc/lxc_driver.c, src/opennebula/one_driver.c, src/openvz/openvz_driver.c, src/phyp/phyp_driver.c, s

[libvirt] [PATCH 9/9] Fix QEMU domain state after a save attempt fails

2010-02-04 Thread Daniel P. Berrange
When a VM save attempt failed, the VM would be left in a paused state. It is neccessary to resume CPU execution upon failure if it was running originally * src/qemu/qemu_driver.c: Resume CPUs upon save failure --- src/qemu/qemu_driver.c | 10 ++ 1 files changed, 10 insertions(+), 0 dele

Re: [libvirt] [PATCH] storage: Replace storageLog with VIR_ERROR

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 06:09:07PM +0100, Daniel Veillard wrote: > On Thu, Feb 04, 2010 at 04:44:29PM +0100, Matthias Bolte wrote: > > --- > > src/storage/storage_driver.c | 23 ++- > > 1 files changed, 10 insertions(+), 13 deletions(-) > > > > diff --git a/src/storage/stora

[libvirt] [PATCH 4/9] Add QEMU driver support for job info on migration ops

2010-02-04 Thread Daniel P. Berrange
Introduce support for virDomainGetJobInfo in the QEMU driver. This allows for monitoring of any API that uses the 'info migrate' monitor command. ie virDomainMigrate, virDomainSave and virDomainCoreDump Unfortunately QEMU does not provide a way to monitor incoming migration so we can't wire up vi

[libvirt] [PATCH 0/9] Progress monitoring & cancellation of jobs

2010-02-04 Thread Daniel P. Berrange
This series introduces 2 new APIs to allow long running jobs to be monitored and cancelled. This applies to virDomainMigrate, virDomainSave, virDomainRestore and virDomainCoreDump at least. The implementation is provided for QEMU only, any others that are able to implementation can do so as desired

[libvirt] [PATCH 5/9] Introduce public API for cancelling async domain jobs

2010-02-04 Thread Daniel P. Berrange
The new virDomainAbortJob() method provides a way for a second thread to abort an ongoing job run by another thread. This extends to any API with which the virDomainGetJobInfo() API is intended to work. Cancellation is not guarenteed, rather best effort on part of the hypervisor and not required t

Re: [libvirt] [PATCH] sexpr_string: avoid leak on OOM error path

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 05:55:58PM +0100, Jim Meyering wrote: > > > >From cc06142a81dc1891dc75306b986ea331f5fd5368 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 4 Feb 2010 17:55:15 +0100 > Subject: [PATCH] sexpr_string: avoid leak on OOM error path > > * src/xen/sexpr.c (sexpr_stri

Re: [libvirt] [PATCH] absolutePathFromBaseFile: don't leak when first arg contains no "/"

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 05:14:40PM +0100, Jim Meyering wrote: > Not only did this function leak(p), but it would also over-allocate > (by the length of basename(base_file)), and then later, re-alloc > to compensate, so I rewrote it: > > >From 1dc52930daa000b407d8a8f18588a19cf4e8b7f5 Mon Sep 17 00:

Re: [libvirt] [PATCH] website: Add a 1em right margin

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 04:45:03PM +0100, Matthias Bolte wrote: > This stops the text and pre-boxes from touching the right border. > --- > docs/libvirt.css |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/docs/libvirt.css b/docs/libvirt.css > index a4d1ddd..dfc93c6 1

Re: [libvirt] [PATCH] cpu conf: Use virBufferFreeAndReset instead of virBufferContentAndReset and VIR_FREE

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 04:43:26PM +0100, Matthias Bolte wrote: > --- > src/conf/cpu_conf.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c > index e7924c1..244d670 100644 > --- a/src/conf/cpu_conf.c > +++ b/src/conf/cpu_c

Re: [libvirt] [PATCH] opennebula: Remove unnecessary casts

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 04:44:13PM +0100, Matthias Bolte wrote: > --- > src/opennebula/one_driver.c | 36 ++-- > 1 files changed, 18 insertions(+), 18 deletions(-) ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan..

Re: [libvirt] [PATCH] storage: Replace storageLog with VIR_ERROR

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 04:44:29PM +0100, Matthias Bolte wrote: > --- > src/storage/storage_driver.c | 23 ++- > 1 files changed, 10 insertions(+), 13 deletions(-) > > diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c > index 50fcbe2..37be77d 100644 >

Re: [libvirt] [PATCH] docs: Refer to virReportOOMError in the HACKING file

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 04:43:02PM +0100, Matthias Bolte wrote: > Instead of refering to __virRaiseError(VIR_ERROR_NO_MEMORY). > --- > HACKING | 22 +++--- > docs/hacking.html.in | 20 ++-- > 2 files changed, 21 insertions(+), 21 deletions(-) > > d

[libvirt] Suggested schedule for next release

2010-02-04 Thread Daniel Veillard
Considering the amount of changes accumulating in a month, I suggest to continue with the end-of-month release cycle, which means basically that we would push features to head until Friday 19th and push the next release on the 26. This is a short cycle since Feb is a short month and we skipped a

[libvirt] [PATCH] sexpr_string: avoid leak on OOM error path

2010-02-04 Thread Jim Meyering
>From cc06142a81dc1891dc75306b986ea331f5fd5368 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 4 Feb 2010 17:55:15 +0100 Subject: [PATCH] sexpr_string: avoid leak on OOM error path * src/xen/sexpr.c (sexpr_string): Free sexpr buffer upon allocation failure. --- src/xen/sexpr.c |1 +

[libvirt] [PATCH] absolutePathFromBaseFile: don't leak when first arg contains no "/"

2010-02-04 Thread Jim Meyering
Not only did this function leak(p), but it would also over-allocate (by the length of basename(base_file)), and then later, re-alloc to compensate, so I rewrote it: >From 1dc52930daa000b407d8a8f18588a19cf4e8b7f5 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 4 Feb 2010 16:55:57 +0100 Subj

Re: [libvirt] Fix wrong nodeinfo->mhz when cpufreq is enabled

2010-02-04 Thread Daniel Veillard
On Tue, Feb 02, 2010 at 06:15:50PM +0100, Thomas Treutner wrote: > Hi, > > I've written a little patch to fix wrong nodeinfo->mhz when the Linux > kernel module cpufreq and a typical governor like ondemand are loaded. > nodeinfo->mhz is then too low as libvirt just reads /proc/cpuinfo, > entry "cp

[libvirt] [PATCH] esx: Remove unnecessary casts

2010-02-04 Thread Matthias Bolte
--- src/esx/esx_driver.c | 74 +- 1 files changed, 37 insertions(+), 37 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index fc254c6..fc5a50e 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -558,7 +558,7 @@ e

[libvirt] [PATCH] cpu conf: Use virBufferFreeAndReset instead of virBufferContentAndReset and VIR_FREE

2010-02-04 Thread Matthias Bolte
--- src/conf/cpu_conf.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index e7924c1..244d670 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -249,7 +249,6 @@ virCPUDefFormat(virConnectPtr conn, i

Re: [libvirt] [PATCH] esx: Cleanup preprocessing structure in esxVI_EnsureSession

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 04:42:45PM +0100, Matthias Bolte wrote: > --- > src/esx/esx_vi.c | 14 ++ > 1 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c > index bc94326..19c85c5 100644 > --- a/src/esx/esx_vi.c > +++ b/src/esx/esx_vi.c

Re: [libvirt] [PATCH] docs: Emphasize that devices have to be inside the element

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 04:42:27PM +0100, Matthias Bolte wrote: > Also cleanup indentation of domain XML examples. > --- > docs/drvxen.html.in | 12 +- > docs/formatdomain.html.in | 776 > + > 2 files changed, 430 insertions(+), 358 deletions(-

Re: [libvirt] [PATCH] virt-pki-validate contains unexpanded SYSCONFDIR variable

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 01:35:49PM +, Daniel P. Berrange wrote: > On Thu, Feb 04, 2010 at 12:55:08AM -0600, Doug Goldstein wrote: > > virt-pki-validate contains an unexpanded SYSCONFDIR variable which > > causes it not to function at all. > > --- > > tools/virt-pki-validate.in |2 +- > > 1

[libvirt] [PATCH] website: Add a 1em right margin

2010-02-04 Thread Matthias Bolte
This stops the text and pre-boxes from touching the right border. --- docs/libvirt.css |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/libvirt.css b/docs/libvirt.css index a4d1ddd..dfc93c6 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -30,6 +30,7 @@ h2, h3,

[libvirt] [PATCH] docs: Refer to virReportOOMError in the HACKING file

2010-02-04 Thread Matthias Bolte
Instead of refering to __virRaiseError(VIR_ERROR_NO_MEMORY). --- HACKING | 22 +++--- docs/hacking.html.in | 20 ++-- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/HACKING b/HACKING index 3844e50..4bf216c 100644 --- a/HACKING +++

[libvirt] [PATCH] storage: Replace storageLog with VIR_ERROR

2010-02-04 Thread Matthias Bolte
--- src/storage/storage_driver.c | 23 ++- 1 files changed, 10 insertions(+), 13 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 50fcbe2..37be77d 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -40,1

[libvirt] [PATCH] opennebula: Remove unnecessary casts

2010-02-04 Thread Matthias Bolte
--- src/opennebula/one_driver.c | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/opennebula/one_driver.c b/src/opennebula/one_driver.c index ad7faca..c96d24d 100644 --- a/src/opennebula/one_driver.c +++ b/src/opennebula/one_driver.c

[libvirt] [PATCH] docs: Emphasize that devices have to be inside the element

2010-02-04 Thread Matthias Bolte
Also cleanup indentation of domain XML examples. --- docs/drvxen.html.in | 12 +- docs/formatdomain.html.in | 776 + 2 files changed, 430 insertions(+), 358 deletions(-) diff --git a/docs/drvxen.html.in b/docs/drvxen.html.in index a6f0e57..4e35

[libvirt] [PATCH] esx: Cleanup preprocessing structure in esxVI_EnsureSession

2010-02-04 Thread Matthias Bolte
--- src/esx/esx_vi.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index bc94326..19c85c5 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -1317,16 +1317,18 @@ esxVI_BuildFullTraversalSpecList(esxVI_SelectionSpec *

Re: [libvirt] [PATCH] cgroup.c: avoid unconditional leaks

2010-02-04 Thread Daniel Veillard
On Thu, Feb 04, 2010 at 02:40:29PM +0100, Jim Meyering wrote: > Daniel P. Berrange wrote: > > On Thu, Feb 04, 2010 at 11:16:53AM +0100, Jim Meyering wrote: > >> Here's output from "git format-patch -U19 --stdout -1", > >> so you see the context: > ... > > > > ACK, that's an unusually large context

Re: [libvirt] [RFC] Proposal for introduction of network traffic filtering capabilities for filtering of network traffic from and to VMs

2010-02-04 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 02/04/2010 08:50:29 AM: > > libvir-list, Gerhard Stenzel, Vivek Kashyap > > 2010/2/4 Gerhard Stenzel : > > On Mon, 2010-01-25 at 14:59 +, Daniel P. Berrange wrote: > >> The shear size of the ruleset inside the element is > >> rather alarming to me. Im

Re: [libvirt] [RFC] Proposal for introduction of network traffic filtering capabilities for filtering of network traffic from and to VMs

2010-02-04 Thread Matthias Bolte
2010/2/4 Gerhard Stenzel : > On Mon, 2010-01-25 at 14:59 +, Daniel P. Berrange wrote: >> The shear size of the ruleset inside the element is >> rather alarming to me. Imagine if you have a guest with more >> than one NIC.  I'm inclined to suggest that the >> element in the domain XML descript

Re: [libvirt] [RFC] Proposal for introduction of network traffic filtering capabilities for filtering of network traffic from and to VMs

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 01:07:59PM +0100, Gerhard Stenzel wrote: > On Mon, 2010-01-25 at 14:59 +, Daniel P. Berrange wrote: > > The shear size of the ruleset inside the element is > > rather alarming to me. Imagine if you have a guest with more > > than one NIC. I'm inclined to suggest that t

Re: [libvirt] [PATCH] cgroup.c: avoid unconditional leaks

2010-02-04 Thread Jim Meyering
Daniel P. Berrange wrote: > On Thu, Feb 04, 2010 at 11:16:53AM +0100, Jim Meyering wrote: >> Here's output from "git format-patch -U19 --stdout -1", >> so you see the context: ... > > ACK, that's an unusually large context that diff generated ! The idea is to make review a little easier when the c

Re: [libvirt] [PATCH] virDomainChrDefParseXML: don't leak upon invalid input

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 12:50:09PM +0100, Jim Meyering wrote: > > > >From 6d0e0e571bba7792df9dacb898849708d5d3b425 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 4 Feb 2010 12:49:53 +0100 > Subject: [PATCH] virDomainChrDefParseXML: don't leak upon invalid input > > * src/conf/domain

Re: [libvirt] [PATCH] cgroup.c: don't leak mem+FD upon OOM

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 11:24:06AM +0100, Jim Meyering wrote: > Here's the patch: > (note, no need to test for mapping == NULL in the no_memory block) > > >From 91dbe896fff64783df1c68769a57a267441143ae Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 4 Feb 2010 11:22:20 +0100 > Subject:

Re: [libvirt] [PATCH] virExecWithHook: avoid leak on OOM error path

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 12:36:25PM +0100, Jim Meyering wrote: > > >From ab102cf853e3b46bf10cf0faafa643a352ed Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 4 Feb 2010 12:25:34 +0100 > Subject: [PATCH] virExecWithHook: avoid leak on OOM error path > > * src/util/util.c (virExecWit

Re: [libvirt] [PATCH] cgroup.c: avoid unconditional leaks

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 11:16:53AM +0100, Jim Meyering wrote: > Here's output from "git format-patch -U19 --stdout -1", > so you see the context: > > >From 47ea9beecf93a796e606b4d906424c05e7f6c9bb Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Thu, 4 Feb 2010 11:14:03 +0100 > Subject: [PAT

Re: [libvirt] [PATCH] virt-pki-validate contains unexpanded SYSCONFDIR variable

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 12:55:08AM -0600, Doug Goldstein wrote: > virt-pki-validate contains an unexpanded SYSCONFDIR variable which > causes it not to function at all. > --- > tools/virt-pki-validate.in |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/virt-pki

Re: [libvirt] [PATCH] cgroup.c: avoid unconditional leaks

2010-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2010 at 06:14:44AM -0700, Eric Blake wrote: > According to Jim Meyering on 2/4/2010 3:16 AM: > > Here's output from "git format-patch -U19 --stdout -1", > > so you see the context: > > for (i = 0; i < ARRAY_CARDINALITY(inherit_values) ; i++) { > > char *value; > > > >

Re: [libvirt] [PATCH] cgroup.c: avoid unconditional leaks

2010-02-04 Thread Eric Blake
According to Jim Meyering on 2/4/2010 3:16 AM: > Here's output from "git format-patch -U19 --stdout -1", > so you see the context: > for (i = 0; i < ARRAY_CARDINALITY(inherit_values) ; i++) { > char *value; > > rc = virCgroupGetValueStr(parent, >

[libvirt] [PATCH 3/5] macvtap support for libvirt -- qemu support

2010-02-04 Thread Stefan Berger
This part adds support for qemu making a macvtap tap device available via file descriptor passed to qemu command line. This also attempts to tear down the macvtap device when a VM terminates. This includes support for attachment and detachment to/from running VM. Signed-off-by: Stefan Berger In

[libvirt] [PATCH 4/5] macvtap support for libvirt -- helper code

2010-02-04 Thread Stefan Berger
This part adds the helper code to setup and tear down macvtap devices using direct communication with the device driver via netlink sockets. Signed-off-by: Stefan Berger Index: libvirt-macvtap/src/util/macvtap.h === --- /dev/null ++

[libvirt] [PATCH 5/5] macvtap support for libvirt -- schema extensions

2010-02-04 Thread Stefan Berger
This part extends the domain xml schema to support the new interface type 'direct'. Signed-off-by: Stefan Berger Index: libvirt-macvtap/docs/schemas/domain.rng === --- libvirt-macvtap.orig/docs/schemas/domain.rng +++ libvirt-macvta

[libvirt] [PATCH 2/5] macvtap support for libvirt -- parse new interface XML

2010-02-04 Thread Stefan Berger
This part adds support to domain_conf.{c|h} for parsing the new interface XML of type 'direct'. Signed-off-by: Stefan Berger Index: libvirt-macvtap/src/conf/domain_conf.c === --- libvirt-macvtap.orig/src/conf/domain_conf.c +++ li

[libvirt] [PATCH 0/5] macvtap support for Qemu/KVM VMs via libvirt

2010-02-04 Thread Stefan Berger
Hello! The following patches provide support for making the macvtap networking device type available to Qemu/KVM VMs. The patches rely on the macvtap driver that just became available through the Linux net-next tree (fixes still may be necessary) and make the device available to Qemu/KVM via a t

[libvirt] [PATCH 1/5] macvtap support for libvirt -- build support

2010-02-04 Thread Stefan Berger
This patch adds build support for libvirt checking for certain contents of /usr/include/linux/if_link.h to see whether macvtap support is compilable on that system. One can disable macvtap support in libvirt via --without-macvtap passed to configure. Signed-off-by: Stefan Berger Index: libvirt/s

Re: [libvirt] [RFC] Proposal for introduction of network traffic filtering capabilities for filtering of network traffic from and to VMs

2010-02-04 Thread Gerhard Stenzel
On Mon, 2010-01-25 at 14:59 +, Daniel P. Berrange wrote: > The shear size of the ruleset inside the element is > rather alarming to me. Imagine if you have a guest with more > than one NIC. I'm inclined to suggest that the > element in the domain XML description should only have a single >

[libvirt] [PATCH] virDomainChrDefParseXML: don't leak upon invalid input

2010-02-04 Thread Jim Meyering
>From 6d0e0e571bba7792df9dacb898849708d5d3b425 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 4 Feb 2010 12:49:53 +0100 Subject: [PATCH] virDomainChrDefParseXML: don't leak upon invalid input * src/conf/domain_conf.c (virDomainChrDefParseXML): Don't leak a virDomainChrDef buffer upon "u

[libvirt] [PATCH] virExecWithHook: avoid leak on OOM error path

2010-02-04 Thread Jim Meyering
>From ab102cf853e3b46bf10cf0faafa643a352ed Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 4 Feb 2010 12:25:34 +0100 Subject: [PATCH] virExecWithHook: avoid leak on OOM error path * src/util/util.c (virExecWithHook): Free argv_str string before returning upon failure to allocate space

[libvirt] [PATCH] cgroup.c: don't leak mem+FD upon OOM

2010-02-04 Thread Jim Meyering
Here's the patch: (note, no need to test for mapping == NULL in the no_memory block) >From 91dbe896fff64783df1c68769a57a267441143ae Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 4 Feb 2010 11:22:20 +0100 Subject: [PATCH] cgroup.c: don't leak mem+FD upon OOM * src/util/cgroup.c (virCgrou

[libvirt] [PATCH] cgroup.c: avoid unconditional leaks

2010-02-04 Thread Jim Meyering
Here's output from "git format-patch -U19 --stdout -1", so you see the context: >From 47ea9beecf93a796e606b4d906424c05e7f6c9bb Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 4 Feb 2010 11:14:03 +0100 Subject: [PATCH] cgroup.c: avoid unconditional leaks * src/util/cgroup.c (virCgroupCpuSe