Re: [libvirt] [PATCH] Silence compiler complaints about non-literal format strings

2010-03-12 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 04:52:04PM -0500, Chris Lalancette wrote: On 03/11/2010 04:12 PM, Laine Stump wrote: * src/util/macvtap.c: replace _() with %s, _(...) in two places --- src/util/macvtap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [libvirt] cpu values

2010-03-12 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 04:46:45PM -0600, Tavares, John wrote: I am trying to compare the results that I am getting on a RHEL 5.3 server using xm list (using libvirt.so.0.3.3) against both my Dom0 and my Linux DomU on the same server to see if the cpu values match to what the kernel is

Re: [libvirt] [PATCH] Fix compiler warnings in virsh.c

2010-03-12 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 04:39:35PM -0500, Laine Stump wrote: No functional change. These all generated compiler warnings which, for some reason weren't converted to errors by --enable-compiler-warnings=error. * tools/virsh.c: * change return type frmo int to void on two functions that

Re: [libvirt] [PATCH] Fix crash in virsh after bogus command.

2010-03-12 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 06:00:54PM -0500, Chris Lalancette wrote: If you ran virsh in interactive mode and ran a command that virsh could not parse, it would then SEGV on subsequent commands. The problem is that we are freeing the vshCmd structure in the syntaxError label at the end of

Re: [libvirt] [PATCH] Fix virsh command 'cd'.

2010-03-12 Thread Daniel Veillard
On Fri, Mar 12, 2010 at 12:03:42AM -0500, Laine Stump wrote: On 03/11/2010 06:00 PM, Chris Lalancette wrote: cmdCd was returning a 0 on success and -1 on error, when the rest of the code expected a TRUE on success and a FALSE on error. Fix the discrepancy. Signed-off-by: Chris

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 06:00:56PM -0500, Chris Lalancette wrote: The nodeGetInfo code was always assuming that machine had a single NUMA node, which is not correct. The good news is that libnuma gives us this information pretty easily, so let's properly report it. okay NOTE: With recent

Re: [libvirt] cpu values

2010-03-12 Thread Tavares, John
Hi Dan. Ok, thanks. I am trying to play around with this and noticed that my code with does use libvirt reports the exact same values as xm. Either way, I do not see the values even being close. Is this expected and if so why?? -Original Message- From: Daniel Veillard

Re: [libvirt] cpu values

2010-03-12 Thread Tavares, John
As an example to show xm and virsh are reporting the same values: $ sudo virsh dominfo 0 Id: 0 Name: Domain-0 UUID: ---- OS Type:linux State: running CPU(s): 1 CPU time: 74108.3s Max memory: no

Re: [libvirt] [PATCH 0/13] [RFC] Network filtering (ACL) extensions for libvirt

2010-03-12 Thread Stefan Berger
One note: the attached patches must be compiled with --without-lxc support due to a linking problem. Will fix this for the next post. Regards, Stefan Hi! The following set of patches add network filtering (ACL) extensions to libvirt and enable network traffic filtering for VMs using

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Chris Lalancette
On 03/12/2010 06:32 AM, Daniel Veillard wrote: On Thu, Mar 11, 2010 at 06:00:56PM -0500, Chris Lalancette wrote: The nodeGetInfo code was always assuming that machine had a single NUMA node, which is not correct. The good news is that libnuma gives us this information pretty easily, so let's

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Daniel Veillard
On Fri, Mar 12, 2010 at 08:45:23AM -0500, Chris Lalancette wrote: On 03/12/2010 06:32 AM, Daniel Veillard wrote: On Thu, Mar 11, 2010 at 06:00:56PM -0500, Chris Lalancette wrote: The nodeGetInfo code was always assuming that machine had a single NUMA node, which is not correct. The good

Re: [libvirt] [PATCH] Allow a user-settable number of VNC autoports.

2010-03-12 Thread Daniel Veillard
On Thu, Mar 11, 2010 at 06:00:55PM -0500, Chris Lalancette wrote: Currently we have a hard-coded maximum of 100 VNC autoports that the qemu driver can use. This may not be enough for running large numbers of guests on larger machines. However, we don't necessarily necessarily want to make it

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Luiz Capitulino
Hi Chris, On Thu, 11 Mar 2010 18:00:56 -0500 Chris Lalancette clala...@redhat.com wrote: The nodeGetInfo code was always assuming that machine had a single NUMA node, which is not correct. The good news is that libnuma gives us this information pretty easily, so let's properly report it.

Re: [libvirt] [PATCH] Make nodeGetInfo report the correct number of NUMA nodes.

2010-03-12 Thread Chris Lalancette
On 03/12/2010 10:10 AM, Luiz Capitulino wrote: Hi Chris, On Thu, 11 Mar 2010 18:00:56 -0500 Chris Lalancette clala...@redhat.com wrote: The nodeGetInfo code was always assuming that machine had a single NUMA node, which is not correct. The good news is that libnuma gives us this

[libvirt] [PATCH] Only use the numa functions when they are available.

2010-03-12 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- src/nodeinfo.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 8d7e055..bf57517 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -160,10 +160,12 @@ int

Re: [libvirt] [PATCH] Only use the numa functions when they are available.

2010-03-12 Thread Daniel Veillard
On Fri, Mar 12, 2010 at 10:56:13AM -0500, Chris Lalancette wrote: Signed-off-by: Chris Lalancette clala...@redhat.com --- src/nodeinfo.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 8d7e055..bf57517 100644 ---

Re: [libvirt] Request to mailing list libvir-list rejected

2010-03-12 Thread Matthias Bolte
2010/3/10 Eric Blake ebl...@redhat.com: [in general, technical lists tend to frown on the practice of top-posting] On 03/10/2010 02:49 PM, Dev.Atom wrote: Sorry, I'm not used to use mailing list I think the relevants part are these functions : int virFileOperation(const char *path, int

Re: [libvirt] Request to mailing list libvir-list rejected

2010-03-12 Thread Eric Blake
On 03/12/2010 09:13 AM, Matthias Bolte wrote: Matthias probably already hit it on the head - gnulib can guarantee that uid_t is defined in spite of mingw not providing it, but I haven't personally checked whether we are using this aspect of gnulib yet, and I will defer to see Matthias'

[libvirt] [PATCH 0/2] virsh: honor VISUAL

2010-03-12 Thread Eric Blake
On IRC yesterday, the comment came up that 'virsh edit' is over-protective, because it prevented me from editing in-terminal using my favorite editor, even after I worked around the fact that sudo sanitizes EDITOR. Besides, historically, VISUAL is used in situations where opening a new window is

[libvirt] [PATCH 1/2] virsh: improve man page

2010-03-12 Thread Eric Blake
* tools/virsh.pod: (DESCRIPTION): Improve grammar. Mention other drivers. (ENVIRONMENT): Document EDITOR. (COPYRIGHT): Bump. --- tools/virsh.pod | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 8f6df19..302de18

[libvirt] [PATCH 2/2] virsh: support VISUAL, and allow metacharacters in EDITOR

2010-03-12 Thread Eric Blake
Common Unix practice is to prefer VISUAL over EDITOR, particularly if the editor of choice spawns a new window. Thus, it is also common to see settings like EDITOR='emacs -nw', with the expectation that the shell will parse this as an argument to 'emacs' and not try to invoke a file containing a

[libvirt] [PATCH] qemu: Fix USB by product with security enabled

2010-03-12 Thread Cole Robinson
We need to call PrepareHostdevs to determine the USB device path before any security calls. PrepareHostUSBDevices was also incorrectly skipping all USB devices. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 11 ++- 1 files changed, 6 insertions(+), 5

[libvirt] [PATCH] maint: make Red Hat copyright notices consistent

2010-03-12 Thread Eric Blake
Spell out 'Red Hat, Inc.': git grep -i 'Copyright.*Red Hat' | grep -v Inc Include (C) consistently: git grep -i 'Copyright [^(].*Red Hat' * src/lxc/lxc_container.c: Update copyright formatting. * src/node_device/node_device_udev.c: Likewise. * src/node_device/node_device_udev.h: Likewise. *

[libvirt] [PATCH] qemu: Add some debugging at domain startup

2010-03-12 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_driver.c | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f8ab545..26b5600 100644 --- a/src/qemu/qemu_driver.c +++

Re: [libvirt] [PATCH] qemu: Add some debugging at domain startup

2010-03-12 Thread Eric Blake
On 03/12/2010 10:49 AM, Cole Robinson wrote: -/* Ensure no historical cgroup for this VM is lieing around bogus settings */ +/* Ensure no historical cgroup for this VM is lieing around bogus + * settings */ +DEBUG0(Removing old cgroup (if required)); That doesn't parse

Re: [libvirt] [PATCH] qemu: Fix USB by product with security enabled

2010-03-12 Thread Eric Blake
On 03/12/2010 10:49 AM, Cole Robinson wrote: We need to call PrepareHostdevs to determine the USB device path before any security calls. PrepareHostUSBDevices was also incorrectly skipping all USB devices. ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization

[libvirt] [PATCH] security: Set permissions for kernel/initrd

2010-03-12 Thread Cole Robinson
Fixes URL installs when running virt-install as root on Fedora. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_security_dac.c| 21 + src/security/security_selinux.c | 16 2 files changed, 37 insertions(+), 0 deletions(-) diff

Re: [libvirt] libvirt modifying iptables rules

2010-03-12 Thread David Lutterkort
On Mon, 2010-03-08 at 23:02 +0100, Felix Schwarz wrote: Am 07.03.2010 15:09, schrieb Varrun Ramani: I am right now undertaking a project which deals with verification of firewall rules. I wish to know which applications/libraries modify/query firewall rules. I came to know that libvirt

[libvirt] [PATCH] esx: Allow 'lsisas1068' as SCSI controller type

2010-03-12 Thread Matthias Bolte
Extend tests to cover all SCSI controller types and document the new type. --- docs/drvesx.html.in |4 +++ src/esx/esx_vmx.c | 14 +++- tests/vmx2xmldata/vmx2xml-scsi-buslogic.vmx |7 --

Re: [libvirt] [PATCH] Change logrotate to be per-hypervisor logs

2010-03-12 Thread Dave Allan
On 03/11/2010 01:33 AM, Osier Yang wrote: hi will it be better provide some configuration in libvirtd.conf or ENV viriable to control the log level of each hypervisor log seperately? such as I want to libvirt will just log errors for lxc, but any messages for qemu, warning, and error message

Re: [libvirt] [virt-tools-list] unable to connect to a ESX via ssh

2010-03-12 Thread Matthias Bolte
2010/3/9 Guido Günther a...@sigxcpu.org: Hi Matthias, On Mon, Mar 08, 2010 at 08:28:07PM +0100, Matthias Bolte wrote: 2010/3/8 Dimitris Kalogeras d.kaloge...@noc.ntua.gr: Hi *, Apologies for cross posting. I have installed the the libvirt and virt-toolss in an ubuntu karmic 9.10. I am

[libvirt] [PATCH] macvtap: Only export symbols if support is enabled

2010-03-12 Thread Matthias Bolte
--- src/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 67f8b6d..4c12586 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -786,7 +786,9 @@ if WITH_LINUX USED_SYM_FILES += libvirt_linux.syms endif +if

[libvirt] [PATCH] esx: Improve documentation about remote URIs

2010-03-12 Thread Matthias Bolte
--- docs/drvesx.html.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in index 9b413ab..6855298 100644 --- a/docs/drvesx.html.in +++ b/docs/drvesx.html.in @@ -32,6 +32,14 @@ gsx://example.com (GSX over

Re: [libvirt] [PATCH] esx: Improve documentation about remote URIs

2010-03-12 Thread Eric Blake
On 03/12/2010 02:34 PM, Matthias Bolte wrote: --- docs/drvesx.html.in |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in index 9b413ab..6855298 100644 --- a/docs/drvesx.html.in +++ b/docs/drvesx.html.in @@ -32,6

Re: [libvirt] [PATCH] macvtap: Only export symbols if support is enabled

2010-03-12 Thread Eric Blake
On 03/12/2010 02:34 PM, Matthias Bolte wrote: --- src/Makefile.am |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 67f8b6d..4c12586 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -786,7 +786,9 @@ if WITH_LINUX