[libvirt] Network XML for static IP address.

2010-03-17 Thread Kumar L Srikanth-B22348
Hi, I want to assign a static IP address to one of the interfaces created through libvirt. Can anyone please let me know the network XML format? I explored lot of sites on this, but I only found assigning IP address through DHCP rather than Static. Please help me. Regards, Srikanth. --

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command

2010-03-17 Thread Jiri Denemark
@@ -2794,6 +2799,19 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd)     if (vshCommandOptBool (cmd, suspend))         flags |= VIR_MIGRATE_PAUSED; +    downtime = vshCommandOptFloat(cmd, downtime, found); +    if (found) { +        unsigned long long nanoseconds = downtime * 1e9;

Re: [libvirt] [PATCH] do not require two ./autogen.sh runs to permit make

2010-03-17 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 09:42:32PM +0100, Jim Meyering wrote: I tracked down the source of the two-autogen.sh-runs-required bug. Here's the fix: From 0583de2de2038d4f8875268391fd4994329d39bf Mon Sep 17 00:00:00 2001 From: Jim Meyering meyer...@redhat.com Date: Tue, 16 Mar 2010 21:08:31

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command

2010-03-17 Thread Matthias Bolte
2010/3/17 Jiri Denemark jdene...@redhat.com: @@ -2794,6 +2799,19 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd)     if (vshCommandOptBool (cmd, suspend))         flags |= VIR_MIGRATE_PAUSED; +    downtime = vshCommandOptFloat(cmd, downtime, found); +    if (found) { +        

Re: [libvirt] [PATCH] do not require two ./autogen.sh runs to permit make

2010-03-17 Thread Jim Meyering
Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 09:42:32PM +0100, Jim Meyering wrote: I tracked down the source of the two-autogen.sh-runs-required bug. Here's the fix: Subject: [PATCH] do not require two ./autogen.sh runs to permit make * autogen.sh (bootstrap_hash): New function.

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command

2010-03-17 Thread Daniel P. Berrange
On Wed, Mar 17, 2010 at 11:05:35AM +0100, Matthias Bolte wrote: 2010/3/17 Jiri Denemark jdene...@redhat.com: @@ -2794,6 +2799,19 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd)     if (vshCommandOptBool (cmd, suspend))         flags |= VIR_MIGRATE_PAUSED; +    downtime =

Re: [libvirt] [PATCH 0/9] Rebased volume wiping API patches

2010-03-17 Thread Daniel P. Berrange
On Mon, Mar 15, 2010 at 10:13:22PM -0400, David Allan wrote: Nobody ack'd (because of general lack of time, I hope) what I think is the final version of the volume wiping API patches, so here is the set again, rebased to the current head. I don't think there is anything controversial in

Re: [libvirt] [PATCH] do not require two ./autogen.sh runs to permit make

2010-03-17 Thread Daniel Veillard
On Tue, Mar 16, 2010 at 09:42:32PM +0100, Jim Meyering wrote: I tracked down the source of the two-autogen.sh-runs-required bug. Yay ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/

Re: [libvirt] [RFC][PATCH v2 0/2] Dynamic backend setup for macvtap interfaces

2010-03-17 Thread Daniel P. Berrange
On Mon, Mar 08, 2010 at 04:29:42PM -0800, Ed Swierk wrote: I posted this RFC/patch set a few weeks ago but didn't receive any response. My implementation works, but I'd like to hear from anyone more familiar with libvirt concurrency than I (i.e. nearly everyone) about how it might be improved.

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command

2010-03-17 Thread Daniel P. Berrange
On Wed, Mar 17, 2010 at 12:02:27PM +0100, Matthias Bolte wrote: 2010/3/17 Daniel P. Berrange berra...@redhat.com: On Wed, Mar 17, 2010 at 11:05:35AM +0100, Matthias Bolte wrote: Conceptually this doesn't make sense. The max downtime parameter is a live tunable that a management app will

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command

2010-03-17 Thread Matthias Bolte
2010/3/17 Daniel P. Berrange berra...@redhat.com: On Wed, Mar 17, 2010 at 11:05:35AM +0100, Matthias Bolte wrote: 2010/3/17 Jiri Denemark jdene...@redhat.com: @@ -2794,6 +2799,19 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd)     if (vshCommandOptBool (cmd, suspend))         flags

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command

2010-03-17 Thread Matthias Bolte
2010/3/17 Daniel P. Berrange berra...@redhat.com: On Wed, Mar 17, 2010 at 12:02:27PM +0100, Matthias Bolte wrote: 2010/3/17 Daniel P. Berrange berra...@redhat.com: On Wed, Mar 17, 2010 at 11:05:35AM +0100, Matthias Bolte wrote: Conceptually this doesn't make sense. The max downtime

Re: [libvirt] [PATCH] Allow suspend during live migration

2010-03-17 Thread Daniel P. Berrange
On Mon, Mar 15, 2010 at 02:19:00PM +0100, Jiri Denemark wrote: Currently no command can be sent to a qemu process while another job is active. This patch adds support for signaling long-running jobs (such as migration) so that other threads may request predefined operations to be done during

Re: [libvirt] [PATCH 1/13] Adding recursive locks

2010-03-17 Thread Daniel P. Berrange
On Thu, Mar 11, 2010 at 08:06:34AM -0500, Stefan Berger wrote: This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including references that cause looks. Loops in the XML are prevented but their detection requires

Re: [libvirt] [PATCH 9/13] Add virsh support for new CLI commands

2010-03-17 Thread Daniel P. Berrange
On Thu, Mar 11, 2010 at 08:09:13AM -0500, Stefan Berger wrote: This patch adds virsh support for the five new CLI commands to manage network filters. Signed-off-by: Stefan Berger stef...@us.ibm.com --- tools/virsh.c | 349 ++ 1

Re: [libvirt] [PATCH 1/13] Adding recursive locks

2010-03-17 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 03/17/2010 07:48:46 AM: Berrange void virMutexDestroy(virMutexPtr m) { pthread_mutex_destroy(m-lock); Minor point, I think it would be better to call it virMutexInitRecursive() so we keep the standard virMutex prefix for naming

Re: [libvirt] [PATCH 9/13] Add virsh support for new CLI commands

2010-03-17 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 03/17/2010 07:52:53 AM: On Thu, Mar 11, 2010 at 08:09:13AM -0500, Stefan Berger wrote: This patch adds virsh support for the five new CLI commands to manage network filters. Signed-off-by: Stefan Berger stef...@us.ibm.com ---

Re: [libvirt] [PATCH 2/9] Define the internal driver API for vol wiping

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:24PM -0400, David Allan wrote: --- src/driver.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/driver.h b/src/driver.h index a64bba0..1a511eb 100644 --- a/src/driver.h +++ b/src/driver.h @@ -723,6 +723,10 @@ typedef int

Re: [libvirt] [PATCH 1/9] Add public API for volume wiping

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:23PM -0400, David Allan wrote: --- include/libvirt/libvirt.h.in |2 ++ src/libvirt_public.syms |5 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index

Re: [libvirt] [PATCH 4/9] Implement the public API for vol wiping

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:26PM -0400, David Allan wrote: --- src/libvirt.c | 47 +++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 1d9b878..74b075b 100644 --- a/src/libvirt.c +++

Re: [libvirt] [PATCH 5/9] Define wire protocol format for vol wiping

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:27PM -0400, David Allan wrote: --- src/remote/remote_protocol.c | 11 +++ src/remote/remote_protocol.h |9 + src/remote/remote_protocol.x |8 +++- 3 files changed, 27 insertions(+), 1 deletions(-) ACK, Daniel -- Daniel

Re: [libvirt] [PATCH 6/9] Implement RPC client for vol wiping

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:28PM -0400, David Allan wrote: --- src/remote/remote_driver.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 11513bd..0ee038e 100644 ---

Re: [libvirt] [PATCH 7/9] Implement the remote dispatch bits of vol wiping

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:29PM -0400, David Allan wrote: * I had to remove daemon/remote_dispatch* and do a make remote.c in daemon in order to get the dispatch files regenerated properly. The make was failing before I did that. Strange, we have an make rpcgen to rebuild the remote

Re: [libvirt] [PATCH 9/9] Virsh support for vol wiping

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:31PM -0400, David Allan wrote: --- tools/virsh.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index aa85ee6..37ff471 100644 --- a/tools/virsh.c +++

Re: [libvirt] [PATCH] Allow suspend during live migration

2010-03-17 Thread Jiri Denemark
ACK to this patch. If you want to solve the async problem with a condition variable it can be a add-on patch later Thanks for the review. I pushed this version and I'll possibly address the async behavior separately. Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH 8/9] Simplified version of volume wiping based on feedback from the list.

2010-03-17 Thread Daniel Veillard
On Mon, Mar 15, 2010 at 10:13:30PM -0400, David Allan wrote: --- src/storage/storage_driver.c | 224 ++ 1 files changed, 224 insertions(+), 0 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index

Re: [libvirt] [PATCH] do not require two ./autogen.sh runs to permit make

2010-03-17 Thread Daniel Veillard
On Wed, Mar 17, 2010 at 11:20:33AM +0100, Jim Meyering wrote: Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 09:42:32PM +0100, Jim Meyering wrote: I tracked down the source of the two-autogen.sh-runs-required bug. Here's the fix: Subject: [PATCH] do not require two ./autogen.sh runs

Re: [libvirt] [PATCH 0/13] [RFC] Network filtering (ACL) extensions for libvirt

2010-03-17 Thread Daniel P. Berrange
On Thu, Mar 11, 2010 at 08:06:04AM -0500, Stefan Berger wrote: Hi! The following set of patches add network filtering (ACL) extensions to libvirt and enable network traffic filtering for VMs using ebtables and, depending on the networking technology being used (tap, but not macvtap), also

Re: [libvirt] [PATCH 8/9] Simplified version of volume wiping based on feedback from the list.

2010-03-17 Thread Laine Stump
On 03/17/2010 10:13 AM, Daniel Veillard wrote: On Mon, Mar 15, 2010 at 10:13:30PM -0400, David Allan wrote: --- src/storage/storage_driver.c | 224 ++ 1 files changed, 224 insertions(+), 0 deletions(-) [...] +char errbuf[64];

Re: [libvirt] [PATCH 0/13] [RFC] Network filtering (ACL) extensions for libvirt

2010-03-17 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 03/17/2010 10:40:36 AM: On Thu, Mar 11, 2010 at 08:06:04AM -0500, Stefan Berger wrote: Hi! The following set of patches add network filtering (ACL) extensions to libvirt and enable network traffic filtering for VMs using ebtables and,

Re: [libvirt] [PATCH 0/13] [RFC] Network filtering (ACL) extensions for libvirt

2010-03-17 Thread Daniel P. Berrange
On Wed, Mar 17, 2010 at 10:53:37AM -0400, Stefan Berger wrote: Daniel P. Berrange berra...@redhat.com wrote on 03/17/2010 10:40:36 AM: On Thu, Mar 11, 2010 at 08:06:04AM -0500, Stefan Berger wrote: Hi! The following set of patches add network filtering (ACL) extensions to

Re: [libvirt] disk XML for error policy

2010-03-17 Thread Daniel P. Berrange
On Tue, Mar 16, 2010 at 10:14:26PM -0400, Dave Allan wrote: Hi Dan, What do you think of this for the disk XML specifying what to do on error: disk type='file' device='disk' source file='/storage/guest_disks/libgdu'/ target dev='vda' bus='virtio'/ on_err

Re: [libvirt] disk XML for error policy

2010-03-17 Thread Dave Allan
On 03/17/2010 11:09 AM, Daniel P. Berrange wrote: On Tue, Mar 16, 2010 at 10:14:26PM -0400, Dave Allan wrote: Hi Dan, What do you think of this for the disk XML specifying what to do on error: disk type='file' device='disk' source file='/storage/guest_disks/libgdu'/ target

Re: [libvirt] [PATCH 8/9] Simplified version of volume wiping based on feedback from the list.

2010-03-17 Thread Laine Stump
On 03/17/2010 10:49 AM, Laine Stump wrote: +if (ret == -1) { +virReportSystemError(ret, + _(Failed to truncate volume with + path '%s' to %ju bytes: '%s'\n), + vol-target.path, (intmax_t)size, +

Re: [libvirt] [PATCH 8/9] Simplified version of volume wiping based on feedback from the list.

2010-03-17 Thread Daniel P. Berrange
On Wed, Mar 17, 2010 at 11:24:03AM -0400, Laine Stump wrote: On 03/17/2010 10:49 AM, Laine Stump wrote: +if (ret == -1) { +virReportSystemError(ret, + _(Failed to truncate volume with + path '%s' to %ju bytes: '%s'\n),

Re: [libvirt] [PATCH] esx: Allow 'lsisas1068' as SCSI controller type

2010-03-17 Thread Matthias Bolte
2010/3/15 Daniel P. Berrange berra...@redhat.com: On Fri, Mar 12, 2010 at 09:19:02PM +0100, Matthias Bolte wrote: diff --git a/tests/xml2vmxdata/xml2vmx-scsi-driver.xml b/tests/xml2vmxdata/xml2vmx-scsi-driver.xml new file mode 100644 index 000..797a26e --- /dev/null +++

Re: [libvirt] [PATCH] esx: Allow 'lsisas1068' as SCSI controller type

2010-03-17 Thread Daniel P. Berrange
On Wed, Mar 17, 2010 at 05:17:38PM +0100, Matthias Bolte wrote: 2010/3/15 Daniel P. Berrange berra...@redhat.com: So I withdraw this patch and rework the controller type handling to use the controller element. There seems to be no documentation about the controller element on the libvirt

[libvirt] Just pushed a few small fixes

2010-03-17 Thread Cole Robinson
Hi all, I've just pushed three small fixes: $ git log -3 --pretty=short commit 2ef091efcc5cd02bbd496972b141cf253f713fdd Author: Philip Hahn h...@univention.de python: Fix networkLookupByUUID commit 0ef58c315506d094a0a4d64f022119a04a1916c0 Author: Cole Robinson crobi...@redhat.com

Re: [libvirt] virsh stucked in virDomainCreate

2010-03-17 Thread Matthias Bolte
[Let's keep it on the list, so other could help too] 2010/3/15 Anthony Lannuzel lannu...@gmail.com: On Sat, Mar 13, 2010 at 6:51 PM, Matthias Bolte matthias.bo...@googlemail.com wrote: 2010/3/13 Anthony Lannuzel lannu...@gmail.com: Hi, I'm having an issue when trying to start a (previously

Re: [libvirt] Userdata for libvirt?

2010-03-17 Thread Matthias Bolte
2010/3/17 Yushu Yao yao.yu...@gmail.com: Hi Experts, Forgive me if not clear enough, will try to be describe what I need. What I need: Start a VM on a remote libvirtd server based on an existing image (Might or might not exist on server), plus some userdata. It is pretty much the same

Re: [libvirt] Userdata for libvirt?

2010-03-17 Thread Yushu Yao
Thanks Matthias, For example, when I start up a guest which depends on an NFS server, I would like to pass the ip address of the NFS server to the new guest, so that the new guest can configure itself to point to the proper NFS server. This is what I mean by userdata. In EC2 or Eucalyptus

[libvirt] [PATCH] website: Increase text size

2010-03-17 Thread Cole Robinson
Personally I find the text so small it is difficult to read, especially in the documentation pages where we can have a large wall of text. Here is a before and after shot of the main page on my machine (scaled down): http://fedorapeople.org/~crobinso/tmp/libvirt-web-before-after.png Text size

[libvirt] [PATCH] website: Drop static FAQ, point to http://wiki.libvirt.org/page/FAQ

2010-03-17 Thread Cole Robinson
The static FAQ was from the days before even QEMU support. I added a few questions to the wiki FAQ about the software license and how to download and install (basically just pointing to downloads.html). The remaining questions on the static page aren't anything that I think is really 'frequently

[libvirt] [PATCH] website: Remove old repos from download section

2010-03-17 Thread Cole Robinson
We haven't been using CVS for quite a while now, so I think we can safely drop the reference to the old server and git mirror. Signed-off-by: Cole Robinson crobi...@redhat.com --- docs/downloads.html.in | 33 - 1 files changed, 0 insertions(+), 33 deletions(-)

[libvirt] [PATCH] dont't crash in virsh dominfo domain

2010-03-17 Thread Guido Günther
Hi, virsh dominfo domain crashes with: #0 strlen () at ../sysdeps/i386/i486/strlen.S:69 #1 0x080891c9 in qemudNodeGetSecurityModel (conn=0x8133940, secmodel=0xb5676ede) at qemu/qemu_driver.c:4911 #2 0xb7eb5623 in virNodeGetSecurityModel (conn=0x8133940, secmodel=0x0) at libvirt.c:5118 #3

Re: [libvirt] [PATCH 0/13] [RFC] Network filtering (ACL) extensions for libvirt

2010-03-17 Thread Stefan Berger
Daniel P. Berrange berra...@redhat.com wrote on 03/17/2010 11:00:26 AM: Please respond to Daniel P. Berrange On Wed, Mar 17, 2010 at 10:53:37AM -0400, Stefan Berger wrote: Daniel P. Berrange berra...@redhat.com wrote on 03/17/2010 10:40:36 AM: I hadn't thought about calling

Re: [libvirt] [PATCH] website: Increase text size

2010-03-17 Thread Jiri Denemark
Personally I find the text so small it is difficult to read, especially in the documentation pages where we can have a large wall of text. ... diff --git a/docs/libvirt.css b/docs/libvirt.css index dfc93c6..46e9a3f 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -33,6 +33,7 @@

Re: [libvirt] [PATCH] docs: pre cannot be nested in p

2010-03-17 Thread Eric Blake
On 03/13/2010 07:09 AM, Matthias Bolte wrote: xsltproc complained about this. --- docs/hacking.html.in |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index f5ec635..03a1bee 100644 --- a/docs/hacking.html.in +++

[libvirt] [PATCH] qemu: Fix FD leak in qemudStartVMDaemon

2010-03-17 Thread Matthias Bolte
The logfile FD is dup2'ed in __virExec in the child. The FD needs to be closed in the parent, otherwise it leaks. --- src/qemu/qemu_driver.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c8f3a15..fbb1275 100644 ---

Re: [libvirt] [PATCH] docs: pre cannot be nested in p

2010-03-17 Thread Matthias Bolte
2010/3/17 Eric Blake ebl...@redhat.com: On 03/13/2010 07:09 AM, Matthias Bolte wrote: xsltproc complained about this. ---  docs/hacking.html.in |    7 ---  1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index f5ec635..03a1bee

Re: [libvirt] [PATCH] Add --downtime option to virsh migrate command

2010-03-17 Thread Eric Blake
On 03/16/2010 08:56 AM, Jiri Denemark wrote: @@ -2794,6 +2799,19 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd) if (vshCommandOptBool (cmd, suspend)) flags |= VIR_MIGRATE_PAUSED; +downtime = vshCommandOptFloat(cmd, downtime, found); +if (found) { +

Re: [libvirt] [PATCH 9/13] Add virsh support for new CLI commands

2010-03-17 Thread Eric Blake
On 03/17/2010 06:47 AM, Stefan Berger wrote: Since you wrote this, we've decide to replace 'gettext_noop' with 'N_' in all virsh code. 'make syntax-check' should warn about this now, i believe Thanks for pointing this out -- fixed. Unfortunately 'make syntax-check' does not report the

[libvirt] [PATCH] maint: enforce recent N_ usage

2010-03-17 Thread Eric Blake
* cfg.mk (sc_prohibit_gettext_noop): New rule. --- cfg.mk |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 3fd9f7b..5b4d6ed 100644 --- a/cfg.mk +++ b/cfg.mk @@ -105,6 +105,11 @@ sc_prohibit_gethostname: msg='use virGetHostname, not

Re: [libvirt] [PATCH 2/9] Define the internal driver API for vol wiping

2010-03-17 Thread Eric Blake
On 03/15/2010 08:13 PM, David Allan wrote: @@ -791,6 +795,7 @@ struct _virStorageDriver { virDrvStorageVolCreateXML volCreateXML; virDrvStorageVolCreateXMLFrom volCreateXMLFrom; virDrvStorageVolDelete volDelete; +virDrvStorageVolWipe volWipe; virDrvStorageVolGetInfo