Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Alexander Graf
On 22.03.2010, at 22:49, Anthony Liguori wrote: On 03/22/2010 03:10 PM, Daniel P. Berrange wrote: What's the feeling about this from the libvirt side of things? Is there interest in support hypervisor specific interfaces should we be looking to provide our own management interface for

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Jes Sorensen
On 03/22/10 22:53, Anthony Liguori wrote: On 03/22/2010 04:33 PM, Gerd Hoffmann wrote: libvirt is very unfriendly to qemu hackers. There is no easy way to add command line switches. There is no easy way to get access to the monitor. I can get it done by pointing emulator to a wrapper script and

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Gerd Hoffmann
On 03/23/10 09:54, Jes Sorensen wrote: On 03/22/10 22:53, Anthony Liguori wrote: On 03/22/2010 04:33 PM, Gerd Hoffmann wrote: libvirt is very unfriendly to qemu hackers. There is no easy way to add command line switches. There is no easy way to get access to the monitor. I can get it done by

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Gerd Hoffmann
- networking: man, setting networking is a mess, libvirt just does it for you. +1 Even when not using libvirt for a reason or another I usually hook my virtual machines into virbr0 (libvirt default network). cheers, Gerd -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] virDomainDiskDefAssignAddress: return int, not void

2010-03-23 Thread Jim Meyering
Eric Blake wrote: On 03/22/2010 02:38 PM, Jim Meyering wrote: Here's the final piece. Here's the final series. I'm including the result of Dan's review as a separate patch only for review. I'll fold it into the 3/4 before pushing. ACK from me on the series. Thanks. Pushed. --

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Gerd Hoffmann
On 03/23/10 11:31, Jes Sorensen wrote: On 03/23/10 11:25, Gerd Hoffmann wrote: [r...@xenb ~]# virsh dumpxml fedora | grep emulator emulator/root/bin/qemu-wrapper/emulator [r...@xenb ~]# cat /root/bin/qemu-wrapper Ah right thanks! However, it's a hack to get around the real problem with

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 11:50:57AM +0100, Juan Quintela wrote: Gerd Hoffmann kra...@redhat.com wrote: - networking: man, setting networking is a mess, libvirt just does it for you. +1 Even when not using libvirt for a reason or another I usually hook my virtual machines into

[libvirt] [RFC] events scripts support

2010-03-23 Thread Daniel Veillard
We would like to introduce a way to configure system wide a script which would be called when some event happens. The script is a single executable set as a libvirtd option by the system administrator (assuming one runs the system libvirtd) or the user (assuming a user run libvirtd). The

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 04:49:21PM -0500, Anthony Liguori wrote: On 03/22/2010 03:10 PM, Daniel P. Berrange wrote: This isn't necessarily libvirt's problem if it's mission is to provide a common hypervisor API that covers the most commonly used features. That is more or less our current

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Juan Quintela
Gerd Hoffmann kra...@redhat.com wrote: - networking: man, setting networking is a mess, libvirt just does it for you. +1 Even when not using libvirt for a reason or another I usually hook my virtual machines into virbr0 (libvirt default network). This is a war for another day :-) I

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Juan Quintela
Anthony Liguori anth...@codemonkey.ws wrote: Hi, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are supported by qemu vs what's implemented in libvirt.

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Jes Sorensen
On 03/23/10 11:25, Gerd Hoffmann wrote: On 03/23/10 09:54, Jes Sorensen wrote: One problem I have found, and I am not sure how to fix this in this context. Sometimes when hacking on qemu, I want to try out a new qemu binary on an existing image, without replacing the system wide one and may

Re: [libvirt] [PATCH 6/6] Implement VNC password change in QEMU

2010-03-23 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 03:21:06PM -0600, Eric Blake wrote: On 03/22/2010 01:05 PM, Daniel P. Berrange wrote: Use the new virDomainUpdateDeviceFlags API to allow the VNC password to be changed on the fly * src/internal.h: Define STREQ_NULLABLE() which is like STREQ() but does not

Re: [libvirt] [PATCH 3/6] Implement virDomainUpdateDeviceFlags API in all drivers with media change

2010-03-23 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 02:58:16PM -0600, Eric Blake wrote: On 03/22/2010 01:05 PM, Daniel P. Berrange wrote: To allow the new virDomainUpdateDeviceFlags() API to be universally used with all drivers, this patch adds an impl to all the current drivers which support CDROM or Floppy disk

Re: [libvirt] [virt-tools-list] XenAPI remote storage - target path

2010-03-23 Thread Pasi Kärkkäinen
On Mon, Mar 15, 2010 at 05:57:57PM +, Sharadha Prabhakar (3P) wrote: Hi, I'm trying to write a Remote Storage driver for XenAPI. For XAPI (used in XenServer and XCP), or for the old XenAPI used in the traditional Xen/xend? -- Pasi I see that target-path is used for both storage pools

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Juan Quintela
Daniel P. Berrange berra...@redhat.com wrote: On Tue, Mar 23, 2010 at 11:50:57AM +0100, Juan Quintela wrote: Gerd Hoffmann kra...@redhat.com wrote: - networking: man, setting networking is a mess, libvirt just does it for you. +1 Even when not using libvirt for a reason or another

Re: [libvirt] [PATCH 2/6] Remote protocol impl for virDomainUpdateDeviceFlags

2010-03-23 Thread Daniel P. Berrange
On Mon, Mar 22, 2010 at 02:28:51PM -0600, Eric Blake wrote: On 03/22/2010 01:05 PM, Daniel P. Berrange wrote: +if (virDomainUpdateDeviceFlags (dom, args-xml, args-flags) == -1) { +virDomainFree(dom); Inconsistency in whether there is a space before ( in function calls. Which

Re: [libvirt] [virt-tools-list] XenAPI remote storage - target path

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 02:22:24PM +0200, Pasi K?rkk?inen wrote: On Mon, Mar 15, 2010 at 05:57:57PM +, Sharadha Prabhakar (3P) wrote: Hi, I'm trying to write a Remote Storage driver for XenAPI. For XAPI (used in XenServer and XCP), or for the old XenAPI used in the traditional

Re: [libvirt] Can not display graphical console of lxc Virtual Machine.

2010-03-23 Thread Daniel P. Berrange
On Fri, Mar 19, 2010 at 10:47:00AM +0530, Kumar L Srikanth-B22348 wrote: Hi all, I am trying to display the graphical console of a lxc virtual machine which was already created and running. For this, I am using 'virt-viewer'. But, when I execute the following command, it's throwing some

Re: [libvirt] FW: [PATCH 1/4] Addition of XenAPI support to libvirt

2010-03-23 Thread Pasi Kärkkäinen
On Fri, Feb 19, 2010 at 03:56:56PM +0100, Daniel Veillard wrote: Similary libcurl i looked at in configure.ac for ESX, this need to be modified to be checked more generally and the LIBCURL_* variables need to be used here too. - I didn't quite understand the libcurl part you

Re: [libvirt] [RFC] events scripts support

2010-03-23 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 03/23/2010 08:12:57 AM: Please respond to Daniel P. Berrange This is a new kind of API in libvirt(d) so I'm submitting this for review. There could be some challenging issues, for example naming i.e. is the object external name like 'foo'

Re: [libvirt] [RFC] events scripts support

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 08:42:25AM -0400, Stefan Berger wrote: libvir-list-boun...@redhat.com wrote on 03/23/2010 08:12:57 AM: Please respond to Daniel P. Berrange This is a new kind of API in libvirt(d) so I'm submitting this for review. There could be some challenging

Re: [libvirt] [virt-tools-list] XenAPI remote storage - target path

2010-03-23 Thread Pasi Kärkkäinen
On Tue, Mar 23, 2010 at 02:22:24PM +0200, Pasi Kärkkäinen wrote: On Mon, Mar 15, 2010 at 05:57:57PM +, Sharadha Prabhakar (3P) wrote: Hi, I'm trying to write a Remote Storage driver for XenAPI. For XAPI (used in XenServer and XCP), or for the old XenAPI used in the traditional

Re: [libvirt] [virt-tools-list] XenAPI remote storage - target path

2010-03-23 Thread Pasi Kärkkäinen
On Tue, Mar 23, 2010 at 12:27:46PM +, Daniel P. Berrange wrote: On Tue, Mar 23, 2010 at 02:22:24PM +0200, Pasi K?rkk?inen wrote: On Mon, Mar 15, 2010 at 05:57:57PM +, Sharadha Prabhakar (3P) wrote: Hi, I'm trying to write a Remote Storage driver for XenAPI. For XAPI (used

Re: [libvirt] FW: [PATCH 1/4] Addition of XenAPI support to libvirt

2010-03-23 Thread Pasi Kärkkäinen
On Tue, Mar 23, 2010 at 01:21:55PM +, Ewan Mellor wrote: On Tue, Mar 23, 2010 at 12:43:09PM +, Pasi Kärkkäinen wrote: On Fri, Feb 19, 2010 at 03:56:56PM +0100, Daniel Veillard wrote: Similary libcurl i looked at in configure.ac for ESX, this need to be modified to be

Re: [libvirt] FW: [PATCH 1/4] Addition of XenAPI support to libvirt

2010-03-23 Thread Ewan Mellor
On Tue, Mar 23, 2010 at 12:43:09PM +, Pasi Kärkkäinen wrote: On Fri, Feb 19, 2010 at 03:56:56PM +0100, Daniel Veillard wrote: Similary libcurl i looked at in configure.ac for ESX, this need to be modified to be checked more generally and the LIBCURL_* variables need to be used

Re: [libvirt] [RFC] events scripts support

2010-03-23 Thread Gerhard Stenzel
On Tue, 2010-03-23 at 12:12 +, Daniel P. Berrange wrote: I think it would be useful to have a libvirt-events daemon that listened for these async events via our public API invoked scripts upon certain scenarios. This is obviously separate from the synchronous hooks. FWIW, a few days

Re: [libvirt] [RFC] events scripts support

2010-03-23 Thread Daniel Veillard
On Tue, Mar 23, 2010 at 12:12:57PM +, Daniel P. Berrange wrote: On Tue, Mar 23, 2010 at 12:17:50PM +0100, Daniel Veillard wrote: We would like to introduce a way to configure system wide a script which would be called when some event happens. The script is a single executable set as a

Re: [libvirt] [RFC] events scripts support

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 03:15:27PM +0100, Daniel Veillard wrote: On Tue, Mar 23, 2010 at 12:12:57PM +, Daniel P. Berrange wrote: On Tue, Mar 23, 2010 at 12:17:50PM +0100, Daniel Veillard wrote: We would like to introduce a way to configure system wide a script which would be called

Re: [libvirt] [PATCH 0/3] Refactor XML parsing code

2010-03-23 Thread Jiri Denemark
Almost identical XML parsing code for either strings or files was copied 15 times. Since it was needed on two other places for parsing CPU XML strings with correct error reporting, I decided to factor the parsing code out to xml.c and used this one implementation in all other places.

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel Veillard
On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote: Hi, Hi Anthony, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are supported by

[libvirt] error: internal error canonical hostname pointed to localhost, but this is not allowed

2010-03-23 Thread Kenneth Nagin
When trying to migrate a VM the destination libvirtd virGetHostnameLocalhost throws an internal error. I issue this command from the source host. virsh migrate rel-vm1 qemu+tls://croton/system error: internal error canonical hostname pointed to localhost, but this is not allowed The

Re: [libvirt] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Anthony Liguori
On 03/23/2010 09:51 AM, Daniel Veillard wrote: On Mon, Mar 22, 2010 at 02:25:00PM -0500, Anthony Liguori wrote: Hi, Hi Anthony, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that

[libvirt] [PATCH] Don't mix relative and absolute paths.

2010-03-23 Thread Philipp Hahn
autoconf goes to great lengths to calculate a proper MKINSTALLDIRS path, so just export the variable for gettext, but don't overwrite it with a broken path: $(top_builddir) is a relative path, while $ac_aux_dir can be an absolute path. Signed-off-by: Philipp Hahn h...@univention.de ---

[libvirt] [PATCH] poll(-0.001) does not sleep forever.

2010-03-23 Thread Philipp Hahn
The conversion from seconds to milliseconds should only be done for actual delays = 0, not for the magic -1 value used for infinite timeouts. Signed-off-by: Philipp Hahn h...@univention.de --- examples/domain-events/events-python/event-test.py |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [libvirt] [PATCH] Don't mix relative and absolute paths.

2010-03-23 Thread Eric Blake
On 03/23/2010 09:07 AM, Philipp Hahn wrote: autoconf goes to great lengths to calculate a proper MKINSTALLDIRS path, Actually, neither autoconf nor automake touches MKINSTALLDIRS; it is all provided by gettext. Did you test with gettext 0.14, automake 1.9.6 and autoconf 2.59? so just export

Re: [libvirt] [PATCH] poll(-0.001) does not sleep forever.

2010-03-23 Thread Eric Blake
On 03/23/2010 09:07 AM, Philipp Hahn wrote: The conversion from seconds to milliseconds should only be done for actual delays = 0, not for the magic -1 value used for infinite timeouts. ACK. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Anthony Liguori
On 03/23/2010 10:57 AM, Paul Brook wrote: I think there is a serious divergence of approach there, instanciating API stating 'we are gonna deprecate them sooner or later' tell the application developper 'my time is more important than yours' and not really something I like to carry to the API

Re: [libvirt] [PATCH] Don't mix relative and absolute paths.

2010-03-23 Thread Philipp Hahn
Hello, Am Dienstag 23 März 2010 16:32:47 schrieben Sie: On 03/23/2010 09:07 AM, Philipp Hahn wrote: autoconf goes to great lengths to calculate a proper MKINSTALLDIRS path, Actually, neither autoconf nor automake touches MKINSTALLDIRS; it is all provided by gettext. Did you test with

[libvirt] [PATCH v3 04/14] Implementation of the public API

2010-03-23 Thread stefanb
This patch adds the implementation of the public API for the network filtering (ACL) extensions to libvirt.c . Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/libvirt.c | 586 ++ 1 file changed, 586 insertions(+) Index:

[libvirt] Unable to open virt-manager

2010-03-23 Thread Doron Fediuck
Hi, I'm trying to work remotely on a server with F12, using vnc. When I start virt-manager, I do not get the authentication popup, and instead I get this message: Unable to open connection to hypervisor URI 'qemu:///system': authentication failed Traceback (most recent call last): File

[libvirt] [PATCH v3 09/14] Add XML parser extensions to the domain XML processing

2010-03-23 Thread stefanb
This patch extends the domain XML processing to parse the top level referenced filter along with potentially provided parameters and also converts the internal data back into XML representation. Signed-off-by: Stefan Berger stef...@us.ibm.com Signed-off-by: Gerhard Stenzel

[libvirt] [PATCH v3 02/14] Add public API

2010-03-23 Thread stefanb
This patch adds extensions to libvirt's public API necessary for controlling the new functionality from remote for example. Signed-off-by: Stefan Berger stef...@us.ibm.com --- include/libvirt/libvirt.h.in | 63 +++ 1 file changed, 63 insertions(+)

[libvirt] [PATCH v3 13/14] Add IPv6 support for the ebtables layer

2010-03-23 Thread stefanb
This patch adds IPv6 support for the ebtables layer. Since the parser etc. are all parameterized, it was fairly easy to add this... Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/conf/nwfilter_conf.c | 230 +- src/conf/nwfilter_conf.h

[libvirt] [PATCH v3 03/14] Add internal API

2010-03-23 Thread stefanb
This patch adds the internal API extensions for network filtering (ACL) support. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/driver.h | 53 + 1 file changed, 53 insertions(+) Index: libvirt-acl/src/driver.h

[libvirt] [PATCH v3 05/14] Definition of the wire format

2010-03-23 Thread stefanb
This patch adds the definition of the wire format for RPC calls for the new network filtering (ACL) functionality added to libvirt. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/remote/remote_protocol.x | 72 ++- 1 file changed, 71

[libvirt] [PATCH v3 00/14] Network filtering (ACL) extensions for libvirt

2010-03-23 Thread stefanb
Hi! This is a repost of this set of patches with some of the suggested fixes applied and ipv6 support on the ebtables layer added. The following set of patches add network filtering (ACL) extensions to libvirt and enable network traffic filtering for VMs using ebtables and, depending on the

[libvirt] [PATCH v3 01/14] Add recursive locks

2010-03-23 Thread stefanb
This patch adds recursive locks necessary due to the processing of network filter XML that can reference other network filters, including references that cause looks. Loops in the XML are prevented but their detection requires recursive locks. Signed-off-by: Stefan Berger stef...@us.ibm.com ---

[libvirt] [PATCH v3 12/14] Add build support

2010-03-23 Thread stefanb
This patch adds build support for the network filtering framework. Signed-off-by: Stefan Berger stef...@us.ibm.com --- configure.ac | 12 daemon/Makefile.am |4 src/Makefile.am | 34 +- src/libvirt_private.syms

[libvirt] [PATCH v3 06/14] Implementation of the RPC client

2010-03-23 Thread stefanb
This patch extends the RPC client for the new network filtering (ACL) functionality. Signed-off-by: Stefan Berger stef...@us.ibm.com --- daemon/remote.c | 194 1 file changed, 194 insertions(+) Index: libvirt-acl/daemon/remote.c

[libvirt] [PATCH v3 10/14] Add qemu support

2010-03-23 Thread stefanb
Add support for Qemu to have firewall rules applied and removed on VM startup and shutdown respectively. This patch also provides support for the updating of a filter that causes all VMs that reference the filter to have their ebtables/iptables rules updated. Signed-off-by: Stefan Berger

[libvirt] [PATCH v3 07/14] Implementation of the RPC call dispatch

2010-03-23 Thread stefanb
This patch extends the RPC dispatcher to support the newly added RPC calls for network filtering (ACL) support. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/remote/remote_driver.c | 311 + 1 file changed, 311 insertions(+) Index:

[libvirt] [PATCH v3 08/14] Add virsh support for new CLI commands

2010-03-23 Thread stefanb
This patch adds virsh support for the five new CLI commands to manage network filters. Signed-off-by: Stefan Berger stef...@us.ibm.com --- tools/virsh.c | 349 ++ 1 file changed, 349 insertions(+) Index: libvirt-acl/tools/virsh.c

Re: [libvirt] [Qemu-devel] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Avi Kivity
On 03/22/2010 09:25 PM, Anthony Liguori wrote: Hi, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are supported by qemu vs what's implemented in

[libvirt] [RFC]: Snapshot API

2010-03-23 Thread Chris Lalancette
Hello, As some of you know, I've been working on a new snapshot API. This API is heavily based on DanB's earlier API proposed here: https://www.redhat.com/archives/libvir-list/2010-January/msg00626.html I've made some modifications to make it more libvirt-ish, and to add a couple of

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Avi Kivity
On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like guest enumeration. So the fundamental topic here is, do we introduce these missing components to allow people to build directly to

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 11:06:20AM -0500, Anthony Liguori wrote: On 03/23/2010 10:57 AM, Paul Brook wrote: I think there is a serious divergence of approach there, instanciating API stating 'we are gonna deprecate them sooner or later' tell the application developper 'my time is more important

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Daniel P. Berrange
On Tue, Mar 23, 2010 at 08:00:21PM +0200, Avi Kivity wrote: On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like guest enumeration. So the fundamental topic here is, do we introduce

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Anthony Liguori
On 03/23/2010 01:00 PM, Avi Kivity wrote: On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like guest enumeration. So the fundamental topic here is, do we introduce these missing

Re: [libvirt] [Qemu-devel] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Anthony Liguori
On 03/23/2010 12:57 PM, Avi Kivity wrote: On 03/22/2010 09:25 PM, Anthony Liguori wrote: Hi, I've mentioned this to a few folks already but I wanted to start a proper thread. We're struggling in qemu with usability and one area that concerns me is the disparity in features that are

Re: [libvirt] [RFC]: Snapshot API

2010-03-23 Thread Eric Blake
On 03/23/2010 01:23 PM, Chris Lalancette wrote: } virDomainSnapshotDeactivate; int virDomainSnapshotDeactivate(virDomainSnapshotPtr snapshot, unsigned int flags); I'm not sure if virDomainSnapshotDeactivate is a good name. I agree it's not a great name. I

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Jamie Lokier
Anthony Liguori wrote: (like mDNS or SLP). The later mechanism scales better and tends to be more robust. (Aside: mDNS is blocked on some larger networks because it creates too much load. On those networks, an aggregator is essential - or a protocol which scales better (less broadcasting)).

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Jamie Lokier
Juan Quintela wrote: - monitor: I need a way to get to the monitor when going through libvirt, in the past you couldn't allow this, but now it looks possible. Now you can just start another monitor connection to qemu :-) Previously I've used a multiplexing script which accepts multiple

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Jamie Lokier
Anthony Liguori wrote: On 03/23/2010 10:57 AM, Paul Brook wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like guest enumeration. Is that simply enumerating running qemu instances, and asking each one about things like it's

Re: [libvirt] [PATCH] tests: Don't add extra padding if counter mod 40 is 0

2010-03-23 Thread Matthias Bolte
2010/3/22 Daniel P. Berrange berra...@redhat.com: On Mon, Mar 22, 2010 at 09:17:21PM +0100, Matthias Bolte wrote: 2010/3/22 Daniel P. Berrange berra...@redhat.com: On Sat, Mar 20, 2010 at 06:14:44PM +0100, Matthias Bolte wrote: --- átests/test-lib.sh | á 10 ++ átests/testutils.c

Re: [libvirt] [PATCH] vbox: Fix segfault on empty device source

2010-03-23 Thread Matthias Bolte
2010/3/22 Eric Blake ebl...@redhat.com: On 03/22/2010 02:40 PM, Matthias Bolte wrote: source file=''/ results in def-disks[i]-src == NULL. But vboxDomainDefineXML didn't check def-disks[i]-src for NULL and expected it to be a valid string. Add checks for def-disks[i]-src != NULL to fix the

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Anthony Liguori
On 03/23/2010 06:25 PM, Jamie Lokier wrote: Alexander Graf wrote: I don't see why we shouldn't be able to automatically generate libqemu.so. We have the *.hx files that describe the syntax of parameters plus list all available options / commands. I'm not sure how exactly QMP works, but

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Anthony Liguori
On 03/23/2010 01:23 PM, Daniel P. Berrange wrote: On Tue, Mar 23, 2010 at 08:00:21PM +0200, Avi Kivity wrote: On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like

[libvirt] [PATCH] esx: Make the conf parser compare names case insensitive in VMX mode

2010-03-23 Thread Matthias Bolte
The keys of entries in a VMX file are case insensitive. Both scsi0:1.fileName and scsi0:1.filename are valid. Therefore, make the conf parser compare names case insensitive in VMX mode to accept every capitalization variation. Also add test cases for this. --- src/util/conf.c

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Avi Kivity
On 03/23/2010 08:23 PM, Daniel P. Berrange wrote: On Tue, Mar 23, 2010 at 08:00:21PM +0200, Avi Kivity wrote: On 03/23/2010 06:06 PM, Anthony Liguori wrote: I thought the monitor protocol *was* our API. If not, why not? It is. But our API is missing key components like

Re: [libvirt] [Qemu-devel] Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Avi Kivity
On 03/23/2010 09:31 PM, Anthony Liguori wrote: One problem is that this is libvirt version specific. For example, libvirt x doesn't support spice so we control that thorough qmp. But libvirt x+1 does support spice and now it gets confused about all the spice messages. That's only a

Re: [libvirt] [Qemu-devel] Re: Supporting hypervisor specific APIs in libvirt

2010-03-23 Thread Avi Kivity
On 03/23/2010 09:24 PM, Anthony Liguori wrote: We also provide an API for guest creation (the qemu command line). As an aside, I'd like to see all command line options have qmp equivalents (most of them can be implemented with a 'set' command that writes qdev values). This allows a