Eric Blake wrote:
On 03/25/2010 02:56 PM, Jim Meyering wrote:
Thanks for highlighting that.
Our syntax-check rule should have caught it.
With the following change, it does, along with one other:
src/conf/domain_conf.c: if (domain-newDef)
Eric Blake wrote:
On 03/25/2010 02:22 AM, Jim Meyering wrote:
-# Using test's -a operator is not portable.
-sc_prohibit_test_minus_a:
+# Using test's -a and -o operators is not portable.
+sc_prohibit_test_minus_ao:
@re='\test .+ -[a] ' \
Adding to this C wrappers for QMP commands threatens to make QMP command
arguments part of the library ABI. Compatible QMP evolution (like
adding an optional argument) turns into a libqmp soname bump.
Counter-productive. How do you plan to avoid that?
.so versioning. Ugly as hell to do
Hi everyone
i've been trying to migrate a domain from hostA to hostB.But everytime i did
it with
virsh --live migrate Domain xen+ssh://r...@destination,
it failed and told me something like
Error Domain not found:xenUnifiedDomainLookupByName.
The same thing happened when i tried to do the same
On 03/25/2010 12:24 PM, Marco Mornati wrote:
Hello Bryan,
I noticed some days ago that a connection to libvirt from java binding
with SSH url (xen+ssh://...) leave an Ssh shell opened also after
connection is closed.
29218 ?S 0:00 ssh -p 22 -l root -T -o BatchMode=yes -e none
On Thu, 25 Mar 2010 08:55:42 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
On 03/25/2010 08:23 AM, Luiz Capitulino wrote:
On Wed, 24 Mar 2010 16:40:18 -0500
Anthony Liguorianth...@codemonkey.ws wrote:
We need to have a common management interface for third party tools.
I understand. Thanks for your explanation!
- satoru
On Thu, Mar 25, 2010 at 05:35:20PM +, Daniel P. Berrange wrote:
On Fri, Mar 26, 2010 at 02:25:18AM +0900, Satoru SATOH wrote:
Libvirtd enabls DHCP service on virtual networks even if the element
'//ip/dhcp' does not exist in the
On 03/26/2010 04:51 AM, Avi Kivity wrote:
On 03/26/2010 10:37 AM, Markus Armbruster wrote:
The importances of libqemu is:
1) Providing a common QMP transport implementation that is extensible
by third parties
2) Providing a set of common transports that support automatic
discovery of command
Hello,
While using multiple disk devices with different bus types (ide and virtio)
I noticed that the order of disks is handled in a special way.
The disk device which was defined as the first item will not be the first
entry in the system xml file.
e.g. if I define a virtio device (which is
Useful mainly for migration. cpuUpdate changes guest CPU requirements in
the following way:
- match == strict || match == exact
- optional features which are supported by host CPU are changed into
required features
- optional features which are not supported by host CPU are disabled
Jiri Denemark (3):
cpuUpdate() for updating guest CPU according to host CPU
Helper function for making a deep-copy of virCPUDefPtr
Introduce UPDATE_CPU flag for virDomainGetXMLDesc
include/libvirt/libvirt.h.in |5 +-
src/conf/cpu_conf.c | 37 ++
src/conf/cpu_conf.h
This flag is used in migration prepare step to send updated XML
definition of a guest.
Also ``virsh dumpxml --update-cpu [--inactive] guest'' command can be
used to see the updated CPU requirements.
---
include/libvirt/libvirt.h.in |5 ++-
src/libvirt.c|3 +-
---
src/conf/cpu_conf.c | 37 +
src/conf/cpu_conf.h |3 +++
src/libvirt_private.syms |1 +
3 files changed, 41 insertions(+), 0 deletions(-)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 612e376..cf91930 100644
---
On 03/26/2010 02:37 AM, Markus Armbruster wrote:
Adding to this C wrappers for QMP commands threatens to make QMP command
arguments part of the library ABI. Compatible QMP evolution (like
adding an optional argument) turns into a libqmp soname bump.
Counter-productive. How do you plan to avoid
As discussed previously this implement hook scripts which
may be called from libvirtd at specific times.
The script are supposed to be small, execute fast as it's synchronous,
their exit value is 0 otherwise it's considered a failure (which may
be ignored but in general will stops the ongoing
On Thu, Mar 25, 2010 at 05:27:16PM +, Daniel P. Berrange wrote:
The QEMU cpu affinity is used in NUMA scenarios to ensure that
guest memory is allocated from a specific node. Normally memory
is allocate on demand in vCPU threads, but when using hugepages
the initial thread leader allocates
Export virPipeReadUntilEOF internally
used to read the data from virExec stdout/err file descriptors
* src/util/util.c src/util/util.h: not static anymore and export it
* src/libvirt_private.syms: allow access internally
diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index
Add hook utilities
This exports 3 basic routines:
- virHookInitialize() initializing the hook support by looking for
scripts availability
- virHookPresent() used to test if there is a hook for a given driver
- virHookCall() which actually calls a synchronous script hook with
the
Add the script hook support to the libvirt daemon
It supports 3 kind of probing times, at daemon startup, when the
daemon reloads its drivers on SIGHUP and when the daemon exits
* daemon/libvirtd.c: daemon hooks for startup, reload and exit
diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
Add an error module and message for the hooks subsystem
* include/libvirt/virterror.h: add VIR_FROM_HOOK and VIR_ERR_HOOK_SCRIPT_FAILED
* src/util/virterror.c: associated strings
diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
index d298447..b35ea6c 100644
---
Add script hook support to the QEmu driver
Right now this implements only 2 basic hooks:
- before the qemu process is being launched
- after the qemu process is terminated
the XML description of the domain is passed to the hook script stdin
/etc/libvirt/hook/qemu
* src/qemu/qemu_driver.c:
Add script hook support to the LXC driver
Right now this implements only 2 basic hooks:
- before the lxc control process is being launched
- after the lxc control process is terminated
the XML description of the domain is passed to the hook script stdin
/etc/libvirt/hook/lxc
*
On 03/26/2010 07:11 AM, Jiri Denemark wrote:
Useful mainly for migration. cpuUpdate changes guest CPU requirements in
the following way:
- match == strict || match == exact
- optional features which are supported by host CPU are changed into
required features
- optional
On 03/26/2010 07:11 AM, Jiri Denemark wrote:
+virCPUDefPtr
+virCPUDefCopy(const virCPUDefPtr cpu);
ACK.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
On Thu, Mar 25, 2010 at 02:45:17PM -0400, Stefan Berger wrote:
In the web documentation mention that the direct device support is there
since libvirt 0.7.7. A Linux kernel 2.6.34 is required for macvtap to be
available as standard device.
Okay, pushed, thanks !
note that this documentation
Here's a revised patch for disk error policy XML incorporating the feedback
from Dan and Daniel.
Dave
David Allan (1):
Add disk error policy to domain XML
docs/schemas/domain.rng| 12 +++-
src/conf/domain_conf.c | 18
* Fixes per feedback from Dan and Daniel
* Added test datafiles
* Re-disabled JSON flags
* Added code to print the error policy attribute when generating XML
---
docs/schemas/domain.rng| 12 +++-
src/conf/domain_conf.c | 18
On Thu, Mar 25, 2010 at 02:50:50PM -0400, Stefan Berger wrote:
To find out where the net type 'direct' needs to be handled I introduced
the 'enum virDomainNetType' in the virDomainNetDef structure and let the
compiler tell me where the case statement is missing. Then I added the
unhandled
On Fri, Mar 26, 2010 at 02:11:34PM +0100, Jiri Denemark wrote:
Useful mainly for migration. cpuUpdate changes guest CPU requirements in
the following way:
- match == strict || match == exact
- optional features which are supported by host CPU are changed into
required features
On 03/26/2010 07:11 AM, Jiri Denemark wrote:
This flag is used in migration prepare step to send updated XML
definition of a guest.
Also ``virsh dumpxml --update-cpu [--inactive] guest'' command can be
used to see the updated CPU requirements.
+++ b/tools/virsh.c
@@ -2504,6 +2504,7 @@
On 03/26/2010 09:41 AM, Daniel Veillard wrote:
Export virPipeReadUntilEOF internally
used to read the data from virExec stdout/err file descriptors
* src/util/util.c src/util/util.h: not static anymore and export it
* src/libvirt_private.syms: allow access internally
ACK. Minor nit,
On Fri, Mar 26, 2010 at 02:11:36PM +0100, Jiri Denemark wrote:
This flag is used in migration prepare step to send updated XML
definition of a guest.
Also ``virsh dumpxml --update-cpu [--inactive] guest'' command can be
used to see the updated CPU requirements.
---
On 03/26/2010 09:42 AM, Daniel Veillard wrote:
@@ -1117,6 +1120,11 @@ virErrorMsg(virErrorNumber error, const char *info)
errmsg = _(Failed to make domain persistent after
migration);
else
errmsg = _(Failed to make domain persistent after
On Fri, Mar 26, 2010 at 02:11:35PM +0100, Jiri Denemark wrote:
---
src/conf/cpu_conf.c | 37 +
src/conf/cpu_conf.h |3 +++
src/libvirt_private.syms |1 +
3 files changed, 41 insertions(+), 0 deletions(-)
diff --git
On Fri, Mar 26, 2010 at 10:09:53AM -0600, Eric Blake wrote:
On 03/26/2010 09:41 AM, Daniel Veillard wrote:
Export virPipeReadUntilEOF internally
used to read the data from virExec stdout/err file descriptors
* src/util/util.c src/util/util.h: not static anymore and export it
*
On Fri, Mar 26, 2010 at 10:16:37AM -0600, Eric Blake wrote:
On 03/26/2010 09:42 AM, Daniel Veillard wrote:
@@ -1117,6 +1120,11 @@ virErrorMsg(virErrorNumber error, const char *info)
errmsg = _(Failed to make domain persistent after
migration);
else
On Fri, Mar 26, 2010 at 05:42:22PM +0100, Daniel Veillard wrote:
On Fri, Mar 26, 2010 at 10:16:37AM -0600, Eric Blake wrote:
On 03/26/2010 09:42 AM, Daniel Veillard wrote:
@@ -1117,6 +1120,11 @@ virErrorMsg(virErrorNumber error, const char *info)
errmsg = _(Failed to make
On 03/26/2010 09:43 AM, Daniel Veillard wrote:
+if (stat(path, sb) 0) {
+ret = 0;
+VIR_DEBUG(No hook script %s, path);
+} else {
+if (access(path, X_OK) != 0) {
Should we also check for !S_ISDIR(sb.st_mode), so that we explicitly
reject directories here,
On 03/26/2010 09:44 AM, Daniel Veillard wrote:
+/* setup the hooks */
+virHookInitialize();
Shouldn't this check for a return of -1?
+
/* Disable error func, now logging is setup */
virSetErrorFunc(NULL, virshErrorHandler);
+/*
+ * Call the daemon startup
typedef enum {
-VIR_DOMAIN_XML_SECURE = 1, /* dump security sensitive information too
*/
-VIR_DOMAIN_XML_INACTIVE = 2/* dump inactive domain information */
+VIR_DOMAIN_XML_SECURE = (1 0), /* dump security sensitive
information too */
+VIR_DOMAIN_XML_INACTIVE
On Fri, Mar 26, 2010 at 10:53:01AM -0600, Eric Blake wrote:
On 03/26/2010 09:43 AM, Daniel Veillard wrote:
+ */
+if ((virHooksFound == -1) ||
+((driver == VIR_HOOK_DRIVER_DAEMON)
+ (op == VIR_HOOK_DAEMON_OP_RELOAD)))
+virHookInitialize();
+
...
+
On 03/26/2010 09:45 AM, Daniel Veillard wrote:
+/* now that we know it is about to start call the hook if present */
+if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) {
+char *xml = virDomainDefFormat(vm-def, 0);
+int hookret;
+
+hookret =
On Thu, Mar 25, 2010 at 01:46:11PM -0400, Stefan Berger wrote:
This patch adds IPv6 support for the ebtables layer. Since the parser
etc. are all parameterized, it was fairly easy to add this...
Signed-off-by: Stefan Berger stef...@us.ibm.com
[...]
+static bool
On 03/26/2010 11:09 AM, Daniel P. Berrange wrote:
Duplicating the definition of all these helpers is a bit of a long
distraction in the middle of this function; is it worth a helper file,
where we could #include command_line_builder.h to get all these
helpers defined, and to reduce the
On 03/26/2010 09:46 AM, Daniel Veillard wrote:
Add script hook support to the LXC driver
Right now this implements only 2 basic hooks:
- before the lxc control process is being launched
- after the lxc control process is terminated
the XML description of the domain is passed to the hook
I pushed this trivial patch to fix a build break earlier today.
Dave
From 67253251c576cf29edd7f45354c4e6664b8f5178 Mon Sep 17 00:00:00 2001
From: David Allan dal...@redhat.com
Date: Fri, 26 Mar 2010 13:05:19 -0400
Subject: [PATCH 1/1] Fix build break
* Add types to switch; the switch is only
Daniel Veillard veill...@redhat.com wrote on 03/26/2010 01:10:14 PM:
it seems that code was really coded without looking at util/network.h
first.
I don't think it's a blocker but I would like to see this reunified,
unless network.h routines really prove unusable (but maybe we should
On Fri, Mar 26, 2010 at 01:43:44PM -0400, Dave Allan wrote:
I pushed this trivial patch to fix a build break earlier today.
Yeah, I didn't see it because I hadn't xen development on that
test box,
thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit
On Thu, Mar 25, 2010 at 01:45:58PM -0400, Stefan Berger wrote:
Hi!
This is a repost of this set of patches with some of the suggested fixes
applied and ipv6 support on the ebtables layer added.
Between V3 and V4 of this patch series the following changes were made:
- occurrences of typo
Eric Blake wrote:
Picks up fixes for gethostname compilation problems on mingw.
* .gnulib: Update to latest.
* build-aux/.gitignore: Regenerate.
* cfg.mk (local-checks-to-skip): Avoid new test not relevent to
libvirt.
This looks fine and passes tests on F12 and rawhide.
I'm about to push
Eric Blake wrote:
My prior patch forced an autogen.sh run, and I was surprised that the
suggested './autogen.sh' lost the fact that I had previously used
'./autogen.sh -C' for speed.
* autogen.sh: Use config.status, if present and there were no arguments.
Thanks.
This looks fine, too.
I
This extension is described in
http://www.redhat.com/archives/libvir-list/2010-March/msg00304.html
Currently all attributes are optional, except name.
* src/conf/domain_conf.h: add data definition for virDomainTimerDef
and add a list of them to virDomainClockDef
*
* src/qemu/qemu_conf.h: define 4 new flags
* src/qemu/qemu_conf.c: check the help text of qemu for presence of
features indicated by each flag.
* tests/qemuhelptest.c: add appropriate flags into the masks for each test
---
src/qemu/qemu_conf.c | 10 ++
This patchset implements the XML described in
http://www.redhat.com/archives/libvir-list/2010-March/msg00304.html
(with one small change - the tickpolicy 'none' was changed to 'delay'
after a later discussion).
It also implements the qemu backend for those timer types that qemu supports.
One
Since the timers are defined to cover all possible config cases for
several different hypervisors, many of these possibilities generate an
error on qemu. Here is what is currently supported:
RTC: If the -rtc commandline option is available, allow setting clock=host
or clock=vm based on the
timers are sub-elements of clocks. A clock can have zero or more
instances of timer. Within the timer, only the name attribute is
required; all other attributes are optional.
A simpler representation of a timer element is:
timer name='platform|pit|rtc|hpet|tsc'
wallclock='host|guest'
FYI, just pushed (no semantic change):
From d0e79bd5fa280a568d5b919fabd5f2f4dacf8f89 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 26 Mar 2010 19:29:54 +0100
Subject: [PATCH] filter new files through cppi, so syntax-check passes once
again
*
Daniel P. Berrange berra...@redhat.com wrote on 03/26/2010 02:04:26
PM:
Please respond to Daniel P. Berrange
On Thu, Mar 25, 2010 at 01:45:58PM -0400, Stefan Berger wrote:
Hi!
This is a repost of this set of patches with some of the suggested
fixes
applied and ipv6 support on
This patch removes the driver dependency from nwfilter_conf.c and moves
a callback function calling into the driver into
nwfilter_gentech_driver.c and passes a pointer to that callback function
upon initialization of nwfilter_conf.c.
Signed-off-by: Stefan Berger stef...@us.ibm.com
Index:
The first one of the following two patches adds support for filtering
of ah, esp and udplite protocols. The 2nd one adds support for filtering
of IPv6 traffic. With this now nearly all protocols of IPv4 and IPv6
(except mh) as supported by iptables/ip6tables are reachable via the
filtering XML.
This patch adds filtering support for the so-far missing protocols 'ah',
'esp' and 'udplite'.
Signed-off-by: Stefan Berger stef...@us.ibm.com
Index: libvirt-acl/src/conf/nwfilter_conf.c
===
---
This patch adds IPv6 filtering support for the following protocols:
- tcp-ipv6
- udp-ipv6
- udplite-ipv6
- esp-ipv6
- ah-ipv6
- sctp-ipv6
- all-ipv6
- icmpv6
Many of the IPv4 data structure could be re-used for IPv6 support.
Since ip6tables also supports pretty much the same command line
On Fri, Mar 26, 2010 at 02:41:30PM -0400, Stefan Berger wrote:
Daniel P. Berrange berra...@redhat.com wrote on 03/26/2010 02:04:26
PM:
Please respond to Daniel P. Berrange
On Thu, Mar 25, 2010 at 01:45:58PM -0400, Stefan Berger wrote:
Hi!
This is a repost of this set of
On 03/26/2010 12:36 PM, Daniel Veillard wrote:
On Fri, Mar 26, 2010 at 12:02:36PM -0400, David Allan wrote:
* Fixes per feedback from Dan and Daniel
* Added test datafiles
* Re-disabled JSON flags
* Added code to print the error policy attribute when generating XML
---
docs/schemas/domain.rng
FYI, just pushed (no semantic change):
From d0e79bd5fa280a568d5b919fabd5f2f4dacf8f89 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Fri, 26 Mar 2010 19:29:54 +0100
Subject: [PATCH] filter new files through cppi, so syntax-check passes once
again
*
Jiri Denemark (3):
cpuUpdate() for updating guest CPU according to host CPU
Helper function for making a deep-copy of virCPUDefPtr
Introduce UPDATE_CPU flag for virDomainGetXMLDesc
I fixed the typo in commit message in 1/3 and pushed these patches. The
documentation patch for virsh.pod
ACK.
virDomainObjPtr virDomainAssignDef(virCapsPtr caps,
...
} else {
-if (domain-newDef)
-virDomainDefFree(domain-newDef);
+virDomainDefFree(domain-newDef);
And nice removal of useless-if-before-free.
Thanks, I rebased the
Automate the reuse of autogen.sh, rather than just erroring out.
* cfg.mk (_update_required): Run autogen.sh, rather than just
warning about it.
(_autogen): New target.
---
Hmm, as long as make is smart enough to warn, and now that running
./autogen.sh with no arguments is reliable at
68 matches
Mail list logo
