Re: [libvirt] virsh setmaxmem

On Mon, Mar 29, 2010 at 04:33:32PM -0600, Eric Blake wrote: On 03/11/2010 08:46 AM, Daniel Veillard wrote: On Wed, Mar 10, 2010 at 03:33:55PM -0500, Chris Lalancette wrote: [revisiting something still flagged in my inbox] All, My recent patch to remove qemudDomainSetMaxMem()

Re: [libvirt] [PATCH 0/4] Add timer element to domain clock elements

On Fri, Mar 26, 2010 at 02:21:36PM -0400, Laine Stump wrote: This patchset implements the XML described in http://www.redhat.com/archives/libvir-list/2010-March/msg00304.html (with one small change - the tickpolicy 'none' was changed to 'delay' after a later discussion). It also

Re: [libvirt] virsh setmaxmem

On 03/30/2010 05:58 AM, Daniel Veillard wrote: On Mon, Mar 29, 2010 at 04:33:32PM -0600, Eric Blake wrote: On 03/11/2010 08:46 AM, Daniel Veillard wrote: On Wed, Mar 10, 2010 at 03:33:55PM -0500, Chris Lalancette wrote: [revisiting something still flagged in my inbox] All, My recent

Re: [libvirt] [PATCH] [0/6] implement synchronous hook scripts

On Mon, Mar 29, 2010 at 06:28:02PM +0200, Daniel Veillard wrote: On Fri, Mar 26, 2010 at 04:32:41PM +0100, Daniel Veillard wrote: The script are supposed to be small, execute fast as it's synchronous, their exit value is 0 otherwise it's considered a failure (which may be ignored but in

Re: [libvirt] [PATCH v1 1/2] Add support for so-far missing protocols for iptables filtering

On Fri, Mar 26, 2010 at 04:41:18PM -0400, Stefan Berger wrote: This patch adds filtering support for the so-far missing protocols 'ah', 'esp' and 'udplite'. Signed-off-by: Stefan Berger stef...@us.ibm.com ACK, looks fine to me, Daniel -- Daniel Veillard | libxml Gnome XML XSLT

Re: [libvirt] [PATCH v1 2/2] Add ip6tables support for IPv6 filtering

On Fri, Mar 26, 2010 at 04:41:19PM -0400, Stefan Berger wrote: This patch adds IPv6 filtering support for the following protocols: - tcp-ipv6 - udp-ipv6 - udplite-ipv6 - esp-ipv6 - ah-ipv6 - sctp-ipv6 - all-ipv6 - icmpv6 Many of the IPv4 data structure could be re-used for IPv6

Re: [libvirt] process= support for 'qemu-kvm -name' [Bug 576950]

On Sun, Mar 28, 2010 at 10:19:51PM -0400, John Morrissey wrote: I wrote (attached here, and to the bug) a quick patch that sets the process name to the same value as the window title. I'm unsure where to go from here. Should I add support for converting native QEMU command lines to libvirt

Re: [libvirt] [PATCH] Remove driver dependency from nwfilter_conf.c

On Fri, Mar 26, 2010 at 03:29:48PM -0400, Stefan Berger wrote: This patch removes the driver dependency from nwfilter_conf.c and moves a callback function calling into the driver into nwfilter_gentech_driver.c and passes a pointer to that callback function upon initialization of

[libvirt] [PATCH] Use libvirt's existing ipv6/ipv4 parser/printer rather than self-written ones

This patch changes the network filtering code to use libvirt's existing IPv4 and IPv6 address parsers/printers rather than my self-written ones. I am introducing a new function in network.c that counts the number of bits in a netmask and ensures that the given address is indeed a netmask, return

[libvirt] possible bug in virConnectGetLibVersion()

I need to get libvirt version. Using function virConnecGetLibVersion(), I've return message like    errore: unknown error My system settings are:    Kernel: 2.6.33    Hypervisor: QEMU 0.12.3    Libvirt: 0.7.6 (cloned from git) The code that fails is in src/libvirt.c:1656    

Re: [libvirt] issues about Migrating with virsh and libvirt functions

Please refer this guide: virsh migrate --live RHEL4test qemu+ssh://test2.bne.redhat.com/system http://www.redhat.com/docs/en-US/Red_Hat_Enterprise_Linux/5.4/html/Virtualization_Guide/sect-Virtualization-KVM_live_migration-Live_KVM_migration_with_virsh.html 2010/3/26 wei ma wei.ma1...@gmail.com:

Re: [libvirt] [PATCH v1 2/2] Add ip6tables support for IPv6 filtering

Daniel Veillard veill...@redhat.com wrote on 03/30/2010 10:02:09 AM: Please respond to veillard On Fri, Mar 26, 2010 at 04:41:19PM -0400, Stefan Berger wrote: This patch adds IPv6 filtering support for the following protocols: - tcp-ipv6 - udp-ipv6 - udplite-ipv6 - esp-ipv6 -

Re: [libvirt] [PATCH] Add dummy nwfilter driver to test driver

2010/3/29 Stefan Berger stef...@us.ibm.com: This patch adds a dummy nwfilter driver to the test driver so that the int-overflow test passes without modifications. Signed-off-by: Stefan Berger stef...@us.ibm.com Index: libvirt/src/test/test_driver.c

Re: [libvirt] [PATCH] Use libvirt's existing ipv6/ipv4 parser/printer rather than self-written ones

On Tue, Mar 30, 2010 at 10:50:20AM -0400, Stefan Berger wrote: This patch changes the network filtering code to use libvirt's existing IPv4 and IPv6 address parsers/printers rather than my self-written ones. I am introducing a new function in network.c that counts the number of bits in a

Re: [libvirt] [PATCH] Add dummy nwfilter driver to test driver

On Tue, Mar 30, 2010 at 04:02:53PM +0100, Matthias Bolte wrote: 2010/3/29 Stefan Berger stef...@us.ibm.com: This patch adds a dummy nwfilter driver to the test driver so that the int-overflow test passes without modifications. Signed-off-by: Stefan Berger stef...@us.ibm.com Index:

Re: [libvirt] [PATCH] Add dummy nwfilter driver to test driver

Matthias Bolte matthias.bo...@googlemail.com wrote on 03/30/2010 11:02:53 AM: 2010/3/29 Stefan Berger stef...@us.ibm.com: This patch adds a dummy nwfilter driver to the test driver so that the int-overflow test passes without modifications. Signed-off-by: Stefan Berger

[libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable

A cosmetic change that makes the entries in the int-2-string maps look more readable. Add some missing entries. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/conf/nwfilter_conf.c | 97 +-- 1 file changed, 28 insertions(+), 69 deletions(-)

Re: [libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable

On 03/30/2010 09:26 AM, Stefan Berger wrote: A cosmetic change that makes the entries in the int-2-string maps look more readable. That's for sure :) Add some missing entries. Is it worth mentioning which ones in the commit message? Other than that, ACK. #endif -} , { -.val

Re: [libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable

Eric Blake ebl...@redhat.com wrote on 03/30/2010 11:34:41 AM: On 03/30/2010 09:26 AM, Stefan Berger wrote: A cosmetic change that makes the entries in the int-2-string maps look more readable. That's for sure :) Add some missing entries. Is it worth mentioning which ones in the

Re: [libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable

On Tue, Mar 30, 2010 at 11:26:47AM -0400, Stefan Berger wrote: A cosmetic change that makes the entries in the int-2-string maps look more readable. Add some missing entries. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/conf/nwfilter_conf.c | 97

Re: [libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable

On Tue, Mar 30, 2010 at 11:26:47AM -0400, Stefan Berger wrote: A cosmetic change that makes the entries in the int-2-string maps look more readable. Add some missing entries. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/conf/nwfilter_conf.c | 97

[libvirt] [PATCH 00/10] Begin to replace scanf and atoi

This set of patches is a first step towards removing the scanf and atoi usage in libvirt. I began with the simple cases and post this now to get some feedback before I start to convert the more difficult ones. 01/10 Replace sscanf in legacy device address parsing 02/10 Replace sscanf in

[libvirt] [PATCH 03/10] Refactor major.minor.micro version parsing into a function

virParseVersionString uses virStrToLong_ui instead of sscanf. This also fixes a bug in the UML driver, that always returned 0 as version number. --- src/esx/esx_driver.c | 31 ++- src/libvirt_private.syms |1 + src/lxc/lxc_driver.c | 10

[libvirt] [PATCH 04/10] cgroup: Replace sscanf with virStrToLong_ll

--- src/util/cgroup.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/util/cgroup.c b/src/util/cgroup.c index 496d9d3..4cb09b6 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -12,7 +12,6 @@ #include stdio.h #include stdint.h -#include inttypes.h

[libvirt] [PATCH 01/10] Replace sscanf in legacy device address parsing

--- src/conf/domain_conf.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 66aa53e..9a517ca 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1290,6 +1290,26 @@

[libvirt] [PATCH 06/10] xen: Use virParseMacAddr instead of sscanf

--- src/xen/xend_internal.c | 18 ++ src/xen/xm_internal.c | 19 +-- 2 files changed, 7 insertions(+), 30 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 46e19cd..0649d23 100644 --- a/src/xen/xend_internal.c +++

[libvirt] [PATCH 02/10] Replace sscanf in nwfilter rule parsing

--- src/conf/nwfilter_conf.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 668918d..24b79a7 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -1226,7 +1226,7 @@

[libvirt] [PATCH 05/10] vbox: Replace atoi with virStrToLong_i

--- src/vbox/vbox_tmpl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 05b075f..07996d4 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -598,7 +598,9 @@ static int PRUnicharToInt(PRUnichar *strUtf16) {

[libvirt] [PATCH 08/10] xenapi: Use virStrToLong_i instead of sscanf for CPU map parsing

--- src/xenapi/xenapi_utils.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/xenapi/xenapi_utils.c b/src/xenapi/xenapi_utils.c index 697ad39..790eebf 100644 --- a/src/xenapi/xenapi_utils.c +++ b/src/xenapi/xenapi_utils.c @@ -309,7 +309,8 @@

[libvirt] [PATCH 09/10] xen: Use virStrToLong_i instead of sscanf for XenD port parsing

--- src/xen/xend_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index 0649d23..c910439 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -4683,7 +4683,7 @@ xenDaemonDomainMigratePerform

[libvirt] [PATCH 10/10] Replace sscanf in PCI device address parsing

This also fixes a problem with MinGW's GCC on Windows. GCC complained bout the L modifier being unknown. --- src/util/pci.c | 59 +++ 1 files changed, 46 insertions(+), 13 deletions(-) diff --git a/src/util/pci.c b/src/util/pci.c index

Re: [libvirt] [PATCH 13/15] util: Replace pciWaitForDeviceCleanup with a stub on Windows

2010/3/22 Daniel P. Berrange berra...@redhat.com: On Mon, Mar 22, 2010 at 10:54:09AM -0600, Eric Blake wrote: On 03/22/2010 09:03 AM, Daniel P. Berrange wrote: On Mon, Mar 22, 2010 at 02:25:43AM +0100, Matthias Bolte wrote: sscanf doesn't support the L modifier on Windows and gnulib has no

Re: [libvirt] [PATCH] maint: show which compiler warning triggered

Eric Blake wrote: * acinclude.m4 (LIBVIRT_COMPILE_WARNINGS): Add -fdiagnostics-show-option. --- Here's an example of how things change, when using './configure --enable-compiler-warnings=error' and introducing something gcc would warn about: CC

Re: [libvirt] [PATCH 02/10] Replace sscanf in nwfilter rule parsing

Matthias Bolte wrote: src/conf/nwfilter_conf.c | 10 +- Hi Matthias, It's great that you're removing all of these sscanf uses. I suppose the plan includes eventually enabling the syntax-check that prohibits them altogether. diff --git a/src/conf/nwfilter_conf.c

Re: [libvirt] [PATCH 01/10] Replace sscanf in legacy device address parsing

On 03/30/2010 10:20 AM, Matthias Bolte wrote: +static int +virDomainParseLegacyDeviceAddress(char *devaddr, + virDomainDevicePCIAddressPtr pci) +{ +char *tmp = devaddr + strspn(devaddr, \t\r\n); Why skip leading whitespace yourself... + +/*

Re: [libvirt] [PATCH 3/2] build: automate the rerun of autogen.sh

Eric Blake wrote: Automate the reuse of autogen.sh, rather than just erroring out. * cfg.mk (_update_required): Run autogen.sh, rather than just warning about it. (_autogen): New target. --- Hmm, as long as make is smart enough to warn, and now that running ./autogen.sh with no

Re: [libvirt] [PATCH 3/2] build: automate the rerun of autogen.sh

On 03/30/2010 11:25 AM, Jim Meyering wrote: Eric Blake wrote: Automate the reuse of autogen.sh, rather than just erroring out. ... -$(error gnulib update required; run ./autogen.sh first) +$(info INFO: gnulib update required; running ./autogen.sh first) +Makefile: _autogen endif

Re: [libvirt] [PATCH 01/10] Replace sscanf in legacy device address parsing

2010/3/30 Eric Blake ebl...@redhat.com: On 03/30/2010 10:20 AM, Matthias Bolte wrote: +static int +virDomainParseLegacyDeviceAddress(char *devaddr, +                                  virDomainDevicePCIAddressPtr pci) +{ +    char *tmp = devaddr + strspn(devaddr, \t\r\n); Why skip leading

Re: [libvirt] ESX snapshot deletion

On 03/29/2010 07:25 PM, Matthias Bolte wrote: 2010/3/29 Chris Lalancette clala...@redhat.com: Hey Mattias, I'm currently working on the semantics of virDomainSnapshotDelete(), which has been renamed from the earlier virDomainSnapshotDeactivate(). In qemu/kvm, it seems like it is

Re: [libvirt] [PATCH 02/10] Replace sscanf in nwfilter rule parsing

2010/3/30 Jim Meyering j...@meyering.net: Matthias Bolte wrote:  src/conf/nwfilter_conf.c |   10 +- Hi Matthias, It's great that you're removing all of these sscanf uses. I suppose the plan includes eventually enabling the syntax-check that prohibits them altogether. Yes, once

[libvirt] CfP with Extended Deadline 5th Workshop on Virtualization in High-Performance Cloud Computing (VHPC'10)

Apologies if you received multiple copies of this message. = CALL FOR PAPERS 5th Workshop on Virtualization in High-Performance Cloud Computing VHPC'10 as part of Euro-Par 2010, Island of Ischia-Naples, Italy

[libvirt] [RFC]: Snapshot API v3

Hello, After our discussions about the snapshot API last week, I went ahead and implemented quite a bit of the API. I also went back to the ESX, Virtualbox, and QEMU API's to try and make sure our API's matched up. What's below is my revised API based on that survey. Following my revised

[libvirt] [PATCH] virsh: add 'exit' as an alias for 'quit'

Call me lazy: some shells use exit (e.g. sh), others use quit (e.g. ftp), but I never remember which. So it's faster to write a patch to make virsh take both than it is to take a 50-50 guess, and get it wrong in half of my attempts. * tools/virsh.c (commands): Add 'exit'. * tools/virsh.pod:

[libvirt] [PATCH] nwfilter: fix some make dist/built/rpm issues

Here is a couple of patches related to make dist, then build from resulting tarball and rpm building. The first one adds a few missing header files in the associated file variables, it's needed otherwise the missing headers would break compilation from a distribution tarball The second one

[libvirt] [PATCH] maint: remove redundant tests after virStrToLong

virStrToLong* guarantees (via strtol) that the end pointer will be set to the point at which parsing stopped (even on failure, this point is the start of the input string). * src/esx/esx_driver.c (esxGetVersion): Remove pointless conditional. * src/qemu/qemu_conf.c (qemuParseCommandLinePCI)

[libvirt] [TCK PATCH] maint: use correct Red Hat copyright

* scripts/domain/050-transient-lifecycle.t: Correct the copyright line. * scripts/domain/051-transient-autostart.t: Likewise. * scripts/domain/060-persistent-lifecycle.t: Likewise. * scripts/domain/061-persistent-autostart.t: Likewise. * scripts/domain/065-persistent-redefine.t: Likewise. *

[libvirt] [PATCH] Fix error in nwfilter test driver

Trivial fix for the cp error in the nwfilter test driver. Signed-off-by: Stefan Berger stef...@us.ibm.com Index: libvirt-acl/src/test/test_driver.c === --- libvirt-acl.orig/src/test/test_driver.c +++

Re: [libvirt] [RFC]: Snapshot API v3

2010/3/30 Jiri Denemark jdene...@redhat.com: Hi. ... /* NOTE: struct _virDomainSnapshot is a private structure, ala  * struct _virDomain.  */ typedef struct _virDomainSnapshot virDomainSnapshot; /* Take a snapshot of the current VM state.  Throws an error if  * the VM is not currently

Re: [libvirt] [PATCH] Fix error in nwfilter test driver

On 03/30/2010 02:52 PM, Stefan Berger wrote: Trivial fix for the cp error in the nwfilter test driver. Signed-off-by: Stefan Berger stef...@us.ibm.com Index: libvirt-acl/src/test/test_driver.c === ---

Re: [libvirt] [RFC]: Snapshot API v3

On 03/30/2010 02:52 PM, Matthias Bolte wrote: 2010/3/30 Jiri Denemark jdene...@redhat.com: Hi. ... /* NOTE: struct _virDomainSnapshot is a private structure, ala * struct _virDomain. */ typedef struct _virDomainSnapshot virDomainSnapshot; /* Take a snapshot of the current VM state.

[libvirt] [PATCH 1/1] Initial POC of port profile id support

--- docs/schemas/domain.rng |8 src/conf/domain_conf.c | 12 src/conf/domain_conf.h |1 + src/libvirt_private.syms |3 +++ src/qemu/qemu_conf.c | 12 src/util/macvtap.c | 13 + src/util/macvtap.h |4 7

[libvirt] [PATCH 0/1] port profile id

The following proof of concept patch attempts to show how we might support the use of port profile IDs. The ID would be associated with an interface on a VM and provided to the network infrastructure at VM start time. Since the interfaces by which the id can be provided are still in flux, the

Re: [libvirt] [PATCH] nwfilter: Make entries in a int-2-string map more readable

On 03/30/2010 09:55 AM, Daniel P. Berrange wrote: +INTMAP_ENTRY(ETHERTYPE_ARP , arp), +INTMAP_ENTRY(ETHERTYPE_IP , ipv4), +INTMAP_ENTRY(ETHERTYPE_IPV6, ipv6), +INTMAP_ENTRY_LAST }; This should all really be replaced with a standard call to VIR_ENUM_DECL + VIR_ENUM_IMPL

[libvirt] [PATCH] virConnectGetLibVersion: Avoid error message on success.

From: Paolo Smiraglia paolo.smirag...@gmail.com * src/libvirt.c (virConnectGetLibVersion): Don't emit error on success. --- Paolo, thanks for the report; I've rewritten it in patch form, with a slight modification. I think it is correct, but would like to hear feedback from someone more

Re: [libvirt] [PATCH 02/10] Replace sscanf in nwfilter rule parsing

libvir-list-boun...@redhat.com wrote on 03/30/2010 12:20:26 PM: --- src/conf/nwfilter_conf.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 668918d..24b79a7 100644 --- a/src/conf/nwfilter_conf.c

Re: [libvirt] [RFC]: Snapshot API v3

On 03/30/2010 04:40 PM, Jiri Denemark wrote: Hi. ... /* NOTE: struct _virDomainSnapshot is a private structure, ala * struct _virDomain. */ typedef struct _virDomainSnapshot virDomainSnapshot; /* Take a snapshot of the current VM state. Throws an error if * the VM is not currently

Re: [libvirt] [PATCH 05/10] vbox: Replace atoi with virStrToLong_i

On 03/30/2010 10:20 AM, Matthias Bolte wrote: --- src/vbox/vbox_tmpl.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 05b075f..07996d4 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -598,7

Re: [libvirt] [PATCH 03/10] Refactor major.minor.micro version parsing into a function

On 03/30/2010 10:20 AM, Matthias Bolte wrote: +/** + * virParseVersionString: + * @str: const char pointer to the version string + * @version: unsigned long pointer to output the version number + * + * Parse an unsigned version number from a version string. Expecting + * 'major.minor.micro'

Re: [libvirt] [PATCH 04/10] cgroup: Replace sscanf with virStrToLong_ll

On 03/30/2010 10:20 AM, Matthias Bolte wrote: -if (sscanf(strval, % SCNi64, value) != 1) +if (virStrToLong_ll(strval, NULL, 10, value) 0) Oops. You effectively changed from %lli to %lld, which means the string now has to be decimal, instead of octal or hex. Did you mean to pass 0 as

Re: [libvirt] [RFC]: Snapshot API v3

On 03/30/2010 05:26 PM, Eric Blake wrote: On 03/30/2010 02:52 PM, Matthias Bolte wrote: 2010/3/30 Jiri Denemark jdene...@redhat.com: Hi. ... /* NOTE: struct _virDomainSnapshot is a private structure, ala * struct _virDomain. */ typedef struct _virDomainSnapshot virDomainSnapshot; /*

Re: [libvirt] [RFC]: Snapshot API v3

2010/3/30 Chris Lalancette clala...@redhat.com: Hello,     After our discussions about the snapshot API last week, I went ahead and implemented quite a bit of the API.  I also went back to the ESX, Virtualbox, and QEMU API's to try and make sure our API's matched up.  What's below is my

Re: [libvirt] [RFC]: Snapshot API v3

2010/3/31 Chris Lalancette clala...@redhat.com: On 03/30/2010 04:40 PM, Jiri Denemark wrote: Hi. ... /* NOTE: struct _virDomainSnapshot is a private structure, ala  * struct _virDomain.  */ typedef struct _virDomainSnapshot virDomainSnapshot; /* Take a snapshot of the current VM state.