Re: [libvirt] iface-list command in virsh

2010-04-20 Thread Dev.Atom
Hi, Yes I know that, and I use the fedora 12 distro, with netcf support and libvirt rpm are compiled with netcf support. That's why it works when I am root, but only when I am root -- From: Matthias Bolte matthias.bo...@googlemail.com Sent:

Re: [libvirt] iface-list command in virsh

2010-04-20 Thread Matthias Bolte
2010/4/20 Dev.Atom arnaud.champ...@devatom.fr: Hi, Yes I know that, and I use the fedora 12 distro, with netcf support and libvirt rpm are compiled with netcf support. That's why it works when I am root, but only when I am root -- From:

Re: [libvirt] iface-list command in virsh

2010-04-20 Thread Dev.Atom
Here is the full test : [r...@mingwenv arnaud]# whoami root [r...@mingwenv arnaud]# virsh Bienvenue dans virsh, le terminal de virtualisation interactif. Taper : « help » pour l'aide ou « help » avec la

Re: [libvirt] [PATCH] Fixup python binding for virDomainSnapshot APIs

2010-04-20 Thread Daniel Veillard
On Wed, Apr 14, 2010 at 04:36:47PM +0200, Daniel Veillard wrote: On Wed, Apr 14, 2010 at 03:03:45PM +0100, Daniel P. Berrange wrote: The generator code was totally wrong for the virDomainSnapshot APIs, not generating the wrapper class, and giving methods the wrong names * generator.py:

[libvirt] compiler warning about unused in_open parameter

2010-04-20 Thread Gustavo Morozowski
Hi, I am trying to build 0.8.0 for windows using Fedora 12 [1], the compile is breaking with the message - make[3]: Entering directory `/home/gustavo/Devel/libvirt-0.8.0/src' CC libvirt_driver_remote_la-remote_driver.lo cc1: warnings being treated as errors remote/remote_driver.c: In

Re: [libvirt] iface-list command in virsh

2010-04-20 Thread Laine Stump
On 04/19/2010 04:06 PM, Dev.Atom wrote: Hi, I'm trying to list physical interface of a remote tcp host via the C API and it fails. I have tried to use virsh iface-list in remote TCP connection and it fails also. I have trying on the libvirt host with my normal account and it fails also, but

Re: [libvirt] iface-list command in virsh

2010-04-20 Thread Dev.Atom
Is there a way to give root privileges to the process via setcap ? From: Laine Stump Sent: Tuesday, April 20, 2010 1:38 PM To: Dev.Atom Cc: libvir-list@redhat.com Subject: Re: [libvirt] iface-list command in virsh On 04/19/2010 04:06 PM, Dev.Atom wrote: Hi, I'm trying to list

Re: [libvirt] [PATCH 0/6] CPU selection fixes and tests

2010-04-20 Thread Jiri Denemark
Eric, Thanks for reviewing this patchset but I have to respin it as make check would not pass on RHEL (basically on any system where there is no /usr/bin/qemu). I'll send version 2 soon. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] Support for faking emulator in qemuxml2argv tests

2010-04-20 Thread Jiri Denemark
Hi, I thought I'd need it but turned out I didn't. In case someone else finds a good use for that, here's the patch. The idea was to provide a way to fake qemu responses on -M ?, -cpu ?, and the like. And in the end I actually need this functionality, so I'll incorporate this patch into a

[libvirt] [PATCH v2 1/7] Deal with CPU models in []

2010-04-20 Thread Jiri Denemark
Qemu committed a patch which list some CPU names in [] when asked for supported CPUs (qemu -cpu ?). Yet, it needs such CPUs to be passed without those square braces. When probing for supported CPU models, we can just strip the square braces and pretend we have never seen them. ---

[libvirt] [PATCH v2 2/7] Move MIN macro to util.h so that others can use it

2010-04-20 Thread Jiri Denemark
--- src/util/util.c |4 src/util/util.h |4 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 268944d..99383d1 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -79,10 +79,6 @@ # define NSIG 32 #endif -#ifndef MIN -#

[libvirt] [PATCH v2 0/7] CPU selection fixes and tests

2010-04-20 Thread Jiri Denemark
In this second version of the patchset, patches were reordered and a comment for format expected by qemudParseX86Models() was modified as suggested by Eric. In addition to these changes, qemu tests were fixed to pass on RHEL. Jirka Jiri Denemark (7): Deal with CPU models in [] Move MIN macro

[libvirt] [PATCH v2 3/7] Support removing features when converting data to CPU

2010-04-20 Thread Jiri Denemark
So far, when CPUID data were converted into CPU model and features, the features can only be added to the model. As a result, when a guest asked for something like qemu64,-svm it would get a qemu32 plus a bunch of additional features instead. This patch adds support for removing feature from the

[libvirt] [PATCH v2 4/7] Use configured CPU model if possible

2010-04-20 Thread Jiri Denemark
Adds ability to provide a preferred CPU model for CPUID data decoding. Such model would be considered as the best possible model (if it's supported by hypervisor) regardless on number of features which have to be added or removed for describing required CPU. --- src/cpu/cpu.c|8

[libvirt] [PATCH v2 6/7] Support for faking emulator in qemuxml2argv tests

2010-04-20 Thread Jiri Denemark
This patch allows for using custom scripts instead of /usr/bin/qemu emulator in domain XML. To do so, one would specify relative path to the custom script in emulator/. The path needs to be relative to qemuxml2argvdata directory and it will be transparently made absolute in runtime. The expected

[libvirt] [PATCH v2 5/7] Fake host CPU for qemu tests

2010-04-20 Thread Jiri Denemark
--- tests/testutilsqemu.c | 30 +- 1 files changed, 29 insertions(+), 1 deletions(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 8dd26d4..e0e5e14 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -6,6 +6,7 @@ # include

[libvirt] [PATCH v2 7/7] Tests for CPU selection in qemu driver

2010-04-20 Thread Jiri Denemark
--- tests/qemuxml2argvdata/qemu.sh | 64 .../qemuxml2argvdata/qemuxml2argv-cpu-exact1.args |1 + tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml | 28 + .../qemuxml2argvdata/qemuxml2argv-cpu-exact2.args |1 +

[libvirt] That the Linux bridge configuration does not work afer I upgraded the kernel to 2.6.33.2.

2010-04-20 Thread Frank Peng
Hello, When I use a standard Redhat kernel, it's ok. Everything's working right. That the Linux bridge configuration does not work afer I upgraded the kernel to 2.6.33.2. Why? [r...@node78 ~]# cat /etc/issue Red Hat Enterprise Linux Server release 5.5 (Tikanga) Kernel \r on an \m

[libvirt] KVM Forum 2010: Call for Papers

2010-04-20 Thread KVM Forum 2010 Program Committee
= CALL FOR PAPERS KVM Forum 2010 = DESCRIPTION The KVM Forum is back! After a break last year we're proud to present this year's gathering around KVM again. The

Re: [libvirt] [PATCH v2 0/7] CPU selection fixes and tests

2010-04-20 Thread Jiri Denemark
In this second version of the patchset, patches were reordered and a comment for format expected by qemudParseX86Models() was modified as suggested by Eric. In addition to these changes, qemu tests were fixed to pass on RHEL. Jirka Jiri Denemark (7): Deal with CPU models in [] Move

Re: [libvirt] [PATCH]: ignore empty type attribute, was Re: empty type parameter in driver tag for disk in machine xml file

2010-04-20 Thread Eric Blake
On 04/19/2010 10:16 AM, Guido Günther wrote: It seems this part of the libvirt xml file was causing the problem: disk type='file' device='disk' driver name='qemu' type=''/ Thanks for the analysis. This also popped up in Debian:

Re: [libvirt] [PATCH] esx: Add support for the VMXNET 2 (Enhanced) NIC model

2010-04-20 Thread Eric Blake
On 04/17/2010 05:28 AM, Matthias Bolte wrote: Add a test case and document it. +++ b/docs/drvesx.html.in @@ -307,10 +307,11 @@ ethernet0.checkMACAddress = false dd AMD PCnet32 network card for older guests. /dd -dtcodevmxnet/code, codevmxnet3/code/dt

Re: [libvirt] Live Migration with non-shared storage for kvm

2010-04-20 Thread Cole Robinson
On 04/19/2010 01:38 AM, Kenneth Nagin wrote: On Wed Apr 07 I sent an email with a patch titled Live Migration with non-shared storage for kvm. What is the status on the patch? If it didn't get an adequate response, it's probably a good idea to rebase the patch against latest code, and

[libvirt] [PATCH] addrToString: give better error message

2010-04-20 Thread Eric Blake
The user probably doesn't care what the gai error numbers are, as much as what the failed conversion IP address was. * src/remote/remote_driver.c (addrToString): Mention which address could not be converted. * daemon/remote.c (addrToString): Likewise. --- In response to

Re: [libvirt] iface-list command in virsh

2010-04-20 Thread Dev.Atom
As the iface-list command doesn't work, I'm trying to get physical interface of a host via nodedev-list, but it doesn't give me bridges, like br0 for example (which exists anyway). How can I retrieve available bridges of a host ? From: Dev.Atom Sent: Tuesday, April 20, 2010 2:09 PM To: Laine

Re: [libvirt] [PATCH] logrotate: don't rotate zero-length logfiles only

2010-04-20 Thread Eric Blake
On 04/18/2010 10:15 AM, Anton Protopopov wrote: Hi. In logrotate configuration files used by libvirt, there is an option 'minsize 100k', which prevents logrotate from rotating small ( 100k) files into an archive. But the target goal of the

Re: [libvirt] [PATCH v2 1/7] Deal with CPU models in []

2010-04-20 Thread Eric Blake
On 04/20/2010 06:41 AM, Jiri Denemark wrote: Qemu committed a patch which list some CPU names in [] when asked for supported CPUs (qemu -cpu ?). Yet, it needs such CPUs to be passed without those square braces. When probing for supported CPU models, we can just strip the square braces and

Re: [libvirt] [PATCH v2 2/7] Move MIN macro to util.h so that others can use it

2010-04-20 Thread Eric Blake
On 04/20/2010 06:42 AM, Jiri Denemark wrote: --- src/util/util.c |4 src/util/util.h |4 2 files changed, 4 insertions(+), 4 deletions(-) +++ b/src/util/util.h @@ -32,6 +32,10 @@ # include sys/select.h # include sys/types.h +# ifndef MIN +# define MIN(a, b)

Re: [libvirt] [PATCH v2 3/7] Support removing features when converting data to CPU

2010-04-20 Thread Eric Blake
On 04/20/2010 06:42 AM, Jiri Denemark wrote: So far, when CPUID data were converted into CPU model and features, the features can only be added to the model. As a result, when a guest asked for something like qemu64,-svm it would get a qemu32 plus a bunch of additional features instead.

Re: [libvirt] [PATCH v2 0/7] CPU selection fixes and tests

2010-04-20 Thread Eric Blake
On 04/20/2010 07:36 AM, Jiri Denemark wrote: In this second version of the patchset, patches were reordered and a comment for format expected by qemudParseX86Models() was modified as suggested by Eric. In addition to these changes, qemu tests were fixed to pass on RHEL. Jirka Jiri Denemark

Re: [libvirt] [PATCH v2 4/7] Use configured CPU model if possible

2010-04-20 Thread Eric Blake
On 04/20/2010 06:42 AM, Jiri Denemark wrote: Adds ability to provide a preferred CPU model for CPUID data decoding. Such model would be considered as the best possible model (if it's supported by hypervisor) regardless on number of features which have to be added or removed for describing

Re: [libvirt] [PATCH v2 5/7] Fake host CPU for qemu tests

2010-04-20 Thread Eric Blake
On 04/20/2010 06:42 AM, Jiri Denemark wrote: --- tests/testutilsqemu.c | 30 +- 1 files changed, 29 insertions(+), 1 deletions(-) -if ((machines = testQemuAllocMachines(nmachines)) == NULL) +if ((caps-host.cpu = virCPUDefCopy(host_cpu)) == NULL || +

Re: [libvirt] [PATCH v2 6/7] Support for faking emulator in qemuxml2argv tests

2010-04-20 Thread Eric Blake
On 04/20/2010 06:42 AM, Jiri Denemark wrote: The problem is RelaxNG schema for domain XML only allows for absolute path be used within emulator/. To workaround it, an extra '/' must be add at the beginning of the path. That is, instead of ./qemu.sh or ../emulator/qemu.sh one would use

Re: [libvirt] [Resend][PATCH 1/3] Add dnsmasq module

2010-04-20 Thread Eric Blake
On 04/18/2010 09:53 PM, Satoru SATOH wrote: This patch adds the files implements dnsmasq (hostsfile) module. Signed-off-by: Satoru SATOH satoru.sa...@gmail.com In addition to Jim's comments: --- src/util/dnsmasq.c | 326

Re: [libvirt] [PATCH] esx: Fix virtualHW.version generation

2010-04-20 Thread Eric Blake
On 04/18/2010 02:32 PM, Matthias Bolte wrote: The supported virtualHW.version doesn't depend on the API version, but on the product version. --- @@ -774,42 +774,41 @@ esxVMX_ParseConfig(esxVI_Context *ctx, const char *vmx, goto failure; } -switch (apiVersion) { -

[libvirt] Bug with creating snapshots in ESX in 0.8.0 (patch included)

2010-04-20 Thread Chris Wong
I was testing out the new snapshot on functionality with GSX (VMWare Server 2.0.2) and noticed that it would fail to create a snapshot on a VM with no snapshots. I tracked it down to the esxDomainSnapshotCreateXML call, which would prematurely fail if the Root Snapshot Tree was empty -- which it

[libvirt] [PATCH] Mark in_open parameter of remoteAuthenticate as unused when it's unused

2010-04-20 Thread Matthias Bolte
Otherwise compiling with -Werror will fail. --- I just pushed this trivial patch. src/remote/remote_driver.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index e3df27b..c2b58e6 100644 ---

Re: [libvirt] compiler warning about unused in_open parameter

2010-04-20 Thread Matthias Bolte
2010/4/20 Gustavo Morozowski gustavo...@gmail.com: Hi, I am trying to build 0.8.0 for windows using Fedora 12 [1], the compile is breaking with the message - make[3]: Entering directory `/home/gustavo/Devel/libvirt-0.8.0/src'  CC     libvirt_driver_remote_la-remote_driver.lo cc1: warnings

Re: [libvirt] [PATCH] esx: Add support for the VMXNET 2 (Enhanced) NIC model

2010-04-20 Thread Matthias Bolte
2010/4/20 Eric Blake ebl...@redhat.com: On 04/17/2010 05:28 AM, Matthias Bolte wrote: Add a test case and document it. +++ b/docs/drvesx.html.in @@ -307,10 +307,11 @@ ethernet0.checkMACAddress = false          dd              AMD PCnet32 network card for older guests.          /dd -        

Re: [libvirt] [PATCH] Mark in_open parameter of remoteAuthenticate as unused when it's unused

2010-04-20 Thread Eric Blake
On 04/20/2010 12:56 PM, Matthias Bolte wrote: Otherwise compiling with -Werror will fail. --- static int -remoteAuthenticate (virConnectPtr conn, struct private_data *priv, int in_open, +remoteAuthenticate (virConnectPtr conn, struct private_data *priv, int in_open +#if !HAVE_SASL

Re: [libvirt] [PATCH] Mark in_open parameter of remoteAuthenticate as unused when it's unused

2010-04-20 Thread Matthias Bolte
2010/4/20 Eric Blake ebl...@redhat.com: On 04/20/2010 12:56 PM, Matthias Bolte wrote: Otherwise compiling with -Werror will fail. ---  static int -remoteAuthenticate (virConnectPtr conn, struct private_data *priv, int in_open, +remoteAuthenticate (virConnectPtr conn, struct private_data

Re: [libvirt] [PATCH] esx: Fix FindByIp response handling

2010-04-20 Thread Eric Blake
On 04/18/2010 02:32 PM, Matthias Bolte wrote: FindByIp may return nothing if there is no host or virtual machine with the given IP address. Handle that case properly. --- src/esx/esx_vi.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi.c

Re: [libvirt] [PATCH] nwfilter: Extend fwall-drv interface and call functions via interface

2010-04-20 Thread Eric Blake
On 04/18/2010 06:43 PM, Stefan Berger wrote: I moving some functions into the interface of the firewall driver and make them only accessible via the driver's interface. Adapt the code That first sentence reads awkwardly, if you want to touch it up before pushing. where needed. One new

Re: [libvirt] [RFC PATCH] Support for qemu aio drive option

2010-04-20 Thread Eric Blake
On 04/18/2010 07:47 AM, Matthias Dahl wrote: This is a quick implementation to support the qemu aio drive option. I tried to stay true to the coding style and this has been tested w/ libvirt 0.7.6 and works just fine. Since I am not that familiar w/ the inner workings of libvirt, I am

Re: [libvirt] [PATCH]: ignore empty type attribute, was Re: empty type parameter in driver tag for disk in machine xml file

2010-04-20 Thread Guido Günther
On Tue, Apr 20, 2010 at 08:20:35AM -0600, Eric Blake wrote: On 04/19/2010 10:16 AM, Guido Günther wrote: [..snip..] since the former is O(1) while the latter is nominally O(n) in the Good point. New patch attached. -- Guido From 6dc897319fd6ff6863895ffac01e5a38ba911abd Mon Sep 17 00:00:00 2001

Re: [libvirt] [PATCH]: ignore empty type attribute, was Re: empty type parameter in driver tag for disk in machine xml file

2010-04-20 Thread Eric Blake
On 04/20/2010 02:18 PM, Guido Günther wrote: On Tue, Apr 20, 2010 at 08:20:35AM -0600, Eric Blake wrote: On 04/19/2010 10:16 AM, Guido Günther wrote: [..snip..] since the former is O(1) while the latter is nominally O(n) in the Good point. New patch attached. Looks good; you have my ACK for

Re: [libvirt] [PATCH] esx: Gather some XML generation macros in esx_vi.h

2010-04-20 Thread Eric Blake
On 04/18/2010 02:33 PM, Matthias Bolte wrote: --- src/esx/esx_vi.c | 27 ++- src/esx/esx_vi.h | 37 + src/esx/esx_vi_methods.c | 17 - src/esx/esx_vi_types.c | 20 4

Re: [libvirt] [RFC PATCH] Support for qemu aio drive option

2010-04-20 Thread Matthias Bolte
2010/4/20 Eric Blake ebl...@redhat.com: On 04/18/2010 07:47 AM, Matthias Dahl wrote: This is a quick implementation to support the qemu aio drive option. I tried to stay true to the coding style and this has been tested w/ libvirt 0.7.6 and works just fine. Since I am not that familiar

Re: [libvirt] [PATCH] nwfilter: add support for connlimit match

2010-04-20 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 04/20/2010 04:11:24 PM: On 04/19/2010 01:13 PM, Stefan Berger wrote: This patch adds support for the connlimit match in iptables that is used to limit number of outgoing directions. Signed-off-by Stefan Berger stef...@us.ibm.com ---

Re: [libvirt] [PATCH] nwfilter: Extend fwall-drv interface and call functions via interface

2010-04-20 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 04/20/2010 04:14:42 PM: On 04/18/2010 06:43 PM, Stefan Berger wrote: I moving some functions into the interface of the firewall driver and make them only accessible via the driver's interface. Adapt the code That first sentence reads awkwardly, if

Re: [libvirt] [RFC PATCH] Support for qemu aio drive option

2010-04-20 Thread Eric Blake
On 04/20/2010 03:23 PM, Matthias Bolte wrote: This is a decent start, but it's still missing XML definition, remote protocol support, and virsh support. docs/api_extension gives a sample patch series that shows all the pieces that are necessary for enhancing the API. This is just an domain

Re: [libvirt] [PATCH] esx: Fix virtualHW.version generation

2010-04-20 Thread Matthias Bolte
2010/4/20 Eric Blake ebl...@redhat.com: On 04/18/2010 02:32 PM, Matthias Bolte wrote: The supported virtualHW.version doesn't depend on the API version, but on the product version. --- @@ -774,42 +774,41 @@ esxVMX_ParseConfig(esxVI_Context *ctx, const char *vmx,          goto failure;      

Re: [libvirt] [PATCH] esx: Fix FindByIp response handling

2010-04-20 Thread Matthias Bolte
2010/4/20 Eric Blake ebl...@redhat.com: On 04/18/2010 02:32 PM, Matthias Bolte wrote: FindByIp may return nothing if there is no host or virtual machine with the given IP address. Handle that case properly. ---  src/esx/esx_vi.c |    7 +++  1 files changed, 7 insertions(+), 0

Re: [libvirt] [PATCH] esx: Gather some XML generation macros in esx_vi.h

2010-04-20 Thread Matthias Bolte
2010/4/20 Eric Blake ebl...@redhat.com: On 04/18/2010 02:33 PM, Matthias Bolte wrote: ---  src/esx/esx_vi.c         |   27 ++-  src/esx/esx_vi.h         |   37 +  src/esx/esx_vi_methods.c |   17 -  

Re: [libvirt] [PATCH] addrToString: give better error message

2010-04-20 Thread Matthias Bolte
2010/4/20 Eric Blake ebl...@redhat.com: The user probably doesn't care what the gai error numbers are, as much as what the failed conversion IP address was. * src/remote/remote_driver.c (addrToString): Mention which address could not be converted. * daemon/remote.c (addrToString): Likewise.

Re: [libvirt] Bug with creating snapshots in ESX in 0.8.0 (patch included)

2010-04-20 Thread Matthias Bolte
2010/4/20 Chris Wong wongc-red...@hoku.net: I was testing out the new snapshot on functionality with GSX (VMWare Server 2.0.2) and noticed that it would fail to create a snapshot on a VM with no snapshots. I tracked it down to the esxDomainSnapshotCreateXML call, which would prematurely fail