Re: [libvirt] unable to set security context (NFSv4 problem?)

2010-04-21 Thread Harald Dunkel
On 04/21/10 20:24, Spencer Shimko wrote: > Harald Dunkel wrote: >> >> Do you think it would be possible to introduce a configure >> option '--with-dac=no'? > > I think that would be a little misleading ;) It sounds like part of the > problem was that the error message wasn't clearly conveying the

Re: [libvirt] seg fault when running snapshot-create

2010-04-21 Thread Stephen Shaw
On Wed, Apr 21, 2010 at 15:16, Chris Lalancette wrote: > On 04/21/2010 04:34 PM, Stephen Shaw wrote: >> I'm getting a seg fault when running virsh snapshot-create 1, but only >> when virt-manager is open and connected. >> >> Here is some of the debug info I was able to come up with - >> http://fpa

[libvirt] [PATCH] maint: enforce whitespace on shell scripts

2010-04-21 Thread Eric Blake
Noticed because virt-pki-validate was very inconsistent on using tabs vs. 8 spaces, sometimes mixing both paradigms on a single line. 'git diff -b' shows significant changes only in cfg.mk. * cfg.mk (sc_TAB_in_indentation): Add a few files. * daemon/libvirtd.init.in: Avoid tabs. * tools/virt-pki-

[libvirt] [PATCH] portability fixes to tools/virt-pki-validate.in

2010-04-21 Thread Eric Blake
From: Dustin Kirkland A few fixes will help make tools/virt-pki-validate.in useful on Debian and Ubuntu. And one fix should be useful to everyone (see #3). 1) note our gnutls-bin package (in addition to your gnutls-utils package) in the no-certtool error text 2) fix a bashism, == should be =

Re: [libvirt] [PATCH] portability fixes to tools/virt-pki-validate.in

2010-04-21 Thread Eric Blake
On 04/21/2010 03:52 PM, Dustin Kirkland wrote: > -ORG=`$CERTOOL -i --infile $CA/cacert.pem | grep Issuer | sed 's+Issuer: > CN=++'` > -if [ "$ORG" == "" ] > +ORG=`$CERTOOL -i --infile $CA/cacert.pem | grep Issuer | sed -e > 's+\s*Issuer: .*CN=++' -e 's+,EMAIL=.*++'` Using \s in sed is not portab

Re: [libvirt] [PATCH] portability fixes to tools/virt-pki-validate.in

2010-04-21 Thread Dustin Kirkland
On Wed, 2010-04-21 at 15:22 -0600, Eric Blake wrote: > On 04/21/2010 03:00 PM, Dustin Kirkland wrote: > > portability fixes to tools/virt-pki-validate.in > > > > A few fixes will help make tools/virt-pki-validate.in useful on Debian > > and Ubuntu. And one fix should be useful to everyone (see #4

Re: [libvirt] [PATCH] portability fixes to tools/virt-pki-validate.in

2010-04-21 Thread Eric Blake
On 04/21/2010 03:00 PM, Dustin Kirkland wrote: > portability fixes to tools/virt-pki-validate.in > > A few fixes will help make tools/virt-pki-validate.in useful on Debian > and Ubuntu. And one fix should be useful to everyone (see #4). > > 1) note our gnutls-bin package (in addition to your gn

Re: [libvirt] seg fault when running snapshot-create

2010-04-21 Thread Chris Lalancette
On 04/21/2010 04:34 PM, Stephen Shaw wrote: > I'm getting a seg fault when running virsh snapshot-create 1, but only > when virt-manager is open and connected. > > Here is some of the debug info I was able to come up with - > http://fpaste.org/9GO6/ (bt) > http://fpaste.org/7gkH/ ('thread apply al

Re: [libvirt] [PATCH 4/4] Fix QEMU domain save to block devices with cgroups enabled

2010-04-21 Thread Eric Blake
On 04/21/2010 10:56 AM, Daniel P. Berrange wrote: > When cgroups is enabled, access to block devices is likely to be > restricted to a whitelist. Prior to saving a guest to a block device, > it is neccessary to add the block device to the whitelist. THis is s/neccessary/necessary/g; s/THis/This/

Re: [libvirt] [PATCH 4/4] Fix QEMU domain save to block devices with cgroups enabled

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 05:56:13PM +0100, Daniel P. Berrange wrote: > When cgroups is enabled, access to block devices is likely to be > restricted to a whitelist. Prior to saving a guest to a block device, > it is neccessary to add the block device to the whitelist. THis is > not required upon res

Re: [libvirt] [PATCH] Make avahi startup more robust.

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 03:22:41PM -0400, Chris Lalancette wrote: > If the hostname of the current virtualization machine > could not be resolved, then libvirtd would fail to > start. However, for disconnected operation (on a laptop, > for instance) the hostname may very legitimately not > be reso

Re: [libvirt] [PATCH 3/4] Fix QEMU save/restore with block devices

2010-04-21 Thread Eric Blake
On 04/21/2010 10:56 AM, Daniel P. Berrange wrote: > The save process was relying on use of the shell >> append > operator to ensure the save data was placed after the libvirt > header + XML. This doesn't work for block devices though. > Replace this code with use of 'dd' and its 'seek' parameter. >

Re: [libvirt] [PATCH 3/4] Fix QEMU save/restore with block devices

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 05:56:12PM +0100, Daniel P. Berrange wrote: > The save process was relying on use of the shell >> append > operator to ensure the save data was placed after the libvirt > header + XML. This doesn't work for block devices though. > Replace this code with use of 'dd' and its '

[libvirt] [PATCH] portability fixes to tools/virt-pki-validate.in

2010-04-21 Thread Dustin Kirkland
portability fixes to tools/virt-pki-validate.in A few fixes will help make tools/virt-pki-validate.in useful on Debian and Ubuntu. And one fix should be useful to everyone (see #4). 1) note our gnutls-bin package (in addition to your gnutls-utils package) in the no-certtool error text 2) adju

Re: [libvirt] seg fault when running snapshot-create

2010-04-21 Thread Stephen Shaw
On Wed, Apr 21, 2010 at 14:34, Stephen Shaw wrote: > I'm getting a seg fault when running virsh snapshot-create 1, but only > when virt-manager is open and connected. > > Here is some of the debug info I was able to come up with - > http://fpaste.org/9GO6/ (bt) > http://fpaste.org/7gkH/ ('thread a

Re: [libvirt] [PATCH 2/4] Avoid create/unlink with block devs used for QEMU save

2010-04-21 Thread Eric Blake
On 04/21/2010 10:56 AM, Daniel P. Berrange wrote: > It is possible to use block devices with domain save/restore. Upon > failure QEMU unlinks the path being saved to. This isn't good when > it is a block device ! > > +struct stat sb; > +int is_bdev = 0; Should this be bool instead of int?

Re: [libvirt] [PATCH 2/4] Avoid create/unlink with block devs used for QEMU save

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 05:56:11PM +0100, Daniel P. Berrange wrote: > It is possible to use block devices with domain save/restore. Upon > failure QEMU unlinks the path being saved to. This isn't good when > it is a block device ! > > * src/qemu/qemu_driver.c: Don't unlink block devices if save fa

[libvirt] seg fault when running snapshot-create

2010-04-21 Thread Stephen Shaw
I'm getting a seg fault when running virsh snapshot-create 1, but only when virt-manager is open and connected. Here is some of the debug info I was able to come up with - http://fpaste.org/9GO6/ (bt) http://fpaste.org/7gkH/ ('thread apply all bt) * After the crash (gdb) p mon->msg $1 = (qemuMoni

Re: [libvirt] [PATCH] maint: ignore 'make syntax-check' failure files

2010-04-21 Thread Eric Blake
On 04/21/2010 02:18 PM, Daniel Veillard wrote: >> @@ -34,6 +34,7 @@ local-checks-to-skip = \ >>sc_GPL_version\ >>sc_always_defined_macros \ >>sc_cast_of_alloca_return_value\ >> + sc_cross_check_PATH_usage_in_tests\ >>sc_d

Re: [libvirt] [PATCH 1/4] Fix crash when cleaning up from failed save attempt

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 05:56:10PM +0100, Daniel P. Berrange wrote: > If a transient QEMU crashes during save attempt, then the virDomainPtr > object may be freed. If a persistent QEMU crashes during save, then > the 'priv->mon' field is no longer valid since it will be inactive. > > * src/qemu/qe

Re: [libvirt] [PATCH 1/4] Make avahi startup more robust.

2010-04-21 Thread Chris Lalancette
On 04/21/2010 04:17 PM, Daniel Veillard wrote: > On Wed, Apr 21, 2010 at 02:50:18PM -0400, Chris Lalancette wrote: >> On 04/21/2010 12:25 PM, Eric Blake wrote: >>> On 04/21/2010 10:03 AM, Chris Lalancette wrote: If the hostname of the current virtualization machine could not be resolved,

Re: [libvirt] [PATCH] maint: ignore 'make syntax-check' failure files

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 10:11:11AM -0600, Eric Blake wrote: > * .gitignore: Add exemption. > * cfg.mk (local-checks-to-skip): Ignore a test to silence a skip > warning. > --- > > Noticed these while fixing the 'make syntax-check' fallout. > They border on trivial, but I decided to wait for an ACK.

Re: [libvirt] [PATCH 1/4] Make avahi startup more robust.

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 02:50:18PM -0400, Chris Lalancette wrote: > On 04/21/2010 12:25 PM, Eric Blake wrote: > > On 04/21/2010 10:03 AM, Chris Lalancette wrote: > >> If the hostname of the current virtualization machine > >> could not be resolved, then libvirtd would fail to > >> start. However,

Re: [libvirt] [PATCH 09/10] Implement virsh qemu-monitor-command.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > tools/Makefile.am |1 + > tools/virsh.c | 55 > + Nothing in tools/virsh.pod? Hmm, we ought to modify docs/api_extension to mention documenting

[libvirt] [PATCH] Make avahi startup more robust.

2010-04-21 Thread Chris Lalancette
If the hostname of the current virtualization machine could not be resolved, then libvirtd would fail to start. However, for disconnected operation (on a laptop, for instance) the hostname may very legitimately not be resolvable. This patch makes it so that if we can't resolve the hostname, avahi

Re: [libvirt] [PATCH 1/4] Make avahi startup more robust.

2010-04-21 Thread Chris Lalancette
On 04/21/2010 12:25 PM, Eric Blake wrote: > On 04/21/2010 10:03 AM, Chris Lalancette wrote: >> If the hostname of the current virtualization machine >> could not be resolved, then libvirtd would fail to >> start. However, for disconnected operation (on a laptop, >> for instance) the hostname may v

Re: [libvirt] [PATCH]: ignore empty type attribute, was Re: empty type parameter in driver tag for disk in machine xml file

2010-04-21 Thread Guido Günther
On Tue, Apr 20, 2010 at 02:20:05PM -0600, Eric Blake wrote: > On 04/20/2010 02:18 PM, Guido Günther wrote: > > On Tue, Apr 20, 2010 at 08:20:35AM -0600, Eric Blake wrote: > >> On 04/19/2010 10:16 AM, Guido Günther wrote: > > [..snip..] > >> since the former is O(1) while the latter is nominally O(

[libvirt] [PATCH V2] nwfilter: lock interface by its index

2010-04-21 Thread Stefan Berger
Changes from V1 to V2: - using INT_BUFSIZE_BOUND() to determine the length of the buffersize for printing and integer into - not explicitly initializing static var threadsTerminate to false anymore, since that's done automatically - there are 2 calls in the virNWFilterLockIface function that c

Re: [libvirt] [PATCH 08/10] Qemu remote protocol.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > Since we are adding a new "per-hypervisor" protocol, we > make it so that the qemu remote protocol uses a new > PROTOCOL and PROGRAM number. This allows us to easily > distinguish it from the normal REMOTE protocol. > > This necessitates changing

Re: [libvirt] unable to set security context (NFSv4 problem?)

2010-04-21 Thread Spencer Shimko
Harald Dunkel wrote: Hi Spencer, I could reproduce the EINVAL on the command line: srvl022:/storage# touch /storage/x srvl022:/storage# chown 110:140 /storage/x chown: changing ownership of `/storage/x': Invalid argument 110 and 140 are not valid UIDs and GIDs on the NF

[libvirt] [PATCH] configure.ac SELinux fixes

2010-04-21 Thread spencer
* Fix a logic error in configure.ac that prevented --with-selinux=no from being used with --with-secdriver-selinux=no. * Fix some strings to clarify the difference between --with-selinux and --with-secdriver-selinux. Signed-off-by: Spencer Shimko --- configure.ac | 12 ++-- 1 files

[libvirt] [PATCH] Fix security context references in DAC code

2010-04-21 Thread spencer
* The error messages coming from qemu's DAC support contain strings from the original SELinux security driver code. This just removes references to "security context" and other SELinux-isms from the DAC code. Signed-off-by: Spencer Shimko --- src/qemu/qemu_security_dac.c | 18 ++

Re: [libvirt] [PATCH 07/10] Qemu arbitrary monitor commands.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > Implement the qemu driver's virDomainQemuMonitorCommand > and hook it into the API entry point. > > > +int qemuMonitorCommand(virDomainPtr domain, const char *cmd, > + char **result, unsigned int flags ATTRIBUTE_UNUSED) > +{

Re: [libvirt] [PATCH 01/10] Fix up ESX preprocessor macros to pass make syntax-check cppi.

2010-04-21 Thread Eric Blake
On 04/21/2010 11:40 AM, Matthias Bolte wrote: >> I independently applied this as obvious; you can drop it from your series. >> https://www.redhat.com/archives/libvir-list/2010-April/msg00906.html >> > > I installed cppi now, so this won't happen again. Now that cppi is in use by a few more develo

Re: [libvirt] [PATCH 06/10] Qemu Monitor API entry point.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > Add the library entry point for the new virDomainQemuMonitorCommand() > entry point. Because this is not part of the "normal" libvirt API, > it gets it's own header file, library file, and will eventually > get it's own over-the-wire protocol later

Re: [libvirt] [PATCH 01/10] Fix up ESX preprocessor macros to pass make syntax-check cppi.

2010-04-21 Thread Matthias Bolte
2010/4/21 Eric Blake : > On 04/21/2010 10:01 AM, Chris Lalancette wrote: >> Signed-off-by: Chris Lalancette >> --- >>  src/esx/esx_vi.h |    8 >>  1 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/src/esx/esx_vi.h b/src/esx/esx_vi.h >> index e0d731e..a2ed5a6 100644 >> --

Re: [libvirt] [PATCH 05/10] Handle arbitrary qemu command-lines in qemuParseCommandLine.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > Now that we have the ability to specify arbitrary qemu > command-line parameters in the XML, use it to handle unknown > command-line parameters when doing a native-to-xml conversion. > > +++ b/src/conf/domain_conf.c > @@ -3719,6 +3719,14 @@ static

Re: [libvirt] [PATCH 04/10] Qemu arbitrary command-line arguments.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > > +static void qemuDomainDefNamespaceFree(void *nsdata) > +{ > +qemuDomainCmdlineDefPtr cmd = nsdata; > +int i; s/int/unsigned int/ > +static int qemuDomainDefNamespaceParse(xmlDocPtr xml, > + xmlNod

Re: [libvirt] [PATCH] Add a test case that validates save to a block device

2010-04-21 Thread Eric Blake
On 04/21/2010 11:03 AM, Daniel P. Berrange wrote: > There are some unusual problems when saving to a block device, > vs a file. This test case covers problems inherant in using s/inherant/inherent/ > block devices > --- > scripts/domain/103-blockdev-save-restore.t | 91 > +

Re: [libvirt] [PATCH[ nwfilter: lock interface by its index

2010-04-21 Thread Stefan Berger
Eric Blake wrote on 04/21/2010 10:59:35 AM: > On 04/20/2010 05:50 PM, Stefan Berger wrote: > > I've done a quick style review, but have not looked closely at the > locking algorithm to see if it is sane, so you'll have to wait for > another review (possibly by me, if I have a longer chunk of ti

[libvirt] [PATCH] Add a test case that validates save to a block device

2010-04-21 Thread Daniel P. Berrange
There are some unusual problems when saving to a block device, vs a file. This test case covers problems inherant in using block devices --- scripts/domain/103-blockdev-save-restore.t | 91 1 files changed, 91 insertions(+), 0 deletions(-) create mode 100644 scripts

Re: [libvirt] [PATCH 03/10] Add namespace callback hooks to domain_conf.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > This patch adds namespace XML parsers to be hooked into > the main domain parser. This allows for individual hypervisor > drivers to add per-namespace XML into the main domain XML. > > @@ -4366,6 +4372,22 @@ static virDomainDefPtr virDomainDefPar

[libvirt] [PATCH 2/4] Avoid create/unlink with block devs used for QEMU save

2010-04-21 Thread Daniel P. Berrange
It is possible to use block devices with domain save/restore. Upon failure QEMU unlinks the path being saved to. This isn't good when it is a block device ! * src/qemu/qemu_driver.c: Don't unlink block devices if save fails --- src/qemu/qemu_driver.c | 22 -- 1 files changed

[libvirt] [PATCH 3/4] Fix QEMU save/restore with block devices

2010-04-21 Thread Daniel P. Berrange
The save process was relying on use of the shell >> append operator to ensure the save data was placed after the libvirt header + XML. This doesn't work for block devices though. Replace this code with use of 'dd' and its 'seek' parameter. The qemuMonitorMigateToCommand() monitor API is used for b

[libvirt] [PATCH 4/4] Fix QEMU domain save to block devices with cgroups enabled

2010-04-21 Thread Daniel P. Berrange
When cgroups is enabled, access to block devices is likely to be restricted to a whitelist. Prior to saving a guest to a block device, it is neccessary to add the block device to the whitelist. THis is not required upon restore, since QEMU reads from stdin * src/qemu/qemu_driver.c: Add block devic

[libvirt] [PATCH 1/4] Fix crash when cleaning up from failed save attempt

2010-04-21 Thread Daniel P. Berrange
If a transient QEMU crashes during save attempt, then the virDomainPtr object may be freed. If a persistent QEMU crashes during save, then the 'priv->mon' field is no longer valid since it will be inactive. * src/qemu/qemu_driver.c: Fix two crashes when QEMU exits during a save attempt --- src/

[libvirt] [PATCH 0/4] Multiple problems with saving to block devices

2010-04-21 Thread Daniel P. Berrange
This patch series makes it possible to save to a block device, instead of a plain file. There were multiple problems - WHen save failed, we might de-reference a NULL pointer - When save failed, we unlinked the device node !! - The approach of using >> to append, doesn't work with block devices

Re: [libvirt] [PATCH 02/10] Make virDomainObjParseFile and virDomainObjParseNode static.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/conf/domain_conf.c | 37 +++-- > src/conf/domain_conf.h |6 -- > 2 files changed, 19 insertions(+), 24 deletions(-) ACK; the reorder is an obvious fallout to av

Re: [libvirt] [PATCH 01/10] Fix up ESX preprocessor macros to pass make syntax-check cppi.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:01 AM, Chris Lalancette wrote: > Signed-off-by: Chris Lalancette > --- > src/esx/esx_vi.h |8 > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/esx/esx_vi.h b/src/esx/esx_vi.h > index e0d731e..a2ed5a6 100644 > --- a/src/esx/esx_vi.h > +++ b/src

Re: [libvirt] [PATCH 1/4] Make avahi startup more robust.

2010-04-21 Thread Eric Blake
On 04/21/2010 10:03 AM, Chris Lalancette wrote: > If the hostname of the current virtualization machine > could not be resolved, then libvirtd would fail to > start. However, for disconnected operation (on a laptop, > for instance) the hostname may very legitimately not > be resolvable. This patc

[libvirt] [PATCHv2] addrToString: give better error message

2010-04-21 Thread Eric Blake
The user probably doesn't care what the gai error numbers are, as much as what the failed conversion IP address was. * src/remote/remote_driver.c (addrToString): Mention which address could not be converted. * daemon/remote.c (addrToString): Likewise. --- Changes in v2: Remove magic numbers in re

[libvirt] [PATCH] build: fix preprocessor indentation

2010-04-21 Thread Eric Blake
* src/esx/esx_vi.h: Placate cppi. --- Sorry for not noticing this earlier, but your patch fails 'make syntax-check'. Pushing this as obvious. src/esx/esx_vi.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_vi.h b/src/esx/esx_vi.h index e0d731e..d581a

Re: [libvirt] [PATCH 1/4] Make avahi startup more robust.

2010-04-21 Thread Chris Lalancette
Grr. Please ignore the subject line. This is not PATCH 1/4, it's a standalone patch. I screwed up when using git format-patch. Chris Lalancette On 04/21/2010 12:03 PM, Chris Lalancette wrote: > If the hostname of the current virtualization machine > could not be resolved, then libvirtd would

[libvirt] [PATCH] maint: ignore 'make syntax-check' failure files

2010-04-21 Thread Eric Blake
* .gitignore: Add exemption. * cfg.mk (local-checks-to-skip): Ignore a test to silence a skip warning. --- Noticed these while fixing the 'make syntax-check' fallout. They border on trivial, but I decided to wait for an ACK. .gitignore |1 + cfg.mk |1 + 2 files changed, 2 insertions

[libvirt] [PATCH 10/10] Add tests for the new Qemu namespace XML.

2010-04-21 Thread Chris Lalancette
Thanks to DV for knocking together the Relax-NG changes quickly for me. Signed-off-by: Chris Lalancette --- docs/schemas/domain.rng| 26 + src/qemu/qemu_driver.c | 16 +- src/qemu/qemu_driver.h

[libvirt] [PATCH 04/10] Qemu arbitrary command-line arguments.

2010-04-21 Thread Chris Lalancette
Implement the qemu hooks for XML namespace data. This allows us to specify a qemu XML namespace, and then specify: arg In the domain XML. Signed-off-by: Chris Lalancette --- src/qemu/qemu_conf.c | 14 + src/qemu/qemu_conf.h | 11 src/qemu/qemu_driver.c | 151 +++

[libvirt] [PATCH 09/10] Implement virsh qemu-monitor-command.

2010-04-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette --- tools/Makefile.am |1 + tools/virsh.c | 55 + 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/tools/Makefile.am b/tools/Makefile.am index 33a3216..b69de75 100644 --- a/tools/Makefile.

[libvirt] [PATCH 1/4] Make avahi startup more robust.

2010-04-21 Thread Chris Lalancette
If the hostname of the current virtualization machine could not be resolved, then libvirtd would fail to start. However, for disconnected operation (on a laptop, for instance) the hostname may very legitimately not be resolvable. This patch makes it so that if we can't resolve the hostname, avahi

[libvirt] [PATCH 01/10] Fix up ESX preprocessor macros to pass make syntax-check cppi.

2010-04-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette --- src/esx/esx_vi.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_vi.h b/src/esx/esx_vi.h index e0d731e..a2ed5a6 100644 --- a/src/esx/esx_vi.h +++ b/src/esx/esx_vi.h @@ -40,7 +40,7 @@ -#define ESX_VI__SOAP__REQUE

[libvirt] [PATCH 07/10] Qemu arbitrary monitor commands.

2010-04-21 Thread Chris Lalancette
Implement the qemu driver's virDomainQemuMonitorCommand and hook it into the API entry point. Signed-off-by: Chris Lalancette --- src/libvirt-qemu.c | 12 +++- src/qemu/qemu_driver.c | 38 ++ src/qemu/qemu_driver.h |3 +++

[libvirt] [PATCH 08/10] Qemu remote protocol.

2010-04-21 Thread Chris Lalancette
Since we are adding a new "per-hypervisor" protocol, we make it so that the qemu remote protocol uses a new PROTOCOL and PROGRAM number. This allows us to easily distinguish it from the normal REMOTE protocol. This necessitates changing the proc in remote_message_header from a "remote_procedure"

[libvirt] [PATCH 03/10] Add namespace callback hooks to domain_conf.

2010-04-21 Thread Chris Lalancette
This patch adds namespace XML parsers to be hooked into the main domain parser. This allows for individual hypervisor drivers to add per-namespace XML into the main domain XML. Signed-off-by: Chris Lalancette --- src/conf/capabilities.c |2 ++ src/conf/capabilities.h | 17

[libvirt] [PATCH 06/10] Qemu Monitor API entry point.

2010-04-21 Thread Chris Lalancette
Add the library entry point for the new virDomainQemuMonitorCommand() entry point. Because this is not part of the "normal" libvirt API, it gets it's own header file, library file, and will eventually get it's own over-the-wire protocol later in the series. Signed-off-by: Chris Lalancette --- i

[libvirt] [PATCH 05/10] Handle arbitrary qemu command-lines in qemuParseCommandLine.

2010-04-21 Thread Chris Lalancette
Now that we have the ability to specify arbitrary qemu command-line parameters in the XML, use it to handle unknown command-line parameters when doing a native-to-xml conversion. Signed-off-by: Chris Lalancette --- src/conf/domain_conf.c | 13 + src/conf/domain_conf.h |2 ++

[libvirt] [PATCH 02/10] Make virDomainObjParseFile and virDomainObjParseNode static.

2010-04-21 Thread Chris Lalancette
Signed-off-by: Chris Lalancette --- src/conf/domain_conf.c | 37 +++-- src/conf/domain_conf.h |6 -- 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2de838b..e4a2cac 100644 --- a/src/c

[libvirt] [PATCH 00/10]: Add arbitrary qemu command-line and monitor commands

2010-04-21 Thread Chris Lalancette
As we discussed previously, here is the patch series to add the ability to specify arbitrary qemu command-line parameters and environment variables, and also give arbitrary monitor commands to a guest. Because these extra arguments have a good shot at confusing libvirt, the use of them is not supp

Re: [libvirt] [PATCH v2] Support for qemu aio drive option

2010-04-21 Thread Eric Blake
On 04/21/2010 08:28 AM, Matthias Dahl wrote: > Revised patch against libvirt 0.7.6 to support qemu's aio option. It's hard to tell from your comments whether you built the patch against the latest git (0.8.0+). > +++ b/docs/formatdomain.html.in > @@ -478,7 +478,9 @@ > attribute is the pr

Re: [libvirt] [PATCH[ nwfilter: lock interface by its index

2010-04-21 Thread Eric Blake
On 04/20/2010 05:50 PM, Stefan Berger wrote: I've done a quick style review, but have not looked closely at the locking algorithm to see if it is sane, so you'll have to wait for another review (possibly by me, if I have a longer chunk of time to spend on it) before you get an ack. > #define VIR

Re: [libvirt] [PATCH] addrToString: give better error message

2010-04-21 Thread Eric Blake
On 04/20/2010 10:13 AM, Eric Blake wrote: > The user probably doesn't care what the gai error numbers are, as > much as what the failed conversion IP address was. > > +char ip[INET6_ADDRSTRLEN]; > + > +if (inet_ntop(sa->sa_family, sa->sa_data, ip, sizeof ip)) { This is wrong. Giv

Re: [libvirt] [RFC PATCH] Support for qemu aio drive option

2010-04-21 Thread Matthias Dahl
On Tuesday 20 April 2010 23:23:26 Matthias Bolte wrote: > Parts that are really missing: Documenting this new domain XML > attribute in docs/formatdomain.html.in and updating the > docs/schemas/domain.rng. Once that done I would consider this patch as > complete. Thanks a lot Eric and Matthias fo

[libvirt] [PATCH v2] Support for qemu aio drive option

2010-04-21 Thread Matthias Dahl
Revised patch against libvirt 0.7.6 to support qemu's aio option. qemu allows the user to choose what io storage api should be used, either the default (threads) or native (linux aio) which in the latter case can result in better performance. This patch exposes this functionality through libvirt.

Re: [libvirt] New VM Snapshot API Not working

2010-04-21 Thread Chris Lalancette
On 04/21/2010 07:34 AM, Tej Parkash, ERS, HCLTech wrote: > All, > > Ok, I got it working. > > Problem was that I didnt include xen option for configure step. > But looks like Xen Hypervisor does not have support of Snapshot. :( > > I guess I have to fall back to save and restore method...

Re: [libvirt] Live Migration with non-shared storage for kvm

2010-04-21 Thread Cole Robinson
On 04/21/2010 03:27 AM, Kenneth Nagin wrote: > >> Cole Robinson wrote on 20/04/2010 19:10:10: > >> From: Cole Robinson >> To: Kenneth Nagin/Haifa/i...@ibmil >> Cc: list libvirt >> Date: 20/04/2010 19:10 >> Subject: Re: [libvirt] Live Migration with non-shared storage for kvm >> >> On 04/19/201

Re: [libvirt] New VM Snapshot API Not working

2010-04-21 Thread Chris Lalancette
On 04/21/2010 05:01 AM, Tej Parkash, ERS, HCLTech wrote: > All, > > I have compiled new libvirt library 0.8.0. Compilation and installation went > really fine except "make check" which has show some test got failed. Here is > what make check said. > > Failed Test: > > ---snip-

Re: [libvirt] [PATCH] Fix initial VCPU pinning in qemu driver

2010-04-21 Thread Daniel P. Berrange
On Wed, Apr 21, 2010 at 09:56:09AM +0200, Jiri Denemark wrote: > First, inital VCPU pinning is set correctly but then it is reset by > assigning qemu process to a new cgroup (which contains all CPUs). It's > easily fixed by swapping these two actions. > --- > src/qemu/qemu_driver.c |4 ++-- >

Re: [libvirt] New VM Snapshot API Not working

2010-04-21 Thread Daniel Veillard
On Wed, Apr 21, 2010 at 05:04:54PM +0530, Tej Parkash, ERS, HCLTech wrote: > All, > > Ok, I got it working. > > Problem was that I didnt include xen option for configure step. > But looks like Xen Hypervisor does not have support of Snapshot. :( > > I guess I have to fall back to save and

[libvirt] New VM Snapshot API Not working

2010-04-21 Thread Tej Parkash, ERS, HCLTech
All, I have compiled new libvirt library 0.8.0. Compilation and installation went really fine except "make check" which has show some test got failed. Here is what make check said. Failed Test: ---snip--- PASS: statstest TEST: qparamtest .

Re: [libvirt] New VM Snapshot API Not working

2010-04-21 Thread Tej Parkash, ERS, HCLTech
All, Ok, I got it working. Problem was that I didnt include xen option for configure step. But looks like Xen Hypervisor does not have support of Snapshot. :( I guess I have to fall back to save and restore method... Sorry for the noise. Thanks Tej ___

Re: [libvirt] unable to set security context (NFSv4 problem?)

2010-04-21 Thread Harald Dunkel
Hi Spencer, I could reproduce the EINVAL on the command line: srvl022:/storage# touch /storage/x srvl022:/storage# chown 110:140 /storage/x chown: changing ownership of `/storage/x': Invalid argument 110 and 140 are not valid UIDs and GIDs on the NFS server. They are defi

Re: [libvirt] Bug with creating snapshots in ESX in 0.8.0 (patch included)

2010-04-21 Thread Matthias Bolte
2010/4/21 Matthias Bolte : > 2010/4/20 Chris Wong : >> I was testing out the new snapshot on functionality with GSX (VMWare Server >> 2.0.2) and noticed that it would fail to create a snapshot on a VM with no >> snapshots. I tracked it down to the esxDomainSnapshotCreateXML call, which >> would pre

Re: [libvirt] iface-list command in virsh

2010-04-21 Thread Daniel P. Berrange
On Tue, Apr 20, 2010 at 07:38:43AM -0400, Laine Stump wrote: > On 04/19/2010 04:06 PM, Dev.Atom wrote: > >Hi, > >I'm trying to list physical interface of a remote tcp host via the C > >API and it fails. I have tried to use virsh iface-list in remote TCP > >connection and it fails also. I have try

[libvirt] [PATCH] Fix initial VCPU pinning in qemu driver

2010-04-21 Thread Jiri Denemark
First, inital VCPU pinning is set correctly but then it is reset by assigning qemu process to a new cgroup (which contains all CPUs). It's easily fixed by swapping these two actions. --- src/qemu/qemu_driver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Originally, I thought it

Re: [libvirt] Live Migration with non-shared storage for kvm

2010-04-21 Thread Kenneth Nagin
>Cole Robinson wrote on 20/04/2010 19:10:10: > From: Cole Robinson > To: Kenneth Nagin/Haifa/i...@ibmil > Cc: list libvirt > Date: 20/04/2010 19:10 > Subject: Re: [libvirt] Live Migration with non-shared storage for kvm > > On 04/19/2010 01:38 AM, Kenneth Nagin wrote: > > > > On Wed Apr 07 I s