> > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> > index 5f4adfd..cc3e3b2 100644
> > --- a/src/qemu/qemu_driver.c
> > +++ b/src/qemu/qemu_driver.c
> > @@ -3081,10 +3081,10 @@ static int qemudSecurityHook(void *data) {
> > /* This must take place before exec(), so that all QEM
> >> Support for faking emulator in qemuxml2argv tests
> >> Tests for CPU selection in qemu driver
> >
> > Argh, the tests cannot pass if libvirt is not already installed. So maybe
> > it's
> > better to move the tests to TCK after all...
>
> Can we run against an uninstalled libvirt? And i
On Thu, Apr 22, 2010 at 08:43:37AM +0200, Harald Dunkel wrote:
> On 04/21/10 20:24, Spencer Shimko wrote:
> > Harald Dunkel wrote:
> >>
> >> Do you think it would be possible to introduce a configure
> >> option '--with-dac=no'?
> >
> > I think that would be a little misleading ;) It sounds like
On Wed, Apr 21, 2010 at 11:25:48AM -0600, Eric Blake wrote:
> On 04/21/2010 10:01 AM, Chris Lalancette wrote:
> >
> > +static void qemuDomainDefNamespaceFree(void *nsdata)
> > +{
> > +qemuDomainCmdlineDefPtr cmd = nsdata;
> > +int i;
>
> s/int/unsigned int/
>
> > +static int qemuDomainD
On Wed, Apr 21, 2010 at 10:38:28PM +0200, Daniel Veillard wrote:
> On Wed, Apr 21, 2010 at 05:56:11PM +0100, Daniel P. Berrange wrote:
> > It is possible to use block devices with domain save/restore. Upon
> > failure QEMU unlinks the path being saved to. This isn't good when
> > it is a block devi
On Wed, Apr 21, 2010 at 02:49:42PM -0600, Eric Blake wrote:
> On 04/21/2010 10:56 AM, Daniel P. Berrange wrote:
> > It is possible to use block devices with domain save/restore. Upon
> > failure QEMU unlinks the path being saved to. This isn't good when
> > it is a block device !
> >
> > +stru
On Wed, Apr 21, 2010 at 11:02:33PM +0200, Daniel Veillard wrote:
> On Wed, Apr 21, 2010 at 05:56:12PM +0100, Daniel P. Berrange wrote:
> > The save process was relying on use of the shell >> append
> > operator to ensure the save data was placed after the libvirt
> > header + XML. This doesn't work
On Wed, Apr 21, 2010 at 03:03:43PM -0600, Eric Blake wrote:
> On 04/21/2010 10:56 AM, Daniel P. Berrange wrote:
> > The save process was relying on use of the shell >> append
> > operator to ensure the save data was placed after the libvirt
> > header + XML. This doesn't work for block devices thou
On Thu, Apr 22, 2010 at 11:35:17AM +0100, Daniel P. Berrange wrote:
> On Wed, Apr 21, 2010 at 02:49:42PM -0600, Eric Blake wrote:
> > On 04/21/2010 10:56 AM, Daniel P. Berrange wrote:
> > > It is possible to use block devices with domain save/restore. Upon
> > > failure QEMU unlinks the path being
On Thu, Apr 22, 2010 at 11:36:06AM +0100, Daniel P. Berrange wrote:
> On Wed, Apr 21, 2010 at 11:02:33PM +0200, Daniel Veillard wrote:
> > On Wed, Apr 21, 2010 at 05:56:12PM +0100, Daniel P. Berrange wrote:
> > > The save process was relying on use of the shell >> append
> > > operator to ensure th
On Thu, Apr 22, 2010 at 01:16:15PM +0200, Daniel Veillard wrote:
> On Thu, Apr 22, 2010 at 11:36:06AM +0100, Daniel P. Berrange wrote:
> > On Wed, Apr 21, 2010 at 11:02:33PM +0200, Daniel Veillard wrote:
> > > On Wed, Apr 21, 2010 at 05:56:12PM +0100, Daniel P. Berrange wrote:
> > > > The save proc
On Wed, Apr 21, 2010 at 02:38:33PM -0400, Stefan Berger wrote:
> Changes from V1 to V2:
[...]
> - there are 2 calls in the virNWFilterLockIface function that can fail
> due to OOM error; in case that happens, loop until the memory is
> available to avoid a failing lock. The call initializing the m
Update of
https://www.redhat.com/archives/libvir-list/2010-April/msg00912.html
Changes this time:
- Pad header/xml to multiple of 512
- Set dd block size & seek as a muliplier of that
- Invert check for block dev, to check for regular file instead
--
libvir-list mailing list
libvir-list@redh
If a transient QEMU crashes during save attempt, then the virDomainPtr
object may be freed. If a persistent QEMU crashes during save, then
the 'priv->mon' field is no longer valid since it will be inactive.
* src/qemu/qemu_driver.c: Fix two crashes when QEMU exits
during a save attempt
---
src/
It is possible to use block devices with domain save/restore. Upon
failure QEMU unlinks the path being saved to. This isn't good when
it is a block device !
* src/qemu/qemu_driver.c: Don't unlink block devices if save fails
---
src/qemu/qemu_driver.c | 22 --
1 files changed
When cgroups is enabled, access to block devices is likely to be
restricted to a whitelist. Prior to saving a guest to a block device,
it is necessary to add the block device to the whitelist. This is
not required upon restore, since QEMU reads from stdin
* src/qemu/qemu_driver.c: Add block device
The save process was relying on use of the shell >> append
operator to ensure the save data was placed after the libvirt
header + XML. This doesn't work for block devices though.
Replace this code with use of 'dd' and its 'seek' parameter.
This means that we need to pad the header + XML out to a
mu
On Wed, Apr 21, 2010 at 05:16:21PM -0400, Chris Lalancette wrote:
> On 04/21/2010 04:34 PM, Stephen Shaw wrote:
> > I'm getting a seg fault when running virsh snapshot-create 1, but only
> > when virt-manager is open and connected.
> >
> > Here is some of the debug info I was able to come up with
On Wed, Apr 21, 2010 at 05:09:31PM -0600, Eric Blake wrote:
> From: Dustin Kirkland
>
> A few fixes will help make tools/virt-pki-validate.in useful on Debian
> and Ubuntu. And one fix should be useful to everyone (see #3).
>
> 1) note our gnutls-bin package (in addition to your gnutls-utils
>
On Wed, Apr 21, 2010 at 05:22:59PM -0600, Eric Blake wrote:
> Noticed because virt-pki-validate was very inconsistent on
> using tabs vs. 8 spaces, sometimes mixing both paradigms on
> a single line.
>
> 'git diff -b' shows significant changes only in cfg.mk.
>
> * cfg.mk (sc_TAB_in_indentation):
On Wed, Apr 21, 2010 at 12:01:18PM -0400, Chris Lalancette wrote:
> Implement the qemu hooks for XML namespace data. This
> allows us to specify a qemu XML namespace, and then
> specify:
>
>
> arg
>
>
Now I see it, it looks a little odd to use the element content
for qemu:arg, while having
On Thu, Apr 22, 2010 at 12:43:28PM +0100, Daniel P. Berrange wrote:
> The save process was relying on use of the shell >> append
> operator to ensure the save data was placed after the libvirt
> header + XML. This doesn't work for block devices though.
> Replace this code with use of 'dd' and its '
On Wed, Apr 21, 2010 at 12:01:17PM -0400, Chris Lalancette wrote:
> This patch adds namespace XML parsers to be hooked into
> the main domain parser. This allows for individual hypervisor
> drivers to add per-namespace XML into the main domain XML.
>
> Signed-off-by: Chris Lalancette
> ---
> sr
On Wed, Apr 21, 2010 at 12:01:16PM -0400, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette
> ---
> src/conf/domain_conf.c | 37 +++--
> src/conf/domain_conf.h |6 --
> 2 files changed, 19 insertions(+), 24 deletions(-)
What's the reason for mak
On Wed, Apr 21, 2010 at 12:01:19PM -0400, Chris Lalancette wrote:
> Now that we have the ability to specify arbitrary qemu
> command-line parameters in the XML, use it to handle unknown
> command-line parameters when doing a native-to-xml conversion.
>
> Signed-off-by: Chris Lalancette
> ---
> s
On Thu, Apr 22, 2010 at 02:00:56PM +0200, Daniel Veillard wrote:
> On Thu, Apr 22, 2010 at 12:43:28PM +0100, Daniel P. Berrange wrote:
> > The save process was relying on use of the shell >> append
> > operator to ensure the save data was placed after the libvirt
> > header + XML. This doesn't work
On Wed, Apr 21, 2010 at 12:01:20PM -0400, Chris Lalancette wrote:
> Add the library entry point for the new virDomainQemuMonitorCommand()
> entry point. Because this is not part of the "normal" libvirt API,
> it gets it's own header file, library file, and will eventually
> get it's own over-the-w
On Wed, Apr 21, 2010 at 05:16:21PM -0400, Chris Lalancette wrote:
> On 04/21/2010 04:34 PM, Stephen Shaw wrote:
> > I'm getting a seg fault when running virsh snapshot-create 1, but only
> > when virt-manager is open and connected.
> >
> > Here is some of the debug info I was able to come up with
On 04/22/2010 08:34 AM, Daniel P. Berrange wrote:
> On Wed, Apr 21, 2010 at 05:16:21PM -0400, Chris Lalancette wrote:
>> On 04/21/2010 04:34 PM, Stephen Shaw wrote:
>>> I'm getting a seg fault when running virsh snapshot-create 1, but only
>>> when virt-manager is open and connected.
>>>
>>> Here i
On Thu, Apr 22, 2010 at 08:54:30AM -0400, Chris Lalancette wrote:
> On 04/22/2010 08:34 AM, Daniel P. Berrange wrote:
> > On Wed, Apr 21, 2010 at 05:16:21PM -0400, Chris Lalancette wrote:
> >> On 04/21/2010 04:34 PM, Stephen Shaw wrote:
> >>> I'm getting a seg fault when running virsh snapshot-crea
Hi Daniel,
On 04/22/10 11:41, Daniel P. Berrange wrote:
>
> This is unfixably broken then. NFS security relies on all clients using
> the same UID/GID <-> name mappings.
>
How comes that we don't run into a similar security problem
for iSCSI?
Regards
Harri
--
libvir-list mailing list
libvir
On Thu, Apr 22, 2010 at 07:09, Daniel P. Berrange wrote:
> On Thu, Apr 22, 2010 at 08:54:30AM -0400, Chris Lalancette wrote:
>> On 04/22/2010 08:34 AM, Daniel P. Berrange wrote:
>> > On Wed, Apr 21, 2010 at 05:16:21PM -0400, Chris Lalancette wrote:
>> >> On 04/21/2010 04:34 PM, Stephen Shaw wrote:
On Thu, Apr 22, 2010 at 03:16:08PM +0200, Harald Dunkel wrote:
> Hi Daniel,
>
> On 04/22/10 11:41, Daniel P. Berrange wrote:
> >
> > This is unfixably broken then. NFS security relies on all clients using
> > the same UID/GID <-> name mappings.
> >
>
> How comes that we don't run into a similar
On 04/22/2010 09:19 AM, Stephen Shaw wrote:
> On Thu, Apr 22, 2010 at 07:09, Daniel P. Berrange wrote:
>> On Thu, Apr 22, 2010 at 08:54:30AM -0400, Chris Lalancette wrote:
>>> On 04/22/2010 08:34 AM, Daniel P. Berrange wrote:
On Wed, Apr 21, 2010 at 05:16:21PM -0400, Chris Lalancette wrote:
>
On Thu, Apr 22, 2010 at 09:39:57AM -0400, Chris Lalancette wrote:
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 5f4adfd..4ec4bd6 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -11034,18 +11040,18 @@ static int
> qemuDomainRevertToSnapshot(virDoma
On 04/22/10 15:39, Daniel P. Berrange wrote:
>
> In iSCSI the user/group IDs are assigned to the block device nodes which
> are always local to each client logged into the iSCSI server. Thus there
> is no requirement for the same interpretation on all clients
>
You mean that iSCSI keeps authen
On Thu, Apr 22, 2010 at 02:12:22PM +0200, Daniel Veillard wrote:
> On Thu, Apr 22, 2010 at 02:00:56PM +0200, Daniel Veillard wrote:
> > On Thu, Apr 22, 2010 at 12:43:28PM +0100, Daniel P. Berrange wrote:
> > > The save process was relying on use of the shell >> append
> > > operator to ensure the s
Thanks a lot for your detailed feedback!
On Tue, Apr 20, 2010 at 07:42:45PM +0200, Jim Meyering wrote:
> Satoru SATOH wrote:
> > This patch adds the files implements dnsmasq (hostsfile) module.
>
> Here is some feedback not on the overall structure or utility,
> but more on a few implementation d
The comment in qemuDomainWaitForMigrationComplete says we are polling
every 50ms but the code sleeps only for 50us. This was already discussed
during review but apparently forgotten when the series was pushed.
---
src/qemu/qemu_driver.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
[adding bug-coreutils]
On 04/22/2010 04:37 AM, Daniel P. Berrange wrote:
>>> -if (virAsprintf(&dest, "exec:%s >>%s 2>/dev/null", argstr,
>>> safe_target) < 0) {
>>> +if (virAsprintf(&dest, "exec:%s | dd of=%s seek=%llub",
>>> +argstr, safe_target, offset) < 0) {
>>
>>
The following series of patches is a prototype implementation of dnsmasq
module.
It implements an idea to save dhcp hosts' macaddr vs. ipaddr mappings to
static file and make dnsmasq loading it with "--dhcp-hostsfile" option,
originally suggested by Dan-san, and can address the problem that too
ma
On Thu, Apr 22, 2010 at 07:55, Daniel P. Berrange wrote:
> On Thu, Apr 22, 2010 at 09:39:57AM -0400, Chris Lalancette wrote:
>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>> index 5f4adfd..4ec4bd6 100644
>> --- a/src/qemu/qemu_driver.c
>> +++ b/src/qemu/qemu_driver.c
Ok, I jus
This patch adds build support for the dnsmasq module.
Signed-off-by: Satoru SATOH
---
po/POTFILES.in |1 +
src/Makefile.am |1 +
src/libvirt_private.syms |9 +
3 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.in
On Thu, Apr 22, 2010 at 04:34:54PM +0200, Jiri Denemark wrote:
> The comment in qemuDomainWaitForMigrationComplete says we are polling
> every 50ms but the code sleeps only for 50us. This was already discussed
> during review but apparently forgotten when the series was pushed.
> ---
> src/qemu/qe
This patch adds the files implements dnsmasq (hostsfile) module.
Signed-off-by: Satoru SATOH
---
src/util/dnsmasq.c | 330
src/util/dnsmasq.h | 59 +
2 files changed, 389 insertions(+), 0 deletions(-)
create mode 100644 src/util/d
From: Jiri Denemark
The hang fix in d376b7d63ec1ef24ba4c812d58b9a414ddb561f8 was incomplete
since it left quite a few {Enter,Exit}Monitor calls which require driver
to be unlocked. Since the driver is locked throughout the whole
function, {Enter,Exit}MonitorWithDriver need to be used instead to
e
On Thu, Apr 22, 2010 at 08:39:26AM -0600, Eric Blake wrote:
> [adding bug-coreutils]
>
> On 04/22/2010 04:37 AM, Daniel P. Berrange wrote:
> >>> -if (virAsprintf(&dest, "exec:%s >>%s 2>/dev/null", argstr,
> >>> safe_target) < 0) {
> >>> +if (virAsprintf(&dest, "exec:%s | dd of=%s seek=%ll
This patch makes dnsmasq daemon started from libvirtd with a
--dhcp-hostsfile option instead of --dhcp-host options for each
'//ip/dhcp/host' entries defined in network xml file.
Remaining issues:
* when and where to save hostsfiles
Signed-off-by: Satoru SATOH
---
src/network/bridge_driver.
* tests/testutilsqemu.c (testQemuCapsInit): Initialize variables.
---
Gcc on F12 caught this, sorry I didn't catch it in the review:
> -if ((machines = testQemuAllocMachines(&nmachines)) == NULL)
> +if ((caps->host.cpu = virCPUDefCopy(&host_cpu)) == NULL ||
> +(machines = testQemu
Support for live migration between hosts that do not share storage was
added to qemu-kvm release 0.12.1.
It supports two flags:
-b migration without shared storage with full disk copy
-i migration without shared storage with incremental copy (same base image
shared between source and destination).
the problem is because of new version of qemu, the name of devices isn't
ide0-0-, is drive-ide0-0-1.
2010/4/22 Jorge Alejandro RodrÃguez
> I can't attach a cd when a vm is running with qemu 0.12.3 (ubuntu 10.04),
> the problem is not with qemu because when I start the vm with kvm command
> (with
On 04/22/2010 05:53 AM, Daniel Veillard wrote:
> On Wed, Apr 21, 2010 at 05:09:31PM -0600, Eric Blake wrote:
>> From: Dustin Kirkland
>>
>> A few fixes will help make tools/virt-pki-validate.in useful on Debian
>> and Ubuntu. And one fix should be useful to everyone (see #3).
>>
>
> ACK,
Thanks
The events demo program is slightly misleading printing
myDomainEventCallback1 EVENT: Domain f14i686(-1) Added
which is not distinguishing Add vs Update events. It should have
been doing
myDomainEventCallback1 EVENT: Domain f14i686(-1) Defined Updated
* examples/domain-events/events-python/
Checking git history since the release of 0.8.0, I'm seeing an
impressive set of bug fixes and cleanups, and relatively few actual
features changes. So I think it's sensible to try to make a new release
0.8.1 basically a 0.8.0 fixed version, and in a relatively short
timeframe. To try to realign
The text monitor code was checking for a '\n' prefix on several
places. Previously this would work, but since the monitor code
re-write the '\n' is already stripped off, so mustn't be checked
for.
* src/qemu/qemu_monitor_text.c: Fix monitor error checking
---
src/qemu/qemu_monitor_text.c | 14 +
Probably as a result of a merge error, the CPU hotplug command
names were completely wrong.
* src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_text.c: Fix
the CPU hotplug command names
---
src/qemu/qemu_monitor_json.c |2 +-
src/qemu/qemu_monitor_text.c |4 ++--
2 files changed, 3 in
On 04/22/2010 09:49 AM, Daniel P. Berrange wrote:
> Probably as a result of a merge error, the CPU hotplug command
> names were completely wrong.
>
> * src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_text.c: Fix
> the CPU hotplug command names
> ---
> src/qemu/qemu_monitor_json.c |2 +-
On 04/22/2010 09:49 AM, Daniel P. Berrange wrote:
> The text monitor code was checking for a '\n' prefix on several
> places. Previously this would work, but since the monitor code
> re-write the '\n' is already stripped off, so mustn't be checked
> for.
>
> * src/qemu/qemu_monitor_text.c: Fix mon
On Thu, Apr 22, 2010 at 04:49:00PM +0100, Daniel P. Berrange wrote:
> Probably as a result of a merge error, the CPU hotplug command
> names were completely wrong.
>
> * src/qemu/qemu_monitor_json.c, src/qemu/qemu_monitor_text.c: Fix
> the CPU hotplug command names
> ---
> src/qemu/qemu_monitor
On Thu, Apr 22, 2010 at 04:49:01PM +0100, Daniel P. Berrange wrote:
> The text monitor code was checking for a '\n' prefix on several
> places. Previously this would work, but since the monitor code
> re-write the '\n' is already stripped off, so mustn't be checked
> for.
>
> * src/qemu/qemu_monit
On Thu, Apr 22, 2010 at 04:33:43PM +0100, Daniel P. Berrange wrote:
> The events demo program is slightly misleading printing
>
> myDomainEventCallback1 EVENT: Domain f14i686(-1) Added
>
> which is not distinguishing Add vs Update events. It should have
> been doing
>
> myDomainEventCallback
On Thu, Apr 22, 2010 at 04:56:00PM +0200, y...@orkuz.home wrote:
> From: Jiri Denemark
>
> The hang fix in d376b7d63ec1ef24ba4c812d58b9a414ddb561f8 was incomplete
> since it left quite a few {Enter,Exit}Monitor calls which require driver
> to be unlocked. Since the driver is locked throughout the
In cases where the security driver failed to restore a label after a
guest has saved, we mistakenly jumped to the error cleanup paths.
This is not good, because the operation has in fact completed and
cannot be rolled back completely. Label restore is non-critical, so
just log the problem instead.
Adds a minimal test case which verifies that it is possible to
set the CPU count to max, and then back to the min. This really
needs libguestfs integration to validate that the guest sees the
change
---
scripts/domain/130-cpu-hotplug.t | 78 ++
1 files changed
The hang fix in d376b7d63ec1ef24ba4c812d58b9a414ddb561f8 was incomplete
since it left quite a few {Enter,Exit}Monitor calls which require driver
to be unlocked. Since the driver is locked throughout the whole
function, {Enter,Exit}MonitorWithDriver need to be used instead to
ensure driver is not lo
On 04/22/2010 10:24 AM, Daniel P. Berrange wrote:
> Adds a minimal test case which verifies that it is possible to
> set the CPU count to max, and then back to the min. This really
> needs libguestfs integration to validate that the guest sees the
> change
> ---
> scripts/domain/130-cpu-hotplug.t
On 04/22/2010 10:45 AM, Stephen Shaw wrote:
> On Thu, Apr 22, 2010 at 07:55, Daniel P. Berrange wrote:
>> On Thu, Apr 22, 2010 at 09:39:57AM -0400, Chris Lalancette wrote:
>>> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
>>> index 5f4adfd..4ec4bd6 100644
>>> --- a/src/qemu/qemu_dri
On Thu, Apr 22, 2010 at 10:49, Chris Lalancette wrote:
> On 04/22/2010 10:45 AM, Stephen Shaw wrote:
>> On Thu, Apr 22, 2010 at 07:55, Daniel P. Berrange
>> wrote:
>>> On Thu, Apr 22, 2010 at 09:39:57AM -0400, Chris Lalancette wrote:
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_drive
On 04/21/2010 11:44 AM, spen...@beyondabstraction.net wrote:
> * Fix a logic error in configure.ac that prevented --with-selinux=no from
> being used with --with-secdriver-selinux=no.
>
> * Fix some strings to clarify the difference between --with-selinux and
> --with-secdriver-selinux.
>
> @@
On Thu, Apr 22, 2010 at 06:37:55PM +0200, Jiri Denemark wrote:
> The hang fix in d376b7d63ec1ef24ba4c812d58b9a414ddb561f8 was incomplete
> since it left quite a few {Enter,Exit}Monitor calls which require driver
> to be unlocked. Since the driver is locked throughout the whole
> function, {Enter,Ex
On Thu, Apr 22, 2010 at 10:41:34AM -0600, Eric Blake wrote:
> On 04/22/2010 10:24 AM, Daniel P. Berrange wrote:
> > Adds a minimal test case which verifies that it is possible to
> > set the CPU count to max, and then back to the min. This really
> > needs libguestfs integration to validate that th
> > The hang fix in d376b7d63ec1ef24ba4c812d58b9a414ddb561f8 was incomplete
> > since it left quite a few {Enter,Exit}Monitor calls which require driver
> > to be unlocked. Since the driver is locked throughout the whole
> > function, {Enter,Exit}MonitorWithDriver need to be used instead to
> > ens
> Gcc on F12 caught this, sorry I didn't catch it in the review:
>
> > -if ((machines = testQemuAllocMachines(&nmachines)) == NULL)
> > +if ((caps->host.cpu = virCPUDefCopy(&host_cpu)) == NULL ||
> > +(machines = testQemuAllocMachines(&nmachines)) == NULL)
> > goto cleanup
> > The comment in qemuDomainWaitForMigrationComplete says we are polling
> > every 50ms but the code sleeps only for 50us. This was already discussed
> > during review but apparently forgotten when the series was pushed.
>
> Oh, yes I remember,
>
> ACK
Pushed, thanks.
Jirka
--
libvir-list m
> > The hang fix in d376b7d63ec1ef24ba4c812d58b9a414ddb561f8 was incomplete
> > since it left quite a few {Enter,Exit}Monitor calls which require driver
> > to be unlocked. Since the driver is locked throughout the whole
> > function, {Enter,Exit}MonitorWithDriver need to be used instead to
> > ens
* Fix for the bug reported at:
https://bugzilla.redhat.com/show_bug.cgi?id=573908
---
src/conf/storage_encryption_conf.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/conf/storage_encryption_conf.c
b/src/conf/storage_encryption_conf.c
index ed71688..7f68d67 10
I just pushed the following trivial patch to fix a problem with indentation in
the domain XML. The problem was reported as:
https://bugzilla.redhat.com/show_bug.cgi?id=573908
Dave
David Allan (1):
Properly indent encryption tags
src/conf/storage_encryption_conf.c |6 +++---
1 files ch
On 04/09/2010 09:27 AM, Daniel P. Berrange wrote:
On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote:
Hello,
In response to a lot of the talk of qemud lately on qemu-devel, the
libvirt community would like to put forward a proposal to help enable
debug/advanced options wh
On 04/12/2010 07:23 AM, Jamie Lokier wrote:
Daniel Veillard wrote:
On Sun, Apr 11, 2010 at 11:17:38PM +0100, Jamie Lokier wrote:
It's not that hard to write this for trivial extra options:
/bin/sh -c 'qemu "$0" "$@" -extra-flag'
(if that works).
That won't work becau
On 04/12/2010 10:20 AM, Luiz Capitulino wrote:
On Fri, 9 Apr 2010 15:27:17 +0100
"Daniel P. Berrange" wrote:
On Fri, Apr 09, 2010 at 09:41:39AM -0400, Chris Lalancette wrote:
Hello,
In response to a lot of the talk of qemud lately on qemu-devel, the
libvirt community would lik
On 04/22/2010 01:45 PM, Anthony Liguori wrote:
Which in turn, could be embedded as:
myguest
...
Operon_G3
5
AuthenticAMD
With respect to injecting QMP commands directly, I think the proposed
debug API is probably reasonable. We could build a libqemu that used
that API as a transport w
Daniel Veillard wrote on 04/22/2010 07:41:47 AM:
>
> [...]
> >
> > +if (virNWFilterLockIface(req->ifname))
> > + goto err_no_lock;
> > +
>
> As long as the error is caught when used, and properly propagated
> that strategy is correct IMHO.
>
> otherwise, patch looks okay to me,
On 04/21/2010 11:44 AM, spen...@beyondabstraction.net wrote:
> * The error messages coming from qemu's DAC support contain strings from the
> original SELinux security driver code. This just removes references to
> "security context" and other SELinux-isms from the DAC code.
That's a long line;
2010/4/21 Eric Blake :
> The user probably doesn't care what the gai error numbers are, as
> much as what the failed conversion IP address was.
>
> * src/remote/remote_driver.c (addrToString): Mention which address
> could not be converted.
> * daemon/remote.c (addrToString): Likewise.
> ---
>
> Ch
On 04/22/2010 02:33 PM, Matthias Bolte wrote:
>> +char ip[INET6_ADDRSTRLEN];
>> +
>> +if (inet_ntop(sa->sa_family,
>> + (sa->sa_family == AF_INET
>> + ? (void *)&((struct sockaddr_in *)sa)->sin_addr
>> + : (void *)&((s
On 04/22/10 20:47, Anthony Liguori wrote:
> On 04/12/2010 07:23 AM, Jamie Lokier wrote:
>> Some simple but versatile hook ideas:
>>
>> - (no space splitting, one option,
>> appended)
>> - (space splitting multiple options)
>> -
>> -
>> -VALUE
>
> I'd strongly suggest not foc
86 matches
Mail list logo
