Re: [libvirt] 'dommemstat' is not working for LXC hypervisor.

2010-04-30 Thread Ryota Ozaki
On Fri, Apr 30, 2010 at 12:43 PM, Kumar L Srikanth-B22348 b22...@freescale.com wrote: Thanks for your time Ozaki. But, I am new to libvirt. Can you please let me know how can we enable memory.use_hierarchy for every creation of libvirt/lxc/domain/? Oh I'm sorry for confusing you, the solution

Re: [libvirt] [PATCH] Ignore qemu STOP event when stopping CPUs

2010-04-30 Thread Jiri Denemark
By setting vm-status to PAUSED before actually sending the request to qemu (and resetting it back if the request fails) we can ignore the event since the event handler does nothing when the guest is already paused. This solution is quite hacky but unfortunately it's the best

Re: [libvirt] [PATCH v2] nwfilter: Also pick IP address from a DHCP ACK message

2010-04-30 Thread Daniel Veillard
On Thu, Apr 29, 2010 at 09:39:15AM -0400, Stefan Berger wrote: The local DHCP server on virtbr0 sends DHCP ACK messages when a VM is started and requests an IP address while the initial DHCP lease on the VM's MAC address hasn't expired. So, also pick the IP address of the VM if that type of

[libvirt] [PATCH] Report all errors in SELinuxRestoreSecurityFileLabel

2010-04-30 Thread jdenemar
From: Jiri Denemark jdene...@redhat.com --- src/security/security_selinux.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 3e20475..1aabb20 100644 --- a/src/security/security_selinux.c +++

Re: [libvirt] [PATCH v2] nwfilter: Also pick IP address from a DHCP ACK message

2010-04-30 Thread Stefan Berger
Daniel Veillard veill...@redhat.com wrote on 04/30/2010 07:50:02 AM: Please respond to veillard [...] -case 53: /* Message type */ +case DHCP_OPT_MESSAGETYPE: /* Message type */ if (dhcp_opts_len = 3) { uint8_t *val = (uint8_t

Re: [libvirt] [PATCH] Add support for another explicit IO error event

2010-04-30 Thread Daniel Veillard
On Thu, Apr 29, 2010 at 05:44:28PM +0100, Daniel P. Berrange wrote: This introduces a new event type VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON This event is the same as the previous VIR_DOMAIN_ID_IO_ERROR event, but also includes a string describing the cause of the event. Thus there is a

Re: [libvirt] [patch 1/3] Clean all tables before applying basic rules

2010-04-30 Thread Daniel Veillard
On Thu, Apr 29, 2010 at 09:34:46PM -0400, Stefan Berger wrote: The functions invoked by the IP address learning thread that apply some basic filtering rules did not clean up any previous filtering rules that may still be there (due to a libvirt restart for example). With the patch below all

Re: [libvirt] [patch 2/3] Syncronize the teardown of rules with the thread

2010-04-30 Thread Daniel Veillard
On Thu, Apr 29, 2010 at 09:34:47PM -0400, Stefan Berger wrote: Introduce a function to notify the IP address learning thread to terminate and thus release the lock on the interface. Notify the thread before grabbing the lock on the interface and tearing down the rules. This prevents a 'virsh

Re: [libvirt] [patch 3/3] Prevent updates while IP address learn thread is running

2010-04-30 Thread Daniel Veillard
On Thu, Apr 29, 2010 at 09:34:48PM -0400, Stefan Berger wrote: Prevent updating and tearing down of filter while the IP address learning thread is running and has its own filtering rules applied. Signed-off-by: Stefan Berger stef...@us.ibm.com Index:

Re: [libvirt] [PATCH] Report all errors in SELinuxRestoreSecurityFileLabel

2010-04-30 Thread Daniel Veillard
On Fri, Apr 30, 2010 at 01:50:10PM +0200, jdene...@redhat.com wrote: From: Jiri Denemark jdene...@redhat.com --- src/security/security_selinux.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/security/security_selinux.c

Re: [libvirt] [PATCH] virFileHasSuffix case sensitivity

2010-04-30 Thread Daniel Veillard
On Thu, Apr 29, 2010 at 04:04:25PM +1200, Paul Dorman wrote: Hi Eric, sure. Here you go. Please let me know if there's anything else I need to do. diff --git a/src/util/util.c b/src/util/util.c index a7bb67c..3209185 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1153,7 +1153,7

Re: [libvirt] [PATCH] Report all errors in SELinuxRestoreSecurityFileLabel

2010-04-30 Thread Jiri Denemark
src/security/security_selinux.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) ACK, thanks ! Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [patch 1/3] Clean all tables before applying basic rules

2010-04-30 Thread Stefan Berger
Daniel Veillard veill...@redhat.com wrote on 04/30/2010 07:59:39 AM: Okay, I had to double check that ebiptablesExecCLI() reall freed the passed buffer content in all case, looks fine, ACK, Pushed. Stefan Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit

Re: [libvirt] [patch 2/3] Syncronize the teardown of rules with the thread

2010-04-30 Thread Stefan Berger
Daniel Veillard veill...@redhat.com wrote on 04/30/2010 08:00:46 AM: [...] }; int virNWFilterLearnIPAddress(virNWFilterTechDriverPtr techdriver, ACK, Pushed. Stefan Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/

Re: [libvirt] [patch 3/3] Prevent updates while IP address learn thread is running

2010-04-30 Thread Stefan Berger
Daniel Veillard veill...@redhat.com wrote on 04/30/2010 08:01:50 AM: Looks fine, ACK, Pushed. Thanks. Stefan Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com | Rpmfind RPM search engine http://rpmfind.net/

Re: [libvirt] (Resend) Live Migration with non-shared storage for kvm

2010-04-30 Thread Cole Robinson
On 04/22/2010 11:06 AM, Kenneth Nagin wrote: Support for live migration between hosts that do not share storage was added to qemu-kvm release 0.12.1. It supports two flags: -b migration without shared storage with full disk copy -i migration without shared storage with incremental copy (same

[libvirt] [PATCHv2 3/2] autobuild.sh: use VPATH build

2010-04-30 Thread Eric Blake
Try to avoid future regressions on the VPATH front. * autobuild.sh: Uncomment VPATH use. Suggested by Daniel P. Berrange. --- Suggested in IRC; I'm still in the midst of testing it out on a fresh git clone. autobuild.sh |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff

Re: [libvirt] [PATCHv2 3/2] autobuild.sh: use VPATH build

2010-04-30 Thread Eric Blake
On 04/30/2010 08:55 AM, Eric Blake wrote: +++ b/autobuild.sh @@ -10,9 +10,9 @@ test -n $1 RESULTS=$1 || RESULTS=results.log test -f Makefile make -k distclean || : rm -rf coverage -#rm -rf build -#mkdir build -#cd build +rm -rf build +mkdir build +cd build ./autogen.sh

Re: [libvirt] (Resend) Live Migration with non-shared storage for kvm

2010-04-30 Thread Eric Blake
On 04/30/2010 06:42 AM, Cole Robinson wrote: Other than that, the code generally looks like (except for the compiler and syntax-check warnings). - Cole (Here's the patch inline for the benefit of other reviewers) In addition to Cole's comments, here's some style nits that 'make

[libvirt] [PATCH] pci: Give an explicit error if device not found

2010-04-30 Thread Cole Robinson
Signed-off-by: Cole Robinson crobi...@redhat.com --- src/util/pci.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/src/util/pci.c b/src/util/pci.c index 81193b7..e1e11bc 100644 --- a/src/util/pci.c +++ b/src/util/pci.c @@ -1028,6 +1028,7 @@

[libvirt] [PATCH] domain: Fix PCI address decimal parsing regression

2010-04-30 Thread Cole Robinson
hostdev address parsing previously attempted to detect the number base: currently it is hardcoded to base 16, which can break PCI assignment via virt-manager. Revert to the previous behavior. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/conf/domain_conf.c |8 1 files

[libvirt] [PATCH] qemu: Report cmdline output if VM dies early

2010-04-30 Thread Cole Robinson
qemuReadLogOutput early VM death detection is racy and won't always work. Startup then errors when connecting to the VM monitor. This won't report the emulator cmdline output which is typically the most useful diagnostic. Check if the VM has died at the very end of the monitor connection step,

Re: [libvirt] [PATCH] domain: Fix PCI address decimal parsing regression

2010-04-30 Thread Daniel Veillard
On Fri, Apr 30, 2010 at 11:44:18AM -0400, Cole Robinson wrote: hostdev address parsing previously attempted to detect the number base: currently it is hardcoded to base 16, which can break PCI assignment via virt-manager. Revert to the previous behavior. Signed-off-by: Cole Robinson

[libvirt] [PATCH] autobuild.sh: provide default prefix

2010-04-30 Thread Eric Blake
Without this patch and with a clean environment, ./autobuild.sh tried to use ./configure --prefix=/, and fails. * autobuild.sh (AUTOBUILD_INSTALL_ROOT): Provide sensible default. Suggested by Daniel P. Berrange. --- autobuild.sh |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff

Re: [libvirt] [PATCH] autobuild.sh: provide default prefix

2010-04-30 Thread Daniel P. Berrange
On Fri, Apr 30, 2010 at 10:58:24AM -0600, Eric Blake wrote: Without this patch and with a clean environment, ./autobuild.sh tried to use ./configure --prefix=/, and fails. * autobuild.sh (AUTOBUILD_INSTALL_ROOT): Provide sensible default. Suggested by Daniel P. Berrange. --- autobuild.sh

Re: [libvirt] [PATCH] autobuild.sh: provide default prefix

2010-04-30 Thread Eric Blake
On 04/30/2010 11:07 AM, Daniel P. Berrange wrote: +++ b/autobuild.sh @@ -6,6 +6,7 @@ set -v # Make things clean. test -n $1 RESULTS=$1 || RESULTS=results.log +: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder} test -f Makefile make -k distclean || : rm -rf coverage ACK Pushed. Looks

[libvirt] Release of libvirt-0.8.1

2010-04-30 Thread Daniel Veillard
As planned, here is the 0.8.1 bug fix release, available from libvirt.org FTP: ftp://libvirt.org/libvirt/ As planned it's rather light on features but includes a very large set of bug fixes, cleanups and portability enhancements, Features: - Add virDomainGetBlockInfo API to query disk

Re: [libvirt] [PATCH] autobuild.sh: provide default prefix

2010-04-30 Thread Daniel Veillard
On Fri, Apr 30, 2010 at 11:20:58AM -0600, Eric Blake wrote: On 04/30/2010 11:07 AM, Daniel P. Berrange wrote: +++ b/autobuild.sh @@ -6,6 +6,7 @@ set -v # Make things clean. test -n $1 RESULTS=$1 || RESULTS=results.log +: ${AUTOBUILD_INSTALL_ROOT=$HOME/builder} test -f Makefile

[libvirt] [PATCH] Fix memory leaks in cmdInterfaceEdit and cmdNWFilterEdit.

2010-04-30 Thread Laine Stump
This applies a fix to thos functions similar to that made to cmdEdit in 270895063d1cf86ab42fa220a8d090c24d58dbc0, thus fnixing a memory leak - if tmp is unlinked and NULLed early in the function, the memory used by tmp is never freed. Since we will always unlink tmp prior to freeing its memory at

Re: [libvirt] [PATCH] Fix a virsh edit memory leak

2010-04-30 Thread Laine Stump
On 04/28/2010 04:27 PM, Chris Lalancette wrote: When running virsh edit, we are unlinking and setting the tmp variable to NULL before going to the end of the function, meaning that we never free tmp. Since the exit to the function will always unlink and free tmp, just remove this bit of code