Ph: +972-4-8296227
Cell: 054-6976227
Fx: +972-4- 8296113
"Do not look back in anger, or forward in fear, but around in awareness."
--James Thurber
Eric Blake wrote on 05/05/2010 01:04:23:
> From: Eric Blake
> To: Cole Robinson
> Cc: Kenneth Nagin/Haifa/i...@ibmil, list libvirt
> Date: 05/
Detected by clang. POSIX requires that the second argument to
va_start be the name of the last variable; and in some implementations,
passing *path instead of path would dereference bogus memory instead
of pulling arguments off the stack.
* src/util/util.c (virBuildPathInternal): Use correct argu
On 05/03/2010 07:52 AM, Cole Robinson wrote:
> On 05/03/2010 04:13 AM, Kenneth Nagin wrote:
>>
>
> ...
>
>> This the patch file:
>> (See attached file: libvirt_migration_ns_100503.patch)
>>
>
> ACK, patch looks fine now.
Kenneth,
I added a commit message, broke a few lines to fit in 80 columns
81 patches to gnulib, picks up several new syntax checks.
* .gnulib: Update to latest.
* .x-sc_prohibit_always_true_header_tests: New file.
* bootstrap.conf (gnulib_modules): Add sched.
* src/util/processinfo.c (includes): is now guaranteed.
* src/network/bridge_driver.c (includes): Drop useless
* bootstrap.conf (gnulib_modules): Add uname.
* configure.ac: Drop uname and sys/utsname.h checks.
* src/nodeinfo.c (nodeGetInfo): Use uname unconditionally.
---
bootstrap.conf |1 +
configure.ac |4 ++--
src/nodeinfo.c | 12 ++--
3 files changed, 5 insertions(+), 12 deletions(
* configure.ac (AC_CHECK_FUNCS_ONCE, AC_SYS_LARGEFILE): Rely on
gnulib for strtok_r and large file support.
(AC_OBJEXT): Drop call now done by AC_PROG_CC.
(m4_foreach_w): Drop macro guaranteed by gnulib.
(AC_C_CONST): Drop call declared obsolete by autoconf.
Signed-off-by: Eric Blake
---
configu
* configure.ac: Drop sys/wait.h check.
* src/libvirt.c (includes): Use header unconditionally.
* src/remote/remote_driver.c (includes): Likewise.
* src/storage/storage_backend.c (includes): Likewise.
* src/util/ebtables.c (includes): Likewise.
* src/util/hooks.c (includes): Likewise.
* src/util/ipt
Gnulib can guarantee that pthread.h exists, but for now, it is a dummy
header with no support for most pthread_* functions. Modify our
use of pthread to use function checks, rather than header checks,
to determine how much pthread support is present.
* bootstrap.conf (gnulib_modules): Add pthread
This replaces the first cut at this series:
https://www.redhat.com/archives/libvir-list/2010-April/msg01341.html
Changes since v1:
squash the original 1/5 and 2/5 into one patch
test every stage of the series on a cross-compile to mingw
add new 5/5, and adjust to recent syntax checks available in
On 04/30/2010 09:44 AM, Cole Robinson wrote:
> @@ -1028,6 +1028,7 @@ pciGetDevice(unsigned domain,
> unsigned function)
> {
> pciDevice *dev;
> +char devdir[PATH_MAX];
Using PATH_MAX as an array size is dangerous; it fails on GNU Hurd where
there is no minimum size. Also,
On 04/30/2010 09:44 AM, Cole Robinson wrote:
> qemuReadLogOutput early VM death detection is racy and won't always work.
> Startup then errors when connecting to the VM monitor. This won't report
> the emulator cmdline output which is typically the most useful diagnostic.
>
> Check if the VM has d
Resending, as the previous one hasn't appeared after waiting for more than a
day. My apologies if this is duplicate.
Hello,
We plan to develop a fancy GUI which would help creating and managing
VMs/Domains for RHEL 5.4 KVM.
However looking at the schemas provided in docs/schemas/ (Ex:
domain.rng
On 04/05/10 18:08, Cole Robinson wrote:
> On 05/04/2010 12:38 PM, Matthew Booth wrote:
>> FYI for the list. I haven't looked at this yet.
>>
>> Matt
>>
>> Original Message
>> Subject: Re: need your help about virito vmchannel
>> Date: Tue, 4 May 2010 18:00:02 +0530
>> From: Amit S
Right now, mingw32-portablexdr is not available in Fedora, but is
present in fedora-mingw.git. With that package, plus
redhat-rpm-config and this patch, it is once again possible to build
mingw32-libvirt from a Fedora 12 host.
* mingw32-libvirt.spec.in (__debug_install_post): Override.
(%files):
On Tue, May 04, 2010 at 01:08:53PM -0400, Cole Robinson wrote:
> On 05/04/2010 12:38 PM, Matthew Booth wrote:
> > FYI for the list. I haven't looked at this yet.
> >
> > Matt
> >
> > Original Message
> > Subject: Re: need your help about virito vmchannel
> > Date: Tue, 4 May 201
On 05/04/2010 12:38 PM, Matthew Booth wrote:
> FYI for the list. I haven't looked at this yet.
>
> Matt
>
> Original Message
> Subject: Re: need your help about virito vmchannel
> Date: Tue, 4 May 2010 18:00:02 +0530
> From: Amit Shah
> To: Matthew Booth
> CC: Jianlin Liu
>
On 05/04/2010 02:54 AM, Daniel Veillard wrote:
> On Tue, May 04, 2010 at 01:41:55AM +0200, Matthias Bolte wrote:
>> When cross-compiling on Linux, configure will misdetect the target as
>> Linux because it uses uname instead of relying on the $host variable.
>> This results in including libvirt_lin
FYI for the list. I haven't looked at this yet.
Matt
Original Message
Subject: Re: need your help about virito vmchannel
Date: Tue, 4 May 2010 18:00:02 +0530
From: Amit Shah
To: Matthew Booth
CC: Jianlin Liu
On (Tue) May 04 2010 [13:18:30], Matthew Booth wrote:
> On 04/05/10
> > Wipe generated interface target only when reading configuration of
> > inactive domains.
>
> ACK.
Thanks, pushed.
Jirka
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Tue, May 04, 2010 at 05:18:24PM +0200, Wolfgang Mauerer wrote:
> Detaching disk devices is not only possible for VIR_DOMAIN_DISK_BUS_VIRTIO,
> but also for VIR_DOMAIN_DISK_BUS_SCSI, so take care of this possibility.
>
> Additionally, when the new-style device syntax is used, we do not need to
>
Detaching disk devices is not only possible for VIR_DOMAIN_DISK_BUS_VIRTIO,
but also for VIR_DOMAIN_DISK_BUS_SCSI, so take care of this possibility.
Additionally, when the new-style device syntax is used, we do not need to
check if the PCI address is valid since we don't need it to do the
hot-unpl
On 05/04/2010 08:39 AM, jdene...@redhat.com wrote:
> From: Jiri Denemark
>
> Wipe generated interface target only when reading configuration of
> inactive domains.
> ---
> src/conf/domain_conf.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/src/conf/domain_conf
From: Jiri Denemark
Wipe generated interface target only when reading configuration of
inactive domains.
---
src/conf/domain_conf.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 546ddf2..3e45f79 100644
--- a/src/c
On 05/04/2010 03:14 AM, Daniel Veillard wrote:
> This includes various things:
> - fix the Requires: libvirt-client to use %{name} to allow easy renaming
> - when building ESX support one need libcurl-devel
> - remove Makefile[.in] from xml/nwfilter in the docs, as this breaks
>parallel inst
Jim Meyering wrote:
...
>> In either case, an automatic indentation checker would catch the problem.
>> This is yet another reason to enforce an indentation style.
>> The longer we wait, the harder it will become.
>
> No one objected to the patch in the parent,
> and there was one ACK, so I'm about
Jim Meyering wrote:
> I introduced a bug with this supposedly-safe, no-semantic-change delta:
>
>
> http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=b6719eab9e95c5daeeea85
>
> See if you can spot it.
>
> Here is the loop in question, as it was prior to my erroneous change:
>
> for (i =
> Jiri Denemark (3):
> lxc: Use virDomainFindByUUID for domain lookup
> lxc: Make SetMemory work for active domains only
> lxc: Check domain is active/inactive as required by operation
>
> src/lxc/lxc_driver.c | 138
> ++
> 1 files changed,
On Tue, May 04, 2010 at 11:56:56AM +0200, Jiri Denemark wrote:
> > > @@ -642,27 +642,30 @@ static int lxcDomainSetMemory(virDomainPtr dom,
> > > unsigned long newmem) {
> > > goto cleanup;
> > > }
> > >
> > > -if (virDomainObjIsActive(vm)) {
> > > -if (driver->cgroup ==
> > @@ -642,27 +642,30 @@ static int lxcDomainSetMemory(virDomainPtr dom,
> > unsigned long newmem) {
> > goto cleanup;
> > }
> >
> > -if (virDomainObjIsActive(vm)) {
> > -if (driver->cgroup == NULL) {
> > -lxcError(VIR_ERR_NO_SUPPORT,
> > -
This includes various things:
- fix the Requires: libvirt-client to use %{name} to allow easy renaming
- when building ESX support one need libcurl-devel
- remove Makefile[.in] from xml/nwfilter in the docs, as this breaks
parallel install ation of i686 and x86_64 packages
- don't include nw
On Tue, May 04, 2010 at 01:41:55AM +0200, Matthias Bolte wrote:
> When cross-compiling on Linux, configure will misdetect the target as
> Linux because it uses uname instead of relying on the $host variable.
> This results in including libvirt_linux.syms into libvirt.syms and
> therefore trying to
On Mon, May 03, 2010 at 02:46:35PM -0500, Charles Duffy wrote:
> On Mon, May 3, 2010 at 1:48 PM, Matthias Bolte <
> matthias.bo...@googlemail.com> wrote:
>
> > 2010/5/3 Charles Duffy :
> > > The question then -- is the 50ms poll in
> > qemuDomainWaitForMigrationComplete
> > > (called from qemudDom
32 matches
Mail list logo
