* Alex Williamson (alex.william...@redhat.com) wrote:
> @@ -1378,6 +1420,9 @@ int qemudExtractVersionInfo(const char *qemu,
>&version, &is_kvm, &kvm_version) == -1)
> goto cleanup2;
>
> +if (flags & QEMUD_CMD_FLAG_DEVICE)
> +qemudParsePCIDeviceStrs
On 05/19/2010 11:54 PM, Charles Duffy wrote:
A revised patch is attached. This lifts its logic from its kernel
counterpart, and is updated only to permit forward slashes (which, while
disallowed for interface names with the kernel, are required for
*device* names -- for which the ESX driver happe
On 05/19/2010 10:05 PM, Laine Stump wrote:
On 05/19/2010 10:41 PM, Charles Duffy wrote:
The attached one-liner (built against RHEL6b1's libvirt but still
applicable against current master as of 10c681622) fixes this issue.
I think we need to add ":" there as well (at least - maybe there are
ot
* Alex Williamson (alex.william...@redhat.com) wrote:
> There doesn't seem to be anything specific to tap devices for this
> array of file descriptors which need to stay open of the guest to use.
> Rename then for others to make use of.
>
> Signed-off-by: Alex Williamson
Simple enough, and allow
Note: The configfd option for qemu is still pending upstream, so
this patch will depend on that being accepted. This patch also
depends on the the s/tapfd/vmfd/ rename patch posted to the list.
This allows libvirt to open the PCI device sysfs config file prior
to dropping privileges so qemu can a
There doesn't seem to be anything specific to tap devices for this
array of file descriptors which need to stay open of the guest to use.
Rename then for others to make use of.
Signed-off-by: Alex Williamson
---
src/qemu/qemu_conf.c | 28 ++--
src/qemu/qemu_driver.c
On 05/19/2010 10:41 PM, Charles Duffy wrote:
Howdy!
I spent some time scratching my head this evening, as libvirt was
stripping the target/@dev entry from my interfa...@type='ethernet'].
Turns out that this was caused by the interface name containing a
period, which is rejected by isValidIfn
Howdy!
I spent some time scratching my head this evening, as libvirt was
stripping the target/@dev entry from my interfa...@type='ethernet'].
Turns out that this was caused by the interface name containing a
period, which is rejected by isValidIfname(). As the kernel allows the
creation of s
On 05/19/2010 04:37 PM, Chris Wright wrote:
> Looks like some cut'n paste error to me.
While we're at it, there have been some complaints, at least on IRC,
that some recent qemu builds changed -help output to start with "QEMU
emulator version" instead of "QEMU PC emulator version", which fails to
On 05/19/2010 04:42 PM, Matthias Bolte wrote:
>> @@ -46,7 +46,8 @@ qemuhelpdata = \
>>qemu-0.10.5 \
>>qemu-0.12.1 \
>>qemu-kvm-0.10.5 \
>> - qemu-kvm-0.11.0-rc2
>> + qemu-kvm-0.11.0-rc2 \
>> + qemu-kvm-0.12.3
>>
>> EXTRA_DIST = \
>> oomtr
On 05/19/2010 04:37 PM, Chris Wright wrote:
> Looks like some cut'n paste error to me.
>
> Signed-off-by: Chris Wright
> ---
> src/qemu/qemu_conf.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 3e334dc..6d2ac
2010/5/20 Eric Blake :
> Commit f30ccb2458829 was incomplete.
>
> * .gitignore: Ignore intermediate directory during failed 'make
> distcheck'.
> * tests/Makefile.am (qemuhelpdata): Distribute new file.
> ---
>
> Pushing as obvious, once a successful 'make distcheck' completes
> a few minutes from
Looks like some cut'n paste error to me.
Signed-off-by: Chris Wright
---
src/qemu/qemu_conf.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 3e334dc..6d2ac6e 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.
Commit f30ccb2458829 was incomplete.
* .gitignore: Ignore intermediate directory during failed 'make
distcheck'.
* tests/Makefile.am (qemuhelpdata): Distribute new file.
---
Pushing as obvious, once a successful 'make distcheck' completes
a few minutes from when I write this.
.gitignore
2010/5/18 Eric Blake :
> On 05/18/2010 10:31 AM, Matthias Bolte wrote:
>> This will be used in the ESX storage driver in order to handle
>> the DatastoreInfo type and inheriting types properly.
>> ---
>> src/esx/esx_vi_generator.py | 13 -
>> src/esx/esx_vi_types.c | 28 ++
2010/5/18 Eric Blake :
> On 05/18/2010 10:30 AM, Matthias Bolte wrote:
>> This semantic will be used in the ESX storage driver.
>> ---
>> src/esx/esx_vi_types.c | 16 +---
>> 1 files changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_t
On 05/19/2010 01:27 PM, Jim Meyering wrote:
> Eric Blake wrote:
>> * src/Makefile.am (EXTRA_DIST): Add THREADS.txt.
>> ---
>>
>> I noticed this while working on back-porting a patch to RHEL-6 - the
>> qemu tree in my git repository had more files than were in the
>> unpacked 0.8.1 tarball.
>>
> Obv
On 05/19/2010 03:29 PM, Cole Robinson wrote:
> I've hit a few small build issues that I don't know how to fix.
>
> daemon/libvirtd.init isn't regenerated if ./configure is re-run. If I do:
>
> ./configure --prefix=/foo && make && ./configure --prefix=/bar && make
>
> daemon/libvirtd.init will re
Below is David Alan's original patch with lots of changes.
In particular, it now parses the following two XML descriptions, one
for 802.1Qbg and 802.1Qbh and stored the data internally. The actual
triggering of the switch setup protocol has not been implemented
here but the relevant code to do t
I've hit a few small build issues that I don't know how to fix.
daemon/libvirtd.init isn't regenerated if ./configure is re-run. If I do:
./configure --prefix=/foo && make && ./configure --prefix=/bar && make
daemon/libvirtd.init will reference /foo and not /bar. The logrotate
files are affected
Eric Blake wrote:
> * src/Makefile.am (EXTRA_DIST): Add THREADS.txt.
> ---
>
> I noticed this while working on back-porting a patch to RHEL-6 - the
> qemu tree in my git repository had more files than were in the
> unpacked 0.8.1 tarball.
>
> src/Makefile.am |3 ++-
> 1 file changed, 2 inserti
On 05/19/2010 09:50 AM, Jim Meyering wrote:
> This is very similar to ones I fixed yesterday.
> The difference is that I'm adding ATTRIBUTE_RETURN_CHECK, now.
> Here, it's easy, since the function is private.
ACK.
--
Eric Blake ebl...@redhat.com+1-801-349-2682
Libvirt virtualization librar
Matthias Bolte wrote:
...
> Yes, this patch solves the problem.
>
...
>> + -e ' warn "WARNING: your pdwtags program is too old\n";' \
>> + -e ' warn "WARNING: skipping the $@ test\n";' \
>> + -e ' warn "WARNING: install dwarves-1.8 or newer\
* src/Makefile.am (EXTRA_DIST): Add THREADS.txt.
---
I noticed this while working on back-porting a patch to RHEL-6 - the
qemu tree in my git repository had more files than were in the
unpacked 0.8.1 tarball.
src/Makefile.am |3 ++-
1 file changed, 2 insertions(+), 1 deletions(-)
diff --git
On Wed, May 19, 2010 at 01:03:32PM -0400, Bryan Kearney wrote:
> I have moved the bindings up to 0.8.1. It is mostly cut and paste code,
> but the test driver does not support some of the new features so I would
> appreciate if someone could bang on them a bit. Specifically, I would
> like to se
2010/5/19 Jim Meyering :
> Matthias Bolte wrote:
>> The "help avoid accidental remote_protocol.x changes" commit 180d4b2b
>> added a make check rule that tried using pdwtags from the dwarves
>> package to protect against accidental remote_protocol.x changes.
>>
>> I installed dwarves package on Ubu
I have moved the bindings up to 0.8.1. It is mostly cut and paste code,
but the test driver does not support some of the new features so I would
appreciate if someone could bang on them a bit. Specifically, I would
like to see someone try out:
Snapshots
Streams (Callbacks in particular)
Secret
On 05/19/2010 06:50 AM, Daniel P. Berrange wrote:
When a disk is on a root squashed NFS server, it may not be
possible to stat() the disk file in virCgroupAllowDevice.
The virStorageFileGetMeta method may also fail to extract
the parent backing store. Both of these errors have to be
ignored to av
On 05/19/2010 01:49 AM, Huang, Zhiteng wrote:
Hi gurus on the list,
I'm trying to bring up a Linux with virtio vhost backend. My system is running
on kernel 2.6.34-rc7, libvirt 0.8.0.
Two questions regarding to vhost:
1) XML format for vhost
I didn't find any documents on libvirt.org descrip
This is very similar to ones I fixed yesterday.
The difference is that I'm adding ATTRIBUTE_RETURN_CHECK, now.
Here, it's easy, since the function is private.
>From cfce459e9aebae840356e62473f550f358834f30 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 19 May 2010 17:48:03 +0200
Subject:
commit dcf30d9c25daabe722c5298f0a90d562b7e9f7d7
Author: Jim Meyering
Date: Tue May 18 07:53:31 2010 +0200
initialize "meta" in virStorageFileGetMetadata, not in each caller
Do not require each caller of virStorageFileGetMetadata and
virStorageFileGetMetadataFromFD to first clear t
Thanks for your response!
I didn't know that VLAN IDs are internal to the individual KVM/QEMU
processes. In fact the VLAN IDs were different within our guests. So
it was not a perfect match...
Meanwhile the question remains, why their solution did work in our
case. But this one should goe to t
On Wed, May 19, 2010 at 04:47:17PM +0200, Jim Meyering wrote:
> From: Jim Meyering
>
> * src/util/uuid.c (virUUIDGenerate): Remove _(...) manually.
> ---
> src/util/uuid.c |6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
ACK
Daniel
--
|: Red Hat, Engineering, London-o-
Daniel P. Berrange wrote:
> On Wed, May 19, 2010 at 04:47:16PM +0200, Jim Meyering wrote:
>> From: Jim Meyering
>>
>> Approximately 60 messages were marked. Since these diagnostics are
>> intended solely for developers and maintainers, encouraging translation
>> is deemed to be counterproductive:
On Wed, May 19, 2010 at 04:47:18PM +0200, Jim Meyering wrote:
> From: Jim Meyering
>
> * cfg.mk (sc_prohibit_gettext_markup): New rule, to enforce
> this policy. Contrary to most diagnostic-emitting functions,
> where we require _(...) markup, here, we require that _() *not*
> be used for certai
On Wed, May 19, 2010 at 04:47:20PM +0200, Jim Meyering wrote:
> From: Jim Meyering
>
> * po/POTFILES.in: Remove src/util/logging.c and src/util/uuid.c.
> * src/phyp/phyp_driver.c (phypUUIDTable_ReadFile): Correct more
> VIR_WARN uses, now manually.
> (phypUUIDTable_Init, phypUUIDTable_Pull): Like
On Wed, May 19, 2010 at 04:47:19PM +0200, Jim Meyering wrote:
> From: Jim Meyering
>
> Run this command:
> git grep -l 'VIR_WARN("%s", "'|xargs perl -pi -e \
> 's/VIR_WARN\("%s", "/VIR_WARN0("/'
> * src/phyp/phyp_driver.c (phypDomainGetInfo): Perform the above.
> (phypDomainCreateAndStart,
On Wed, May 19, 2010 at 04:47:16PM +0200, Jim Meyering wrote:
> From: Jim Meyering
>
> Approximately 60 messages were marked. Since these diagnostics are
> intended solely for developers and maintainers, encouraging translation
> is deemed to be counterproductive:
> http://thread.gmane.org/gmane
Here are 5 patches, mostly mechanical,
to straighten out the VIR_WARN and VIR_WARN0 situation.
1: mechanically remove all _(...) uses in VIR_WARN*.
2: remove the few remaining _(...) uses manually
3: add syntax-check rule to enforce the policy
4 clean up bogosity I noticed along the way, first aut
From: Jim Meyering
* src/util/uuid.c (virUUIDGenerate): Remove _(...) manually.
---
src/util/uuid.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/util/uuid.c b/src/util/uuid.c
index 459273a..9c626ce 100644
--- a/src/util/uuid.c
+++ b/src/util/uuid.c
@@ -1,5 +1
From: Jim Meyering
* cfg.mk (sc_prohibit_gettext_markup): New rule, to enforce
this policy. Contrary to most diagnostic-emitting functions,
where we require _(...) markup, here, we require that _() *not*
be used for certain functions (or function-like macros).
---
cfg.mk | 19 +---
From: Jim Meyering
* po/POTFILES.in: Remove src/util/logging.c and src/util/uuid.c.
* src/phyp/phyp_driver.c (phypUUIDTable_ReadFile): Correct more
VIR_WARN uses, now manually.
(phypUUIDTable_Init, phypUUIDTable_Pull): Likewise.
---
po/POTFILES.in |2 --
src/phyp/phyp_driver.c | 12
From: Jim Meyering
Approximately 60 messages were marked. Since these diagnostics are
intended solely for developers and maintainers, encouraging translation
is deemed to be counterproductive:
http://thread.gmane.org/gmane.comp.emulators.libvirt/25050/focus=25052
Run this command:
git grep -l
From: Jim Meyering
Run this command:
git grep -l 'VIR_WARN("%s", "'|xargs perl -pi -e \
's/VIR_WARN\("%s", "/VIR_WARN0("/'
* src/phyp/phyp_driver.c (phypDomainGetInfo): Perform the above.
(phypDomainCreateAndStart, phypUUIDTable_ReadFile): Likewise.
---
src/phyp/phyp_driver.c | 12 ++
Changes since v1:
- Add virsh.pod documentation
Signed-off-by: Chris Lalancette
---
tools/Makefile.am |1 +
tools/virsh.c | 55 +
tools/virsh.pod | 16 +++
3 files changed, 72 insertions(+), 0 deletions(-)
diff --git
Since we are adding a new "per-hypervisor" protocol, we
make it so that the qemu remote protocol uses a new
PROTOCOL and PROGRAM number. This allows us to easily
distinguish it from the normal REMOTE protocol.
This necessitates changing the proc in remote_message_header
from a "remote_procedure"
Thanks to DV for knocking together the Relax-NG changes
quickly for me.
Changes since v1:
- Change the domain.rng to correspond to the new schema
- Don't allocate caps->ns in testQemuCapsInit since it is a static table
Signed-off-by: Chris Lalancette
---
docs/schemas/domain.rng
Now that we have the ability to specify arbitrary qemu
command-line parameters in the XML, use it to handle unknown
command-line parameters when doing a native-to-xml conversion.
Changes since v1:
- Rename num_extra to num_args
- Fix up a memory leak on an error path
Signed-off-by: Chris Lalanc
Implement the qemu driver's virDomainQemuMonitorCommand
and hook it into the API entry point.
Changes since v1:
- Rename the (external) qemuMonitorCommand to qemuDomainMonitorCommand
- Add virCheckFlags to qemuDomainMonitorCommand
Signed-off-by: Chris Lalancette
---
src/qemu/qemu_driver.c
Add the library entry point for the new virDomainQemuMonitorCommand()
entry point. Because this is not part of the "normal" libvirt API,
it gets it's own header file, library file, and will eventually
get it's own over-the-wire protocol later in the series.
Changes since v1:
- Go back to using t
Implement the qemu hooks for XML namespace data. This
allows us to specify a qemu XML namespace, and then
specify:
In the domain XML.
Changes since v1:
- Change the arg XML to XML
- Fix up some memory leaks in qemuDomainDefNamespaceParse
- Rename num_extra and extra to num_args and ar
This patch adds namespace XML parsers to be hooked into
the main domain parser. This allows for individual hypervisor
drivers to add per-namespace XML into the main domain XML.
Changes since v1:
- Use a statically declared table for caps->ns, removing the need to
allocate/free it.
Signed-off
As we discussed previously, here is the patch series to add the ability
to specify arbitrary qemu command-line parameters and environment variables,
and also give arbitrary monitor commands to a guest. Because these
extra arguments have a good shot at confusing libvirt, the use of them
is not supp
Jiri Denemark wrote:
>> > Nonetheless, many of my manual changes highlighted
>> > existing (bogus) attempts to translate VIR_WARN0? diagnostics.
>> > Those should be addressed regardless.
>> >
>> > Considering the large number of existing VIR_WARN uses with strings
>> > marked for translation, do
Matthias Bolte wrote:
> The "help avoid accidental remote_protocol.x changes" commit 180d4b2b
> added a make check rule that tried using pdwtags from the dwarves
> package to protect against accidental remote_protocol.x changes.
>
> I installed dwarves package on Ubuntu 10.04 and make check fails f
On Wed, May 19, 2010 at 04:11:36PM +0200, Csom Gyula wrote:
> Hi there,
>
> We experienced network problems (namely net packet storm), when using
> multiple NICs and
> the same VLAN ID-s for different KVM guests. It turned out that we could
> workaround the
> problem by simply assigning differ
Hi there,
We experienced network problems (namely net packet storm), when using multiple
NICs and
the same VLAN ID-s for different KVM guests. It turned out that we could
workaround the
problem by simply assigning different VLAN ID-s to the different NICs. (Btw our
case
looked similar to the
The problem desribed here: https://bugzilla.redhat.com/show_bug.cgi?id=593266
Please update http://www.libvirt.org/formatdomain.html and describe
NEW xml tags, like for hard drive and all cpu
tags, other if any.
--
Segmentation fault
--
libvir-list mailing list
libvir-list@redhat.com
http
2010/5/19 Jiri Denemark :
>> The problem desribed here: https://bugzilla.redhat.com/show_bug.cgi?id=593266
>>
>> Please update http://www.libvirt.org/formatdomain.html and describe
>> NEW xml tags, like for hard drive and all cpu
>> tags, other if any.
>
> What cpu tag are you missing from the
On Mon, May 17, 2010 at 10:06:13AM -0700, Vivek Kashyap wrote:
> On Mon, 17 May 2010, Daniel P. Berrange wrote:
>
> >On Mon, May 17, 2010 at 07:28:05AM -0400, Stefan Berger wrote:
> >>This is a repost of this previously posted patch. I'd like someone to
> >>ACK it or let me know how to proceed wit
When a disk is on a root squashed NFS server, it may not be
possible to stat() the disk file in virCgroupAllowDevice.
The virStorageFileGetMeta method may also fail to extract
the parent backing store. Both of these errors have to be
ignored to avoid breaking NFS deployments
* src/qemu/qemu_driver
> The problem desribed here: https://bugzilla.redhat.com/show_bug.cgi?id=593266
>
> Please update http://www.libvirt.org/formatdomain.html and describe
> NEW xml tags, like for hard drive and all cpu
> tags, other if any.
What cpu tag are you missing from the documentation? The description a
62 matches
Mail list logo
