Eric Blake wrote:
On 05/12/2010 07:23 PM, Eric Blake wrote:
[trying to clear out some old mail]
From bc3404d9f12c42cf883a43395fee6fc14c952b2c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 11 May 2010 15:43:32 +0200
Subject: [PATCH] lxcSetSchedulerParameters:
For example, http://libvirt.org/formatdomain.html#elementsDisks
does not contain serial/serial tag.
(https://bugzilla.redhat.com/show_bug.cgi?id=593266)
I wrote to community (users and developers). No one has added this
information to the site...
--
Segmentation fault
--
libvir-list
On Mon, May 24, 2010 at 04:05:41PM -0600, Eric Blake wrote:
On 05/14/2010 07:10 AM, Daniel P. Berrange wrote:
The virDomainGetBlockInfo API allows query physical block
extent and allocated block extent. These are normally the
same value unless storing a special format like qcow2
inside a
On Fri, May 21, 2010 at 12:27:27PM -0400, Cole Robinson wrote:
On 05/20/2010 03:57 PM, Chris Lalancette wrote:
We've been running into a lot of situations where
virGetHostname() is returning localhost, where a plain
gethostname() would have returned the correct thing. This
is because
On Mon, May 24, 2010 at 01:12:12PM -0700, Chris Wright wrote:
* Hugh O. Brock (hbr...@redhat.com) wrote:
On Mon, May 24, 2010 at 11:47:18AM -0700, Chris Wright wrote:
* Daniel P. Berrange (berra...@redhat.com) wrote:
On Sun, May 23, 2010 at 12:51:50PM -0400, Stefan Berger wrote:
On Mon, May 24, 2010 at 02:52:30PM -0400, Cole Robinson wrote:
Currently all host audio backends are disabled if a VM is using VNC, in
favor of the QEMU VNC audio extension. Unfortunately no released VNC
client supports this extension, so users have no way of getting audio
to work if using
On Mon, May 24, 2010 at 08:31:27PM -0300, Eduardo Otubo wrote:
Hello,
These two functions, virDrvStorageVolLookupByKey and
virDrvStorageVolLookupByPath should use virStoragePoolPtr as parameter
instead of virConnectPtr for some few reasons:
1) Should follow the standard virStorage*Ptr
On Tue, May 25, 2010 at 01:07:50PM +0600, ? wrote:
For example, http://libvirt.org/formatdomain.html#elementsDisks
does not contain serial/serial tag.
(https://bugzilla.redhat.com/show_bug.cgi?id=593266)
I wrote to community (users and developers). No one has added this
Below is David Alan's original patch with lots of changes.
In particular, it now parses the following two XML descriptions, one
for 802.1Qbg and 802.1Qbh and stored the data internally. The actual
triggering of the switch setup protocol has not been implemented
here but the relevant code to do
On Tue, May 25, 2010 at 10:43:41AM +0800, Osier Yang wrote:
still no /etc/libvirt/hooks and example hook scripts in 0.8.1-6.
anyone can provide some simple hook scripts? thanks
- Osier
Osier, could you file a BZ for this to make sure we don't lose track
of it?
Thanks,
--Hugh
Daniel
On Mon, 2010-05-24 at 20:17 -0700, Scott Feldman wrote:
From: Scott Feldman scofe...@cisco.com
This patch builds on the work recently posted by Stefan Berger. It builds
on top of Stefan's three posted patches:
[PATCH v9] vepa: parsing for 802.1Qb{g|h} XML
[RFC][PATCH 1/3]
Scott Feldman wrote:
From: Scott Feldman scofe...@cisco.com
...
diff --git a/configure.ac b/configure.ac
...
-if test $with_macvtap = yes; then
+if test $with_macvtap = yes || $with_virtualport = yes; then
Hi Scott,
The above introduces a syntax error.
Fix it by inserting a test after the
This patch builds on the work recently posted by Stefan Berger. It builds
on top of Stefan's three posted patches:
[PATCH v10] vepa: parsing for 802.1Qb{g|h} XML
[RFC][PATCH 1/3] vepa+vsi: Introduce dependency on libnl
[PATCH v3] Add host UUID (to libvirt capabilities)
This introduces a new set of APIs in src/util/command.h
to use for invoking commands. This is intended to replace
all current usage of virRun and virExec variants, with a
more flexible and less error prone API.
---
src/Makefile.am |1 +
src/util/command.c | 782
This proof of concept shows how two existing uses of virExec
and virRun can be ported to the new virCommand APIs, and how
much simpler the code becomes
---
src/util/hooks.c| 221 +++---
src/util/iptables.c | 70 +++-
2 files changed,
---
docs/Makefile.am | 12 ++--
docs/internals.html.in |9 +
docs/sitemap.html.in |4
3 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
index 70b9e51..24519fd 100644
--- a/docs/Makefile.am
+++
We have had great success with our APIs for memory allocation and
string buffer management, removing most of the potential for incorrect
API usage, thus avoiding many common errors. It is time todo the same
for command execution.
This patch series is a proof of concept for a set of APIs I've
been
On 05/24/2010 04:35 PM, Eric Blake wrote:
On 05/24/2010 02:24 PM, Chris Lalancette wrote:
Unfortunately the NWFilter functions were outside of the
extern C { ... } declaration in include/libvirt/libvirt.h.in,
which means that they couldn't be properly used with C++. Move
them inside of the
On 05/25/2010 03:07 AM, íÁÒË ëÏÒÅÎÂÅÒÇ wrote:
For example, http://libvirt.org/formatdomain.html#elementsDisks
does not contain serial/serial tag.
(https://bugzilla.redhat.com/show_bug.cgi?id=593266)
I wrote to community (users and developers). No one has added this
information to the
On Mon, May 24, 2010 at 02:57:33PM -0400, Stefan Berger wrote:
This patch adds the host UUID (to the capabilities of libvirt). The user
may provide it in libvirtd.conf overriding whatever sysfs may
return. If none or no valid UUID is provided in libvirtd.conf, reading the
UUID from sysfs is
On 05/24/2010 04:34 PM, Eric Blake wrote:
On 05/24/2010 02:20 PM, Chris Lalancette wrote:
Sounds good to me - if all entry points filter on all accepted flags,
then helper functions can assume that flags are already valid. As long
as the filtering gets done somewhere, we've left the door open
On 05/24/2010 12:52 PM, Cole Robinson wrote:
+
+/* Need to sanitize:
+ * // - //
+ * /// - /
+ * /../foo - /../foo
+ * /.//foo - /foo
+ * /foo///bar/ - /foo/bar
+ * ./foo/./.- /foo
+ */
+
For my second attempt at a valid
On 05/25/2010 10:42 AM, Eric Blake wrote:
On 05/24/2010 12:52 PM, Cole Robinson wrote:
+
+/* Need to sanitize:
+ * // - //
+ * /// - /
+ * /../foo - /../foo
+ * /.//foo - /foo
+ * /foo///bar/ - /foo/bar
+ * ./foo/./.- /foo
+
On 05/25/2010 08:33 AM, Chris Lalancette wrote:
Basic live migration was broken by the commit that added
non-shared block support in two ways:
1) It added a virCheckFlags() to doNativeMigrate(). Besides
the fact that typical usage of virCheckFlags() is in driver
entry points, and
On 05/25/2010 10:48 AM, Eric Blake wrote:
On 05/25/2010 08:33 AM, Chris Lalancette wrote:
Basic live migration was broken by the commit that added
non-shared block support in two ways:
1) It added a virCheckFlags() to doNativeMigrate(). Besides
the fact that typical usage of
2010/5/25 Chris Lalancette clala...@redhat.com:
On 05/24/2010 04:34 PM, Eric Blake wrote:
On 05/24/2010 02:20 PM, Chris Lalancette wrote:
Sounds good to me - if all entry points filter on all accepted flags,
then helper functions can assume that flags are already valid. As long
as the
On 05/24/2010 04:50 PM, Cole Robinson wrote:
My bad, I figured dconn had the same URI on the dest host as it did on
the source host. ACK to this patch then.
Maybe for the future we should consider always building a manual migrate
URI in virsh.c (or maybe libvirt.c), using the destination
On Tue, May 25, 2010 at 08:42:31AM -0600, Eric Blake wrote:
On 05/24/2010 12:52 PM, Cole Robinson wrote:
+
+/* Need to sanitize:
+ * // - //
+ * /// - /
+ * /../foo - /../foo
+ * /.//foo - /foo
+ * /foo///bar/ - /foo/bar
+
2010/5/25 Daniel P. Berrange berra...@redhat.com:
On Mon, May 24, 2010 at 02:57:33PM -0400, Stefan Berger wrote:
This patch adds the host UUID (to the capabilities of libvirt). The user
may provide it in libvirtd.conf overriding whatever sysfs may
return. If none or no valid UUID is provided
On Tue, May 25, 2010 at 05:01:48PM +0200, Matthias Bolte wrote:
2010/5/25 Daniel P. Berrange berra...@redhat.com:
On Mon, May 24, 2010 at 02:57:33PM -0400, Stefan Berger wrote:
This patch adds the host UUID (to the capabilities of libvirt). The user
may provide it in libvirtd.conf
On Tue, 2010-05-25 at 15:26 +0100, Daniel P. Berrange wrote:
virBufferAddLit(xml, capabilities\n\n);
virBufferAddLit(xml, host\n);
+virBufferVSprintf(xml,uuid%s/uuid\n, host_uuid);
virBufferAddLit(xml, cpu\n);
virBufferVSprintf(xml,
On 05/25/2010 08:26 AM, Daniel P. Berrange wrote:
+
+# UUID of the host:
+# Provide the UUID of the host here in case the command
+# 'dmidecode -s system-uuid' does not provide a valid uuid. In case
+# 'dmidecode' does not provide a valid UUID and none is provided here, a
+# temporary UUID
On Tue, May 25, 2010 at 09:08:15AM -0600, Eric Blake wrote:
On 05/25/2010 08:26 AM, Daniel P. Berrange wrote:
+
+# UUID of the host:
+# Provide the UUID of the host here in case the command
+# 'dmidecode -s system-uuid' does not provide a valid uuid. In case
+# 'dmidecode' does not
On 05/25/2010 10:54 AM, Daniel P. Berrange wrote:
On Tue, May 25, 2010 at 08:42:31AM -0600, Eric Blake wrote:
On 05/24/2010 12:52 PM, Cole Robinson wrote:
+
+/* Need to sanitize:
+ * // - //
+ * /// - /
+ * /../foo - /../foo
+ * /.//foo -
Spurious / in a pool target path makes life difficult for apps using the
GetVolByPath, and doing other path based comparisons with pools. This
has caused a few issues for virt-manager users:
https://bugzilla.redhat.com/show_bug.cgi?id=494005
https://bugzilla.redhat.com/show_bug.cgi?id=593565
Add
On 05/25/2010 09:49 AM, Cole Robinson wrote:
This function is crying out for a real test case to be written and put
under tests/, feeding it all sorts of evil input.
Agreed, however I'm backtracking a bit on this, my next post is only
going to sanitize spurious /, like my original posting
On 05/25/2010 09:49 AM, Cole Robinson wrote:
Spurious / in a pool target path makes life difficult for apps using the
GetVolByPath, and doing other path based comparisons with pools. This
has caused a few issues for virt-manager users:
https://bugzilla.redhat.com/show_bug.cgi?id=494005
On 5/25/10 8:30 AM, Stefan Berger stef...@us.ibm.com wrote:
+usleep(125000);
Magic constant?
How did you determine this number?
How often are we expected to hit it?
Please add a comment.
This *may* be something I suggested -- to wait for 1/8 sec. Not sure
whether this is
On 05/25/2010 06:45 AM, Daniel P. Berrange wrote:
On Mon, May 24, 2010 at 02:52:30PM -0400, Cole Robinson wrote:
Currently all host audio backends are disabled if a VM is using VNC, in
favor of the QEMU VNC audio extension. Unfortunately no released VNC
client supports this extension, so users
On 05/25/2010 12:09 PM, Eric Blake wrote:
On 05/25/2010 09:49 AM, Cole Robinson wrote:
Spurious / in a pool target path makes life difficult for apps using the
GetVolByPath, and doing other path based comparisons with pools. This
has caused a few issues for virt-manager users:
On 05/24/2010 02:52 PM, Cole Robinson wrote:
Signed-off-by: Cole Robinson crobi...@redhat.com
---
src/storage/storage_backend_mpath.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/storage/storage_backend_mpath.c
b/src/storage/storage_backend_mpath.c
index
This patch builds on the work recently posted by Stefan Berger. It builds
on top of Stefan's three posted patches:
[PATCH v10] vepa: parsing for 802.1Qb{g|h} XML
[RFC][PATCH 1/3] vepa+vsi: Introduce dependency on libnl
[PATCH v3] Add host UUID (to libvirt capabilities)
This patch was somehow broken - many of the lines have been
word-wrapped, so patch bombs out. The v6 patch you sent didn't have this
problem...
Can you resend it using the same method you used for v6? (assuming
something changed ;-)
On 05/25/2010 12:54 PM, Stefan Berger wrote:
This patch
On 05/24/2010 06:24 AM, Stefan Berger wrote:
This patch introduces a dependency on libnl, which subsequent patches
will then use.
I'm hoping that this is the correct version to be reviewing - but since
it looks like the vepa patches depend on this one, we need to push this
one through :)
---
Reposting due to malformatted patch.
This patch builds on the work recently posted by Stefan Berger. It builds
on top of Stefan's three posted patches:
[PATCH v10] vepa: parsing for 802.1Qb{g|h} XML
[RFC][PATCH 1/3] vepa+vsi: Introduce dependency on libnl
[PATCH v3] Add
On 05/25/2010 07:24 AM, Daniel P. Berrange wrote:
We have had great success with our APIs for memory allocation and
string buffer management, removing most of the potential for incorrect
API usage, thus avoiding many common errors. It is time todo the same
for command execution.
Yes, this
On 05/24/2010 06:24 AM, Stefan Berger wrote:
@@ -283,6 +289,10 @@ BuildRequires: yajl-devel
%if %{with_libpcap}
BuildRequires: libpcap-devel
%endif
+%if %{with_libnl}
+BuildRequires: libnl-devel
+Requires: libnl
+%endif
Correction - it was pointed out to me on IRC that the 'Requires:
On Tue, 2010-05-25 at 11:58 -0600, Eric Blake wrote:
On 05/24/2010 06:24 AM, Stefan Berger wrote:
@@ -283,6 +289,10 @@ BuildRequires: yajl-devel
%if %{with_libpcap}
BuildRequires: libpcap-devel
%endif
+%if %{with_libnl}
+BuildRequires: libnl-devel
+Requires: libnl
+%endif
On 5/25/10 10:24 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
Reposting due to malformatted patch.
Thanks for fixing the malformed issue.
My testing is done with this version v7 plus the other patches list below.
No issues.
ACK.
[PATCH v10] vepa: parsing for 802.1Qb{g|h}
On 05/25/2010 02:34 PM, Stefan Berger wrote:
On Tue, 2010-05-25 at 11:58 -0600, Eric Blake wrote:
On 05/24/2010 06:24 AM, Stefan Berger wrote:
@@ -283,6 +289,10 @@ BuildRequires: yajl-devel
%if %{with_libpcap}
BuildRequires: libpcap-devel
%endif
+%if %{with_libnl}
On Tue, 2010-05-25 at 14:53 -0400, Laine Stump wrote:
On 05/25/2010 02:34 PM, Stefan Berger wrote:
On Tue, 2010-05-25 at 11:58 -0600, Eric Blake wrote:
On 05/24/2010 06:24 AM, Stefan Berger wrote:
@@ -283,6 +289,10 @@ BuildRequires: yajl-devel
%if %{with_libpcap}
On 05/25/2010 07:18 AM, Stefan Berger wrote:
Below is David Alan's original patch with lots of changes.
A collective big ACK to this patch!
You may want to consolidate all the v1-v10 comments into one
comprehensive notice (with less of the back and forth) before pushing
(and if you
Chris Lalancette wrote:
Basic live migration was broken by the commit that added
non-shared block support in two ways:
1) It added a virCheckFlags() to doNativeMigrate(). Besides
...
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 77e71cc..941b482 100644
---
Scott Feldman wrote:
On 5/25/10 10:24 AM, Stefan Berger stef...@linux.vnet.ibm.com wrote:
Reposting due to malformatted patch.
Thanks for fixing the malformed issue.
My testing is done with this version v7 plus the other patches list below.
No issues.
ACK.
[PATCH v10] vepa:
Daniel P. Berrange wrote:
---
docs/Makefile.am | 12 ++--
docs/internals.html.in |9 +
docs/sitemap.html.in |4
3 files changed, 23 insertions(+), 2 deletions(-)
diff --git a/docs/Makefile.am b/docs/Makefile.am
...
+ liGuide to adding a
In reviewing/testing some incoming patches, I noticed a new
make check failure.
There were two problems:
- not diagnosing an invalid host UUID. The lack of this diagnostic
made it slightly more challenging to track down the next problem:
- not accommodating the fact that our template now
Stefan Berger wrote:
This patch builds on the work recently posted by Stefan Berger. It builds
on top of Stefan's three posted patches:
Not a show-stopper, but your patch is corrupted due to split lines.
If you tell your mail client not to do that, it'll be easier
on folks who end up applying
On 05/25/2010 01:12 PM, Jim Meyering wrote:
In reviewing/testing some incoming patches, I noticed a new
make check failure.
There were two problems:
- not diagnosing an invalid host UUID. The lack of this diagnostic
made it slightly more challenging to track down the next problem:
- not
On 05/25/2010 07:24 AM, Daniel P. Berrange wrote:
This introduces a new set of APIs in src/util/command.h
to use for invoking commands. This is intended to replace
all current usage of virRun and virExec variants, with a
more flexible and less error prone API.
---
src/Makefile.am
On 05/25/2010 07:24 AM, Daniel P. Berrange wrote:
---
docs/Makefile.am | 12 ++--
docs/internals.html.in |9 +
docs/sitemap.html.in |4
3 files changed, 23 insertions(+), 2 deletions(-)
+++ b/docs/Makefile.am
@@ -53,7 +53,7 @@ gif = \
On 05/25/2010 07:24 AM, Daniel P. Berrange wrote:
This proof of concept shows how two existing uses of virExec
and virRun can be ported to the new virCommand APIs, and how
much simpler the code becomes
Love it!
-va_start(args, arg);
-
while ((s = va_arg(args, const char *)))
-
On Tue, 2010-05-25 at 16:12 -0400, Laine Stump wrote:
On 05/25/2010 07:18 AM, Stefan Berger wrote:
Below is David Alan's original patch with lots of changes.
A collective big ACK to this patch!
Pushed it now.
You may want to consolidate all the v1-v10 comments into one
On 05/25/2010 02:49 PM, Eric Blake wrote:
On 05/25/2010 01:12 PM, Jim Meyering wrote:
In reviewing/testing some incoming patches, I noticed a new
make check failure.
There were two problems:
- not diagnosing an invalid host UUID. The lack of this diagnostic
made it slightly more
* src/util/macvtap.c: (associatePortProfileId)
(disassociatePortProfileId): Move inside HAVE_MACVTAP
conditional.
Reported by Eduardo Otubo
---
Pushing as trivial, to fix the build.
src/util/macvtap.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/util/macvtap.c
On 05/25/2010 05:18 AM, Stefan Berger wrote:
---
docs/schemas/domain.rng| 69 +++
src/conf/domain_conf.c | 202
+
Sorry for not noticing sooner, but we really need to do a better job of
updating
A build on Ubuntu reported:
|| Generating formatnwfilter.html.tmp
/dados/develop/libvirt/docs/formatnwfilter.html.in|390| HTML parser error :
Unexpected end tag : p
|| /p
|| ^
/dados/develop/libvirt/docs/formatnwfilter.html.in|705| HTML parser error :
Unexpected end tag : code
||
On 05/25/2010 08:22 PM, Eric Blake wrote:
A build on Ubuntu reported:
|| Generating formatnwfilter.html.tmp
/dados/develop/libvirt/docs/formatnwfilter.html.in|390| HTML parser error :
Unexpected end tag : p
||/p
|| ^
/dados/develop/libvirt/docs/formatnwfilter.html.in|705| HTML parser
Didn't have time to fix this today; virVirtualPortProfileFormat is
conditionally implemented based on PROXY, but unconditionally called.
Throwing it out there in case someone else wants to beat me to the fix.
cc1: warnings being treated as errors
../src/conf/domain_conf.c: In function
On 05/25/2010 05:31 PM, Eduardo Otubo wrote:
On 05/25/2010 08:22 PM, Eric Blake wrote:
A build on Ubuntu reported:
|| Generating formatnwfilter.html.tmp
/dados/develop/libvirt/docs/formatnwfilter.html.in|390| HTML parser
error : Unexpected end tag : p
||/p
|| ^
On 05/24/2010 09:27 PM, Stefan Berger wrote:
Eduardo Otubo ot...@linux.vnet.ibm.com wrote on 05/18/2010 05:01:40 PM:
Please respond to otubo
On 05/14/2010 05:27 PM, Stefan Berger wrote:
+
+virStoragePoolPtr
+phypSPLookupByName(virConnectPtr conn, const char *sp_name)
+{
Hey folks,
I am poking at Sys::Virt a little. Here's a patch to help with
dependencies.
Cheers,
C.J.
$ diff -u Sys-Virt-0.2.4/Makefile.PL Sys-Virt-0.2.4-cjac/Makefile.PL
--- Sys-Virt-0.2.4/Makefile.PL 2010-05-19 11:56:18.0 +
+++ Sys-Virt-0.2.4-cjac/Makefile.PL 2010-05-26
71 matches
Mail list logo
