Re: [libvirt] [PATCH] Fix minor virsh man page typos and formatting problems.

On 06/08/2010 10:23 AM, Eric Blake wrote: On 06/05/2010 04:39 AM, Justin Clift wrote: --- tools/virsh.pod | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 422ae7f..79900e5 100644 --- a/tools/virsh.pod +++

Re: [libvirt] [PATCH] Fix minor virsh man page typos and formatting problems.

On Tue, Jun 08, 2010 at 04:36:05PM +1000, Justin Clift wrote: On 06/08/2010 10:23 AM, Eric Blake wrote: On 06/05/2010 04:39 AM, Justin Clift wrote: --- tools/virsh.pod | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod

Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump

On Mon, Jun 07, 2010 at 04:58:08PM -0400, David Allan wrote: --- src/conf/storage_conf.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 422e76a..7ed49a1 100644 --- a/src/conf/storage_conf.c +++

Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump

On 06/08/2010 06:40 PM, Daniel P. Berrange wrote: snip For paranoia, we should probably use virBufferEscapeString() in this place Found virBufferEscapeString() in buf.c/h, but it's not listed on the API Reference page on the website. Is it supposed to be? Regards and best wishes, Justin

Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump

On Tue, Jun 08, 2010 at 08:20:37PM +1000, Justin Clift wrote: On 06/08/2010 06:40 PM, Daniel P. Berrange wrote: snip For paranoia, we should probably use virBufferEscapeString() in this place Found virBufferEscapeString() in buf.c/h, but it's not listed on the API Reference page on the

[libvirt] [PATCH] Adds the missing vol-pool command to virsh.

Hi all, This patch adds a vol-pool command to virsh, to round out the conversion functions for vols in virsh. At the moment, if we start with a volume name and a pool id, we're all good. We can convert from that pair to either a volume key or volume path. But, if we're given just a volume

Re: [libvirt] [PATCH] Fix minor virsh man page typos and formatting problems.

On 06/08/2010 06:32 PM, Daniel P. Berrange wrote: snip Tip when learning to use git send-email is to send the email to yourself instead of the mailing list first :-) Thanks Daniel. After much gnashing of teeth and getting the hang of things, this looks to be working now when sending to

Re: [libvirt] [PATCH] Adds the missing vol-pool command to virsh.

On 06/08/2010 06:03 AM, Justin Clift wrote: Hi all, Much better - git am liked this patch. And a tip for your matching your commit message style to other commits: list a category first, use all lower-case, and end without a period. While not essential, doing these things will make 'git log

Re: [libvirt] [PATCH] Adds the missing vol-pool command to virsh.

On 06/08/2010 11:17 PM, Eric Blake wrote: On 06/08/2010 06:03 AM, Justin Clift wrote: Hi all, Much better - git am liked this patch. And a tip for your matching your commit message style to other commits: list a category first, use all lower-case, and end without a period. While not

Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump

On Tue, Jun 08, 2010 at 11:31:21AM +0100, Daniel P. Berrange wrote: On Tue, Jun 08, 2010 at 08:20:37PM +1000, Justin Clift wrote: On 06/08/2010 06:40 PM, Daniel P. Berrange wrote: snip For paranoia, we should probably use virBufferEscapeString() in this place Found

[libvirt] [PATCH] virsh: add new vol-pool command

This patch adds a new vol-pool command to virsh, to round out the identifier conversion functions for volumes in virsh. Now it is possible to work with volumes when starting from just a volume key or volume path. --- tools/virsh.c | 48 1 files

Re: [libvirt] PATCH: Include port number with virtio serial devices

On Thu, Jun 03, 2010 at 08:59:27AM -0600, Eric Blake wrote: On 06/03/2010 08:00 AM, Cole Robinson wrote: +++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic

[libvirt] [PATCH] virsh: remove Xen reference in header comment

--- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 1279f41..e444501 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1,5 +1,5 @@ /* - * virsh.c: a Xen shell used to exercise the libvirt API + * virsh.c: a shell to

[libvirt] [PATCH] virsh: fixed trivial comment and debug message in vshCommandOptVolBy function

--- tools/virsh.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index e444501..2e8cbec 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -9411,17 +9411,19 @@ vshCommandOptVolBy(vshControl *ctl, const vshCmd *cmd, if (name)

[libvirt] [PATCH] virsh: add the volume commands to the virsh man page

This patch also includes the new vol-pool command. --- tools/virsh.pod | 105 +++ 1 files changed, 105 insertions(+), 0 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 08e361d..3b0cf16 100644 --- a/tools/virsh.pod +++

[libvirt] [PATCH] Enable probing of VPC disk format type

A look at the QEMU source revealed the missing bits of info about the VPC file format, so we can enable this now * src/util/storage_file.c: Enable VPC format, providing version and disk size offset fields --- src/util/storage_file.c |6 ++ 1 files changed, 2 insertions(+), 4

[libvirt] [PATCH] virsh: add --pool support to vol-key command

--- tools/virsh.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 2e8cbec..1e00114 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -5947,13 +5947,13 @@ cmdVolList(vshControl *ctl, const vshCmd *cmd

Re: [libvirt] [PATCH] Enable probing of VPC disk format type

On 06/08/2010 09:06 AM, Daniel P. Berrange wrote: A look at the QEMU source revealed the missing bits of info about the VPC file format, so we can enable this now * src/util/storage_file.c: Enable VPC format, providing version and disk size offset fields --- src/util/storage_file.c |

[libvirt] [PATCH] virsh: add snapshot backing store support to vol-create-as

This patch adds two new parameters to the vol-create-as command: --snapshot-backing-vol volume-name-or-key-or-path --snapshot-backing-vol-format format-of-backing-vol virsh # vol-create-as guest_images_lvm snapvol1 5G --snapshot-backing-vol \ rhel6vm1lun1 Vol snapvol1 created

Re: [libvirt] [PATCH] virsh: add snapshot backing store support to vol-create-as

On 06/09/2010 02:25 AM, Daniel P. Berrange wrote: snip I think this naming is a little too long. We can shorten to just 'backing-vol' and 'backing-vol-format', since that matches the XML nameing too Sure, no worries. Should I adjust the patch and resubmit? Regards and best wishes, Justin

[libvirt] [PATCH] virsh: add snapshot backing store support to vol-create-as

This patch adds two new parameters to the vol-create-as command: --backing-vol volume-name-or-key-or-path --backing-vol-format format-of-backing-vol virsh # vol-create-as guest_images_lvm snapvol1 5G --backing-vol \ rhel6vm1lun1 Vol snapvol1 created virsh # vol-create-as

Re: [libvirt] [PATCH] virsh: add snapshot backing store support to vol-create-as

On 06/09/2010 02:25 AM, Daniel P. Berrange wrote: I think this naming is a little too long. We can shorten to just 'backing-vol' and 'backing-vol-format', since that matches the XML nameing too Proactively resubmitted. Should come through any second now. :) Regards and best wishes, Justin

[libvirt] [PATCH] Fix enumeration of partitions in disks with a trailing digit in path

Disks with a trailing digit in their path (eg /dev/loop0 or /dev/dm0) have an extra 'p' appended before the partition number (eg, to form /dev/loop0p1 not /dev/loop01). Fix the partition lookup to append this extra 'p' when required * src/storage/parthelper.c: Add a 'p' before partition number

Re: [libvirt] [PATCH] Fix enumeration of partitions in disks with a trailing digit in path

On 06/08/2010 11:27 AM, Daniel P. Berrange wrote: Disks with a trailing digit in their path (eg /dev/loop0 or /dev/dm0) have an extra 'p' appended before the partition number (eg, to form /dev/loop0p1 not /dev/loop01). Fix the partition lookup to append this extra 'p' when required *

Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump

On Tue, Jun 08, 2010 at 09:40:30AM +0100, Daniel P. Berrange wrote: On Mon, Jun 07, 2010 at 04:58:08PM -0400, David Allan wrote: --- src/conf/storage_conf.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c

Re: [libvirt] [PATCH 1/1] Fix leaks in udev device add/remove v3

On 06/07/2010 11:23 AM, David Allan wrote: * This patch is a modification of a patch submitted by Nigel Jones. It fixes several memory leaks on device addition/removal: 1. Free the virNodeDeviceDefPtr in udevAddOneDevice if the return value is non-zero 2. Always release the node

Re: [libvirt] [PATCH 1/1] Fix leaks in udev device add/remove v3

On Tue, Jun 08, 2010 at 12:38:47PM -0600, Eric Blake wrote: On 06/07/2010 11:23 AM, David Allan wrote: * This patch is a modification of a patch submitted by Nigel Jones. It fixes several memory leaks on device addition/removal: 1. Free the virNodeDeviceDefPtr in udevAddOneDevice if

[libvirt] [PATCH 0/3] allow starting qemu in paused state

https://bugzilla.redhat.com/show_bug.cgi?id=589465 This patch series only works for creation of a transient domain from XML, because only virDomainCreateXML() had a flag parameter (the virDomainCreate() API is rather lacking, in that respect). As such, the series is minimally invasive, and can

[libvirt] [PATCH 1/3] virDomainCreateXML: support new flag

* include/libvirt/libvirt.h.in (virDomainCreateFlags): Add VIR_DOMAIN_START_PAUSED. * src/libvirt.c (virDomainCreateXML): Update documentation. * src/lxc/lxc_driver.c (lxcDomainCreateAndStart): Reject new flag as unimplemented. * src/opennebula/one_driver.c (oneDomainCreateAndStart): Likewise. *

[libvirt] Fwd: How do you disable hpet in a kvm?

Forwarding to libvir-list. The KVM developers have been recommending that all guests use -no-hpet flag. Indeed, we've been adding this flag in libguestfs for quite a long time. However I notice that libvirt [in Rawhide] does not include this flag for my guests. Rich. - Forwarded message

[libvirt] [PATCH 2/3] qemu: allow creation of a paused domain

https://bugzilla.redhat.com/show_bug.cgi?id=589465 Some guests (eg with badly configured grub, or Windows' installation cd) require quick response from the console user. That's why we have a launchPaused option in vdsm. To implement it via libvirt, we need to ask libvirt not to call

Re: [libvirt] [PATCH 2/2] Add multiIQN tests

On 06/07/2010 02:58 PM, David Allan wrote: * Fix broken rng schema * Add test input output files --- docs/schemas/storagepool.rng | 16 -- tests/storagepoolxml2xmlin/pool-iscsi-multiiqn.xml | 22

Re: [libvirt] Fwd: How do you disable hpet in a kvm?

On 06/08/2010 03:59 PM, Richard W.M. Jones wrote: Forwarding to libvir-list. The KVM developers have been recommending that all guests use -no-hpet flag. Indeed, we've been adding this flag in libguestfs for quite a long time. However I notice that libvirt [in Rawhide] does not include this

Re: [libvirt] [PATCH 1/3] virDomainCreateXML: support new flag

diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 19d5205..c806441 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -121,7 +121,8 @@ typedef virDomainInfo *virDomainInfoPtr; * Domain. */ typedef enum { - VIR_DOMAIN_NONE

Re: [libvirt] [PATCH 3/3] virsh: add --paused option to create

diff --git a/tools/virsh.c b/tools/virsh.c index 1279f41..6b05949 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1141,6 +1141,7 @@ static const vshCmdOptDef opts_create[] = { #ifndef WIN32 {console, VSH_OT_BOOL, 0, N_(attach to console after creation)}, #endif +{paused,

Re: [libvirt] [PATCH 1/3] virDomainCreateXML: support new flag

On 06/08/2010 02:42 PM, Jiri Denemark wrote: diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in index 19d5205..c806441 100644 --- a/include/libvirt/libvirt.h.in +++ b/include/libvirt/libvirt.h.in @@ -121,7 +121,8 @@ typedef virDomainInfo *virDomainInfoPtr; * Domain.

Re: [libvirt] [PATCH 2/3] qemu: allow creation of a paused domain

https://bugzilla.redhat.com/show_bug.cgi?id=589465 Some guests (eg with badly configured grub, or Windows' installation cd) require quick response from the console user. That's why we have a launchPaused option in vdsm. To implement it via libvirt, we need to ask libvirt not to call

Re: [libvirt] [PATCH 3/3] virsh: add --paused option to create

On 06/08/2010 02:57 PM, Jiri Denemark wrote: +unsigned int paused = (vshCommandOptBool(cmd, paused) + ? VIR_DOMAIN_START_PAUSED + : VIR_DOMAIN_NONE); I'd probably name this variable flags to avoid confusion (or the need to rename it)

Re: [libvirt] [PATCH] Adding support for IVM

On 06/04/2010 03:40 PM, Eduardo Otubo wrote: Adding support for the IBM IVM Virtualization system under Power Hypervisor. @@ -96,12 +99,6 @@ phypOpen(virConnectPtr conn, return VIR_DRV_OPEN_ERROR; } -if (conn-uri-path == NULL) { -

Re: [libvirt] [PATCH] virsh: add new vol-pool command

On 06/08/2010 08:06 AM, Justin Clift wrote: This patch adds a new vol-pool command to virsh, to round out the identifier conversion functions for volumes in virsh. Now it is possible to work with volumes when starting from just a volume key or volume path. When resending, it helps to use

Re: [libvirt] [PATCH] virsh: add the volume commands to the virsh man page

On 06/08/2010 09:00 AM, Justin Clift wrote: This patch also includes the new vol-pool command. Looks good; I also checked 'make man tools/virsh.1' and didn't spot anything obviously wrong in the generated output. Perhaps we want to tweak vol-edit to mention that it uses $EDITOR, to match some

Re: [libvirt] [PATCH] Implement support for virtio plan9fs filesystem passthrough in QEMU

On 06/07/2010 03:32 AM, Daniel P. Berrange wrote: Make use of the existing filesystem element to support plan9fs filesystem passthrough in the QEMU driver filesystem type='mount' source dir='/export/to/guest'/ target dir='/import/from/host'/ /filesystem NB, the

Re: [libvirt] guest clock offset, configuration

On 06/07/2010 08:55 AM, Jakub Hrozek wrote: Hi, I'm having some trouble with guests booting up with huge clock offset (4 hrs). The offset is always the same which leads me to suspecting a configuration issue rather than a bug. I looked around libvirt documentation and so far checked these: