[libvirt] [PATCH] qemu: reduce file padding requirements

2010-06-09 Thread Eric Blake
Followup to https://bugzilla.redhat.com/show_bug.cgi?id=599091, commit 20206a4b, to reduce disk waste in padding. * src/qemu/qemu_monitor.h (QEMU_MONITOR_MIGRATE_TO_FILE_BS): Drop back to 512. (QEMU_MONITOR_MIGRATE_TO_FILE_TRANSFER_SIZE): New macro. * src/qemu/qemu_driver.c (qemudDomainSaveFlag):

Re: [libvirt] [PATCH] Improve error message for disabled client-side drivers

2010-06-09 Thread Eric Blake
On 06/09/2010 05:28 PM, Matthias Bolte wrote: > Report that libvirt was built without that driver instead of > trying to connect to a libvirtd, when we know that this is > going to fail. > --- > > I had this on my todo list for a while now, because multiple people on > the mailing list and on IRC

[libvirt] [PATCH] Improve error message for disabled client-side drivers

2010-06-09 Thread Matthias Bolte
Report that libvirt was built without that driver instead of trying to connect to a libvirtd, when we know that this is going to fail. --- I had this on my todo list for a while now, because multiple people on the mailing list and on IRC reported problems that can be summarized as: "I just built/

[libvirt] [PATCHv2 1/2] build: avoid pthreads-win32 on mingw

2010-06-09 Thread Eric Blake
* src/util/threads.c (includes) [WIN32]: On mingw, favor native threading over pthreads-win32 library. * src/util/thread.h [WIN32] Likewise. Suggested by Daniel P. Berrange. --- Changes from v1: new patch: On 06/03/2010 08:02 AM, Daniel P. Berrange wrote: >>> So, is the libvirt patch worth instal

[libvirt] [PATCHv2 2/2] build: fix some mingw issues

2010-06-09 Thread Eric Blake
On Fedora 13 with sufficient mingw32-* packages installed, running ./autobuild.sh failed to cross-compile to mingw because mingw32-pthreads installed a broken . With that issue fixed, the build still failed due to use of O_SYNC. Meanwhile, recent .spec.in changes got out of sync, and running ./au

Re: [libvirt] [PATCH 2/2] Adjust block size used by dd to speed QEMU domain save operations.

2010-06-09 Thread Eric Blake
On 06/04/2010 08:38 AM, Daniel P. Berrange wrote: >> In that case, it may be better to have two constants - the preferred >> transfer size (1M), and the XML padding block size (512 as before, or >> perhaps 4k given newer disk architectures that prefer 4k), along with >> code that allows the final t

[libvirt] [PATCH] maint: simplify some ignore files

2010-06-09 Thread Eric Blake
* .hgignore: Delete, no longer used. * examples/python/.gitignore: Delete, covered globally. * include/.gitignore: Likewise. * python/tests/.gitignore: Likewise. * docs/schemas/.gitignore: Likewise. * tests/xml2sexprdata/.gitignore: Likewise. * tests/sexpr2xmldata/.gitignore: Likewise. * tests/conf

[libvirt] [PATCH] build: restore operation of bit-rotted 'make cov'

2010-06-09 Thread Eric Blake
'./autobuild.sh' with lcov installed discovered that our coverage support has been bit-rotting for a while. This restores it back to a successful state, although I have not yet spent any time looking through the resulting files to look for low-hanging fruit in the unit test coverage front. * conf

[libvirt] [PATCH 2/2] virsh: introduce change-disk command

2010-06-09 Thread Eric Blake
Implement an idea originally requested 22 Mar 2010. * tools/virsh.c (cmdChangeDisk): New command, providing convenience wrapper around update-device. (commands): List it. * tools/virsh.pod (change-disk): Document it. (attach-disk): Update cross-reference. --- tools/virsh.c | 113 ++

[libvirt] [PATCH 1/2] virsh: document attach-disk better

2010-06-09 Thread Eric Blake
http://bugzilla.redhat.com/601143, part 1 - document existing behavior. Ever since Mar 2010 (commit ced154cb), the use of 'attach-disk' or 'attach-device' to change cdrom/floppy media has been documented but deprecated, but the replacement to use 'update-device' was not documented. * tools/virsh.

[libvirt] [PATCH 0/2] virsh: document and improve cdrom-change semantics

2010-06-09 Thread Eric Blake
http://bugzilla.redhat.com/601143 complained that there was no documentation of the fact that 'attach-disk' on a floppy or cdrom is really way to change the contents of the media in that disk, rather than a request to add a second virtual device. Back in March, we changed things to add a new comman

Re: [libvirt] [PATCH 1/2] Add multiiqn XML dump

2010-06-09 Thread Daniel P. Berrange
On Tue, Jun 08, 2010 at 10:04:56AM -0400, Hugh O. Brock wrote: > On Tue, Jun 08, 2010 at 11:31:21AM +0100, Daniel P. Berrange wrote: > > On Tue, Jun 08, 2010 at 08:20:37PM +1000, Justin Clift wrote: > > > On 06/08/2010 06:40 PM, Daniel P. Berrange wrote: > > > > > > >For paranoia, we should probab

Re: [libvirt] [PATCH 0/3] allow starting qemu in paused state

2010-06-09 Thread Eric Blake
On 06/09/2010 06:07 AM, Daniel P. Berrange wrote: >> If desired, a later patch can add hooks >> (either a new XML element, or a new command comparable to autostart >> that can toggle the state of a hidden field associated with domains) >> so that virDomainCreate() can also be used to start a paused

Re: [libvirt] [PATCH] virsh: add the volume commands to the virsh man page

2010-06-09 Thread Justin Clift
On 06/09/2010 11:59 PM, Eric Blake wrote: Sorry for any confusion. No stress. :) Regards and best wishes, Justin Clift -- Salasaga - Open Source eLearning IDE http://www.salasaga.org -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/

Re: [libvirt] [PATCH] virsh: add the volume commands to the virsh man page

2010-06-09 Thread Eric Blake
On 06/08/2010 07:05 PM, Eric Blake wrote: > On 06/08/2010 09:00 AM, Justin Clift wrote: >> This patch also includes the new vol-pool command. > > Looks good; I also checked 'make && man tools/virsh.1' and didn't spot > anything obviously wrong in the generated output. > > Perhaps we want to tweak

Re: [libvirt] [PATCH] virsh: fixed trivial comment and debug message in vshCommandOptVolBy function

2010-06-09 Thread Eric Blake
On 06/08/2010 08:46 AM, Justin Clift wrote: > --- > tools/virsh.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/virsh.c b/tools/virsh.c > index e444501..2e8cbec 100644 > --- a/tools/virsh.c > +++ b/tools/virsh.c > @@ -9411,17 +9411,19 @@ vshCommandOptVol

Re: [libvirt] [PATCH] virsh: add snapshot backing store support to vol-create-as

2010-06-09 Thread Daniel P. Berrange
On Wed, Jun 09, 2010 at 02:38:32AM +1000, Justin Clift wrote: > This patch adds two new parameters to the vol-create-as command: > > --backing-vol > --backing-vol-format > > virsh # vol-create-as guest_images_lvm snapvol1 5G --backing-vol \ > rhel6vm1lun1 > Vol snapvol1 crea

Re: [libvirt] [PATCH 0/3] allow starting qemu in paused state

2010-06-09 Thread Daniel P. Berrange
On Tue, Jun 08, 2010 at 01:53:49PM -0600, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=589465 > > This patch series only works for creation of a transient domain from > XML, because only virDomainCreateXML() had a flag parameter (the > virDomainCreate() API is rather lacking, in

Re: [libvirt] [PATCH] virsh: remove xen reference in header comment v2

2010-06-09 Thread Eric Blake
On 06/09/2010 03:00 AM, Justin Clift wrote: > With libvirt and virsh now being used for much more than Xen, this > patch removes the outdated reference to Xen in the file header. > > --- > > Also changed the commit message to be all lower case, as previously > mentioned by Eric. ;) You're pickin

Re: [libvirt] [PATCH] esx: Refactor esxUtil_ParseQuery's parameter handling

2010-06-09 Thread Matthias Bolte
2010/6/4 Eric Blake : > On 06/03/2010 06:05 PM, Matthias Bolte wrote: >> Pass a struct containing the parameters instead of passing each >> one individually. This make future extensions a bit simpler. >> --- >>  src/esx/esx_driver.c |   44 ++--- >>  src/esx/esx_util.c   |  100 >> +

Re: [libvirt] [PATCH] esx: Add proxy query parameter

2010-06-09 Thread Matthias Bolte
2010/6/4 Eric Blake : > On 06/03/2010 06:06 PM, Matthias Bolte wrote: >> Allow to specify a proxy to be used by libcurl. >> --- >>  docs/drvesx.html.in  |   20 - >>  src/esx/esx_driver.c |   12 +++--- >>  src/esx/esx_util.c   |   57 >> ++

[libvirt] [PATCH] virsh: add pool support to vol-key command v2

2010-06-09 Thread Justin Clift
Presently the vol-key command only supports being provided with a volume path. This patch adds support for providing it with a pool and volume identifier pair as well. virsh # vol-key --pool --- This is a clean patch against current git head, plus avoids a potential memory leak in the prev

Re: [libvirt] [PATCH] virsh: add new vol-pool command

2010-06-09 Thread Justin Clift
On 06/09/2010 10:54 AM, Eric Blake wrote: When resending, it helps to use 'git send-email --subject-prefix=PATCHv2' to call attention to the fact that it is a resend. Thanks Eric. I'll resend the outstanding ones with v2 in the Subject line. Please disregard any ones without v2 prior to this

[libvirt] [PATCH] virsh: remove xen reference in header comment v2

2010-06-09 Thread Justin Clift
With libvirt and virsh now being used for much more than Xen, this patch removes the outdated reference to Xen in the file header. --- Also changed the commit message to be all lower case, as previously mentioned by Eric. ;) tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions