[libvirt] Virtual disk size associated with a Domain

2010-06-11 Thread IKI-サガル バルウェ
Hello, Is there any way to fetch the size of all the virtual disks associated with a Domain?? I could not find one in the libvirt API., I tried using 'virStorageVol' and 'virStoragePool', but they returned null objects. Also I fetched 'virDomainBlockStats', but did not understand the

Re: [libvirt] Create a copy of a Domain

2010-06-11 Thread Daniel P. Berrange
On Fri, Jun 11, 2010 at 10:22:18AM +0900, IKI-サガル バルウェ wrote: Thanks Daniel, I think you must at least change the UUID (/domain/uuid) and name (/domain/name) in the XML description. Very like you also need to duplicate the used disk images and update their paths

Re: [libvirt] Virtual disk size associated with a Domain

2010-06-11 Thread Daniel P. Berrange
On Fri, Jun 11, 2010 at 06:09:19PM +0900, IKI-サガル バルウェ wrote: Hello, Is there any way to fetch the size of all the virtual disks associated with a Domain?? I could not find one in the libvirt API., I tried using 'virStorageVol' and 'virStoragePool', but they returned null objects. Also

[libvirt] [PATCHv3 0/2] virsh: add pool support to vol-key, plus help text fix

2010-06-11 Thread Justin Clift
Hi all, The following two patches are a resubmission. The first adds --pool support to the vol-key command. The seconds improves the help text for the vol-name, vol-path, and vol-key commands. Hopefully now I have the patch prefix correct as well. :) Regards and best wishes, Justin Clift

[libvirt] [PATCHv3 1/2] virsh: add pool support to vol-key command

2010-06-11 Thread Justin Clift
Presently the vol-key command only supports being provided with a volume path. This patch adds support for providing it with a pool and volume identifier pair as well. virsh # vol-key --pool pool-name-or-uuid vol-name-or-path --- This is a clean patch against current git head, plus avoids a

[libvirt] [PATCHv3 2/2] virsh: improve help text for vol query commands

2010-06-11 Thread Justin Clift
Improves the help text for vol-path, vol-name, and vol-key, which previously referred to volume UUIDs. Addresses BZ # 598365. --- tools/virsh.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 7d8ae0e..8c9ae83 100644 ---

[libvirt] sound hardware?

2010-06-11 Thread Brandon Thomas
Are there any plans for adding functionality so that the pulse-audio server can be used as a sound hardware device? Brandon -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] Trivial virsh.pod additions --all for list command and similar

2010-06-11 Thread Justin Clift
Hi all, This is just a trivial patch to virsh.pod (from git master). It adds the following pieces to the virsh man page: + Shows the --inactive and --all optional parameters for the list command. Closes Bugzilla #575512, reported by Renich Bon Ciric (CC'd)

Re: [libvirt] [PATCH] [PATCH v13-pre1] add 802.1Qbh and 802.1Qbg handling

2010-06-11 Thread Vivek Kashyap
Stefan Berger stef...@linux.vnet.ibm.com wrote on 05/29/2010 05:20:52 AM: From: Stefan Berger stef...@linux.vnet.ibm.com To: Scott Feldman scofe...@cisco.com, a...@arndb.de, Vivek Kashyap/ Beaverton/i...@ibmus Cc: libvir-list@redhat.com, Stefan Berger/Watson/i...@ibmus Date:

[libvirt] wrong path of domblkstat

2010-06-11 Thread jbuy0710
Hi all: I tried to use virsh domblkstat to get block information of a vm(xen para-virtualized), and it returns error message like this error: Failed to get block stats vm1 hda error: internal error read_bd_stats: Failed to read any block statistics I found the code in

[libvirt] Update to libvirt-lxc driver doc page

2010-06-11 Thread Serge Hallyn
Here is a new drvlxc.html.in file to make the first example work. I'll play with the second example next. thanks, -serge LXC container driver The libvirt LXC driver manages "Linux Containers". Containers are sets of processes with private namespaces which can (but don't always) look

Re: [libvirt] PATCH: support virtual disks

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 10:52:28AM -0700, Andrew Farmer wrote: Libvirt currently makes the assumption that disk devices are always accessible as files on the local system. However, certain types of virtual storage on qemu (e.g, NBD) may not be. This patch defines a new virtual disk device

Re: [libvirt] [PATCHv2 1/5] libvirt: introduce domainCreateWithFlags API

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 12:21:19PM -0600, Eric Blake wrote: Persistent domain creation needs the same features as transient domains, but virDomainCreate lacks the flags argument present in virDomainCreateXML. virDomainCreateFlags is already claimed as a public enum, so we have to break

Re: [libvirt] [PATCHv2 4/5] qemu: support starting persistent domain paused

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 12:21:22PM -0600, Eric Blake wrote: Match earlier change for qemu pause support with virDomainCreateXML. * src/qemu/qemu_driver.c (qemudDomainObjStart): Add parameter; all callers changed. (qemudDomainStartWithFlags): Implement flag support. ---

Re: [libvirt] [PATCHv2 3/5] drivers: add virDomainCreateWithFlags if virDomainCreate exists

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 12:21:21PM -0600, Eric Blake wrote: * src/esx/esx_driver.c (esxDomainCreate): Move guts... (esxDomainCreateWithFlags): ...to new function. (esxDriver): Trivially support the new API. * src/lxc/lxc_driver.c (lxcDomainStart, lxcDomainStartWithFlags) (lxcDriver):

Re: [libvirt] [PATCHv2 2/5] remote: protocol implementation for virDomainCreateWithFlags

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 12:21:20PM -0600, Eric Blake wrote: Define the wire format for the new virDomainCreateWithFlags API, and implement client and server side of marshaling code. * daemon/remote.c (remoteDispatchDomainCreateWithFlags): Add server side dispatch for

Re: [libvirt] [PATCHv2 5/5] virsh: add start --paused support

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 12:21:23PM -0600, Eric Blake wrote: Make 'start --paused' mirror 'create --paused'. * tools/virsh.c (cmdStart): Use new virDomainCreateWithFlags API when needed. * tools/virsh.pod (start): Document --paused. --- diff from v1: favor older API rather than newer API

Re: [libvirt] [PATCH] vbox: check getenv(DISPLAY) for NULL in vboxDomainDumpXML

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 10:44:33PM +0200, Matthias Bolte wrote: Otherwise this will segfault if DISPLAY is not defined. --- src/vbox/vbox_tmpl.c | 16 ++-- 1 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index

Re: [libvirt] [PATCH] Check getenv(PATH) for NULL in virFindFileInPath

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 10:42:56PM +0200, Matthias Bolte wrote: Otherwise this will segfault if PATH is not defined. Reported by Emre Erenoglu --- src/util/util.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index

Re: [libvirt] [PATCHv3 1/2] virsh: add pool support to vol-key command

2010-06-11 Thread Daniel P. Berrange
On Fri, Jun 11, 2010 at 09:51:55PM +1000, Justin Clift wrote: Presently the vol-key command only supports being provided with a volume path. This patch adds support for providing it with a pool and volume identifier pair as well. virsh # vol-key --pool pool-name-or-uuid

Re: [libvirt] [PATCHv3 2/2] virsh: improve help text for vol query commands

2010-06-11 Thread Daniel P. Berrange
On Fri, Jun 11, 2010 at 09:52:24PM +1000, Justin Clift wrote: Improves the help text for vol-path, vol-name, and vol-key, which previously referred to volume UUIDs. Addresses BZ # 598365. --- tools/virsh.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) ACK Daniel --

Re: [libvirt] wrong path of domblkstat

2010-06-11 Thread Chris Lalancette
On 06/10/10 - 10:46:52AM, jbuy0710 wrote: Hi all: I tried to use virsh domblkstat to get block information of a vm(xen para-virtualized), and it returns error message like this error: Failed to get block stats vm1 hda error: internal error read_bd_stats: Failed to read any block

Re: [libvirt] Planning for libvirt-0.8.2 release

2010-06-11 Thread Chris Lalancette
On 06/11/10 - 01:09:14AM, Daniel Veillard wrote: As some may have noticed I'm a bit away from the list, and will still for one more week. If we want to plan for a friday 25 release as suggested a couple of week ago this means we have one more week for commiting big changes (e.g. the new

[libvirt] [PATCH] nwfilter: use match target on incoming traffic

2010-06-11 Thread Stefan Berger
The following patch enables the iptables match target to be used by default for incoming traffic. So far it has only be used for outgoing traffic. Signed-off-by: Stefan Berger --- src/nwfilter/nwfilter_ebiptables_driver.c | 19 ++- 1 file changed, 14 insertions(+), 5

Re: [libvirt] [PATCH] Improve error message for disabled client-side drivers

2010-06-11 Thread Daniel P. Berrange
On Thu, Jun 10, 2010 at 01:28:29AM +0200, Matthias Bolte wrote: Report that libvirt was built without that driver instead of trying to connect to a libvirtd, when we know that this is going to fail. --- I had this on my todo list for a while now, because multiple people on the mailing list

[libvirt] [PATCH] nwfilter: add XML attribute to control match target

2010-06-11 Thread Stefan Berger
This patch adds an optional XML attribute to a nwfilter rule to give the user control over whether the rule is supposed to be using the match target or not. A rule may now look like as follows with the nomatch attribute either having value '1' or 'true' (case-insensitive). [...] rule

Re: [libvirt] [PATCH] nwfilter: add XML attribute to control match target

2010-06-11 Thread Daniel P. Berrange
On Fri, Jun 11, 2010 at 10:41:50AM -0400, Stefan Berger wrote: This patch adds an optional XML attribute to a nwfilter rule to give the user control over whether the rule is supposed to be using the match target or not. A rule may now look like as follows with the nomatch attribute either

Re: [libvirt] [PATCH] vbox: check getenv(DISPLAY) for NULL in vboxDomainDumpXML

2010-06-11 Thread Matthias Bolte
2010/6/11 Daniel P. Berrange berra...@redhat.com: On Thu, Jun 10, 2010 at 10:44:33PM +0200, Matthias Bolte wrote: Otherwise this will segfault if DISPLAY is not defined. ---  src/vbox/vbox_tmpl.c |   16 ++--  1 files changed, 10 insertions(+), 6 deletions(-) diff --git

Re: [libvirt] [PATCH] Check getenv(PATH) for NULL in virFindFileInPath

2010-06-11 Thread Matthias Bolte
2010/6/11 Daniel P. Berrange berra...@redhat.com: On Thu, Jun 10, 2010 at 10:42:56PM +0200, Matthias Bolte wrote: Otherwise this will segfault if PATH is not defined. Reported by Emre Erenoglu ---  src/util/util.c |    5 -  1 files changed, 4 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] Improve error message for disabled client-side drivers

2010-06-11 Thread Matthias Bolte
2010/6/11 Daniel P. Berrange berra...@redhat.com: On Thu, Jun 10, 2010 at 01:28:29AM +0200, Matthias Bolte wrote: Report that libvirt was built without that driver instead of trying to connect to a libvirtd, when we know that this is going to fail. --- I had this on my todo list for a while

[libvirt] [PATCH] virsh: add --uuid option to vol-pool

2010-06-11 Thread Justin Clift
Adds an optional switch, --uuid, for telling the virsh vol-pool command to return the pool UUID rather than pool name. --- Just added for flexibility. tools/virsh.c | 13 +++-- tools/virsh.pod |8 +--- 2 files changed, 16 insertions(+), 5 deletions(-) diff --git

Re: [libvirt] [PATCH] Improve error message for disabled client-side drivers

2010-06-11 Thread Daniel P. Berrange
On Fri, Jun 11, 2010 at 06:25:29PM +0200, Matthias Bolte wrote: 2010/6/11 Daniel P. Berrange berra...@redhat.com: On Thu, Jun 10, 2010 at 01:28:29AM +0200, Matthias Bolte wrote: Report that libvirt was built without that driver instead of trying to connect to a libvirtd, when we know that

[libvirt] Fwd: Re: [PATCH] nwfilter: add XML attribute to control match target

2010-06-11 Thread Stefan Berger
On 06/11/2010 10:53 AM, Daniel P. Berrange wrote: On Fri, Jun 11, 2010 at 10:41:50AM -0400, Stefan Berger wrote: This patch adds an optional XML attribute to a nwfilter rule to give the user control over whether the rule is supposed to be using the match target or not. A rule may now look

Re: [libvirt] [PATCHv2-resend] uml: sanity check external data before using it

2010-06-11 Thread Eric Blake
On 06/10/2010 02:06 PM, Matthias Bolte wrote: 2010/6/10 Eric Blake ebl...@redhat.com: Otherwise, a malicious packet could cause a DoS via spurious out-of-memory failure. * src/uml/uml_driver.c (umlMonitorCommand): Validate that incoming data is reliable before using it to

Re: [libvirt] [PATCH] Add -nodefconfig to the QEMU argv

2010-06-11 Thread Eric Blake
On 06/10/2010 12:19 PM, Daniel P. Berrange wrote: We already use the '-nodefaults' command line arg with QEMU to stop it adding any default devices to guests. Unfortunately, QEMU will load global config files from /etc/qemu that may also add default devices. These aren't blocked by

Re: [libvirt] [PATCH] Improve error message for disabled client-side drivers

2010-06-11 Thread Matthias Bolte
2010/6/11 Daniel P. Berrange berra...@redhat.com: On Fri, Jun 11, 2010 at 06:25:29PM +0200, Matthias Bolte wrote: 2010/6/11 Daniel P. Berrange berra...@redhat.com: On Thu, Jun 10, 2010 at 01:28:29AM +0200, Matthias Bolte wrote: Report that libvirt was built without that driver instead of

Re: [libvirt] [PATCH] Improve error message for disabled client-side drivers

2010-06-11 Thread Eric Blake
On 06/11/2010 10:45 AM, Matthias Bolte wrote: I started this patch like that. I added a minimal driver that does exactly that and I edited virInitialize like this: # ifdef WITH_ESX if (esxRegister() == -1) return -1; # else if (disabledRegister(esx) == -1) return -1; if

[libvirt] [PATCH v2] nwfilter: add XML attribute to control match target

2010-06-11 Thread Stefan Berger
This patch adds an optional XML attribute to a nwfilter rule to give the user control over whether the rule is supposed to be using the state match or not. A rule may now look like shown in the XML below with the statematch attribute either having value '0' or 'false' (case-insensitive).

Re: [libvirt] PATCH: support virtual disks

2010-06-11 Thread Andrew Farmer
On 11 Jun 2010, at 06:28, Daniel P. Berrange wrote: On Thu, Jun 10, 2010 at 10:52:28AM -0700, Andrew Farmer wrote: Libvirt currently makes the assumption that disk devices are always accessible as files on the local system. However, certain types of virtual storage on qemu (e.g, NBD) may not

[libvirt] [PATCH] esx: Accept 'disk' as harddisk device type in .vmx files

2010-06-11 Thread Matthias Bolte
--- src/esx/esx_vmx.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index 5cadb5a..675318f 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -1542,16 +1542,20 @@ esxVMX_ParseDisk(esxVI_Context *ctx, virConfPtr

[libvirt] [PATCH] esx: Update case insensitive .vmx tests

2010-06-11 Thread Matthias Bolte
Commit b9efc7dc3b97ef667ab99cee884b8485ebcb2f91 made virFileHasSuffix case insensitive. Honor this in the tests by switching vmdk to VMDK. --- tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx |2 +- tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml |2 +- 2 files changed, 2 insertions(+),