Re: [libvirt] [PATCHv2] virsh: tweak help output for VSH_OT_DATA

2010-06-29 Thread Laine Stump
On 06/29/2010 07:09 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=609044 complained that 'virsh help pool-create-as' didn't document the shortcut that you can do 'virsh pool-create-as $name $type --target $target' rather than having to supply the four optional source- argumen

[libvirt] [PATCHv2] virsh: tweak help output for VSH_OT_DATA

2010-06-29 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=609044 complained that 'virsh help pool-create-as' didn't document the shortcut that you can do 'virsh pool-create-as $name $type --target $target' rather than having to supply the four optional source- arguments in order to fill out the necessary positio

Re: [libvirt] [PATCH] virsh: tweak help output for VSH_OT_DATA

2010-06-29 Thread Eric Blake
On 06/29/2010 04:21 PM, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=609044 complained > that 'virsh help pool-create-as' didn't document the shortcut > that you can do 'virsh pool-create-as $name $type --target $target' > rather than having to supply the four optional source- ar

[libvirt] [PATCH] virsh: tweak help output for VSH_OT_DATA

2010-06-29 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=609044 complained that 'virsh help pool-create-as' didn't document the shortcut that you can do 'virsh pool-create-as $name $type --target $target' rather than having to supply the four optional source- arguments in order to fill out the necessary positio

Re: [libvirt] [PATCH v2] vbox: Let configure detect/set the XPCOMC directory

2010-06-29 Thread Eric Blake
On 06/29/2010 03:29 PM, Matthias Bolte wrote: > This allows the user to give an explicit path to configure > > ./configure --with-vbox=/path/to/virtualbox > > instead of having the VirtualBox driver probe a set of possible > paths at runtime. If no explicit path is specified then configure > pr

[libvirt] [PATCH v2] vbox: Let configure detect/set the XPCOMC directory

2010-06-29 Thread Matthias Bolte
This allows the user to give an explicit path to configure ./configure --with-vbox=/path/to/virtualbox instead of having the VirtualBox driver probe a set of possible paths at runtime. If no explicit path is specified then configure probes the set of "known" paths. https://bugzilla.redhat.com/

Re: [libvirt] [PATCH] vbox: Let configure detect/set the XPCOMC directory

2010-06-29 Thread Eric Blake
On 06/29/2010 12:27 PM, Matthias Bolte wrote: > This allows the user to give an explicit path to configure > > ./configure --with-vbox=/path/to/virtualbox > > instead of having the VirtualBox driver probe a set of possible > paths at runtime. If no explicit path is specified then configure > pr

[libvirt] [PATCH] vbox: Let configure detect/set the XPCOMC directory

2010-06-29 Thread Matthias Bolte
This allows the user to give an explicit path to configure ./configure --with-vbox=/path/to/virtualbox instead of having the VirtualBox driver probe a set of possible paths at runtime. If no explicit path is specified then configure probes the set of "known" paths. https://bugzilla.redhat.com/

Re: [libvirt] [PATCH] cgroup: Add missing errno == ENOENT check in virCgroupRemoveRecursively

2010-06-29 Thread Eric Blake
On 06/28/2010 08:49 PM, Ryota Ozaki wrote: >>> grpdir = opendir(grppath); >>> if (grpdir == NULL) { >>> +if (errno == ENOENT) >>> +return 0; >> >> Shouldn't this be continue instead of return 0, so as to go on to the >> next readdir() in case there is anything else in

Re: [libvirt] Update on PHP libvirt

2010-06-29 Thread Radek Hladik
Dne 29.6.2010 17:04, Justin Clift napsal(a): This looks like a very worthwhile effort. Would you be ok with us adding a link from our list? http://libvirt.org/bindings.html It would be great. Radek smime.p7s Description: S/MIME Cryptographic Signature -- libvir-list mailing list libvir-l

Re: [libvirt] Libvirt synchronous hooks

2010-06-29 Thread edison
I have the same problem, that needs to do some extra things, not supported by libvirt API, such as setting up vlan, getting host/guest statistics etc. Right now, I have agent running on the host, which communicating with my management server. My agent is connecting to libvirt daemon on the same mac

Re: [libvirt] Update on PHP libvirt

2010-06-29 Thread Radek Hladik
Dne 29.6.2010 17:38, Eric Blake napsal(a): On 06/29/2010 09:27 AM, David W King wrote: I'm running Ubuntu 10.04 with php 5.3.2. In order to get the extension to compile I had to apply the attached patch. Could you please resend that patch as a context diff? ed script diffs are practically im

Re: [libvirt] Update on PHP libvirt

2010-06-29 Thread David W King
Sorry. Here's the diff -urp output. The compiler output is: /root/php-libvirt/libvirt.c:19: error: duplicate ‘static’ David King Goshen College ITS davi...@goshen.edu 574-535-7726 On 06/29/2010 11:38 AM, Eric Blake wrote: > On 06/29/2010 09:27 AM, David W King wrote: >> I'm running Ubuntu 10.

Re: [libvirt] [PATCHv5 1/2] virsh: add new --details option to pool-list

2010-06-29 Thread Justin Clift
On 06/30/2010 12:38 AM, Eric Blake wrote: We really DO want to give 0 exit status, after listing a header but no clients. However, the rest of your patch is in good shape, so I squashed this in: Thanks Eric. Got it. :) The output does look better now if there weren't any pools too. Regards

Re: [libvirt] Update on PHP libvirt

2010-06-29 Thread Eric Blake
On 06/29/2010 09:27 AM, David W King wrote: > I'm running Ubuntu 10.04 with php 5.3.2. In order to get the extension > to compile I had to apply the attached patch. Could you please resend that patch as a context diff? ed script diffs are practically impossible to apply correctly if anything els

Re: [libvirt] Update on PHP libvirt

2010-06-29 Thread David W King
I'm running Ubuntu 10.04 with php 5.3.2. In order to get the extension to compile I had to apply the attached patch. ~david David King Goshen College ITS davi...@goshen.edu 574-535-7726 On 06/29/2010 10:18 AM, Radek Hladik wrote: > I would like to post some update about PHP bindings for libvir

Re: [libvirt] Update on PHP libvirt

2010-06-29 Thread Justin Clift
On 06/30/2010 12:18 AM, Radek Hladik wrote: The code (available at http://phplibvirt.cybersales.cz/ ) implements basic Libvirt functions for readonly access and machine live-cycle management. I should be able to add any other libvirt function but i do not know all the libvirt functions so well.

Re: [libvirt] [PATCH 1/2] Check for active PCI devices when doing nodedevice operations.

2010-06-29 Thread Chris Lalancette
On 06/22/10 - 03:33:43PM, Eric Blake wrote: > On 06/15/2010 06:35 AM, Chris Lalancette wrote: > > On 06/15/10 - 01:13:00PM, Daniel P. Berrange wrote: > >> You're accessing 'driver' here without first locking it > > > > D'oh, of course. Thanks for that. Updated patch below. > > > > > >>From 56b

Re: [libvirt] [PATCH 2/2] Fix crash when detaching devices from qemu domains.

2010-06-29 Thread Chris Lalancette
On 06/22/10 - 03:38:19PM, Eric Blake wrote: > On 06/15/2010 06:03 AM, Chris Lalancette wrote: > > Make sure to *not* call qemuDomainPCIAddressReleaseAddr if > > QEMUD_CMD_FLAG_DEVICE is *not* set (for older qemu). This > > prevents a crash when trying to do device detachment from > > a qemu guest.

Re: [libvirt] [PATCHv5 1/2] virsh: add new --details option to pool-list

2010-06-29 Thread Eric Blake
On 06/28/2010 10:47 AM, Justin Clift wrote: > This patch adds a new --details option to the virsh pool-list > command, making its output more useful to people who use virsh > for significant lengths of time. > > Addresses BZ # 605543 > > https://bugzilla.redhat.com/show_bug.cgi?id=605543 > > -

[libvirt] Update on PHP libvirt

2010-06-29 Thread Radek Hladik
I would like to post some update about PHP bindings for libvirt I started last year. As usual I do not have enough time to work on it however the last version 0.3 seems to be quite stable. I did get some reports from people using it and it seems that the code is working without problems. I will

[libvirt] Libvirt synchronous hooks

2010-06-29 Thread Radek Hladik
I am trying Libvirt synchronous hooks and I would like to ask a question. I would like to use the machine start (qemu+kvm) hook to set up the storage for the machine. I already mentioned my setup in this mailing list but for now it is only important that VM storage is a md raid constructed from

Re: [libvirt] [PATCH] virFileResolveLink: guarantee an absolute path

2010-06-29 Thread Eric Blake
On 06/29/2010 02:40 AM, Daniel Veillard wrote: > On Mon, Jun 28, 2010 at 03:09:39PM -0600, Eric Blake wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=608092 >> >> * src/util/util.c (virFileResolveLink): Use >> canonicalize_file_name, rather than areadlink. >> --- >> > > ACK, that's a relat

Re: [libvirt] [PATCH] Avoid calling virStorageFileIsSharedFS with NULL

2010-06-29 Thread Eric Blake
On 06/29/2010 02:41 AM, Daniel Veillard wrote: > On Mon, Jun 28, 2010 at 11:58:43PM -0400, Laine Stump wrote: >> On 06/28/2010 11:54 PM, Laine Stump wrote: >>> From: Laine Stump >>> >>> This code was just recently added (by me) and didn't account for the >>> fact that stdin_path is sometimes NULL.

Re: [libvirt] [PATCHv2] phyp: don't steal storage management from other drivers

2010-06-29 Thread Eric Blake
On 06/29/2010 02:34 AM, Daniel P. Berrange wrote: > On Mon, Jun 28, 2010 at 02:21:46PM -0600, Eric Blake wrote: >> Fix regression introduced in commit a4a287242 - basically, the >> phyp storage driver should only accept the same URIs that the >> main phyp driver is willing to accept. Blindly accep

Re: [libvirt] [PATCH] Avoid invoking the qemu monitor destroy callback if the constructor fails

2010-06-29 Thread Eric Blake
On 06/29/2010 05:02 AM, Daniel P. Berrange wrote: > Some, but not all, codepaths in the qemuMonitorOpen() method > would trigger the destroy callback. The caller does not expect > this to be invoked if construction fails, only during normal > release of the monitor. This resulted in a possible doub

[libvirt] [PATCH] Avoid invoking the qemu monitor destroy callback if the constructor fails

2010-06-29 Thread Daniel P. Berrange
Some, but not all, codepaths in the qemuMonitorOpen() method would trigger the destroy callback. The caller does not expect this to be invoked if construction fails, only during normal release of the monitor. This resulted in a possible double-unref of the virDomainObjPtr, because the caller explic

Re: [libvirt] Segfault in virDomainObjListSearchName when listing domains (qemu backend)

2010-06-29 Thread Daniel P. Berrange
On Mon, Jun 28, 2010 at 07:29:43PM +0200, Guido Winkelmann wrote: > Am Montag, 28. Juni 2010 schrieben Sie: > > On Mon, Jun 28, 2010 at 06:06:00PM +0200, Guido Winkelmann wrote: > > > Another segfault, again after calling list in virsh after a domain failed > > > to start: > > > > I haven't reprod

Re: [libvirt] [PATCH] Avoid calling virStorageFileIsSharedFS with NULL

2010-06-29 Thread Daniel Veillard
On Mon, Jun 28, 2010 at 11:58:43PM -0400, Laine Stump wrote: > On 06/28/2010 11:54 PM, Laine Stump wrote: > >From: Laine Stump > > > >This code was just recently added (by me) and didn't account for the > >fact that stdin_path is sometimes NULL. If it's NULL, and > >SetSecurityAllLabel fails, a se

Re: [libvirt] [PATCH] virFileResolveLink: guarantee an absolute path

2010-06-29 Thread Daniel Veillard
On Mon, Jun 28, 2010 at 03:09:39PM -0600, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=608092 > > * src/util/util.c (virFileResolveLink): Use > canonicalize_file_name, rather than areadlink. > --- > > For this patch, I chose to avoid any symlink resolution if an > lstat shows t

Re: [libvirt] [PATCHv2] phyp: don't steal storage management from other drivers

2010-06-29 Thread Daniel P. Berrange
On Mon, Jun 28, 2010 at 02:21:46PM -0600, Eric Blake wrote: > Fix regression introduced in commit a4a287242 - basically, the > phyp storage driver should only accept the same URIs that the > main phyp driver is willing to accept. Blindly accepting all > URIs meant that the phyp storage driver was