Re: [libvirt] [PATCH] cgroup: Add missing errno == ENOENT check in virCgroupRemoveRecursively

2010-06-30 Thread Ryota Ozaki
On Wed, Jun 30, 2010 at 3:21 AM, Eric Blake ebl...@redhat.com wrote: On 06/28/2010 08:49 PM, Ryota Ozaki wrote:      grpdir = opendir(grppath);      if (grpdir == NULL) { +        if (errno == ENOENT) +            return 0; Shouldn't this be continue instead of return 0, so as to go on to

[libvirt] [PATCH] cgroup: Fix compilation broken on MinGW due to dirent-d_type

2010-06-30 Thread Ryota Ozaki
As pointed out by Eric Blake, using dirent-d_type breaks compilation on MinGW. This patch addresses this by using '#if defined' as same as doing for virCgroupForDriver. --- src/util/cgroup.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/util/cgroup.c

Re: [libvirt] [PATCH] cgroup: Fix compilation broken on MinGW due to dirent-d_type

2010-06-30 Thread Ryota Ozaki
On Wed, Jun 30, 2010 at 8:49 PM, Ryota Ozaki ozaki.ry...@gmail.com wrote: As pointed out by Eric Blake, using dirent-d_type breaks compilation on MinGW. This patch addresses this by using '#if defined' as same as doing for virCgroupForDriver. Note that I didn't test this patch because I don't

Re: [libvirt] [PATCH] Avoid invoking the qemu monitor destroy callback if the constructor fails

2010-06-30 Thread Jiri Denemark
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f428665..ff613a0 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -671,6 +671,12 @@ qemuMonitorOpen(virDomainObjPtr vm, return mon; cleanup: +/* We don't want the 'destroy' callback

Re: [libvirt] [PATCH] Avoid invoking the qemu monitor destroy callback if the constructor fails

2010-06-30 Thread Daniel P. Berrange
On Wed, Jun 30, 2010 at 02:40:58PM +0200, Jiri Denemark wrote: diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index f428665..ff613a0 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -671,6 +671,12 @@ qemuMonitorOpen(virDomainObjPtr vm, return

Re: [libvirt] [PATCHv2] virsh: tweak help output for VSH_OT_DATA

2010-06-30 Thread Eric Blake
On 06/29/2010 05:48 PM, Laine Stump wrote: On 06/29/2010 07:09 PM, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=609044 complained that 'virsh help pool-create-as' didn't document the shortcut that you can do 'virsh pool-create-as $name $type --target $target' rather than

[libvirt] [PATCH] html docs: add link to PHP bindings by Radek Hladik

2010-06-30 Thread Justin Clift
--- docs/bindings.html.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 63cd740..ee63ce3 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -16,6 +16,7 @@ higher level kind of languages:/p

[libvirt] Ask for help about libvirt error: can't get physical interface data for kvm.

2010-06-30 Thread Feng Dan Liu
Hi I find this mail address from the internet and hope I can get the reply from anyone of you, that will be very appreciated. I'm using virsh to manage the KVM(qemu-kvm 0.12.4, libvirt 0.8.1), but I encounter an error as below: I saw both libvirt api and virsh commands support to get the

Re: [libvirt] [PATCH] html docs: add link to PHP bindings by Radek Hladik

2010-06-30 Thread Eric Blake
On 06/30/2010 07:53 AM, Justin Clift wrote: --- docs/bindings.html.in |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/bindings.html.in b/docs/bindings.html.in index 63cd740..ee63ce3 100644 --- a/docs/bindings.html.in +++ b/docs/bindings.html.in @@ -16,6

[libvirt] Maintenance of ruby bindings

2010-06-30 Thread Neil Wilson
Hi, Is there anybody looking after the Ruby bindings? Are you still taking patches? It seems quite out of date wrt. the current interface. Rgs Neil Wilson -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] cgroup: Fix compilation broken on MinGW due to dirent-d_type

2010-06-30 Thread Eric Blake
On 06/30/2010 05:49 AM, Ryota Ozaki wrote: As pointed out by Eric Blake, using dirent-d_type breaks compilation on MinGW. This patch addresses this by using '#if defined' as same as doing for virCgroupForDriver. --- src/util/cgroup.c |8 1 files changed, 8 insertions(+), 0

Re: [libvirt] Maintenance of ruby bindings

2010-06-30 Thread Daniel P. Berrange
On Wed, Jun 30, 2010 at 03:37:44PM +0100, Neil Wilson wrote: Hi, Is there anybody looking after the Ruby bindings? Are you still taking patches? It seems quite out of date wrt. the current interface. There isn't any active maintainer for them, so any volunteers to submit patches, or become a

Re: [libvirt] [PATCH] cgroup: Fix compilation broken on MinGW due to dirent-d_type

2010-06-30 Thread Ryota Ozaki
On Wed, Jun 30, 2010 at 11:34 PM, Eric Blake ebl...@redhat.com wrote: On 06/30/2010 05:49 AM, Ryota Ozaki wrote: As pointed out by Eric Blake, using dirent-d_type breaks compilation on MinGW. This patch addresses this by using '#if defined' as same as doing for virCgroupForDriver. ---  

Re: [libvirt] Maintenance of ruby bindings

2010-06-30 Thread Chris Lalancette
On 06/30/10 - 03:56:31PM, Daniel P. Berrange wrote: On Wed, Jun 30, 2010 at 03:37:44PM +0100, Neil Wilson wrote: Hi, Is there anybody looking after the Ruby bindings? Are you still taking patches? It seems quite out of date wrt. the current interface. There isn't any active maintainer

[libvirt] FYI: a short guide to libvirt network filtering iptables/ebtables use

2010-06-30 Thread Daniel P. Berrange
I just wrote this to assist some Red Hat folks understanding what libvirt does with iptables, and thought it is useful info for the whole libvirt community. When I have time I'll adjust this content so that it can fit into the website in relevant pages/places. Firewall / network

Re: [libvirt] FYI: a short guide to libvirt network filtering iptables/ebtables use

2010-06-30 Thread Justin Clift
On 07/01/2010 01:04 AM, Daniel P. Berrange wrote: I just wrote this to assist some Red Hat folks understanding what libvirt does with iptables, and thought it is useful info for the whole libvirt community. When I have time I'll adjust this content so that it can fit into the website in relevant

Re: [libvirt] [PATCH] html docs: add link to PHP bindings by Radek Hladik

2010-06-30 Thread Eric Blake
On 06/30/2010 09:16 AM, Justin Clift wrote: On 07/01/2010 12:07 AM, Eric Blake wrote: snip +listrongPHP/strong: Radek Hladik is developinga href=http://phplibvirt.cybersales.cz/;PHP bindings/a./li ACK. Pushed. Anyone know how to get the website updated with the latest compiled doc

Re: [libvirt] Maintenance of ruby bindings

2010-06-30 Thread Neil Wilson
On Wed, 2010-06-30 at 15:56 +0100, Daniel P. Berrange wrote: There isn't any active maintainer for them, so any volunteers to submit patches, or become a regular maintainer are welcome :) Shifting the archive across to git would help! What do you use to auto-generate the python interface? I

Re: [libvirt] FYI: a short guide to libvirt network filtering iptables/ebtables use

2010-06-30 Thread Eric Blake
On 06/30/2010 09:13 AM, Justin Clift wrote: On 07/01/2010 01:04 AM, Daniel P. Berrange wrote: I just wrote this to assist some Red Hat folks understanding what libvirt does with iptables, and thought it is useful info for the whole libvirt community. When I have time I'll adjust this content

Re: [libvirt] FYI: a short guide to libvirt network filtering iptables/ebtables use

2010-06-30 Thread Daniel P. Berrange
On Thu, Jul 01, 2010 at 01:13:20AM +1000, Justin Clift wrote: On 07/01/2010 01:04 AM, Daniel P. Berrange wrote: I just wrote this to assist some Red Hat folks understanding what libvirt does with iptables, and thought it is useful info for the whole libvirt community. When I have time I'll

Re: [libvirt] Maintenance of ruby bindings

2010-06-30 Thread Daniel P. Berrange
On Wed, Jun 30, 2010 at 04:21:53PM +0100, Neil Wilson wrote: On Wed, 2010-06-30 at 15:56 +0100, Daniel P. Berrange wrote: There isn't any active maintainer for them, so any volunteers to submit patches, or become a regular maintainer are welcome :) Shifting the archive across to git

Re: [libvirt] FYI: a short guide to libvirt network filtering iptables/ebtables use

2010-06-30 Thread Justin Clift
On 07/01/2010 01:30 AM, Daniel P. Berrange wrote: snip I'd rather this content were in the appropriate pages in the main website rather than the wiki, because the wiki pages never fit into the site navigation well this content is relevant for several of the existing pages on the site. I'm

Re: [libvirt] Ask for help about libvirt error: can't get physical interface data for kvm.

2010-06-30 Thread Laine Stump
On 06/30/2010 05:18 AM, Feng Dan Liu wrote: I saw both libvirt api and virsh commands support to get the physical interfaces data, but it always fail when I using them for KVM hypervisor. I was thought that it was due to the old version of libvirt/KVM hypervisor, but the error still exist

Re: [libvirt] Maintenance of ruby bindings

2010-06-30 Thread Bryan Kearney
On 06/30/2010 11:21 AM, Neil Wilson wrote: On Wed, 2010-06-30 at 15:56 +0100, Daniel P. Berrange wrote: There isn't any active maintainer for them, so any volunteers to submit patches, or become a regular maintainer are welcome :) Shifting the archive across to git would help! What do you

Re: [libvirt] Maintenance of ruby bindings

2010-06-30 Thread Chris Lalancette
On 06/30/10 - 04:21:53PM, Neil Wilson wrote: On Wed, 2010-06-30 at 15:56 +0100, Daniel P. Berrange wrote: There isn't any active maintainer for them, so any volunteers to submit patches, or become a regular maintainer are welcome :) Shifting the archive across to git would help! What

Re: [libvirt] FYI: a short guide to libvirt network filtering iptables/ebtables use

2010-06-30 Thread Jon Masters
On Wed, 2010-06-30 at 16:04 +0100, Daniel P. Berrange wrote: I just wrote this to assist some Red Hat folks understanding what libvirt does with iptables, and thought it is useful info for the whole libvirt community. When I have time I'll adjust this content so that it can fit into the

[libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-06-30 Thread Cole Robinson
Log some info if we can't find a config file. Make parse failures fatal, and actually raise an error message. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/qemu/qemu_conf.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_conf.c

[libvirt] [PATCH] util: virExec: Dispatch all errors raised after fork

2010-06-30 Thread Cole Robinson
Any error message raised after the process has forked needs to be followed by virDispatchError, otherwise we have no chance of ever seeing it. This was selectively done for hook functions in the past, but really applies to all post-fork errors. Signed-off-by: Cole Robinson crobi...@redhat.com ---

[libvirt] [PATCH] udev: Parse PCI devices even if libpciaccess fails

2010-06-30 Thread Cole Robinson
We only use libpciaccess for resolving device product/vendor. If initializing the library fails (say if using qemu:///session), don't warn so loudly, and carry on as usual. Signed-off-by: Cole Robinson crobi...@redhat.com --- src/node_device/node_device_udev.c |9 ++--- 1 files changed,

Re: [libvirt] [PATCH] udev: Parse PCI devices even if libpciaccess fails

2010-06-30 Thread Dave Allan
On Wed, Jun 30, 2010 at 04:38:37PM -0400, Cole Robinson wrote: We only use libpciaccess for resolving device product/vendor. If initializing the library fails (say if using qemu:///session), don't warn so loudly, and carry on as usual. Signed-off-by: Cole Robinson crobi...@redhat.com ---

Re: [libvirt] [PATCH] util: virExec: Dispatch all errors raised after fork

2010-06-30 Thread Eric Blake
On 06/30/2010 02:38 PM, Cole Robinson wrote: Any error message raised after the process has forked needs to be followed by virDispatchError, otherwise we have no chance of ever seeing it. This was selectively done for hook functions in the past, but really applies to all post-fork errors.

Re: [libvirt] [PATCH] qemu: Improve some qemu.conf error reporting

2010-06-30 Thread Eric Blake
On 06/30/2010 02:38 PM, Cole Robinson wrote: Log some info if we can't find a config file. Make parse failures fatal, and actually raise an error message. Signed-off-by: Cole Robinson crobi...@redhat.com ACK. #define CHECK_TYPE(name,typ) if (p p-type != (typ)) { \