[libvirt] [PATCH] Make virsh setmaxmem balloon only when successful.

2010-07-07 Thread Chris Lalancette
After playing around with virsh setmaxmem for a bit, I ran into some surprising behavior; if a hypervisor does not support the virDomainSetMaxMemory() API, but the value specified for setmaxmem is less than the current amount of memory in the domain, the domain would be ballooned down *before* an e

[libvirt] [PATCH v4 7/8] Implement virsh qemu-monitor-command.

2010-07-07 Thread Chris Lalancette
Changes since v1: - Add virsh.pod documentation Changes since v2: - None Changes since v3: - None Signed-off-by: Chris Lalancette --- tools/Makefile.am |1 + tools/virsh.c | 55 + tools/virsh.pod | 16 +++ 3 files

[libvirt] [PATCH v4 5/8] Qemu arbitrary monitor commands.

2010-07-07 Thread Chris Lalancette
Implement the qemu driver's virDomainQemuMonitorCommand and hook it into the API entry point. Changes since v1: - Rename the (external) qemuMonitorCommand to qemuDomainMonitorCommand - Add virCheckFlags to qemuDomainMonitorCommand Changes since v2: - Drop ATTRIBUTE_UNUSED from the flags Chang

[libvirt] [PATCH v4 6/8] Qemu remote protocol.

2010-07-07 Thread Chris Lalancette
Since we are adding a new "per-hypervisor" protocol, we make it so that the qemu remote protocol uses a new PROTOCOL and PROGRAM number. This allows us to easily distinguish it from the normal REMOTE protocol. This necessitates changing the proc in remote_message_header from a "remote_procedure"

[libvirt] [PATCH v4 4/8] Qemu Monitor API entry point.

2010-07-07 Thread Chris Lalancette
Add the library entry point for the new virDomainQemuMonitorCommand() entry point. Because this is not part of the "normal" libvirt API, it gets its own header file, library file, and will eventually get its own over-the-wire protocol later in the series. Changes since v1: - Go back to using the

[libvirt] [PATCH v4 3/8] Handle arbitrary qemu command-lines in qemuParseCommandLine.

2010-07-07 Thread Chris Lalancette
Now that we have the ability to specify arbitrary qemu command-line parameters in the XML, use it to handle unknown command-line parameters when doing a native-to-xml conversion. Changes since v1: - Rename num_extra to num_args - Fix up a memory leak on an error path Changes since v2: - Add a

[libvirt] [PATCH v4 2/8] Qemu arbitrary command-line arguments.

2010-07-07 Thread Chris Lalancette
Implement the qemu hooks for XML namespace data. This allows us to specify a qemu XML namespace, and then specify: In the domain XML. Changes since v1: - Change the arg XML to XML - Fix up some memory leaks in qemuDomainDefNamespaceParse - Rename num_extra and extra to num_args and ar

[libvirt] [PATCH v4 8/8] Add tests for the new Qemu namespace XML.

2010-07-07 Thread Chris Lalancette
Thanks to DV for knocking together the Relax-NG changes quickly for me. Changes since v1: - Change the domain.rng to correspond to the new schema - Don't allocate caps->ns in testQemuCapsInit since it is a static table Changes since v2: - Change domain.rng to add restrictions on allowed enviro

[libvirt] [PATCH v4 0/8]: Add arbitrary qemu command-line and monitor commands

2010-07-07 Thread Chris Lalancette
As we discussed previously, here is the patch series to add the ability to specify arbitrary qemu command-line parameters and environment variables, and also give arbitrary monitor commands to a guest. Because these extra arguments have a good shot at confusing libvirt, the use of them is not supp

[libvirt] [PATCH v4 1/8] Add namespace callback hooks to domain_conf.

2010-07-07 Thread Chris Lalancette
This patch adds namespace XML parsers to be hooked into the main domain parser. This allows for individual hypervisor drivers to add per-namespace XML into the main domain XML. Changes since v1: - Use a statically declared table for caps->ns, removing the need to allocate/free it. Changes si

[libvirt] [PATCH] Implement virsh managedsave-remove command.

2010-07-07 Thread Chris Lalancette
Signed-off-by: Chris Lalancette --- tools/virsh.c | 55 +++ tools/virsh.pod |6 ++ 2 files changed, 61 insertions(+), 0 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 2d749de..8e5aa42 100644 --- a/tools/virsh.c +++ b/

Re: [libvirt] [PATCH] daemon: Fix compilation error of dispatch.c

2010-07-07 Thread Ryota Ozaki
On Thu, Jul 8, 2010 at 3:31 AM, Ryota Ozaki wrote: > On Thu, Jul 8, 2010 at 2:40 AM, Daniel Veillard wrote: >> On Thu, Jul 08, 2010 at 01:55:23AM +0900, Ryota Ozaki wrote: >>> > Unfortunately the errors still happen after updating. Even worse, they >>> > happen >>> > on an old commit that I was

Re: [libvirt] [PATCH] daemon: Fix compilation error of dispatch.c

2010-07-07 Thread Ryota Ozaki
On Thu, Jul 8, 2010 at 2:40 AM, Daniel Veillard wrote: > On Thu, Jul 08, 2010 at 01:55:23AM +0900, Ryota Ozaki wrote: >> > Unfortunately the errors still happen after updating. Even worse, they >> > happen >> > on an old commit that I was able to compile successfully so far. So I guess >> > my bo

Re: [libvirt] [PATCH v3 8/8] Add tests for the new Qemu namespace XML.

2010-07-07 Thread Chris Lalancette
On 07/07/10 - 01:01:45PM, Daniel P. Berrange wrote: > > diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c > > index bd81018..501bc75 100644 > > --- a/tests/qemuargv2xmltest.c > > +++ b/tests/qemuargv2xmltest.c > > @@ -228,6 +228,11 @@ mymain(int argc, char **argv) > > DO_TEST_FU

Re: [libvirt] [PATCH] daemon: Fix compilation error of dispatch.c

2010-07-07 Thread Daniel Veillard
On Thu, Jul 08, 2010 at 01:55:23AM +0900, Ryota Ozaki wrote: > > Unfortunately the errors still happen after updating. Even worse, they > > happen > > on an old commit that I was able to compile successfully so far. So I guess > > my box went wrong at some point. > > FYI. My box has repaired by r

Re: [libvirt] [PATCH] daemon: Fix compilation error of dispatch.c

2010-07-07 Thread Ryota Ozaki
> Unfortunately the errors still happen after updating. Even worse, they happen > on an old commit that I was able to compile successfully so far. So I guess > my box went wrong at some point. FYI. My box has repaired by removing /usr/local/include/rpc/ which is installed by portablexdr to build M

Re: [libvirt] [PATCH v3 2/8] Qemu arbitrary command-line arguments.

2010-07-07 Thread Chris Lalancette
On 07/02/10 - 12:33:31PM, Eric Blake (cygwin) wrote: > On 07/02/2010 09:18 AM, Chris Lalancette wrote: > > +if (tmp[0] == '\0') { > > +qemuReportError(VIR_ERR_INTERNAL_ERROR, > > +"%s", _("Empty qemu environment name > > specified")); > > +

Re: [libvirt] [PATCH] cpu: Add new models from qemu's target-x86_64.conf

2010-07-07 Thread Jiri Denemark
> > src/cpu/cpu_map.xml | 283 > > +++ > > 1 files changed, 283 insertions(+), 0 deletions(-) > > ACK Thanks, pushed. Jirka -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] cpu: Add support for CPU vendor

2010-07-07 Thread Jiri Denemark
> > By specifying element in CPU requirements a guest can be > > restricted to run only on CPUs by a given vendor. Host CPU vendor is > > also specified in capabilities XML. > > > > The vendor is checked when migrating a guest but it's not forced, i.e., > > a guest configured without element can

Re: [libvirt] [PATCH] cpuBaseline: Detect empty set of common features

2010-07-07 Thread Jiri Denemark
> > In case the set of CPUs has no features in common, report incompatible > > CPUs instead of returning the simplest CPU model with all features > > disabled. > > --- > > src/cpu/cpu_x86.c | 26 ++ > > 1 files changed, 26 insertions(+), 0 deletions(-) > > ACK Thanks, p

Re: [libvirt] [PATCH] cpuBaseline: Don't mess with the CPU returned by arch driver

2010-07-07 Thread Jiri Denemark
> > All features in the baseline CPU definition were always created with > > policy='require' even though an arch driver returned them with different > > policy settings. > > --- > > src/cpu/cpu.c | 12 +--- > > src/cpu/cpu_x86.c |2 ++ > > 2 files changed, 3 insertions(+), 11 de

Re: [libvirt] [PATCH] Make html docs in non-srcdir build

2010-07-07 Thread Jiri Denemark
> > docs/Makefile.am |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/docs/Makefile.am b/docs/Makefile.am > > index c01e085..1183321 100644 > > --- a/docs/Makefile.am > > +++ b/docs/Makefile.am > > @@ -53,7 +53,7 @@ gif = \ > >architecture.gif \ > >node

Re: [libvirt] [PATCH v3 8/8] Add tests for the new Qemu namespace XML.

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:18:25AM -0400, Chris Lalancette wrote: > Thanks to DV for knocking together the Relax-NG changes > quickly for me. > > Changes since v1: > - Change the domain.rng to correspond to the new schema > - Don't allocate caps->ns in testQemuCapsInit since it is a static table

Re: [libvirt] [PATCH v3 7/8] Implement virsh qemu-monitor-command.

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:18:24AM -0400, Chris Lalancette wrote: > Changes since v1: > - Add virsh.pod documentation > > Changes since v2: > - None > > Signed-off-by: Chris Lalancette > --- > tools/Makefile.am |1 + > tools/virsh.c | 55 > ++

Re: [libvirt] [PATCH v3 6/8] Qemu remote protocol.

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:18:23AM -0400, Chris Lalancette wrote: > Since we are adding a new "per-hypervisor" protocol, we > make it so that the qemu remote protocol uses a new > PROTOCOL and PROGRAM number. This allows us to easily > distinguish it from the normal REMOTE protocol. > > This nece

Re: [libvirt] [PATCH v3 5/8] Qemu arbitrary monitor commands.

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:18:22AM -0400, Chris Lalancette wrote: > Implement the qemu driver's virDomainQemuMonitorCommand > and hook it into the API entry point. > > Changes since v1: > - Rename the (external) qemuMonitorCommand to qemuDomainMonitorCommand > - Add virCheckFlags to qemuDomainMo

Re: [libvirt] [PATCH v3 3/8] Handle arbitrary qemu command-lines in qemuParseCommandLine.

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:18:20AM -0400, Chris Lalancette wrote: > Now that we have the ability to specify arbitrary qemu > command-line parameters in the XML, use it to handle unknown > command-line parameters when doing a native-to-xml conversion. > > Changes since v1: > - Rename num_extra to

Re: [libvirt] [PATCHv6 2/2] virsh: add new --details option to vol-list

2010-07-07 Thread Daniel P. Berrange
On Tue, Jul 06, 2010 at 12:16:13AM +1000, Justin Clift wrote: > This patch adds a new --details option to the virsh vol-list > command, making its output more useful when many luns are > present. > > Addresses BZ # 605543 > > https://bugzilla.redhat.com/show_bug.cgi?id=605543 > > --- > > This

Re: [libvirt] [PATCH v3 4/8] Qemu Monitor API entry point.

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:18:21AM -0400, Chris Lalancette wrote: > Add the library entry point for the new virDomainQemuMonitorCommand() > entry point. Because this is not part of the "normal" libvirt API, > it gets its own header file, library file, and will eventually > get it's own over-the-wi

Re: [libvirt] [PATCH] cpu: Add new models from qemu's target-x86_64.conf

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:16:26PM +0200, Jiri Denemark wrote: > --- > src/cpu/cpu_map.xml | 283 > +++ > 1 files changed, 283 insertions(+), 0 deletions(-) ACK Daniel -- |: Red Hat, Engineering, London-o- http://people.redhat.com/berrang

Re: [libvirt] [PATCH v3 2/8] Qemu arbitrary command-line arguments.

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:18:19AM -0400, Chris Lalancette wrote: > Implement the qemu hooks for XML namespace data. This > allows us to specify a qemu XML namespace, and then > specify: > > > > > > > In the domain XML. > > Changes since v1: > - Change the arg XML to XML > - Fix up som

Re: [libvirt] [PATCH] cpuBaseline: Detect empty set of common features

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:16:16PM +0200, Jiri Denemark wrote: > In case the set of CPUs has no features in common, report incompatible > CPUs instead of returning the simplest CPU model with all features > disabled. > --- > src/cpu/cpu_x86.c | 26 ++ > 1 files changed, 2

Re: [libvirt] [PATCH v3 1/8] Add namespace callback hooks to domain_conf.

2010-07-07 Thread Daniel Berrange
On Fri, Jul 02, 2010 at 11:18:18AM -0400, Chris Lalancette wrote: > This patch adds namespace XML parsers to be hooked into > the main domain parser. This allows for individual hypervisor > drivers to add per-namespace XML into the main domain XML. > > Changes since v1: > - Use a statically decl

Re: [libvirt] [PATCH] cpu: Add support for CPU vendor

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:16:22PM +0200, Jiri Denemark wrote: > By specifying element in CPU requirements a guest can be > restricted to run only on CPUs by a given vendor. Host CPU vendor is > also specified in capabilities XML. > > The vendor is checked when migrating a guest but it's not forc

Re: [libvirt] [PATCH] esx: Make esxVI_*_Deserialize dynamically dispatched

2010-07-07 Thread Daniel P. Berrange
On Tue, Jul 06, 2010 at 08:19:15PM +0200, Matthias Bolte wrote: > This will be used to deserialize the response from a call > to esxVI_SearchDatastore_Task (to be added in the next patch) > properly. > --- > src/esx/esx_vi_generator.py | 45 ++-- > src/esx/esx_vi_types.c

Re: [libvirt] [PATCH] esx: Allow 'pvscsi' as SCSI controller model

2010-07-07 Thread Daniel P. Berrange
On Tue, Jul 06, 2010 at 08:18:40PM +0200, Matthias Bolte wrote: > --- > docs/drvesx.html.in | 13 - > docs/schemas/domain.rng |1 + > src/conf/domain_conf.c|3 ++- > src/conf/domain_conf.h|1 +

Re: [libvirt] [PATCH] cpuBaseline: Don't mess with the CPU returned by arch driver

2010-07-07 Thread Daniel P. Berrange
On Fri, Jul 02, 2010 at 11:16:09PM +0200, Jiri Denemark wrote: > All features in the baseline CPU definition were always created with > policy='require' even though an arch driver returned them with different > policy settings. > --- > src/cpu/cpu.c | 12 +--- > src/cpu/cpu_x86.c |

Re: [libvirt] [PATCH] esx: Add autodetection for the SCSI controller model

2010-07-07 Thread Daniel P. Berrange
On Tue, Jul 06, 2010 at 08:19:55PM +0200, Matthias Bolte wrote: > This works for file-backed SCSI disk device with a datastore > related source path. > --- > docs/drvesx.html.in|6 ++ > docs/schemas/domain.rng|1 + > src/conf/domain_conf.c |1 + > src/conf/d