[libvirt] [PATCH 4/5] domain conf: Support multiple devices

Change console handling to a proper device list, as done for other character devices. Even though certain drivers can actually handle multiple consoles, for now just maintain existing behavior where possible. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c |

[libvirt] [PATCH 2/5] domain conf: Rename character prop targetType -> deviceType

There is actually a difference between the character device type (serial, parallel, channel, ...) and the target type (virtio, guestfwd). Currently they are awkwardly conflated. Start to pull them apart by renaming targetType -> deviceType. This is an entirely mechanical change. Signed-off-by: Co

[libvirt] [PATCH 5/5] qemu: virtio console support

Enable specifying a virtio console device with: Signed-off-by: Cole Robinson --- docs/formatdomain.html.in | 19 ++- docs/schemas/domain.rng| 14 +- src/conf/domain_conf.c | 52 ++

[libvirt] [PATCH 1/5] docs: domain: Document virtio

Signed-off-by: Cole Robinson --- docs/formatdomain.html.in | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4cca67f..b569811 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -

[libvirt] [PATCH 3/5] domain conf: char: Add an explicit targetType field

targetType only tracks the actual format we are parsing. TYPE_DEFAULT is the typical serial/parallel format, NONE is for the device which prints nothing. Signed-off-by: Cole Robinson --- src/conf/domain_conf.c | 108 --- src/conf/domain_conf.h | 1

[libvirt] [PATCH 0/5] qemu: support virtio console

The following series adds virtio console XML and qemu driver support. The first 3 patches are just cleanups/improvements. Patch 4 adds XML support for more than 1 console device (not strictly required for virtio console, but it's a valid use case). Patch 5 actually adds virtio console support. Tha

Re: [libvirt] [PATCH] uml_driver: correct logic error in umlMonitorCommand

Matthias Bolte wrote: > 2010/7/13 Jim Meyering : >> The stray "< 0" removed by the fix below >> would have made umlMonitorCommand always fail >> with its "incomplete reply ..." diagnostic. >> >> >From 5f075332e33f7e9bf2d7979934b8dc7c3312b6e8 Mon Sep 17 00:00:00 2001 >> From: Jim Meyering >> Date:

Re: [libvirt] [PATCH] qemuConnectMonitor: do not mask SELinux failure

Matthias Bolte wrote: > 2010/7/13 Jim Meyering : >> coverity spotted the expressions that could never be true: >> (a && b && c) < 0.  Here's the fix: >> >> >> >From 6d61d90a6df81900f4b2be752403758175000973 Mon Sep 17 00:00:00 2001 >> From: Jim Meyering >> Date: Tue, 13 Jul 2010 15:15:04 -0500 >> S

Re: [libvirt] [PATCH] qemuConnectMonitor: do not mask SELinux failure

2010/7/13 Jim Meyering : > coverity spotted the expressions that could never be true: > (a && b && c) < 0.  Here's the fix: > > > >From 6d61d90a6df81900f4b2be752403758175000973 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Tue, 13 Jul 2010 15:15:04 -0500 > Subject: [PATCH] qemuConnectMonit

Re: [libvirt] [PATCH] uml_driver: correct logic error in umlMonitorCommand

2010/7/13 Jim Meyering : > The stray "< 0" removed by the fix below > would have made umlMonitorCommand always fail > with its "incomplete reply ..." diagnostic. > > >From 5f075332e33f7e9bf2d7979934b8dc7c3312b6e8 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Tue, 13 Jul 2010 15:28:35 -0500

Re: [libvirt] [PATCH] daemon: dispatch.c should include stdio.h (and stdarg.h)

On Thu, Jul 8, 2010 at 9:45 PM, Jiri Denemark wrote: >> dispatch.c requires stdio.h (and stdarg.h), however, currently >> dispatch.c implicitly relys on rpc/xdr.h to include stdio.h. >> If rpc/xdr.h unxpectedly does not include stdio.h, the compilation >> of dispatch.c fails. >> >> This can happen

Re: [libvirt] (how much) support for kqemu domain

On Wed, Jul 14, 2010 at 11:11:48AM -0400, John Lumby wrote: > > I am wondering about the extent to which "old" qemu-0.11.1 > and kqemu-1.4.0 are supported by virt-manager. > > > I see I can specify --virt-type=kqemu on virt-install and > it remembers domain type='kqemu', and does things such a

[libvirt] (how much) support for kqemu domain

I am wondering about the extent to which "old" qemu-0.11.1 and kqemu-1.4.0 are supported by virt-manager. I see I can specify --virt-type=kqemu on virt-install and it remembers domain type='kqemu', and does things such as refusing to start the vm if the kqemu kernel mod not loaded, but it

Re: [libvirt] [PATCH] python: Fix IOErrorReasonCallback bindings

On 07/13/2010 10:54 PM, Dave Allan wrote: > On Tue, Jul 13, 2010 at 06:09:31PM -0400, Cole Robinson wrote: >> A copy and paste error was causing us to dispatch the incorrect >> routine. Spotted by Dan Kenigsberg. >> --- >> python/libvirt-override.c |2 +- >> 1 files changed, 1 insertions(+), 1

Re: [libvirt] libvirtError: internal error unknown boot device 'floppy'

On 07/14/2010 10:04 AM, John Lumby wrote: > >> Date: Wed, 14 Jul 2010 09:37:41 -0400 >> From: crobi...@redhat.com >> To: johnlu...@hotmail.com >> CC: libvir-list@redhat.com; virt-tools-l...@redhat.com >> Subject: Re: [libvirt] libvirtError: internal error unknown boot device >> 'floppy' >> >> On

Re: [libvirt] libvirtError: internal error unknown boot device 'floppy'

> Date: Wed, 14 Jul 2010 09:37:41 -0400 > From: crobi...@redhat.com > To: johnlu...@hotmail.com > CC: libvir-list@redhat.com; virt-tools-l...@redhat.com > Subject: Re: [libvirt] libvirtError: internal error unknown boot device > 'floppy' > > On 07/13/2010 09:30 PM, John Lumby wrote: > > Hello.

Re: [libvirt] libvirtError: internal error unknown boot device 'floppy'

On 07/13/2010 09:30 PM, John Lumby wrote: > Hello.I believe I've found a bug in libvirtd but not sure. > > > Using libvirt-0.8.1 and virtinst-0.500.3 (and virt-manager-0.8.4 and > Python 2.6.5 if relevant) on a linux system (kernel 2.6.35-rc4 if relevant) > > > I ran this virt-install comma

Re: [libvirt] libvirt(-java): virDomainMigrateSetMaxDowntime

On Tue, Jul 13, 2010 at 09:23:37PM +0200, Thomas Treutner wrote: > [forgot list] > > On 07/13/2010 08:21 PM, Cole Robinson wrote: > >On 07/13/2010 01:12 PM, Daniel P. Berrange wrote: > >>On Tue, Jul 13, 2010 at 06:56:53PM +0200, Thomas Treutner wrote: > >>>So my question: Would it be possible to e