Re: [libvirt] [RHEL6 PATCH] Correct cpuid flags and "model" fields, V2

2010-08-03 Thread john cooper
A question arose in today's kvm meeting concerning any impact to libvirt from this change. I've discussed it with Cole and it seems to be a non-issue. But just to err on the side of caution, here's a summary: The current cpu model definition of "qemu64" upstream is problematic from kvm's perspec

[libvirt] [PATCHv2] qemu: Fix PCI address allocation

2010-08-03 Thread Eric Blake
From: Jiri Denemark When attaching a PCI device which doesn't explicitly set its PCI address, libvirt allocates the address automatically. The problem is that when checking which PCI address is unused, we only check for those with slot number higher than the highest slot number ever used. Thus a

Re: [libvirt] [PATCH] Don't leak delay string when freeing virInterfaceBridgeDefs

2010-08-03 Thread Daniel Veillard
On Tue, Aug 03, 2010 at 10:40:26AM -0400, Laine Stump wrote: > I noticed this while looking into checking the default bridge delay to 0. > --- > src/conf/interface_conf.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/conf/interface_conf.c b/src/conf/interface_c

[libvirt] [PATCH] Don't leak delay string when freeing virInterfaceBridgeDefs

2010-08-03 Thread Laine Stump
I noticed this while looking into checking the default bridge delay to 0. --- src/conf/interface_conf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index 6430f7a..b24526f 100644 --- a/src/conf/interface_conf.c +++ b

[libvirt] [PATCH] Fix build error in virsh.c

2010-08-03 Thread Laine Stump
I just pushed this under the trivial rule... Another gettext string with no format args sent to printf as a format string. --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 2ccf08b..c0ee3ee 100644 --- a/tools/virsh.c ++

Re: [libvirt] [virt-tools-list] Add a manually configured XEN

2010-08-03 Thread Michal Novotny
Hi, I can see the point Bernhard. It seems that libvirt is not aware of this guest. Well, if virsh (part of libvirt) is seeing the guest only then the guest is running then you need to create a configuration for that in the libvirt itself. I know there's something like: virsh domxml-from-nati

Re: [libvirt] [PATCH] [RFC] ISCSI transport protocol support in libvirt

2010-08-03 Thread Aurelien ROUGEMONT
On 08/02/2010 09:58 PM, Daniel Veillard wrote: Hi Aurelien, Hi Daniel, Sorry for coming back so late, I accumulated a bit of backlog and since this clearly wasn't for 0.8.3 it ended up on the backburner... no worries, everyone has priorities. Context : Some days ago I have decided