Re: [libvirt] [PATCH] Avoid unnecessary bootstrap runs in VPATH builds

2010-08-11 Thread Jiri Denemark
OK, this should be the complete fix. I like your option better. Jirka autogen.sh |2 +- cfg.mk |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) ACK to this version. OK, thanks. I pushed it now. Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] nodeinfo: skip offline CPUs

2010-08-11 Thread Daniel Veillard
On Tue, Aug 10, 2010 at 04:17:56PM -0600, Eric Blake wrote: On 08/10/2010 04:01 PM, Daniel Veillard wrote: On Tue, Aug 10, 2010 at 03:44:37PM -0600, Eric Blake wrote: https://bugzilla.redhat.com/622515 - When hot-unplugging CPUs, libvirt failed to start a guest that had been pinned to CPUs

Re: [libvirt] [PATCH] allow memballoon type of none to desactivate it

2010-08-11 Thread Daniel Veillard
On Mon, Aug 09, 2010 at 06:53:34PM +0100, Daniel P. Berrange wrote: On Mon, Aug 09, 2010 at 06:38:27PM +0200, Daniel Veillard wrote: The balloon device is automatically added to qemu guests if supported, but it may be useful to desactivate it. The simplest to not change the existing

Re: [libvirt] [PATCH] esx: Explicitly disable unused floppy0 device for GSX

2010-08-11 Thread Daniel Veillard
On Mon, Aug 09, 2010 at 04:44:14PM -0600, Eric Blake wrote: On 08/05/2010 06:45 PM, Matthias Bolte wrote: floppy0.present defaults to true for GSX. Therefore, it needs to be explicitly disabled for GSX. --- src/esx/esx_vmx.c | 10 ++ 1 files changed, 10 insertions(+), 0

Re: [libvirt] Block-migrate

2010-08-11 Thread Daniel Veillard
On Mon, Aug 09, 2010 at 11:57:34PM +0200, Ruben Kerkhof wrote: Hi Justin, On Mon, Aug 9, 2010 at 22:30, Justin Clift jcl...@redhat.com wrote: On 08/07/2010 11:55 PM, Ruben Kerkhof wrote: snip Maybe I'm using the wrong options for virsh migrate, but they're not described in the

Re: [libvirt] [PATCH] esx: Improve VMX file name parsing and formatting

2010-08-11 Thread Daniel Veillard
On Sat, Aug 07, 2010 at 09:54:34PM +0200, Matthias Bolte wrote: 2010/8/7 Matthias Bolte matthias.bo...@googlemail.com: For parsing try to match by datastore mount path first, if that fails fallback to /vmfs/volumes/datastore/path parsing. This also fixes problems with GSX on Windows.

Re: [libvirt] Block-migrate

2010-08-11 Thread Daniel P. Berrange
On Sat, Aug 07, 2010 at 03:55:10PM +0200, Ruben Kerkhof wrote: I've been playing with the new block-migrate feature, but am unable to get it to work. [r...@src ~]# virsh migrate --live --p2p --tunnelled --copy-storage-all 4c5c75b9-decc-41c9-9296-20ca5bd5c355 qemu://dst/system error:

Re: [libvirt] Block-migrate

2010-08-11 Thread Ruben Kerkhof
Hi Daniel, On Wed, Aug 11, 2010 at 14:16, Daniel P. Berrange berra...@redhat.com wrote: On Sat, Aug 07, 2010 at 03:55:10PM +0200, Ruben Kerkhof wrote: I've been playing with the new block-migrate feature, but am unable to get it to work. [r...@src ~]# virsh migrate --live --p2p  --tunnelled

Re: [libvirt] Block-migrate

2010-08-11 Thread Ruben Kerkhof
On Wed, Aug 11, 2010 at 14:22, Ruben Kerkhof ru...@rubenkerkhof.com wrote: Actually, I've got it working now, with the --direct option and the --p2p --direct option. The tunneled method fails though. I'm trying to debug this now. I've got the tunnelled method working now as well, but had to

Re: [libvirt] [PATCH] esx: Split VMX code into a general and an ESX specific part

2010-08-11 Thread Matthias Bolte
2010/8/10 Eric Blake ebl...@redhat.com: On 08/05/2010 09:47 AM, Matthias Bolte wrote: Introduce esxVMX_Context containing functions pointers to glue both parts together in an generic way. s/an/a/ Fixed. Move the ESX specific part to esx_driver.c. This is a step towards making the VMX

Re: [libvirt] [PATCH] Add ubd to the list of disk prefixes

2010-08-11 Thread Soren Hansen
On Tue, Aug 10, 2010 at 07:18:06AM -0600, Eric Blake wrote: Pushed, along with a .mailmap update to satisfy 'make syntax-check'. Soren, this patch introduced a third distinct author address for you - let me know if you want AUTHORS updated to swap which one is listed as your primary address.

Re: [libvirt] [PATCH 2/2] Add a detailed message when tap device add fails

2010-08-11 Thread Doug Goldstein
On Tue, Aug 10, 2010 at 5:38 PM, Eric Blake ebl...@redhat.com wrote: On 08/10/2010 04:14 PM, Eric Blake wrote: On 08/10/2010 03:43 PM, Doug Goldstein wrote: Added a more detailed error message when adding a tap devices fails and the kernel is missing tun support. Signed-off-by: Doug

[libvirt] using sync_manager with libvirt

2010-08-11 Thread David Teigland
Hi, We've been working on a program called sync_manager that implements shared-storage-based leases to protect shared resources. One way we'd like to use it is to protect vm images that reside on shared storage, i.e. preventing two vm's on two hosts from using the same image at once. It's

Re: [libvirt] Block-migrate

2010-08-11 Thread Justin Clift
On 08/11/2010 11:35 PM, Ruben Kerkhof wrote: On Wed, Aug 11, 2010 at 14:22, Ruben Kerkhofru...@rubenkerkhof.com wrote: Actually, I've got it working now, with the --direct option and the --p2p --direct option. The tunneled method fails though. I'm trying to debug this now. I've got the

Re: [libvirt] Block-migrate

2010-08-11 Thread Ruben Kerkhof
On Wed, Aug 11, 2010 at 18:08, Justin Clift jcl...@redhat.com wrote: Would you have time to add the steps / command line arguments you used to a page on the wiki? Writing it up in a fuller fashion would take some time, but it sounds like you have the steps for making it work understood, so

[libvirt] [PATCH] bridge: Fix potential segfault when preparing dnsmasq arguments

2010-08-11 Thread Jiri Denemark
We add --dhcp-lease-max=xxx argument when network-def-nranges 0 but we only allocate space for in the opposite case :-) I guess we are lucky enough to miscount somewhere else so that we actually allocate more space than we need since no-one has hit this bug so far. ---

Re: [libvirt] using sync_manager with libvirt

2010-08-11 Thread Daniel P. Berrange
On Tue, Aug 10, 2010 at 12:44:06PM -0400, David Teigland wrote: Hi, We've been working on a program called sync_manager that implements shared-storage-based leases to protect shared resources. One way we'd like to use it is to protect vm images that reside on shared storage, i.e.

Re: [libvirt] [PATCH] bridge: Fix potential segfault when preparing dnsmasq arguments

2010-08-11 Thread Eric Blake
On 08/11/2010 10:44 AM, Jiri Denemark wrote: We add --dhcp-lease-max=xxx argument when network-def-nranges 0 but we only allocate space for in the opposite case :-) I guess we are lucky enough to miscount somewhere else so that we actually allocate more space than we need since no-one has hit

[libvirt] [PATCH] bridge: Add --dhcp-no-override option to dnsmasq

2010-08-11 Thread Jiri Denemark
--dhcp-no-override description from dnsmasq man page: Disable re-use of the DHCP servername and filename fields as extra option space. If it can, dnsmasq moves the boot server and filename information (from dhcp-boot) out of their dedicated fields into DHCP

Re: [libvirt] using sync_manager with libvirt

2010-08-11 Thread David Teigland
On Wed, Aug 11, 2010 at 05:59:55PM +0100, Daniel P. Berrange wrote: On Tue, Aug 10, 2010 at 12:44:06PM -0400, David Teigland wrote: Hi, We've been working on a program called sync_manager that implements shared-storage-based leases to protect shared resources. One way we'd like to use

Re: [libvirt] [PATCH] bridge: Add --dhcp-no-override option to dnsmasq

2010-08-11 Thread Eric Blake
On 08/11/2010 12:41 PM, Jiri Denemark wrote: --dhcp-no-override description from dnsmasq man page: Disable re-use of the DHCP servername and filename fields as extra option space. If it can, dnsmasq moves the boot server and filename information (from dhcp-boot) out

Re: [libvirt] using sync_manager with libvirt

2010-08-11 Thread Eric Blake
On 08/11/2010 02:53 PM, Chris Lalancette wrote: Unfortunately, this is not how migration works in qemu/kvm. Using your nomenclature above, it's more like the following: A guest is running on S. A migration is then initiated, at which point D fires up a qemu process with a -incoming

Re: [libvirt] using sync_manager with libvirt

2010-08-11 Thread David Teigland
On Wed, Aug 11, 2010 at 04:53:20PM -0400, Chris Lalancette wrote: 1. sm-S holds the lease, and is monitoring qemu 2. migration begins from S to D 3. libvirt-D runs sm-D: sync_manager -c qemu with the addition of a new sync_manager option --receive-lease 4. sm-D writes its hostid D to

Re: [libvirt] using sync_manager with libvirt

2010-08-11 Thread Daniel P. Berrange
On Wed, Aug 11, 2010 at 03:37:12PM -0400, David Teigland wrote: On Wed, Aug 11, 2010 at 05:59:55PM +0100, Daniel P. Berrange wrote: On Tue, Aug 10, 2010 at 12:44:06PM -0400, David Teigland wrote: Hi, We've been working on a program called sync_manager that implements

Re: [libvirt] using sync_manager with libvirt

2010-08-11 Thread David Teigland
On Wed, Aug 11, 2010 at 03:07:29PM -0600, Eric Blake wrote: On 08/11/2010 02:53 PM, Chris Lalancette wrote: Unfortunately, this is not how migration works in qemu/kvm. Using your nomenclature above, it's more like the following: A guest is running on S. A migration is then initiated,

Re: [libvirt] using sync_manager with libvirt

2010-08-11 Thread Daniel P. Berrange
On Wed, Aug 11, 2010 at 05:19:27PM -0400, David Teigland wrote: On Wed, Aug 11, 2010 at 04:53:20PM -0400, Chris Lalancette wrote: 1. sm-S holds the lease, and is monitoring qemu 2. migration begins from S to D 3. libvirt-D runs sm-D: sync_manager -c qemu with the addition of a new

Re: [libvirt] [PATCH] esx: Explicitly disable unused floppy0 device for GSX

2010-08-11 Thread Matthias Bolte
2010/8/11 Daniel Veillard veill...@redhat.com: On Mon, Aug 09, 2010 at 04:44:14PM -0600, Eric Blake wrote: On 08/05/2010 06:45 PM, Matthias Bolte wrote: floppy0.present defaults to true for GSX. Therefore, it needs to be explicitly disabled for GSX. ---  src/esx/esx_vmx.c |   10

[libvirt] [PATCH v2] esx: Explicitly disable unused floppy devices

2010-08-11 Thread Matthias Bolte
floppy0.present defaults to true. Therefore, it needs to be explicitly set to false when the XML config doesn't specify the corresponding floppy device. --- v2: - This issue affects ESX too, the assumed default was wrong in general - Explicitly disable unused floppy devices independent of the

Re: [libvirt] [PATCH] esx: Improve VMX file name parsing and formatting

2010-08-11 Thread Matthias Bolte
2010/8/11 Daniel Veillard veill...@redhat.com: On Sat, Aug 07, 2010 at 09:54:34PM +0200, Matthias Bolte wrote: 2010/8/7 Matthias Bolte matthias.bo...@googlemail.com: For parsing try to match by datastore mount path first, if that fails fallback to /vmfs/volumes/datastore/path parsing. This

Re: [libvirt] [PATCH] esx: Use MD5 sum of mount path as storage pool UUID

2010-08-11 Thread Matthias Bolte
2010/8/9 Justin Clift jcl...@redhat.com: On 08/09/2010 06:56 AM, Matthias Bolte wrote: With the previous storage pool UUID source not all storage pools had a proper UUID, especially GSX storage pools. The mount path is unique per host and cannot change during the lifetime of the datastore.

Re: [libvirt] [PATCH] esx: Use MD5 sum of mount path as storage pool UUID

2010-08-11 Thread Maximilian Wilhelm
Anno domini 2010 Matthias Bolte scripsit: [...] There is another problem with the approach of using the mount path hash as UUID. In case of a Windows based GSX server you can use CIFS shares as datastores addressed via UNC paths like \\nas\share. If you have multiple GSX server sharing that

Re: [libvirt] [PATCH] esx: Use MD5 sum of mount path as storage pool UUID

2010-08-11 Thread Daniel P. Berrange
On Thu, Aug 12, 2010 at 01:40:14AM +0200, Matthias Bolte wrote: 2010/8/9 Justin Clift jcl...@redhat.com: On 08/09/2010 06:56 AM, Matthias Bolte wrote: With the previous storage pool UUID source not all storage pools had a proper UUID, especially GSX storage pools. The mount path is