Re: [libvirt] Block-migrate

2010-08-13 Thread Justin Clift
On 08/11/2010 11:35 PM, Ruben Kerkhof wrote: On Wed, Aug 11, 2010 at 14:22, Ruben Kerkhofru...@rubenkerkhof.com wrote: Actually, I've got it working now, with the --direct option and the --p2p --direct option. The tunneled method fails though. I'm trying to debug this now. I've got the

Re: [libvirt] [PATCH] Move the tunnelled migration unix socket to /var/lib/libvirt/qemu

2010-08-13 Thread Chris Lalancette
On 08/12/10 - 01:55:28PM, Eric Blake wrote: On 08/12/2010 10:57 AM, Chris Lalancette wrote: Since the qemu process is running as qemu:qemu, it can't actually look at the unix socket in /var/run/libvirt/qemu which is owned by root and has permission 700. Move the unix socket to

Re: [libvirt] [PATCH] Fix tunnelled migration with qemu running as qemu:qemu.

2010-08-13 Thread Chris Lalancette
On 08/12/10 - 01:54:18PM, Eric Blake wrote: On 08/12/2010 08:25 AM, Chris Lalancette wrote: The problem is that on the source of the migration, libvirtd is responsible for creating the unix socket over which the data will flow. Since libvirtd is running as root, this file will be created

Re: [libvirt] [PATCH v2] nwfilter: extend nwfilter reload support

2010-08-13 Thread Daniel P. Berrange
On Thu, Aug 12, 2010 at 02:18:26PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/nwfilter/nwfilter_driver.c === --- libvirt-acl.orig/src/nwfilter/nwfilter_driver.c +++ libvirt-acl/src/nwfilter/nwfilter_driver.c @@ -143,15

[libvirt] [PATCH 0/3] Managed save updates

2010-08-13 Thread Chris Lalancette
A couple of updates to the managed save code in qemu. Details are in the individual patches. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH 3/3] Plumb managedsave compression through to virsh.

2010-08-13 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- tools/virsh.c | 22 +- 1 files changed, 21 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 352d44a..5e97293 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1404,6 +1404,7 @@ static

[libvirt] [PATCH 1/3] Fix up qemu domain save/managed save locking.

2010-08-13 Thread Chris Lalancette
The current version of the qemu managed save implementation is subject to a race where the domain shuts down between the time that we start the command and the time that we actually try to do the save. Close this race by making qemuDomainSaveFlags() expect both the driver and the passed-in vm

[libvirt] [PATCH 2/3] Managed save compression flags.

2010-08-13 Thread Chris Lalancette
Add in the ability to specify compression flags from the managed save API. We map these to the supported QEMU compression flags internally. Signed-off-by: Chris Lalancette clala...@redhat.com --- include/libvirt/libvirt.h.in |7 +++ src/qemu/qemu_driver.c | 25

Re: [libvirt] [PATCH 2/3] Managed save compression flags.

2010-08-13 Thread Daniel P. Berrange
On Fri, Aug 13, 2010 at 10:53:48AM -0400, Chris Lalancette wrote: Add in the ability to specify compression flags from the managed save API. We map these to the supported QEMU compression flags internally. I'm not really convinced we need todo this. I think the host level setting in

[libvirt] [PATCH 2/3] qemu: Release PCI slot when detaching disk and net devices

2010-08-13 Thread Jiri Denemark
--- src/qemu/qemu_driver.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2ca3940..108f67b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8649,6 +8649,10 @@ static int

[libvirt] [PATCH 0/3] qemu: Several PCI device assignment fixes

2010-08-13 Thread Jiri Denemark
Jiri Denemark (3): qemu: Re-reserve all PCI addresses on libvirtd restart qemu: Release PCI slot when detaching disk and net devices qemu: Fix copypaste error in warning message src/qemu/qemu_driver.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) -- 1.7.2

[libvirt] [PATCH 3/3] qemu: Fix copypaste error in warning message

2010-08-13 Thread Jiri Denemark
This also makes the message consistent with the message used in error path of qemudDomainAttachHostPciDevice. --- src/qemu/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 108f67b..dbc3d5c 100644 ---

[libvirt] [PATCH 1/3] qemu: Re-reserve all PCI addresses on libvirtd restart

2010-08-13 Thread Jiri Denemark
When reconnecting to existing VMs, we re-reserved only those PCI addresses which were explicitly mentioned in domain XML. Since some addresses are always reserved (e.g., 0:0:0 and 0:0:1), we need to handle those too. Also all this should only be done if device flag is supported by qemu. ---

Re: [libvirt] Block-migrate

2010-08-13 Thread Ruben Kerkhof
Hi Justin, On Fri, Aug 13, 2010 at 08:53, Justin Clift jcl...@redhat.com wrote: Hi Ruben, Chris Lalancette was kind enough to look into why libvirt was requiring root:root QEMU ownership for tunnelled migration to work.  He found the problem (temporary socket file being located in root owned

[libvirt] [PATCH] nwfilter: fix a memory leak

2010-08-13 Thread Stefan Berger
Fixing a memory leak. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/nwfilter/nwfilter_ebiptables_driver.c |3 +++ 1 file changed, 3 insertions(+) Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c === ---

[libvirt] [PATCH] nwfilter: serialize execution of scripts with ebtables cmds

2010-08-13 Thread Stefan Berger
While testing the SIGHUP handling and reloading of the nwfilter driver, I found that when the filters are rebuilt and mutlipe threads handled the individual interfaces, concurrently running multiple external bash scripts causes strange failures even though the executed ebtables commands are

[libvirt] [PATCH[ nwfilter: Discard class D and E IP addresses when sniffing

2010-08-13 Thread Stefan Berger
When sniffing the network traffic, discard class D and E IP addresses when sniffing traffic. This was a reason why filters were not correctly rebuilt on VMs on the local 192.* network when libvirt was restarted and those VMs did not use a DHCP request to get its IP address. Signed-off-by:

Re: [libvirt] [PATCH] nwfilter: serialize execution of scripts with ebtables cmds

2010-08-13 Thread Eric Blake
On 08/13/2010 12:35 PM, Stefan Berger wrote: While testing the SIGHUP handling and reloading of the nwfilter driver, I found that when the filters are rebuilt and mutlipe threads handled the individual interfaces, concurrently running multiple external bash scripts causes strange failures

Re: [libvirt] [PATCH v2] nwfilter: extend nwfilter reload support

2010-08-13 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 08/13/2010 10:44:51 AM: Please respond to Daniel P. Berrange On Thu, Aug 12, 2010 at 02:18:26PM -0400, Stefan Berger wrote: Index: libvirt-acl/src/nwfilter/nwfilter_driver.c === ---

Re: [libvirt] [PATCH[ nwfilter: Discard class D and E IP addresses when sniffing

2010-08-13 Thread Eric Blake
On 08/13/2010 12:38 PM, Stefan Berger wrote: When sniffing the network traffic, discard class D and E IP addresses when sniffing traffic. This was a reason why filters were not correctly rebuilt on VMs on the local 192.* network when libvirt was restarted and those VMs did not use a DHCP

Re: [libvirt] [PATCH] nwfilter: fix a memory leak

2010-08-13 Thread Eric Blake
On 08/13/2010 12:28 PM, Stefan Berger wrote: Fixing a memory leak. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/nwfilter/nwfilter_ebiptables_driver.c |3 +++ 1 file changed, 3 insertions(+) Index: libvirt-acl/src/nwfilter/nwfilter_ebiptables_driver.c

Re: [libvirt] [PATCH] Generate libvirt_qemu.def from libvirt_qemu.syms for MinGW builds

2010-08-13 Thread Eric Blake
On 08/12/2010 05:23 PM, Matthias Bolte wrote: @@ -1866,6 +1866,7 @@ case $host in # Also set the symbol file to .def, so src/Makefile generates libvirt.def # from libvirt.syms and passes libvirt.def instead of libvirt.syms to the linker LIBVIRT_SYMBOL_FILE=libvirt.def +

Re: [libvirt] [PATCH] Only require XDR when building libvirtd or the remote driver

2010-08-13 Thread Eric Blake
On 08/12/2010 05:24 PM, Matthias Bolte wrote: --- configure.ac | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index a762bae..764405c 100644 --- a/configure.ac +++ b/configure.ac dnl +dnl check for XDR

Re: [libvirt] [PATCH] nwfilter: serialize execution of scripts with ebtables cmds

2010-08-13 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 08/13/2010 03:08:11 PM: [image removed] Re: [libvirt] [PATCH] nwfilter: serialize execution of scripts with ebtables cmds Eric Blake to: Stefan Berger 08/13/2010 03:17 PM Sent by: libvir-list-boun...@redhat.com Cc:

Re: [libvirt] [PATCH] Only require XDR when building libvirtd or the remote driver

2010-08-13 Thread Matthias Bolte
2010/8/13 Eric Blake ebl...@redhat.com: On 08/12/2010 05:24 PM, Matthias Bolte wrote: ---  configure.ac |   31 +++  1 files changed, 19 insertions(+), 12 deletions(-) diff --git a/configure.ac b/configure.ac index a762bae..764405c 100644 --- a/configure.ac +++

Re: [libvirt] [PATCH] nwfilter: fix a memory leak

2010-08-13 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 08/13/2010 03:06:21 PM: On 08/13/2010 12:28 PM, Stefan Berger wrote: Fixing a memory leak. Signed-off-by: Stefan Berger stef...@us.ibm.com --- src/nwfilter/nwfilter_ebiptables_driver.c |3 +++ 1 file changed, 3 insertions(+)

Re: [libvirt] [PATCH[ nwfilter: Discard class D and E IP addresses when sniffing

2010-08-13 Thread Eric Blake
On 08/13/2010 01:45 PM, Stefan Berger wrote: -// skip eth. bcast and mcast addresses, +// skip eth. bcast and mcast addresses (224.0.0.0 - +// 239.255.255.255), class E (255.*) // and zero address in DHCP

Re: [libvirt] [PATCH[ nwfilter: Discard class D and E IP addresses when sniffing

2010-08-13 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 08/13/2010 03:56:12 PM: [image removed] On 08/13/2010 01:45 PM, Stefan Berger wrote: -// skip eth. bcast and mcast addresses, +// skip eth. bcast and mcast addresses (224.0.0.0 - +//

[libvirt] [PATCH v2] nwfilter: Discard class D and E IP addresses when sniffing packets

2010-08-13 Thread Stefan Berger
V2: Corrected comment and simplified mask to check for class D and E IP addresses When sniffing the network traffic, discard class D and E IP addresses when sniffing traffic. This was a reason why filters were not correctly rebuilt on VMs on the local 192.* network when libvirt was restarted

Re: [libvirt] [PATCH v2] nwfilter: Discard class D and E IP addresses when sniffing packets

2010-08-13 Thread Eric Blake
On 08/13/2010 02:15 PM, Stefan Berger wrote: V2: Corrected comment and simplified mask to check for class D and E IP addresses When sniffing the network traffic, discard class D and E IP addresses when sniffing traffic. This was a reason why filters were not correctly rebuilt on VMs on the

[libvirt] [PATCH v3] nwfilter:

2010-08-13 Thread Stefan Berger
v3: - Fixed an indentation problem - added bool parameter to function terminating the IP address learner threads to determine whether future threads may still run (needed in case of driver reload) or all must terminate (need in case of libvirtd termination) v2: - Fixes to the

[libvirt] [PATCH v3] nwfilter: extend nwfilter reload support

2010-08-13 Thread Stefan Berger
This time with a proper title. v3: - Fixed an indentation problem - added bool parameter to function terminating the IP address learner threads to determine whether future threads may still run (needed in case of driver reload) or all must terminate (need in case of libvirtd

Re: [libvirt] [PATCH v2] nwfilter: Discard class D and E IP addresses when sniffing packets

2010-08-13 Thread Stefan Berger
Stefan Berger IBM T. J. Watson Research Center, Hawthorne, NY, USA tel#: +1 914 784 7767 , fax#: +1 914 784 6225 e-mail: stef...@us.ibm.com libvir-list-boun...@redhat.com wrote on 08/13/2010 04:21:45 PM: [image removed] Re: [libvirt] [PATCH v2] nwfilter: Discard class D and E IP

Re: [libvirt] [PATCH v3] nwfilter:

2010-08-13 Thread Eric Blake
Incomplete subject line? It used to be nwfilter: extend nwfilter reload support On 08/13/2010 02:29 PM, Stefan Berger wrote: v3: - Fixed an indentation problem - added bool parameter to function terminating the IP address learner threads to determine whether future threads may

Re: [libvirt] [PATCH v3] nwfilter:

2010-08-13 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 08/13/2010 04:44:38 PM: Incomplete subject line? It used to be nwfilter: extend nwfilter reload support Yes. Due to a race condition :-) On 08/13/2010 02:29 PM, Stefan Berger wrote: v3: - Fixed an indentation problem - added bool

Re: [libvirt] [PATCH v3] nwfilter:

2010-08-13 Thread Eric Blake
On 08/13/2010 03:11 PM, Stefan Berger wrote: +virNWFilterPoolLoadAllConfigs(conn, + driverState-pools, Indentation problem still looks like it is here. The indentation problem doesn't exist in my local patch. Could this be another Thunderbird formatting issue? Sorry, not this

Re: [libvirt] [PATCH v3] nwfilter:

2010-08-13 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 08/13/2010 05:16:39 PM: On 08/13/2010 03:11 PM, Stefan Berger wrote: +virNWFilterPoolLoadAllConfigs(conn, + driverState-pools, Indentation problem still looks like it is here. The indentation problem doesn't exist in my local patch.

[libvirt] PATCH 0/4: AppArmor updates

2010-08-13 Thread Jamie Strandboge
This patchset consists of various small updates to the AppArmor security driver: 0001-apparmor-dont-ignore-open.patch: Exit with error if virDomainDiskDefForeachPath() fails, unless the disk doesn't exist, at which point we skip it without error. Also add several tests to virt-aa-helper-test for

[libvirt] PATCH 1/4: AppArmor updates

2010-08-13 Thread Jamie Strandboge
Attached is 0001-apparmor-dont-ignore-open.patch -- Jamie Strandboge | http://www.canonical.com Index: libvirt-0.8.3/src/security/virt-aa-helper.c === --- libvirt-0.8.3.orig/src/security/virt-aa-helper.c 2010-08-12

[libvirt] PATCH 2/4: AppArmor updates

2010-08-13 Thread Jamie Strandboge
Attached is 0002-apparmor-chardev.patch -- Jamie Strandboge | http://www.canonical.com Author: Jamie Strandboge ja...@canonical.com Description: fix serial ports, parallel ports and channels Forwarded: yes Bug-Ubuntu: LP: #578527, LP: #609055 Index:

[libvirt] PATCH 4/4: AppArmor updates

2010-08-13 Thread Jamie Strandboge
Attached is 0004-apparmor-fix-warn.patch -- Jamie Strandboge | http://www.canonical.com diff -Naurp libvirt.orig/src/security/virt-aa-helper.c libvirt/src/security/virt-aa-helper.c --- libvirt.orig/src/security/virt-aa-helper.c 2010-08-13 16:23:44.0 -0500 +++

[libvirt] PATCH 3/4: AppArmor updates

2010-08-13 Thread Jamie Strandboge
Attached is 0003-apparmor-examples.patch -- Jamie Strandboge | http://www.canonical.com diff -Naurp libvirt.orig/examples/apparmor/libvirt-qemu libvirt/examples/apparmor/libvirt-qemu --- libvirt.orig/examples/apparmor/libvirt-qemu 2010-04-06 16:14:52.0 -0500 +++

Re: [libvirt] [PATCH] Generate libvirt_qemu.def from libvirt_qemu.syms for MinGW builds

2010-08-13 Thread Matthias Bolte
2010/8/13 Eric Blake ebl...@redhat.com: On 08/12/2010 05:23 PM, Matthias Bolte wrote: @@ -1866,6 +1866,7 @@ case $host in      # Also set the symbol file to .def, so src/Makefile generates libvirt.def      # from libvirt.syms and passes libvirt.def instead of libvirt.syms to the linker