[libvirt] Technical review of new libvirt TLS doco needed

2010-08-26 Thread Justin Clift
Hi all, Does someone have the time/inclination to review these new libvirt docs, showing how to set up TLS, for technical accuracy? Creating the Certificate Authority Cert http://wiki.libvirt.org/page/TLSCreateCACertSteps Creating the Server Certs http://wiki.libvirt.org/page/TLSCreat

Re: [libvirt] [PATCH] maint: turn on gcc logical-op checking

2010-08-26 Thread Eric Blake
On 07/26/2010 08:27 AM, Eric Blake wrote: On 07/24/2010 02:36 PM, Matthias Bolte wrote: + * nuking the wrappers; even if it removes some type-check safety. */ +# undef curl_easy_getinfo +# undef curl_easy_setopt + #define VIR_FROM_THIS VIR_FROM_ESX No need to hack here. We can define CURL_D

[libvirt] [PATCH] esx: Rework datastore path parsing and handling

2010-08-26 Thread Matthias Bolte
Instead of splitting the path part of a datastore path into directory and file name, keep this in one piece. An example: "[datastore] directory/file" was split into this before: datastoreName = "datastore" directoryName = "directory" fileName = "file" Now it's split into this: datast

Re: [libvirt] [PATCH] esx: Fix esxVI_BuildSelectSet's invalid argument check

2010-08-26 Thread Matthias Bolte
2010/8/27 Eric Blake : > On 08/26/2010 04:10 PM, Matthias Bolte wrote: >> >> The check was altered in 8c48743b9737ad4d246ab6043fd299316f9a2091 >> and got too strict, I've no clue how that snuck in. This check >> makes every try to open a connection using the ESX driver fail >> with an invalid argum

Re: [libvirt] [PATCH] esx: Fix esxVI_BuildSelectSet's invalid argument check

2010-08-26 Thread Eric Blake
On 08/26/2010 04:10 PM, Matthias Bolte wrote: The check was altered in 8c48743b9737ad4d246ab6043fd299316f9a2091 and got too strict, I've no clue how that snuck in. This check makes every try to open a connection using the ESX driver fail with an invalid argument error. Revert the change to the c

[libvirt] [PATCH] esx: Fix esxVI_BuildSelectSet's invalid argument check

2010-08-26 Thread Matthias Bolte
The check was altered in 8c48743b9737ad4d246ab6043fd299316f9a2091 and got too strict, I've no clue how that snuck in. This check makes every try to open a connection using the ESX driver fail with an invalid argument error. Revert the change to the check and add a comment to prevent future mistake

Re: [libvirt] [PATCH REPOST] esx: Add read-only storage volume access

2010-08-26 Thread Matthias Bolte
2010/8/23 Daniel P. Berrange : > On Mon, Aug 23, 2010 at 12:25:19AM +0200, Matthias Bolte wrote: >> This allows to list existing volumes and to retrieve information >> about them. >> --- >>  src/esx/esx_driver.c           |  112 +-- >>  src/esx/esx_storage_driver.c   |  433 >>

Re: [libvirt] PATCH 1/4: AppArmor updates

2010-08-26 Thread Jamie Strandboge
On Mon, 2010-08-16 at 15:59 -0500, Jamie Strandboge wrote: > On Mon, 2010-08-16 at 20:11 +0100, Daniel P. Berrange wrote: > > How can the domain start if the configured disk file doesn't exist on > > the host filesystem ? QEMU will try to open a non-existant file, fail, > > and abort. Failing on no