Re: [libvirt] [PATCH] esx: Map the .vmx annotation to the domain XML description

2010-08-27 Thread Matthias Bolte
2010/8/27 Eric Blake : > On 08/27/2010 10:31 AM, Matthias Bolte wrote: >> >> +    char *annotation = NULL; >> +    char *tmp; >> +    int length; > > s/int/size_t/ > >>      int controller; >>      int bus; >>      int port; >> @@ -947,6 +950,33 @@ esxVMX_ParseConfig(esxVMX_Context *ctx, virCapsPtr

Re: [libvirt] Xencaptest.c failing?

2010-08-27 Thread Matthias Bolte
2010/8/27 Thomas Graves : > Hello, > > We are running xen3.4.3 on rhel5.4 and trying to build the new libvirt 0.8.3 > and the xencaptest is failing. > > It seems to be failing because it is passing NULL in as the virtconn and it > ends up going into the following code section in function > xenHyper

Re: [libvirt] Technical review of new libvirt TLS doco needed

2010-08-27 Thread Matthias Bolte
2010/8/27 Justin Clift : > Hi all, > > Does someone have the time/inclination to review these new libvirt docs, > showing how to set up TLS, for technical accuracy? > >  Creating the Certificate Authority Cert >  http://wiki.libvirt.org/page/TLSCreateCACertSteps > >  Creating the Server Certs >  ht

Re: [libvirt] How to override TLS client cert and key locations used for migration?

2010-08-27 Thread Matthias Bolte
2010/8/26 Justin Clift : > Hi guys, > > Does anyone know if it's possible to override the default locations used for > the TLS client certificate and it's private key, as used in migration? > > We have overrides in libvirtd.conf for the server cert and its private key, > but I'm not seeing anything

[libvirt] Xencaptest.c failing?

2010-08-27 Thread Thomas Graves
Hello, We are running xen3.4.3 on rhel5.4 and trying to build the new libvirt 0.8.3 and the xencaptest is failing. It seems to be failing because it is passing NULL in as the virtconn and it ends up going into the following code section in function xenHypervisorBuildCapabilities: if (sys_inte

Re: [libvirt] [PATCH] esx: Map the .vmx annotation to the domain XML description

2010-08-27 Thread Eric Blake
On 08/27/2010 10:31 AM, Matthias Bolte wrote: +char *annotation = NULL; +char *tmp; +int length; s/int/size_t/ int controller; int bus; int port; @@ -947,6 +950,33 @@ esxVMX_ParseConfig(esxVMX_Context *ctx, virCapsPtr caps, const char *vmx, goto cleanu

[libvirt] [PATCH] esx: Map the .vmx annotation to the domain XML description

2010-08-27 Thread Matthias Bolte
Take care of escaping '"' and '|' (the escape character). Add tests for this. --- src/esx/esx_vmx.c| 124 - tests/vmx2xmldata/vmx2xml-annotation.vmx |3 + tests/vmx2xmldata/vmx2xml-annotation.xml | 16 tests/vmx2xmltest.c

Re: [libvirt] [PATCH] maint: turn on gcc logical-op checking

2010-08-27 Thread Eric Blake
On 08/27/2010 02:32 AM, Matthias Bolte wrote: Well, even if this is fixed in GCC>= 4.5.0 and a workaround was added to libcurl and Fedora isn't affected anymore doesn't mean that this problem is fixed for all systems/distros out there. I think we could remove CURL_DISABLE_TYPECHECK for GCC>= 4.

Re: [libvirt] [PATCH] PHYP: Bad comparison when checking for existing domain name

2010-08-27 Thread Matthias Bolte
2010/8/25 Eduardo Otubo : > On 08/17/2010 04:04 PM, Eduardo Otubo wrote: >> >> When creating a new domain from an XML, the check for an existing >> domain name should compare the return of the function to a a valid >> LPAR ID (!= -1) and not to error (== -1). >> --- >>  src/phyp/phyp_driver.c |    

Re: [libvirt] [PATCH] maint: turn on gcc logical-op checking

2010-08-27 Thread Matthias Bolte
2010/8/27 Eric Blake : > On 07/26/2010 08:27 AM, Eric Blake wrote: >> >> On 07/24/2010 02:36 PM, Matthias Bolte wrote: + * nuking the wrappers; even if it removes some type-check safety.  */ +# undef curl_easy_getinfo +# undef curl_easy_setopt +  #define VIR_FROM_THIS