Re: [libvirt] OSX 10.6 build failures

2010-09-14 Thread Doug Goldstein
On Tue, Sep 14, 2010 at 7:57 PM, Osier wrote: > > - "Osier" wrote: > >> From: "Osier" >> To: "Justin Clift" >> Cc: "Libvirt Developers Mailing List" >> Sent: Wednesday, September 15, 2010 8:45:20 AM GMT +08:00 Beijing / >> Chongqing / Hong Kong / Urumqi >> Subject: Re: [libvirt] OSX 10.6

Re: [libvirt] OSX 10.6 build failures

2010-09-14 Thread Osier
- "Osier" wrote: > From: "Osier" > To: "Justin Clift" > Cc: "Libvirt Developers Mailing List" > Sent: Wednesday, September 15, 2010 8:45:20 AM GMT +08:00 Beijing / Chongqing > / Hong Kong / Urumqi > Subject: Re: [libvirt] OSX 10.6 build failures > > - "Justin Clift" wrote: > > > Fr

Re: [libvirt] OSX 10.6 build failures

2010-09-14 Thread Osier
- "Justin Clift" wrote: > From: "Justin Clift" > To: "Libvirt Developers Mailing List" > Sent: Wednesday, September 15, 2010 7:42:48 AM GMT +08:00 Beijing / Chongqing > / Hong Kong / Urumqi > Subject: [libvirt] OSX 10.6 build failures > > Hi us, > > Going through the process of getting l

[libvirt] OSX 10.6 build failures

2010-09-14 Thread Justin Clift
Hi us, Going through the process of getting libvirt to compile on OSX, making notes of the failures on the way through (from a clean system) to be fixed. a) libtool -> glibtool libtoolize -> glibtoolize It turns out that autogen.sh is hard coded to use "libtool", and wants the GNU ve

Re: [libvirt] RFC [3/3]: Lock manager usage scenarios

2010-09-14 Thread Ayal Baron
- "Daniel P. Berrange" wrote: > On Mon, Sep 13, 2010 at 03:49:38PM +0200, Saggi Mizrahi wrote: > > On Mon, 2010-09-13 at 14:29 +0100, Daniel P. Berrange wrote: > > > On Mon, Sep 13, 2010 at 03:20:13PM +0200, Saggi Mizrahi wrote: > > > > On Mon, 2010-09-13 at 13:35 +0100, Daniel P. Berrange w

[libvirt] [PATCH 2/3] Make SASL work over UNIX domain sockets

2010-09-14 Thread Daniel P. Berrange
The addrToString methods were not coping with UNIX domain sockets which have no normal host+port address. Hardcode special handling for these so that SASL routines can work over UNIX sockets. Also fix up SSF logic in remote client so that it presumes that a UNIX socket is secure * daemon/remote.c:

[libvirt] [PATCH 1/3] Refactor some daemon code to facilitate introduction of static probes

2010-09-14 Thread Daniel P. Berrange
Refactor some daemon code to facilitate the introductioin of static probes, sanitizing function exit paths in many places * daemon/libvirtd.c: Pass the dname string into remoteCheckDN to let caller deal with failure paths. Add separate exit paths to remoteCheckCertificate for auth failure vs d

[libvirt] [PATCH 0/3] Experimental support for DTrace probes

2010-09-14 Thread Daniel P. Berrange
This patchset provides the infrastructure for supporting dynamic probing of libvirtd, using static DTrace markers. This can be used by SystemTAP on Linux, or DTrace on Solaris/OS-X/BSD for low overhead tracing. The proof of concept provides a handful of markers wrt to network client connections, s

[libvirt] [PATCH 3/3] Add dtrace static probes in libvirtd

2010-09-14 Thread Daniel P. Berrange
Adds initial support for dtrace static probes in libvirtd daemon, assuming use of systemtap dtrace compat shim on Linux. The probes are inserted for network client connect, disconnect, TLS handshake states and authentication protocol states. This can be tested by running the xample program and the

Re: [libvirt] RFC [3/3]: Lock manager usage scenarios

2010-09-14 Thread David Teigland
On Mon, Sep 13, 2010 at 02:29:49PM +0100, Daniel P. Berrange wrote: > > > We are looking into the possibility of not having a process manage a > > VM but rather having the sync_manager process register with a central > > daemon and exec into qemu (or anything else) so assuming there is a > > proces

Re: [libvirt] [PATCH] maint: silence warning from libtool

2010-09-14 Thread Eric Blake
On 09/14/2010 09:57 AM, Jiri Denemark wrote: diff --git a/configure.ac b/configure.ac index a71f5e8..5ded22b 100644 --- a/configure.ac +++ b/configure.ac @@ -122,9 +122,6 @@ AM_CONDITIONAL([HAVE_GLIBC_RPCGEN], $ac_cv_path_RPCGEN -t/dev/null 2>&1]) dnl Miscellaneous external pro

Re: [libvirt] [PATCH] maint: silence warning from libtool

2010-09-14 Thread Jiri Denemark
> diff --git a/configure.ac b/configure.ac > index a71f5e8..5ded22b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -122,9 +122,6 @@ AM_CONDITIONAL([HAVE_GLIBC_RPCGEN], > $ac_cv_path_RPCGEN -t /dev/null 2>&1]) > > dnl Miscellaneous external programs. > -AC_PATH_PROG([RM], [rm]

[libvirt] New wiki pages with libvirt SSH setup instructions

2010-09-14 Thread Justin Clift
Hi all, Just added some new pages to the wiki, this time covering how to configure remote access to libvirt through SSH, not using root: http://wiki.libvirt.org/page/SSHSetup <--- entry page http://wiki.libvirt.org/page/SSHPolicyKitSetup This has details for several different Linux dist

Re: [libvirt] [PATCH] Rebuild network filter for UML guests on updates

2010-09-14 Thread Eric Blake
On 09/14/2010 02:07 AM, Soren Hansen wrote: When nwfilter support was added to UML, I didn't realise the UML driver needed instrumentation to make updating nwfilters on the fly work. This patch adds this bit of glue. Signed-off-by: Soren Hansen --- src/uml/uml_driver.c | 18 +

Re: [libvirt] [PATCH] virsh: Use virBuffer for generating XML

2010-09-14 Thread Jiri Denemark
> > @@ -7903,52 +7904,40 @@ cmdAttachInterface(vshControl *ctl, const vshCmd > > *cmd) > > } > > > > /* Make XML of interface */ > > -tmp = vshMalloc(ctl, 1); > > -buf = vshMalloc(ctl, strlen(type) + 25); > > -sprintf(buf, "\n" , type); > > +virBufferVSprintf(&buf, "\n"

Re: [libvirt] [PATCH] build: use portable sed expressions

2010-09-14 Thread Eric Blake
On 09/14/2010 05:09 AM, Paolo Bonzini wrote: On 09/10/2010 06:43 PM, Eric Blake wrote: * src/Makefile.am (libvirt.def, libvirt_qemu.def): '\}' and '\t' are not required by POSIX. Use '}' and literal tab instead. (install-data-local): Avoid sed -i. * tests/read-bufsiz: Likewise. Reported by Mitc

Re: [libvirt] [PATCH] virsh: Use virBuffer for generating XML

2010-09-14 Thread Eric Blake
On 09/14/2010 05:54 AM, Jiri Denemark wrote: cmdAttachInterface and cmdAttachDisk still used vshRealloc and sprintf for generating XML, which is hardly maintainable. Let's get rid of this old code. All right and about time! That was on my TODO list as well, but you beat me to it :) @@ -790

Re: [libvirt] [PATCH 0/3] test cases for spoofing prevention

2010-09-14 Thread Gerhard Stenzel
On Tue, 2010-09-14 at 14:10 +0100, Daniel P. Berrange wrote: > This is bizarre - I don't see any characters in the $cmdfile > string that are above ASCII-7 range, so should be identical > whether its utf8 encoded or not !?!? Do you know why this > makes it work correctly ? The presence of ${mac1

Re: [libvirt] [PATCH 0/3] test cases for spoofing prevention

2010-09-14 Thread Daniel P. Berrange
On Tue, Sep 14, 2010 at 02:52:13PM +0200, Gerhard Stenzel wrote: > On Fri, 2010-09-10 at 16:02 +0200, Gerhard Stenzel wrote: > > Sounds good and I will give it a try ... > > All my tests worked except scripts/nwfilter/210-no-mac-spoofing.t, which > failed with on Fedora 13: > ... > # ' > /test.sh

Re: [libvirt] [PATCH 0/3] test cases for spoofing prevention

2010-09-14 Thread Gerhard Stenzel
On Fri, 2010-09-10 at 16:02 +0200, Gerhard Stenzel wrote: > Sounds good and I will give it a try ... All my tests worked except scripts/nwfilter/210-no-mac-spoofing.t, which failed with on Fedora 13: ... # ' > /test.sh input must be 8 bytes long at /usr/lib64/perl5/Crypt/DES.pm line 57. # Looks li

[libvirt] [PATCH] virsh: Use virBuffer for generating XML

2010-09-14 Thread Jiri Denemark
cmdAttachInterface and cmdAttachDisk still used vshRealloc and sprintf for generating XML, which is hardly maintainable. Let's get rid of this old code. --- tools/virsh.c | 152 1 files changed, 54 insertions(+), 98 deletions(-) diff --git

Re: [libvirt] [PATCH] build: use portable sed expressions

2010-09-14 Thread Paolo Bonzini
On 09/10/2010 06:43 PM, Eric Blake wrote: > * src/Makefile.am (libvirt.def, libvirt_qemu.def): '\}' and '\t' > are not required by POSIX. Use '}' and literal tab instead. > (install-data-local): Avoid sed -i. > * tests/read-bufsiz: Likewise. > Reported by Mitchell Hashimoto. > --- > > This should

Re: [libvirt] XML support for arbitrary command line arguments

2010-09-14 Thread Harsh Bora
If I am not wrong, we are not reinventing the wheel, in fact we are asking to support the 'invention' of an efficient means of accessing the underlying storage on same physical machine. The question is, why to take a (virtual) long route through network based protocols which will involve overhe

Re: [libvirt] XML support for arbitrary command line arguments

2010-09-14 Thread Daniel P. Berrange
On Tue, Sep 14, 2010 at 08:27:38PM +1000, Justin Clift wrote: > On 09/14/2010 07:43 PM, Daniel P. Berrange wrote: > >The other interesting question to me is actually what todo in the guest > >with this. I think for this to be useful we really want some kind of > >magic in udev to automatically moun

Re: [libvirt] XML support for arbitrary command line arguments

2010-09-14 Thread Justin Clift
On 09/14/2010 07:43 PM, Daniel P. Berrange wrote: The other interesting question to me is actually what todo in the guest with this. I think for this to be useful we really want some kind of magic in udev to automatically mount the filesystem based on the mount tag data, and in particular define

Re: [libvirt] XML support for arbitrary command line arguments

2010-09-14 Thread Daniel P. Berrange
On Tue, Sep 14, 2010 at 11:03:04AM +0530, Harsh Bora wrote: > As QEMU provides support for accessing such shared directory with the > help of 9p server, and therefore need to be passed additional > commandline argument while starting, I wanted to test it using XML and > libvirt. > So, if the id

[libvirt] [PATCH] Rebuild network filter for UML guests on updates

2010-09-14 Thread Soren Hansen
When nwfilter support was added to UML, I didn't realise the UML driver needed instrumentation to make updating nwfilters on the fly work. This patch adds this bit of glue. Signed-off-by: Soren Hansen --- src/uml/uml_driver.c | 18 ++ 1 files changed, 18 insertions(+), 0 deleti