[libvirt] [PATCH v3 03/13] Adds xml entries for memory tunables

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com The patch adds xml entries to the domain.rng file. v2: + Fix typo min_guarantee Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com --- docs/schemas/domain.rng | 31 +++ 1 files changed, 31 insertions(+),

[libvirt] [PATCH v3 01/13] Adding structure and defines for virDomainSet/GetMemoryParameters

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com This patch adds a structure virMemoryParameter, it contains the name of the parameter and the type of the parameter along with a union. v3: + Protoype for virDomainGetMemoryParameters and dummy python binding. v2: + Includes dummy python

[libvirt] [PATCH v3 00/13] Implement memory control api

2010-09-28 Thread Nikunj A. Dadhania
Changelog from v2: * Implement virDomainGetMemoryParameters api * Add virDomainGetMemoryParameters to memtune command in virsh * Provide domainGetMemoryParameters implementation for remote, QEmu and LXC drivers * Auto-generate code using rpcgen and remote_generate_stubs.pl * Squash

[libvirt] [PATCH v3 09/13] Adding memtunables to libvirt-lxc command

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com libvirt-lxc now configures the hardlimit, softlimit and swaplimit, if specified in the domain xml file or picks up the defaults. Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com --- src/lxc/lxc_controller.c | 22

[libvirt] [PATCH v3 05/13] Implement cgroup memory controller tunables

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Provides interfaces for setting/getting memory tunables like hard_limit, soft_limit and swap_hard_limit Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com --- src/libvirt_private.syms |6 +++ src/util/cgroup.c| 106

[libvirt] [PATCH v3 06/13] Implement driver interface domainSetMemoryParamters for QEmu

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Driver interface for setting memory hard_limit, soft_limit and swap hard_limit. v2: + Use #define string constants for hard_limit, etc. + fix typo: min_guarantee Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com ---

[libvirt] [PATCH v3 12/13] Adding memtune command to virsh tool

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com The command helps to control the memory/swap parameters for the system, for eg. hard_limit (max memory the vm can use), soft_limit (limit during memory contention), swap_hard_limit(max swap the vm can use) v3: + Added call to

[libvirt] [PATCH v3 02/13] Adding virDomainSetMemoryParameters and virDomainGetMemoryParameters API

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Public api to set/get memory tunables supported by the hypervisors. RFC: https://www.redhat.com/archives/libvir-list/2010-August/msg00607.html v3: * Add domainGetMemoryParamters and NULL in all the driver interface v2: * Initialize

[libvirt] [PATCH v3 10/13] Implement driver interface domainSetMemoryParamters for LXC

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Add support in the lxc driver for various memory controllable parameters v2: + Use #define string constants for hard_limit, etc + fix typo: min_guarantee Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com --- src/lxc/lxc_driver.c |

[libvirt] [PATCH v3 08/13] Adding memtunables to qemuSetupCgroup

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com QEmu startup would pick up the memory tunables specified in the domain configuration file. Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com --- src/qemu/qemu.conf |4 ++-- src/qemu/qemu_conf.c |3 ++-

[libvirt] [PATCH v3 13/13] Remote protocol changes and implements virDomainSet/GetMemoryParameters

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com v3: * Squased all the remote driver changes to one single big patch and auto-generated is around 40% * Implements domainSetMemoryParameters and domainGetMemoryParameters for remote driver daemon/remote.c

[libvirt] [PATCH v3 04/13] XML parsing for memory tunables

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Adding parsing code for memory tunables in the domain xml file v2: + Fix typo min_guarantee Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com --- src/conf/domain_conf.c | 50 +---

[libvirt] [PATCH v3 11/13] Implement driver interface domainGetMemoryParamters for LXC

2010-09-28 Thread Nikunj A. Dadhania
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com Driver interface for getting memory parameters, eg. hard_limit, soft_limit and swap_hard_limit. Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com --- src/lxc/lxc_driver.c | 113 ++ 1

Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-28 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 09/27/2010 05:07:47 PM: On 09/27/2010 12:40 PM, Stefan Berger wrote: Extend the nwfilter.rng schema to accept comment attributes for all protocol types. Signed-off-by: Stefan Berger stef...@us.ibm.com + define name=comment-attribute +

[libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Justin Clift
This addresses a compilation failure issue reported last year on OS X: https://www.redhat.com/archives/libvir-list/2009-May/msg00166.html In testing here, the compilation only fails on 32 bit OS X, but works on 64 bit, even when using exact same compile and linking flags. This commit

Re: [libvirt] [PATCH] nwfilter: remove recently added workaround define for macos x

2010-09-28 Thread Justin Clift
On 09/28/2010 08:48 PM, Stefan Berger wrote: On 09/27/2010 09:10 PM, Justin Clift wrote: This reverses commit 04c3704, which added a define to nwfilter to allow libvirtd compilation on Mac OS X. Stefan Bergers commit, 2e7294d, is the proper solution, removing the requirement for nwfilter on

[libvirt] [PATCH] mac os x: use awk selected by build system rather than first in path

2010-09-28 Thread Justin Clift
Prior to this patch, the ChangeLog generation was hard coded to use awk, when it should have been using the AWK variable set by our build system. This breaks compilation on a newly installed OS X system, where the default path has the Mac (non GNU) awk in the default search PATH before any

Re: [libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Eric Blake
[adding bug-gnulib] On 09/28/2010 06:36 AM, Justin Clift wrote: This addresses a compilation failure issue reported last year on OS X: https://www.redhat.com/archives/libvir-list/2009-May/msg00166.html which in turn mentions: gcc -Wall -Wformat -Wmissing-prototypes -Wnested-externs

Re: [libvirt] [PATCH] mac os x: use awk selected by build system rather than first in path

2010-09-28 Thread Eric Blake
On 09/28/2010 07:38 AM, Justin Clift wrote: Prior to this patch, the ChangeLog generation was hard coded to use awk, when it should have been using the AWK variable set by our build system. This breaks compilation on a newly installed OS X system, where the default path has the Mac (non GNU)

Re: [libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Eric Blake
[replies can omit bug-gnulib] On 09/28/2010 08:29 AM, Eric Blake wrote: [adding bug-gnulib] which in turn mentions: gcc -Wall -Wformat -Wmissing-prototypes -Wnested-externs -Wpointer- arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Wstrict-prototypes -Winline

Re: [libvirt] [PATCH] mac os x: don't compile failing example program on 32 bit mac os x

2010-09-28 Thread Justin Clift
On 09/29/2010 12:29 AM, Eric Blake wrote: snip But the failed link mentions rpl_poll, not poll, which means this is most likely a gnulib bug in the poll module. Rather than skipping this test on just 32-bit MacOS in libvirt, I think the better thing to do is address why gnulib is triggering a

[libvirt] [PATCH] Rework configure logic for virtualport support

2010-09-28 Thread Stefan Berger
In this patch I am reworking the logic around detecting virtual port support and requiring the libnl dependency. - It requires --with-macvtap and displays an error in case of --without-macvtap --with-virtualport. - It tests for availability of certain data in include files and displays an

Re: [libvirt] [PATCH] Rework configure logic for virtualport support

2010-09-28 Thread Eric Blake
On 09/28/2010 11:01 AM, Stefan Berger wrote: In this patch I am reworking the logic around detecting virtual port support and requiring the libnl dependency. - It requires --with-macvtap and displays an error in case of --without-macvtap --with-virtualport. - It tests for availability of

Re: [libvirt] [PATCH] Rework configure logic for virtualport support

2010-09-28 Thread Stefan Berger
On 09/28/2010 01:52 PM, Eric Blake wrote: On 09/28/2010 11:01 AM, Stefan Berger wrote: -AC_TRY_COMPILE([ #include sys/socket.h - #include linux/rtnetlink.h ], - [ int x = IFLA_PORT_MAX; ], - [ with_virtualport=yes ], - [ with_virtualport=no ]) -if test $with_virtualport = yes; then - val=1

Re: [libvirt] [PATCH V2] Rework configure logic for virtualport support

2010-09-28 Thread Eric Blake
On 09/28/2010 12:31 PM, Stefan Berger wrote: V2: - added missing AC_ARG_WITH() for --with-virtualport In this patch I am reworking the logic around detecting virtual port support and requiring the libnl dependency. - It requires --with-macvtap and displays an error in case of --without-macvtap

Re: [libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

2010-09-28 Thread Eric Blake
On 09/27/2010 02:26 PM, Stefan Berger wrote: The patch below extends the XML parser and generator so that every protocol now can have a comment node. Comments are limited to 256 characters and are tested to only contain printable characters or spaces. Literal spaces, or generic blanks

Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-28 Thread Eric Blake
On 09/28/2010 04:28 AM, Stefan Berger wrote: okay. It also leaves out 8-bit bytes - could that be a problem for i18n where people want comments with native-language accented characters? That is, are we being too strict here? Maybe a better pattern would be to reject specific non-printing

Re: [libvirt] RFC: add currentVcpu element

2010-09-28 Thread Eric Blake
On 09/27/2010 11:20 AM, Eric Blake wrote: No change to existing API semantics, although the implementation can wrap old APIs to call the new ones with appropriate flags where appropriate to minimize code duplication. One more API to think about: virDomainGetInfo returns a virDomainInfoPtr,

Re: [libvirt] [PATCH v2 1/5] Extend XML parser and generator to support comment attribute

2010-09-28 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 09/28/2010 03:19:42 PM: On 09/27/2010 02:26 PM, Stefan Berger wrote: The patch below extends the XML parser and generator so that every protocol now can have a comment node. Comments are limited to 256 characters and are tested to only contain

Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes

2010-09-28 Thread Stefan Berger
Eric Blake ebl...@redhat.com wrote on 09/28/2010 03:26:48 PM: [image removed] Re: [libvirt] [PATCH v2 3/5] Extend nwfilter schema to accept comment attributes Eric Blake to: Stefan Berger 09/28/2010 03:27 PM Cc: libvir-list On 09/28/2010 04:28 AM, Stefan Berger wrote:

Re: [libvirt] RFC: add currentVcpu element

2010-09-28 Thread Eric Blake
On 09/27/2010 11:20 AM, Eric Blake wrote: Another question I had, is there a way in QEmu to specifiy a different cpu count from the -smp indicating the startup count ? I wish I knew off-hand, as it would make it easier for me to implement when I get to that part of the patch series :) But