Re: [libvirt] The last two remaining "out of the box" build failures for OS X

2010-09-29 Thread Justin Clift
On 09/30/2010 03:10 PM, Doug Goldstein wrote: > I don't have my Mac with me right now but if you want prod me off list and maybe we can work up a work around that will handle this case properly and that will support the BSDs as well as Mac OS X. Sure, doing so now. :) -- libvir-list mailing l

Re: [libvirt] The last two remaining "out of the box" build failures for OS X

2010-09-29 Thread Doug Goldstein
On Wed, Sep 29, 2010 at 8:04 AM, Justin Clift wrote: > Hi all, > > On the home straight getting libvirt to work "out of the box" on MacOS X. >  (ideal scenario: it's "good enough" today. :>) I applaud all your efforts that you've been doing for sure! > >  + Leaving off --without-storage-fs give

[libvirt] [PATCH 11/12] vcpu: complete vcpu support in qemu driver

2010-09-29 Thread Eric Blake
* src/qemu/qemu_driver.c (qemudDomainSetVcpusFlags) (qemudDomainGetVcpusFlags): Support all feasible flag combinations. --- Aargh - my ISP SMTP server said that 11 emails is the limit for one session, so I have to resend the last two of my series (and figure out how to config git to use multiple s

[libvirt] [PATCH 12/12] food for thought

2010-09-29 Thread Eric Blake
Here's where I ran out of time for the day. I'm much less familiar with xen than with qemu, so I have no idea how to tell if xen's documented domain/vcpu_avail (which is what we want for current vcpus) is usable in contrast to domain/vcpus (the maximum amount). For that matter, I'm not even sure

[libvirt] [PATCH 09/12] vcpu: add virsh support

2010-09-29 Thread Eric Blake
* tools/virsh.c (cmdSetvcpus): Add new flags. Let invalid commands through to driver, to ease testing of hypervisor argument validation. (cmdVcpucount): New command. (commands): Add new command. * tools/virsh.pod (setvcpus, vcpucount): Document new behavior. --- I know - the typical API addition

[libvirt] [PATCH 07/12] vcpu: make old API trivially wrap to new API

2010-09-29 Thread Eric Blake
* src/esx/esx_driver.c (esxDomainSetVcpus, escDomainGetMaxVpcus): Move guts... (esxDomainSetVcpusFlags, esxDomainGetVcpusFlags): ...to new functions. (esxDriver): Trivially support the new API. * src/openvz/openvz_driver.c (openvzDomainSetVcpus) (openvzDomainSetVcpusFlags, openvzDomainGetMaxVcpus)

[libvirt] [PATCH 10/12] vcpu: improve vcpu support in qemu command line

2010-09-29 Thread Eric Blake
* src/qemu/qemu_conf.c (qemuParseCommandLineSmp): Distinguish between vcpus and maxvcpus, for new enough qemu. * tests/qemuargv2xmltest.c (mymain): Add new test. * tests/qemuxml2argvtest.c (mymain): Likewise. * tests/qemuxml2xmltest.c (mymain): Likewise. * tests/qemuxml2argvdata/qemuxml2argv-smp.ar

[libvirt] [PATCH 08/12] vcpu: support maxvcpu in domain_conf

2010-09-29 Thread Eric Blake
* src/conf/domain_conf.h (_virDomainDef): Adjust vcpus to unsigned short, to match virDomainGetInfo limit. Add maxvcpus member. * src/conf/domain_conf.c (virDomainDefParseXML) (virDomainDefFormat): parse and print out vcpu details. * src/xen/xend_internal.c (xenDaemonParseSxpr) (xenDaemonFormatSxp

[libvirt] [PATCH 06/12] vcpu: implement the remote protocol

2010-09-29 Thread Eric Blake
* daemon/remote.c (remoteDispatchDomainSetVcpusFlags) (remoteDispatchDomainGetVcpusFlags): New functions. * src/remote/remote_driver.c (remoteDomainSetVcpusFlags) (remoteDomainGetVcpusFlags, remote_driver): Client side serialization. * src/remote/remote_protocol.x (remote_domain_set_vcpus_flags_arg

[libvirt] [PATCH 04/12] vcpu: define internal driver API

2010-09-29 Thread Eric Blake
* src/driver.h (virDrvDomainSetVcpusFlags) (virDrvDomainGetVcpusFlags): New typedefs. (_virDriver): New callback members. * src/esx/esx_driver.c (esxDriver): Add stub for driver. * src/lxc/lxc_driver.c (lxcDriver): Likewise. * src/opennebula/one_driver.c (oneDriver): Likewise. * src/openvz/openvz_d

[libvirt] [PATCH 03/12] vcpu: add new public API

2010-09-29 Thread Eric Blake
API agreed on in https://www.redhat.com/archives/libvir-list/2010-September/msg00456.html * include/libvirt/libvirt.h.in (virDomainVcpuFlags) (virDomainSetVcpusFlags, virDomainGetVcpusFlags): New declarations. * src/libvirt_public.syms: Export new symbols. --- However, in implementing things, I'm

[libvirt] [PATCH 05/12] vcpu: implement the public APIs

2010-09-29 Thread Eric Blake
* src/libvirt.c (virDomainSetVcpusFlags, virDomainGetVcpusFlags): New functions. --- Pretty mechanical. src/libvirt.c | 125 +++- 1 files changed, 122 insertions(+), 3 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index ca383ba..3a2

[libvirt] [PATCH 00/12] vcpus: initial implemantation of .

2010-09-29 Thread Eric Blake
As promised, here's my first round of patches to make support add the ability to persistently remember if a domain should have fewer vcpus at boot than the maximum allowed for hot-plugging. Patches 1-10 are pretty well tested, 11 may need some tweaking to get the semantics right, and 12 is mainly

[libvirt] [PATCH 01/12] vcpu: improve cpuset attribute

2010-09-29 Thread Eric Blake
The attribute has been available since commit e193b5dd, but without documentation or RNG validation. * docs/schemas/domain.rng (vcpu): Further validate cpuset. * docs/formatdomain.html.in: Document it. * src/conf/domain_conf.c: Fix typos. --- docs/formatdomain.html.in | 12 ++-- docs/s

[libvirt] [PATCH 02/12] vcpu: add current attribute to element

2010-09-29 Thread Eric Blake
Syntax agreed on in https://www.redhat.com/archives/libvir-list/2010-September/msg00476.html * docs/schemas/domain.rng: Add new attribute. * docs/formatdomain.html.in: Document it. * tests/qemuxml2argvdata/qemuxml2argv-smp.xml: Add to domainschematest. * tests/xml2sexprdata/xml2sexpr-pv-vcpus.xml:

[libvirt] [PATCH] esx: Add support for virtual serial device network backing

2010-09-29 Thread Matthias Bolte
Since version 4.1 ESX(i) can expose virtual serial devices over TCP. Add support in the VMX handling code for this, add test cases to cover it and add links to some documentation. ESX supports two additional protocols: TELNETS and TLS. Add them to the list of serial-over-TCP protocols. --- docs/

Re: [libvirt] [PATCH] configure: tweak logic flow of virtport check

2010-09-29 Thread Stefan Berger
On 09/29/2010 10:22 AM, Justin Clift wrote: This fixes a small logic bug, where passing --without-macvtap on the configure line, or otherwise indicating a lack of support for macvtap, causes configure to bail. --- configure.ac | 13 - 1 files changed, 12 insertions(+), 1 deletio

Re: [libvirt] [PATCH] configure: tweak logic flow of virtport check

2010-09-29 Thread Justin Clift
On 09/30/2010 01:39 AM, Stefan Berger wrote: Thanks. I saw the configure failure you posted, started working on a patch and then got busy doing something else... No worries. :) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv3] PHYP: Checking for NULL values when building new guest

2010-09-29 Thread Daniel Veillard
On Wed, Aug 25, 2010 at 01:27:44PM -0300, Eduardo Otubo wrote: > When creating a new gust, the function phypBuildLpar() was not > checking for NULL values, making the driver to have a segmentation > fault. > --- > src/phyp/phyp_driver.c | 23 +++ > 1 files changed, 23 inserti

Re: [libvirt] [PATCH] configure: tweak logic flow of virtport check

2010-09-29 Thread Justin Clift
On 09/30/2010 12:38 AM, Eric Blake wrote: On 09/29/2010 08:22 AM, Justin Clift wrote: This fixes a small logic bug, where passing --without-macvtap on the configure line, or otherwise indicating a lack of support for macvtap, causes configure to bail. --- configure.ac | 13 - 1 files

Re: [libvirt] [PATCH] configure: tweak logic flow of virtport check

2010-09-29 Thread Eric Blake
On 09/29/2010 08:22 AM, Justin Clift wrote: This fixes a small logic bug, where passing --without-macvtap on the configure line, or otherwise indicating a lack of support for macvtap, causes configure to bail. --- configure.ac | 13 - 1 files changed, 12 insertions(+), 1 deletion

Re: [libvirt] [PATCH] mpath: disable devmapper-multipath checking on non-linux

2010-09-29 Thread Justin Clift
On 09/30/2010 12:05 AM, Eric Blake wrote: On 09/29/2010 06:56 AM, Justin Clift wrote: The configure script was breaking on MacOS X unless passed: --without-storage-mpath This patch leverages Stefan Bergers earlier work for nwfilter, so non-linux systems don't even attempt to build multipath.

[libvirt] [PATCH] configure: tweak logic flow of virtport check

2010-09-29 Thread Justin Clift
This fixes a small logic bug, where passing --without-macvtap on the configure line, or otherwise indicating a lack of support for macvtap, causes configure to bail. --- configure.ac | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac i

Re: [libvirt] [PATCH V2] Rework configure logic for virtualport support

2010-09-29 Thread Justin Clift
On 09/29/2010 10:44 PM, Justin Clift wrote: On 09/29/2010 09:58 PM, Stefan Berger wrote: ACK. Pushed. Ouch, that appears to have j Ouch, this just broke the ./configure script on Mac OS X: * checking for iconv... yes checking how to link with libiconv... -liconv checking

Re: [libvirt] [PATCH] mpath: disable devmapper-multipath checking on non-linux

2010-09-29 Thread Eric Blake
On 09/29/2010 06:56 AM, Justin Clift wrote: The configure script was breaking on MacOS X unless passed: --without-storage-mpath This patch leverages Stefan Bergers earlier work for nwfilter, so non-linux systems don't even attempt to build multipath. ACK. -- Eric Blake ebl...@redhat.com

[libvirt] The last two remaining "out of the box" build failures for OS X

2010-09-29 Thread Justin Clift
Hi all, On the home straight getting libvirt to work "out of the box" on MacOS X. (ideal scenario: it's "good enough" today. :>) With the very latest git snapshot, to get a working compile requires these options to be used: ./configure --without-network --without-storage-fs Leaving either

[libvirt] [PATCH] mpath: disable devmapper-multipath checking on non-linux

2010-09-29 Thread Justin Clift
The configure script was breaking on MacOS X unless passed: --without-storage-mpath This patch leverages Stefan Bergers earlier work for nwfilter, so non-linux systems don't even attempt to build multipath. --- configure.ac | 18 +- 1 files changed, 9 insertions(+), 9 deletio

Re: [libvirt] [PATCH V2] Rework configure logic for virtualport support

2010-09-29 Thread Justin Clift
On 09/29/2010 09:58 PM, Stefan Berger wrote: ACK. Pushed. Ouch, that appears to have j Ouch, this just broke the ./configure script on Mac OS X: * checking for iconv... yes checking how to link with libiconv... -liconv checking for GNU gettext in libintl... yes checking wh

Re: [libvirt] [PATCH] autogen: added glibtool and pkg-config checks

2010-09-29 Thread Justin Clift
On 09/29/2010 10:13 PM, Gary V. Vaughan wrote: Just wanting to get an idea when we can drop the simple override patch for Mac OS X? :) If that was directed at me, I wasn't paying enough attention to the rest of the thread to know what that patch is... ;) Nah. With libvirt, we presently have

Re: [libvirt] [PATCH V2] Rework configure logic for virtualport support

2010-09-29 Thread Stefan Berger
On 09/28/2010 03:14 PM, Eric Blake wrote: On 09/28/2010 12:31 PM, Stefan Berger wrote: V2: - added missing AC_ARG_WITH() for --with-virtualport In this patch I am reworking the logic around detecting virtual port support and requiring the libnl dependency. - It requires --with-macvtap and dis

Re: [libvirt] RFC: add element

2010-09-29 Thread Daniel Veillard
On Tue, Sep 28, 2010 at 04:36:51PM -0600, Eric Blake wrote: > On 09/27/2010 11:20 AM, Eric Blake wrote: > >> > >>Another question I had, is there a way in QEmu to specifiy a different > >>cpu count from the -smp indicating the startup count ? > > > >I wish I knew off-hand, as it would make it easie

Re: [libvirt] RFC: add element

2010-09-29 Thread Daniel Veillard
On Tue, Sep 28, 2010 at 01:36:13PM -0600, Eric Blake wrote: > On 09/27/2010 11:20 AM, Eric Blake wrote: > >No change to existing API semantics, although the implementation can > >wrap old APIs to call the new ones with appropriate flags where > >appropriate to minimize code duplication. > > One mo

[libvirt] [libvirt-tck] [RFC] 802.1Qbg test scripts

2010-09-29 Thread Gerhard Stenzel
Hi Daniel, I am currently looking into TCK test cases to verify setting 802.1Qbg functionality from libvirt. My current approach requires changes to some library functions in lib/Sys/Virt/TCK/. I would appreciate your feedback about these changes before continuing much further. I also attach the te