Re: [libvirt] [PATCH] Added new attribute exportfs_type to filesystem element

2010-10-06 Thread Harsh Bora
Hi Daniel, Makes sense, agreed. However, did you get a chance to review the security_model patch? https://www.redhat.com/archives/libvir-list/2010-September/msg00435.html On 10/06/2010 09:59 PM, Daniel P. Berrange wrote: On Wed, Oct 06, 2010 at 06:22:29PM +0200, Daniel Veillard wrote: On Thu,

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-06 Thread Justin Clift
On 09/22/2010 11:56 PM, Justin Clift wrote: As a follow up, our libvirt formula has been pulled into the upstream repository, and is now available on OSX to everyone using Homebrew: http://mxcl.github.com/homebrew/ -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mai

Re: [libvirt] [PATCH] document authentication with PolicyKit-1

2010-10-06 Thread Justin Clift
On 10/07/2010 07:42 AM, Eric Blake wrote: I just encountered the same problem with the newer PolicyKit as discussed e.g. in this thread: http://lists.fedoraproject.org/pipermail/virt/2010-June/002081.html I solved it and thought updating the documentation for PolicyKit 1 would be nice. Patch a

Re: [libvirt] [PATCH 12/12] food for thought

2010-10-06 Thread Eric Blake
On 09/29/2010 06:09 PM, Eric Blake wrote: Here's where I ran out of time for the day. I'm much less familiar with xen than with qemu, so I have no idea how to tell if xen's documented domain/vcpu_avail (which is what we want for current vcpus) is usable in contrast to domain/vcpus (the maximum a

[libvirt] nwfilter: test code to provoke deadlock

2010-10-06 Thread Stefan Berger
Attached are the bash scripts and xml files for provoking the deadlock. With the new patch applied the deadlock does not occur anymore. Regards, Stefan chg-vm1-filter.sh Description: Bourne shell script chg-vm2-filter.sh Description: Bourne shell script dummy-vm1 32768 32

[libvirt] [PATCH] [RFC] nwfilter: resolve deadlock between VM operations and filter update

2010-10-06 Thread Stefan Berger
V2: remove the locks from qemudVMFilterRebuild & umlVMFilterRebuild This is from a bug report and conversation on IRC where Soren reported that while a filter update is occurring on one or more VMs (due to a rule having been edited for example), a deadlock can occur when a VM referencing a

Re: [libvirt] [PATCH] [RFC] nwfilter: resolve deadlock between VM operations and filter update

2010-10-06 Thread Stefan Berger
On 10/06/2010 12:27 PM, Stefan Berger wrote: distributed where it matters I can remove the qemu_driver and uml_driver lock from qemudVMFilterRebuild() and umlVMFilterRebuild() and not requiring the recursive locks. Uiui, the words are right, the code is not. I apologize. V2 coming shortly +

Re: [libvirt] [PATCH] document authentication with PolicyKit-1

2010-10-06 Thread Eric Blake
On 07/13/2010 04:33 AM, Gerd v. Egidy wrote: [looking through old mail] Hi, I just encountered the same problem with the newer PolicyKit as discussed e.g. in this thread: http://lists.fedoraproject.org/pipermail/virt/2010-June/002081.html I solved it and thought updating the documentation fo

Re: [libvirt] [PATCH] [DOCS] nwfilter: Add 2nd example to the html docs

2010-10-06 Thread Daniel Veillard
On Wed, Oct 06, 2010 at 02:56:44PM -0400, Stefan Berger wrote: > This patch adds another example to the nwfilter html page and > provides 2 solutions for how to write a filter meeting the given > requirements using newly added features. > > Signed-off-by: Stefan Berger Good :-) ACK, Daniel

Re: [libvirt] [PATCH] [DOCS] nwfilter: Add 2nd example to the html docs

2010-10-06 Thread Eric Blake
On 10/06/2010 12:56 PM, Stefan Berger wrote: + Second example custom filter + + In this example we now want to build a similar filter as in the + example above, but extend the list of requirements with an + ftp server located inside the VM. Further, we will be using features + that have been ad

[libvirt] [PATCH] [DOCS] nwfilter: Add 2nd example to the html docs

2010-10-06 Thread Stefan Berger
This patch adds another example to the nwfilter html page and provides 2 solutions for how to write a filter meeting the given requirements using newly added features. Signed-off-by: Stefan Berger --- docs/formatnwfilter.html.in | 180 +++- 1 file

[libvirt] Using -netdev with qemu/kvm rather than old style

2010-10-06 Thread Pete Ashdown
I have 0.8.3 installed and my net devices are still being defined via -net rather than -netdev. I have found that using the latter allows my ethernet to properly offload and gives a 35% performance gain. Looking through the libvirt code I find in qemu_conf.c: /* Possible combinations

Re: [libvirt] [patch 5/5] nwfilter: Extend docs with information about the comment attribute

2010-10-06 Thread Daniel Veillard
On Wed, Oct 06, 2010 at 01:25:35PM -0400, Stefan Berger wrote: > Daniel Veillard wrote on 10/06/2010 12:02:39 PM: > > > > > Please respond to veillard > > > > On Fri, Oct 01, 2010 at 08:28:54PM -0400, Stefan Berger wrote: > > > I am adding a row with information about the newly supported state

Re: [libvirt] [patch 4/5] nwfilter: Extend schema to accept state attribute

2010-10-06 Thread Daniel Veillard
On Wed, Oct 06, 2010 at 01:18:47PM -0400, Stefan Berger wrote: > Daniel Veillard wrote on 10/06/2010 12:00:04 PM: > > > Re: [libvirt] [patch 4/5] nwfilter: Extend schema to accept state > attribute > > > > On Fri, Oct 01, 2010 at 08:28:53PM -0400, Stefan Berger wrote: > > > Extend the nwfilter.

Re: [libvirt] [patch 4/5] nwfilter: Extend schema to accept state attribute

2010-10-06 Thread Eric Blake
On 10/06/2010 11:18 AM, Stefan Berger wrote: Hum, we really want to accept something like NEW,NEW,NEW,NEW ? I understand that we may want to add RELATED to another state, but that regexp could probably be refined, isn't it ? I think the proposed solution is not as 'strict' as it should be

Re: [libvirt] [patch 5/5] nwfilter: Extend docs with information about the comment attribute

2010-10-06 Thread Stefan Berger
Daniel Veillard wrote on 10/06/2010 12:02:39 PM: > > Please respond to veillard > > On Fri, Oct 01, 2010 at 08:28:54PM -0400, Stefan Berger wrote: > > I am adding a row with information about the newly supported state > > attribute to each of the tables describing supported attributes ofprotoc

Re: [libvirt] [patch 4/5] nwfilter: Extend schema to accept state attribute

2010-10-06 Thread Stefan Berger
Daniel Veillard wrote on 10/06/2010 12:00:04 PM: > Re: [libvirt] [patch 4/5] nwfilter: Extend schema to accept state attribute > > On Fri, Oct 01, 2010 at 08:28:53PM -0400, Stefan Berger wrote: > > Extend the nwfilter.rng schema to accept state attributes. > > > > Signed-off-by: Stefan Berger

Re: [libvirt] [PATCH] Added new attribute exportfs_type to filesystem element

2010-10-06 Thread Daniel P. Berrange
On Wed, Oct 06, 2010 at 06:22:29PM +0200, Daniel Veillard wrote: > On Thu, Sep 30, 2010 at 10:30:10PM +0530, Harsh Prateek Bora wrote: > > This patch introduces a new attribute export_fs to the filesystem > > element which specifies the type of export. Currently only 'local' > > type of exported fi

[libvirt] [PATCH] [RFC] nwfilter: resolve deadlock between VM operations and filter update

2010-10-06 Thread Stefan Berger
This is from a bug report and conversation on IRC where Soren reported that while a filter update is occurring on one or more VMs (due to a rule having been edited for example), a deadlock can occur when a VM referencing a filter is started. The problem is caused by the two locking sequences

Re: [libvirt] indentation (was: [PATCH 11/12] vcpu: complete vcpu support in qemu driver)

2010-10-06 Thread Daniel Veillard
On Fri, Oct 01, 2010 at 02:21:05PM -0600, Eric Blake wrote: > On 10/01/2010 09:31 AM, Daniel Veillard wrote: > >>-ret = qemudDomainHotplugVcpus(vm, nvcpus); > >>+switch (flags) { > >>+case VIR_DOMAIN_VCPU_MAXIMUM | VIR_DOMAIN_VCPU_PERSISTENT: > > > > hum I usually indent the cases 4 sp

Re: [libvirt] [PATCH] Added new attribute exportfs_type to filesystem element

2010-10-06 Thread Daniel Veillard
On Thu, Sep 30, 2010 at 10:30:10PM +0530, Harsh Prateek Bora wrote: > This patch introduces a new attribute export_fs to the filesystem > element which specifies the type of export. Currently only 'local' > type of exported filesystem is supported. More types like NFS, clusterFS, etc. > can be adde

Re: [libvirt] [patch 4/5] nwfilter: Extend schema to accept state attribute

2010-10-06 Thread Daniel Veillard
On Fri, Oct 01, 2010 at 08:28:53PM -0400, Stefan Berger wrote: > Extend the nwfilter.rng schema to accept state attributes. > > Signed-off-by: Stefan Berger [...] > + > + > + > + name="pattern">((NEW|ESTABLISHED|RELATED|INVALID)(,(NEW|ESTABLISHED|RELATED|INVALID))*|NONE) > + > +

Re: [libvirt] [patch 5/5] nwfilter: Extend docs with information about the comment attribute

2010-10-06 Thread Daniel Veillard
On Fri, Oct 01, 2010 at 08:28:54PM -0400, Stefan Berger wrote: > I am adding a row with information about the newly supported state > attribute to each of the tables describing supported attributes of protocols. > > Signed-off-by: Stefan Berger > > --- > docs/formatnwfilter.html.in | 30 +

Re: [libvirt] [patch 3/5] nwfilter: Add test case for testing the state attribute

2010-10-06 Thread Daniel Veillard
On Fri, Oct 01, 2010 at 08:28:52PM -0400, Stefan Berger wrote: > This patch adds a test case for testing the XML parser's and instantiator's > support of the state attribute. The other test case tests existing > capabilities. Both test cases will be used in TCK again. > > Signed-off-by: Stefan Ber

Re: [libvirt] [patch 2/5] nwfilter: Instantiate state match in ip(6)tables rules

2010-10-06 Thread Daniel Veillard
On Fri, Oct 01, 2010 at 08:28:51PM -0400, Stefan Berger wrote: > In this patch I am extending the rule instantiator to create the state > match according to the state attribute in the XML. Only one iptables > rule in the incoming or outgoing direction will be created for a rule > in direction 'in'

Re: [libvirt] [patch 1/5] nwfilter: Extend XML parser and generator to support state attribute

2010-10-06 Thread Daniel Veillard
On Fri, Oct 01, 2010 at 08:28:50PM -0400, Stefan Berger wrote: > The patch below extends the XML parser and generator so that every l3 protocol > now can have a state attribute. > > Signed-off-by: Stefan Berger Hum, I don't see that much parsing in there, certainly some XML formatter but the

Re: [libvirt] bug: network lock-out

2010-10-06 Thread Laine Stump
On 10/05/2010 03:53 PM, Zdenek Styblik wrote: I've removed dnsmasq because it was giving away IP addresses, although DHCP has not been defined in XML. I've mentioned this some time ago in an e-mail with poetic subj: "dnsmasq, dhcp - bug or feature" :) I tried changing my default network to rem

Re: [libvirt] [PATCH 4/4] xen: Fix virDomain{At,De}tachDevice

2010-10-06 Thread Eric Blake
On 10/01/2010 02:09 PM, Jiri Denemark wrote: According to API documentation virDomain{At,De}tachDevice calls are supposed to only work on active guests for device hotplug. For anything beyond that, their *Flags variants have to be used. Despite the variant which was acked on libvirt mailing list

Re: [libvirt] [PATCH 3/4] xen: xenXMDomain*DeviceFlags should obey all flags

2010-10-06 Thread Eric Blake
On 10/01/2010 02:09 PM, Jiri Denemark wrote: xenXMDomain*DeviceFlags() silently ignores requests to modify live configuration of an active guest while still touching its persistent configuration. --- src/xen/xm_internal.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCH 2/4] xen: Fix logic bug in xenDaemon*DeviceFlags

2010-10-06 Thread Eric Blake
On 10/04/2010 06:01 AM, Jiri Denemark wrote: It seems like we need a 12-way table (in fact, this is pretty much what I ended up resorting to with my vcpus stuff). Here's my shot at it, from reading the comments (but not actually testing it); once we fix this attempt to an actual table, then I ca

Re: [libvirt] [PATCH 1/4] xen: Make xenDaemon*DeviceFlags errors less confusing

2010-10-06 Thread Eric Blake
On 10/04/2010 05:47 AM, Jiri Denemark wrote: Should we always error out if _LIVE and inactive, or should we special-case _CONFIG|_LIVE by silently ignoring the _LIVE flag on inactive domains? Since there is the _CURRENT variant of the flag, erroring out if _LIVE and inactive seems like the rig

Re: [libvirt] [PATCH] xen: Fix bogus error when attaching a device

2010-10-06 Thread Daniel P. Berrange
On Tue, Oct 05, 2010 at 09:48:24AM -0400, Laine Stump wrote: > > >The xm internal xen driver only supports disk and network devices to be > >added to a guest. On an attempt to attach any other device the xm driver > >used VIR_ERR_XML_ERROR which resulted in a completely bogus error > >message: > >

Re: [libvirt] [TCK][PATCH] nwfilter: implement support for --force flag

2010-10-06 Thread Daniel P. Berrange
On Mon, Oct 04, 2010 at 09:41:50AM -0400, Stefan Berger wrote: > Implement support for the --force command line option to delete > existing VMs and nwfilters starting with 'tck'. Fix how the --no-attach > flag is handled. > > Signed-off-by: Stefan Berger > > diff --git a/scripts/nwfilter/nwfi

Re: [libvirt] The last two remaining "out of the box" build failures for OS X

2010-10-06 Thread Justin Clift
On 10/06/2010 10:55 PM, Daniel P. Berrange wrote: These ones should be fixable/fixed. Daniel Thanks. It'll have to be done at some point in the future though, as I've kind of moved on. :) -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] The last two remaining "out of the box" build failures for OS X

2010-10-06 Thread Daniel P. Berrange
On Wed, Sep 29, 2010 at 11:04:45PM +1000, Justin Clift wrote: > Hi all, > > On the home straight getting libvirt to work "out of the box" on MacOS > X. (ideal scenario: it's "good enough" today. :>) > > With the very latest git snapshot, to get a working compile requires > these options to be u

Re: [libvirt] [libvirt-tck] [RFC] 802.1Qbg test scripts

2010-10-06 Thread Daniel P. Berrange
On Wed, Sep 29, 2010 at 11:25:31AM +0200, Gerhard Stenzel wrote: > Hi Daniel, > I am currently looking into TCK test cases to verify setting 802.1Qbg > functionality from libvirt. My current approach requires changes to some > library functions in lib/Sys/Virt/TCK/. > I would appreciate your feedba