?Hi,
I'm current renaming C# binding classes as Eric suggest. And I have a little
problem with the naming of the virGetVersion and virInitialize, I think
put them in a class named virLibrary but I don't know if it is a good
idea.
Arnaud
--
Hi Matthias,
in fact, it seems that custom marshaling is not the solution. The reason is
that .net (or Mono) doesn't allow the custom marshaling of a struct member.
There one way that I haven't explore : create a custom marshaler for the
structure and manage struct member in the custom
Okay, it's a good idea, I'm going for it
--
From: Daniel P. Berrange berra...@redhat.com
Sent: Tuesday, October 19, 2010 6:15 PM
To: Matthias Bolte matthias.bo...@googlemail.com
Cc: arnaud.champ...@devatom.fr; libvir-list@redhat.com
Subject: Re:
The problem with DllMap, is that it works only under Mono, not under .Net
:(
--
From: Matthias Bolte matthias.bo...@googlemail.com
Sent: Tuesday, October 19, 2010 6:38 PM
To: arnaud.champ...@devatom.fr
Cc: libvir-list@redhat.com
Subject: Re:
On Tue, Oct 19, 2010 at 12:04:27PM -0400, John Morrissey wrote:
On Tue, Oct 19, 2010 at 05:45:42PM +0200, Daniel Veillard wrote:
Patch looks fine but I didn't applied it yet because make check
raises an error now:
D'oh, I nearly beat you to noticing. :-) I was just building some
2010/10/20 Nikunj A. Dadhania nik...@linux.vnet.ibm.com:
On Tue, 19 Oct 2010 15:49:05 +0200, Daniel Veillard veill...@redhat.com
wrote:
On Tue, Oct 19, 2010 at 03:00:21PM +0200, Matthias Bolte wrote:
2010/10/18 Nikunj A. Dadhania nik...@linux.vnet.ibm.com:
[...]
tools/virsh.c: Add new
2010/10/19 Eric Blake ebl...@redhat.com:
On 10/19/2010 11:06 AM, Matthias Bolte wrote:
---
I pushed this under the trivial complie error fix rule :)
Thanks.
@@ -80,7 +80,7 @@ void virAuditSend(const char *file ATTRIBUTE_UNUSED,
const char *func, size_t li
void virAuditSend(const char
On Tue, Oct 19, 2010 at 07:06:05PM +0200, Matthias Bolte wrote:
---
I pushed this under the trivial complie error fix rule :)
Matthias
daemon/remote.c |4 ++--
src/util/virtaudit.c |4 ++--
src/util/virtaudit.h |2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
?I have also a problem about virError. I plan to make a class virError to
handle all error related methods, the problem : a struct virError already
exists and I don't want to mix things :S
--
From: arnaud.champ...@devatom.fr
Sent: Wednesday,
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com
include/libvirt/libvirt.h.in: Update comment with actual description
Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com
---
include/libvirt/libvirt.h.in | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git
On Wed, Oct 20, 2010 at 02:56:16PM +0530, Nikunj A. Dadhania wrote:
From: Nikunj A. Dadhania nik...@linux.vnet.ibm.com
include/libvirt/libvirt.h.in: Update comment with actual description
Signed-off-by: Nikunj A. Dadhania nik...@linux.vnet.ibm.com
---
include/libvirt/libvirt.h.in | 12
2010/10/19 Eric Blake ebl...@redhat.com:
On 10/19/2010 12:34 PM, Matthias Bolte wrote:
---
tests/daemon-conf | 4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tests/daemon-conf b/tests/daemon-conf
index 0e756d4..921e589 100755
--- a/tests/daemon-conf
+++
2010/10/20 arnaud.champ...@devatom.fr:
The problem with DllMap, is that it works only under Mono, not under .Net :(
Well, no problem three. You keep the [DllImport(libvirt-0.dll)] in
the code for .Net, so it works for .Net and add a DllMap that tells
Mono that it should use libvirt.so.0 on
Impeccable ;)
--
From: Matthias Bolte matthias.bo...@googlemail.com
Sent: Wednesday, October 20, 2010 12:12 PM
To: arnaud.champ...@devatom.fr
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH] Change/create solution and project for Visual
Well it works fine, DllMap make the trick.
--
From: arnaud.champ...@devatom.fr
Sent: Wednesday, October 20, 2010 12:13 PM
To: Matthias Bolte matthias.bo...@googlemail.com
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH] Change/create
On 10/20/2010 03:41 AM, Matthias Bolte wrote:
2010/10/19 Eric Blakeebl...@redhat.com:
On 10/19/2010 12:34 PM, Matthias Bolte wrote:
---
tests/daemon-conf |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tests/daemon-conf b/tests/daemon-conf
index 0e756d4..921e589
On Wed, Oct 20, 2010 at 01:44:56PM +0200, arnaud.champ...@devatom.fr wrote:
?Hi,
here is a new patch. It propose to separate types of function by classes. For
example :
all virConnect[*] (virConnectOpen, virConnectNumOfDomains, etc...) functions
are in the virConnect class.
all
Also output the min_guarantee element when set.
---
src/conf/domain_conf.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index a997e06..6486f9c 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@
To get them under the common VIR_DOMAIN_MEMORY_* prefix.
---
include/libvirt/libvirt.h.in |4 ++--
src/lxc/lxc_driver.c |4 ++--
src/qemu/qemu_driver.c |4 ++--
tools/virsh.c|6 +++---
4 files changed, 9 insertions(+), 9 deletions(-)
diff --git
On Wed, Oct 20, 2010 at 02:07:45PM +0200, arnaud.champ...@devatom.fr wrote:
?Okay, I'll make the change... Currently at naming level, my problem is
around Error class. Do you have a suggestion ?
What's wrong with following the example I gave, eg
namespace Libvirt [
public class Error {
2010/10/20 Eric Blake ebl...@redhat.com:
On 10/20/2010 03:41 AM, Matthias Bolte wrote:
2010/10/19 Eric Blakeebl...@redhat.com:
On 10/19/2010 12:34 PM, Matthias Bolte wrote:
---
tests/daemon-conf | 4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git
Also exit early when nparams is 0.
---
tools/virsh.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/tools/virsh.c b/tools/virsh.c
index d1ef698..3e37b06 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -2941,17 +2941,22 @@ cmdMemtune(vshControl * ctl, const
?I just found Error too large for the person who will use C# bindings :S
but... I can use Error, technically no problem.
PS : I don't know exactly the english word, by too large I just want to
avoid confusion
--
From: Daniel P. Berrange
There is no point in trying to fill params beyond the first error,
because when qemuDomainGetMemoryParameters returns -1 then the caller
cannot detect which values in params are valid.
---
There is a similar pattern in qemuDomainSetMemoryParameters that tries
to apply all given params even if one
?virStream will expose problems also, as Stream is also a class in .Net
framework
--
From: arnaud.champ...@devatom.fr
Sent: Wednesday, October 20, 2010 2:26 PM
To: Daniel P. Berrange berra...@redhat.com
Cc: libvir-list@redhat.com
Subject: Re:
On Wed, Oct 20, 2010 at 02:56:37PM +0200, arnaud.champ...@devatom.fr wrote:
?virStream will expose problems also, as Stream is also a class in .Net
framework
Why is that any problem ? Namespaces exist precisely to solve this problem.
You only need name uniqueness within the namespace.
?You're are right. I just reference my own experience. Anyway, I'm putting
Stream.
--
From: Daniel P. Berrange berra...@redhat.com
Sent: Wednesday, October 20, 2010 2:59 PM
To: arnaud.champ...@devatom.fr
Cc: libvir-list@redhat.com
Subject: Re:
Dne 19.10.2010 20:07, Matthias Bolte napsal(a):
2010/10/19 Radek Hladikra...@eadresa.cz:
Dne 19.10.2010 17:32, Matthias Bolte napsal(a):
2010/10/19 Radek Hladikra...@eadresa.cz:
Hello,
I did find out that in some cases virConnectClose does not close
the
connection at all. It only
On Wed, Oct 20, 2010 at 02:09:25PM +0200, Matthias Bolte wrote:
To get them under the common VIR_DOMAIN_MEMORY_* prefix.
---
include/libvirt/libvirt.h.in |4 ++--
src/lxc/lxc_driver.c |4 ++--
src/qemu/qemu_driver.c |4 ++--
tools/virsh.c|6
On Wed, Oct 20, 2010 at 02:26:18PM +0200, Matthias Bolte wrote:
Also exit early when nparams is 0.
---
tools/virsh.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
Okay, error message normalization sounds good too,
thanks !
Daniel
--
Daniel Veillard |
On Wed, Oct 20, 2010 at 02:03:09PM +0200, Matthias Bolte wrote:
Also output the min_guarantee element when set.
---
src/conf/domain_conf.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
ACK, one cleanup, and one bug fix,
thanks !
Daniel
--
Daniel Veillard |
On Wed, Oct 20, 2010 at 02:37:53PM +0200, Matthias Bolte wrote:
There is no point in trying to fill params beyond the first error,
because when qemuDomainGetMemoryParameters returns -1 then the caller
cannot detect which values in params are valid.
---
Okay ACK
There is a similar pattern
On 10/20/2010 11:05 PM, arnaud.champ...@devatom.fr wrote:
?Hi Justin,
I have written a little simple sample of using of C# bindings. In fact
it is a sample project which connect to a clear TCP libvirt/qemu via
virConnectOpen the list the storage pools. Here's the code :
Thanks.
I should
The test for vcpu element is unrelated to vnc so the easiest fix is to
remove related configuration.
---
tests/xmconfigdata/test-paravirt-vcpu.cfg |5 -
tests/xmconfigdata/test-paravirt-vcpu.xml |2 --
2 files changed, 0 insertions(+), 7 deletions(-)
diff --git
On 10/20/2010 08:16 AM, Jiri Denemark wrote:
The test forvcpu element is unrelated to vnc so the easiest fix is to
remove related configuration.
---
tests/xmconfigdata/test-paravirt-vcpu.cfg |5 -
tests/xmconfigdata/test-paravirt-vcpu.xml |2 --
2 files changed, 0 insertions(+),
The test forvcpu element is unrelated to vnc so the easiest fix is to
remove related configuration.
---
tests/xmconfigdata/test-paravirt-vcpu.cfg |5 -
tests/xmconfigdata/test-paravirt-vcpu.xml |2 --
2 files changed, 0 insertions(+), 7 deletions(-)
ACK. I was just
2010/10/19 arnaud.champ...@devatom.fr:
Hi,
here are 2 patches for C# libvirt bindings.
These patches create a new solution/project couple for Visual Studio 2010
with also a sample code and a solution/project couple for MonoDevelop with a
sample code also.
The sample code have been tested
2010/10/20 arnaud.champ...@devatom.fr:
Hi,
here is a new patch. It propose to separate types of function by classes.
For example :
all virConnect[*] (virConnectOpen, virConnectNumOfDomains, etc...) functions
are in the virConnect class.
all virDomain[*] (virDomainCreate, virDomainDestroy,
2010/10/20 arnaud.champ...@devatom.fr:
This patch rename file / classes from virConnect to Connect, virDomain to
Domain, etc...
Arnaud
I pushed this one too and did a patch remove trailing white spaces on top.
I tested the bindings by successfully compiling and using the
virConnectOpen
The QEMU 0.13 release is finally out and from testing in RHEL-6
we know that its JSON and netdev features are now good enough
for us to use by default.
* src/qemu/qemu_conf.c: Enable JSON + netdev for QEMU = 0.13
---
src/qemu/qemu_conf.c | 17 -
1 files changed, 8
Okay I'll take a look, is the transport in http ? (just to be curious, I
haven't been able to make it work in https)
--
From: Matthias Bolte matthias.bo...@googlemail.com
Sent: Wednesday, October 20, 2010 6:35 PM
To: arnaud.champ...@devatom.fr
The transport shouldn't make a difference. To make it work with HTTPS
you'll have to replace the self-signed certificates on the ESX server
or tell libvirt to disable server certificate checks using:
esx://192.168.0.17/?no_verify=1
Matthias
2010/10/20 arnaud.champ...@devatom.fr:
Okay I'll
On 10/20/2010 11:38 AM, Daniel P. Berrange wrote:
The QEMU 0.13 release is finally out and from testing in RHEL-6
we know that its JSON and netdev features are now good enough
for us to use by default.
* src/qemu/qemu_conf.c: Enable JSON + netdev for QEMU= 0.13
---
src/qemu/qemu_conf.c | 17
* src/libvirt_private.syms: Sort by header name, then within
header, and drop duplicate virNetworkDefParseNode,
virFileLinkPointsTo and virXPathBoolean.
---
Fixes the duplication first noted here, and hopefully makes the
file easier to maintain.
2010/10/20 Daniel Veillard veill...@redhat.com:
On Wed, Oct 20, 2010 at 02:09:25PM +0200, Matthias Bolte wrote:
To get them under the common VIR_DOMAIN_MEMORY_* prefix.
---
include/libvirt/libvirt.h.in | 4 ++--
src/lxc/lxc_driver.c | 4 ++--
src/qemu/qemu_driver.c |
2010/10/20 Daniel Veillard veill...@redhat.com:
On Wed, Oct 20, 2010 at 02:03:09PM +0200, Matthias Bolte wrote:
Also output the min_guarantee element when set.
---
src/conf/domain_conf.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
ACK, one cleanup, and one bug fix,
2010/10/20 Daniel Veillard veill...@redhat.com:
On Wed, Oct 20, 2010 at 02:37:53PM +0200, Matthias Bolte wrote:
There is no point in trying to fill params beyond the first error,
because when qemuDomainGetMemoryParameters returns -1 then the caller
cannot detect which values in params are
On 10/20/2010 03:14 AM, Matthias Bolte wrote:
Hmm - ATTRIBUTE_UNUSED is an indication that on some paths, the variable
might not be used; and not a requirement that it must not be used. Would
anyone object to this followup, for one less #ifdef?
diff --git i/src/util/virtaudit.c
* tools/virsh.c (opts_freecell, opts_memtune, opts_vcpupin)
(opts_setvcpus, opts_setmaxmem, opts_setmem)
(opts_migrate_setmaxdowntime): Use VSH_OT_INT when only an integer
is expected.
(vshCmddefHelp, vshCmddefGetData): Allow mandatory VSH_OT_INT
arguments.
---
changes in v2:
Update some
It's strange it works on my linux :S
--
From: Matthias Bolte matthias.bo...@googlemail.com
Sent: Wednesday, October 20, 2010 8:02 PM
To: arnaud.champ...@devatom.fr
Cc: libvir-list@redhat.com
Subject: Re: [libvirt] [PATCH] C# Bindings - rename
* tools/virsh.c (cmdMemtune): Use long long for memory
sizes. Simplify allocation, and plug memory leak.
---
No need to cripple virsh with a 32-bit limit.
Change from v1:
fix compilation failure, rebase on top of other recent memtune fixes
tools/virsh.c | 19 ---
1 files
It seems that the marshaling of the virConnectCredential structure failed,
but I only said that by view your debug traces. Can you say me which are the
environment of Mono (which version of Mono, which MonoDevelop, these kind of
things) ? because I have no idea about what's going wrong, I have
I'm testing on Ubuntu 10.04 with
mono 2.4.4~svn151842-1ubuntu4
monodevelop 2.2.1+dfsg-1ubuntu2
and libvirt and libvirt-csharp from git.
Matthias
2010/10/20 arnaud.champ...@devatom.fr:
It seems that the marshaling of the virConnectCredential structure failed,
but I only said that by view
On 06/10/2010 06:31 AM, Eric Blake wrote:
Followup to https://bugzilla.redhat.com/show_bug.cgi?id=599091,
commit 20206a4b, to reduce disk waste in padding.
* src/qemu/qemu_monitor.h (QEMU_MONITOR_MIGRATE_TO_FILE_BS): Drop
back to 512.
(QEMU_MONITOR_MIGRATE_TO_FILE_TRANSFER_SIZE): New macro.
*
54 matches
Mail list logo
