[libvirt] [PATCH] docs: removed old changelog file, as it is no longer relevant

2010-10-22 Thread Justin Clift
We instead point to the live git log URL for the few links still needing to point to something. --- docs/ChangeLog.awk | 49 - docs/ChangeLog.xsl | 37 - docs/Makefile.am | 13 +

[libvirt] [PATCH] docs: added a table of contents to the new c sharp bindings page

2010-10-22 Thread Justin Clift
--- docs/csharp.html.in | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/csharp.html.in b/docs/csharp.html.in index 3e15176..a32fbd2 100644 --- a/docs/csharp.html.in +++ b/docs/csharp.html.in @@ -3,7 +3,9 @@ body h1C# API bindings/h1 -

Re: [libvirt] [libvirt-tck 3/3] Add test case for daemon hook testing

2010-10-22 Thread Osier
updated, and patch attached. - Osier - Daniel P. Berrange berra...@redhat.com wrote: On Tue, Oct 19, 2010 at 03:41:55AM -0400, Osier wrote: attach updated patch for daemon hook testing.. replaced cat with slurp, corrected typos. From 963158c860d5415117e70b67458745c2b4cf9c13 Mon

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-22 Thread Justin Clift
On 10/22/2010 05:18 PM, Ruben Kerkhof wrote: snip I thought I'd give it a try, to see how far I get on Leopard (10.5). Hey Ruben, thanks for the attempt. :) Would you be ok to try a slightly updated version of the libvirt formula? If so, you just need to update the libvirt.rb formula file, to

Re: [libvirt] [libvirt-tck 3/3] Add test case for daemon hook testing

2010-10-22 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 02:32:20AM -0400, Osier wrote: updated, and patch attached. From 8d2a62528a7820939c4d7c86dd10cbf16ea5d751 Mon Sep 17 00:00:00 2001 From: Osier Yang jy...@redhat.com Date: Fri, 22 Oct 2010 14:40:13 +0800 Subject: [TCK] Skip daemon hook testing if URI is not

Re: [libvirt] [PATCH 05/11] Remove pointless nwIPAddress struct void *casts

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 02:02:44PM -0600, Eric Blake wrote: On 10/21/2010 12:17 PM, Daniel P. Berrange wrote: The nwIPAddress was simply a wrapper about virSocketAddr. Just use the latter directly, removing all the extra field de-references from code helper APIs for parsing/formatting.

Re: [libvirt] [PATCH 1/2] Add dtrace static probes in libvirtd

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 09:59:55PM +0200, Daniel Veillard wrote: On Thu, Oct 21, 2010 at 07:19:32PM +0100, Daniel P. Berrange wrote: Adds initial support for dtrace static probes in libvirtd daemon, assuming use of systemtap dtrace compat shim on Linux. The probes are inserted for network

Re: [libvirt] [PATCH] Convert virNetwork to use virSocketAddr everywhere

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 03:14:25PM -0600, Eric Blake wrote: On 10/21/2010 12:21 PM, Daniel P. Berrange wrote: Instead of storing the IP address string in virNetwork related structs, store the parsed virSocketAddr. This will make it easier to add IPv6 support in the future, by letting driver

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 09:52:51PM +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of PCs. Those blocks of data describe things like BIOS version informations, machine vendor, model and identifiers, as well as various parts of

Re: [libvirt] [PATCH] 1/4 SMBIOS XML format extension

2010-10-22 Thread Daniel Veillard
On Thu, Oct 21, 2010 at 03:35:37PM -0600, Eric Blake wrote: On 10/21/2010 02:13 PM, Daniel Veillard wrote: The suggested XML description follows the logical structure of the data, one top smbios description, with one or more blocks, each containing the entries, the example below gives an

Re: [libvirt] [PATCH] 2/4 Add conf parsing and freeing

2010-10-22 Thread Daniel Veillard
On Thu, Oct 21, 2010 at 03:45:40PM -0600, Eric Blake wrote: On 10/21/2010 02:16 PM, Daniel Veillard wrote: This lacks the saving of the smbios data, should not be hard really, and the parsing is rather trivial, the data structures follow the XML format: Daniel +static void

Re: [libvirt] [PATCH] 3/4 Add SMBIOS QEmu driver

2010-10-22 Thread Daniel Veillard
On Thu, Oct 21, 2010 at 03:58:50PM -0600, Eric Blake wrote: On 10/21/2010 02:23 PM, Daniel Veillard wrote: The main trouble here is that the QEmu command uses names which are similar to the official names for the entries used by the DMTF, but that mean we cant base on name equality. I was

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel Veillard
On Fri, Oct 22, 2010 at 09:28:48AM +0100, Daniel P. Berrange wrote: On Thu, Oct 21, 2010 at 09:52:51PM +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of PCs. Those blocks of data describe things like BIOS version

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 11:23:45AM +0200, Daniel Veillard wrote: On Fri, Oct 22, 2010 at 09:28:48AM +0100, Daniel P. Berrange wrote: On Thu, Oct 21, 2010 at 09:52:51PM +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of

[libvirt] [PATCH v2 1/2] support compressed crashdump of guests

2010-10-22 Thread KAMEZAWA Hiroyuki
Thank you for advices for v1. This version adss dump_image_format config for qemu.conf. 1/2 adds dump_image_format, 2/2 adds the check for availability of compression program for save_image_format and dump_image_format. == Add dump_image_format[] to qemu.conf and support compressed dump at virsh

[libvirt] [PATCH v2 2/2] check compression program is available at config

2010-10-22 Thread KAMEZAWA Hiroyuki
At compression, external programs are used but it is not checked whether the program is available or not. Check it at parsing qemu.conf and find problems in early stage. --- src/qemu/qemu_conf.c | 46 +++--- 1 file changed, 39 insertions(+), 7

[libvirt] [TCK] Add test case for domain hook testing.

2010-10-22 Thread Osier Yang
The test case will be valid only when the Sys::Virt::TCK connection object is qemu:///system or lxc:///, because currently libvirt only support hooks for QEMU and LXC domain. Also update scripts/hooks/051-daemon-hook.t, replace $hook-foo with $hook-foo(). --- lib/Sys/Virt/TCK/Hooks.pm |

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-22 Thread Ruben Kerkhof
On Fri, Oct 22, 2010 at 08:54, Justin Clift jcl...@redhat.com wrote: On 10/22/2010 05:18 PM, Ruben Kerkhof wrote: snip I thought I'd give it a try, to see how far I get on Leopard (10.5). Hey Ruben, thanks for the attempt. :) Would you be ok to try a slightly updated version of the libvirt

Re: [libvirt] [PATCH 00/11] Misc fixes and changes related to virSocket APIs

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 07:17:14PM +0100, Daniel P. Berrange wrote: In working on the DTrace patches I needed to be able to format a struct sockaddr into a string easily. The virSocketFormatAddr API was close to what I needed, but couldn't handle including the port number, nor UNIX domain

Re: [libvirt] [PATCH 2/2] Include socket address in client probe data

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 10:05:42PM +0200, Daniel Veillard wrote: On Thu, Oct 21, 2010 at 07:19:33PM +0100, Daniel P. Berrange wrote: It is useful to know where the client is connecting from, so include the socket address in probe data. * daemon/libvirtd.h: Use virSocketAddr for storing

Re: [libvirt] [PATCH v2] qemu: call drive_unplug in DetachPciDiskDevice

2010-10-22 Thread Daniel P. Berrange
On Thu, Oct 21, 2010 at 09:56:48PM -0500, Ryan Harper wrote: Currently libvirt doesn't confirm whether the guest has responded to the disk removal request. In some cases this can leave the guest with continued access to the device while the mgmt layer believes that it has been removed. With

Re: [libvirt] [PATCH] docs: removed old changelog file, as it is no longer relevant

2010-10-22 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 05:10:39PM +1100, Justin Clift wrote: We instead point to the live git log URL for the few links still needing to point to something. --- docs/ChangeLog.awk | 49 - docs/ChangeLog.xsl | 37

Re: [libvirt] [PATCH] docs: added a table of contents to the new c sharp bindings page

2010-10-22 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 05:30:53PM +1100, Justin Clift wrote: --- docs/csharp.html.in | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/csharp.html.in b/docs/csharp.html.in index 3e15176..a32fbd2 100644 --- a/docs/csharp.html.in +++

Re: [libvirt] [TCK] Add test case for domain hook testing.

2010-10-22 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 06:05:46AM +0800, Osier Yang wrote: The test case will be valid only when the Sys::Virt::TCK connection object is qemu:///system or lxc:///, because currently libvirt only support hooks for QEMU and LXC domain. Also update scripts/hooks/051-daemon-hook.t, replace

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 11:23:45AM +0200, Daniel Veillard wrote: On Fri, Oct 22, 2010 at 09:28:48AM +0100, Daniel P. Berrange wrote: On Thu, Oct 21, 2010 at 09:52:51PM +0200, Daniel Veillard wrote: The SMBIOS data are a standardized set of data structures available in the BIOS area of

[libvirt] [PATCH] vbox: Fix compile errors due to the virSocketAddr series

2010-10-22 Thread Matthias Bolte
--- src/vbox/vbox_tmpl.c | 116 +++--- 1 files changed, 100 insertions(+), 16 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 5a859a4..ddbca97 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -626,6 +626,45

Re: [libvirt] [PATCH] vbox: Fix compile errors due to the virSocketAddr series

2010-10-22 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 02:23:15PM +0200, Matthias Bolte wrote: --- src/vbox/vbox_tmpl.c | 116 +++--- 1 files changed, 100 insertions(+), 16 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 5a859a4..ddbca97 100644

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel Veillard
On Fri, Oct 22, 2010 at 01:16:16PM +0100, Daniel P. Berrange wrote: On Fri, Oct 22, 2010 at 11:23:45AM +0200, Daniel Veillard wrote: On Fri, Oct 22, 2010 at 09:28:48AM +0100, Daniel P. Berrange wrote: [...] I can't help thinking that we should define a set of general metadata tags, and

[libvirt] [PATCH] esx: Add documentation about certificates and connection problems

2010-10-22 Thread Matthias Bolte
--- docs/drvesx.html.in | 103 +- docs/remote.html.in |8 +++- 2 files changed, 107 insertions(+), 4 deletions(-) diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in index dfc91bb..a0f87c1 100644 --- a/docs/drvesx.html.in +++

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel Veillard
On Fri, Oct 22, 2010 at 01:09:30AM +0200, Matthias Bolte wrote: 2010/10/21 Daniel Veillard veill...@redhat.com: Okay, I looked at what can be done for ESX. Looking at the SMBIOS data from _inside_ a ESX guest using dmidecode I can get this smbios table type=0 entry

Re: [libvirt] [PATCH] esx: Add documentation about certificates and connection problems

2010-10-22 Thread Daniel Veillard
On Fri, Oct 22, 2010 at 03:04:43PM +0200, Matthias Bolte wrote: --- docs/drvesx.html.in | 103 +- docs/remote.html.in |8 +++- 2 files changed, 107 insertions(+), 4 deletions(-) diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel Veillard
On Fri, Oct 22, 2010 at 04:00:31PM +0200, Matthias Bolte wrote: 2010/10/22 Daniel Veillard veill...@redhat.com:  Okay, I looked up for VirtualBox, and apparently there is some support for editing some of the BIOS and system entries too based on this post  

[libvirt] [PATCH v3] qemu: call drive_unplug in DetachPciDiskDevice

2010-10-22 Thread Ryan Harper
Currently libvirt doesn't confirm whether the guest has responded to the disk removal request. In some cases this can leave the guest with continued access to the device while the mgmt layer believes that it has been removed. With a recent qemu monitor command[1] we can deterministically revoke

Re: [libvirt] [PATCH] docs: removed old changelog file, as it is no longer relevant

2010-10-22 Thread Justin Clift
On 10/22/2010 10:11 PM, Daniel P. Berrange wrote: On Fri, Oct 22, 2010 at 05:10:39PM +1100, Justin Clift wrote: We instead point to the live git log URL for the few links still needing to point to something. snip ACK Thanks Daniel, pushed. -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] docs: added a table of contents to the new c sharp bindings page

2010-10-22 Thread Justin Clift
On 10/22/2010 10:11 PM, Daniel P. Berrange wrote: On Fri, Oct 22, 2010 at 05:30:53PM +1100, Justin Clift wrote: --- docs/csharp.html.in | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/docs/csharp.html.in b/docs/csharp.html.in index

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-22 Thread Mitchell Hashimoto
On Thu, Oct 21, 2010 at 11:18 PM, Ruben Kerkhof ru...@rubenkerkhof.com wrote: I thought I'd give it a try, to see how far I get on Leopard (10.5). From what I know following this list, I don't think anyone has ever tried to compile for Leopard (10.5) and has focussed exclusively on Snow

Re: [libvirt] [PATCH] Convert virNetwork to use virSocketAddr everywhere

2010-10-22 Thread Eric Blake
On 10/21/2010 03:14 PM, Eric Blake wrote: +++ b/src/util/dnsmasq.c @@ -76,23 +76,28 @@ hostsfileFree(dnsmasqHostsfile *hostsfile) static int hostsfileAdd(dnsmasqHostsfile *hostsfile, const char *mac, - const char *ip, + virSocketAddr *ip, const char *name) { + char *ipstr; if

Re: [libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-22 Thread Eric Blake
On 10/22/2010 05:19 AM, Stefan Berger wrote: Using automated replacement with sed and editing I have now replaced all occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of course. Some replacements were straight forward, others I needed to pay attention. I hope I payed attention in

[libvirt] [PATCH] [TCK] Forgot to copy *.fwall.dat file

2010-10-22 Thread Stefan Berger
Move to the format Eric suggested and copy the missing .fwall.dat file. Signed-off-by: Stefan Berger stef...@us.ibm.com diff --git a/Build.PL b/Build.PL index 2a4de43..97b4140 100644 --- a/Build.PL +++ b/Build.PL @@ -29,7 +29,7 @@ sub process_pkgdata_files { my $name =

[libvirt] [PATCH] tests: Silence qemuxml2argv test

2010-10-22 Thread Jiri Denemark
--- tests/qemuxml2argvtest.c | 240 +- 1 files changed, 132 insertions(+), 108 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 551d6c4..4eb3cc6 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Matthias Bolte
2010/10/22 Daniel Veillard veill...@redhat.com: On Fri, Oct 22, 2010 at 04:00:31PM +0200, Matthias Bolte wrote: 2010/10/22 Daniel Veillard veill...@redhat.com:  Okay, I looked up for VirtualBox, and apparently there is some support for editing some of the BIOS and system entries too based on

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Matthias Bolte
2010/10/22 Matthias Bolte matthias.bo...@googlemail.com: 2010/10/22 Daniel Veillard veill...@redhat.com: On Fri, Oct 22, 2010 at 04:00:31PM +0200, Matthias Bolte wrote: 2010/10/22 Daniel Veillard veill...@redhat.com:  Okay, I looked up for VirtualBox, and apparently there is some support

Re: [libvirt] [PATCH] [TCK] Forgot to copy *.fwall.dat file

2010-10-22 Thread Eric Blake
On 10/22/2010 11:00 AM, Stefan Berger wrote: Move to the format Eric suggested and copy the missing .fwall.dat file. Signed-off-by: Stefan Berger stef...@us.ibm.com diff --git a/Build.PL b/Build.PL index 2a4de43..97b4140 100644 --- a/Build.PL +++ b/Build.PL @@ -29,7 +29,7 @@ sub

Re: [libvirt] [PATCH] tests: Silence qemuxml2argv test

2010-10-22 Thread Eric Blake
On 10/22/2010 11:02 AM, Jiri Denemark wrote: --- tests/qemuxml2argvtest.c | 240 +- 1 files changed, 132 insertions(+), 108 deletions(-) ACK, and thanks for getting to this. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

Re: [libvirt] [PATCH] tests: Silence qemuxml2argv test

2010-10-22 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 10/22/2010 01:02:15 PM: --- tests/qemuxml2argvtest.c | 240 +- 1 files changed, 132 insertions(+), 108 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index

[libvirt] [PATCH] maint: ignore new test executable

2010-10-22 Thread Eric Blake
* tests/.gitignore: Sort, and add sockettest. --- Pushing under the trivial rule, so that I don't accidentally add a binary when I do 'git add .'. tests/.gitignore | 47 +++ 1 files changed, 23 insertions(+), 24 deletions(-) diff --git

Re: [libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-22 Thread Eric Blake
On 10/22/2010 05:19 AM, Stefan Berger wrote: Using automated replacement with sed and editing I have now replaced all occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of course. Some replacements were straight forward, others I needed to pay attention. I hope I payed attention in

Re: [libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-22 Thread Eric Blake
On 10/22/2010 05:19 AM, Stefan Berger wrote: Using automated replacement with sed and editing I have now replaced all occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of course. Some replacements were straight forward, others I needed to pay attention. I hope I payed attention in

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-22 Thread Ruben Kerkhof
On Fri, Oct 22, 2010 at 18:19, Mitchell Hashimoto mitchell.hashim...@gmail.com wrote: On Thu, Oct 21, 2010 at 11:18 PM, Ruben Kerkhof ru...@rubenkerkhof.com wrote: I thought I'd give it a try, to see how far I get on Leopard (10.5). From what I know following this list, I don't think

Re: [libvirt] [PATCH] tests: Silence qemuxml2argv test

2010-10-22 Thread Jiri Denemark
tests/qemuxml2argvtest.c | 240 +- 1 files changed, 132 insertions(+), 108 deletions(-) ACK, and thanks for getting to this. I pushed this patch, thanks. Jirka -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] [TCK] Forgot to copy *.fwall.dat file

2010-10-22 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 10/22/2010 01:21:21 PM: [image removed] Re: [libvirt] [PATCH] [TCK] Forgot to copy *.fwall.dat file Eric Blake to: Stefan Berger 10/22/2010 01:31 PM Sent by: libvir-list-boun...@redhat.com Cc: libvir-list On 10/22/2010 11:00

Re: [libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-22 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 10/22/2010 02:24:38 PM: On 10/22/2010 05:19 AM, Stefan Berger wrote: Using automated replacement with sed and editing I have now replaced all occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of course. Some replacements were straight

Re: [libvirt] [PATCH] vbox: Stop hardcoding a single path for VBoxXPCOMC.so

2010-10-22 Thread Eric Blake
On 10/22/2010 01:44 PM, Matthias Bolte wrote: This partly reverts df90ca7661b0a789bd790ccf8258a4527c13eb8d. Don't disable the VirtualBox driver when configure can't find VBoxXPCOMC.so, rely on detection at runtime again instead. Keep --with-vbox=/path/to/virtualbox intact, added to for:

Re: [libvirt] [PATCH] 0/4 Add SMBIOS settings to domain definition

2010-10-22 Thread Daniel Veillard
On Fri, Oct 22, 2010 at 07:15:43PM +0200, Matthias Bolte wrote: 2010/10/22 Matthias Bolte matthias.bo...@googlemail.com: 2010/10/22 Daniel Veillard veill...@redhat.com: On Fri, Oct 22, 2010 at 04:00:31PM +0200, Matthias Bolte wrote: 2010/10/22 Daniel Veillard veill...@redhat.com:  Okay,

Re: [libvirt] [PATCH] esx: Add documentation about certificates and connection problems

2010-10-22 Thread Matthias Bolte
2010/10/22 Daniel Veillard veill...@redhat.com: On Fri, Oct 22, 2010 at 03:04:43PM +0200, Matthias Bolte wrote: ---  docs/drvesx.html.in |  103 +-  docs/remote.html.in |    8 +++-  2 files changed, 107 insertions(+), 4 deletions(-) diff

[libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Justin Clift
This 1-liner was actually written by Eric Blake, over IRC. It addresses a compilation failure in make dist and make rpm for systems without the dtrace/systemtap development libraries installed. --- daemon/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Eric Blake
On 10/22/2010 02:57 PM, Justin Clift wrote: This 1-liner was actually written by Eric Blake, over IRC. It addresses a compilation failure in make dist and make rpm for systems without the dtrace/systemtap development libraries installed. --- daemon/Makefile.am |2 +- 1 files changed, 1

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Justin Clift
On 10/23/2010 08:05 AM, Eric Blake wrote: snip if WITH_DTRACE libvirtd_LDADD += probes.o -libvirtd_SOURCES += probes.h +libvirtd_nodist_SOURCES = probes.h Given your testing of my one-liner IRC comment: ACK. Thanks. Pushed. :) -- libvir-list mailing list libvir-list@redhat.com

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Eric Blake
On 10/22/2010 03:05 PM, Eric Blake wrote: On 10/22/2010 02:57 PM, Justin Clift wrote: This 1-liner was actually written by Eric Blake, over IRC. It addresses a compilation failure in make dist and make rpm for systems without the dtrace/systemtap development libraries installed. ---

Re: [libvirt] [PATCH] daemon: exclude requirement for probes.h on systems without systemtap

2010-10-22 Thread Justin Clift
On 10/23/2010 08:52 AM, Eric Blake wrote: snip Given your testing of my one-liner IRC comment: ACK. Actually, the automake manual says this needs to be nodist_libvirtd_SOURCES (sorry I didn't check the manual before ACK'ing; and I'm assuming you tested without dtrace). Just pushed the

Re: [libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-22 Thread Eric Blake
On 10/22/2010 05:19 AM, Stefan Berger wrote: Using automated replacement with sed and editing I have now replaced all occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of course. Some replacements were straight forward, others I needed to pay attention. I hope I payed attention in

[libvirt] [PATCH] configure: adds an option for not using the readline library

2010-10-22 Thread Justin Clift
So we can use --with-readline=no for situations where that helpful. ie. MacOS X 10.5. By default, we use --with-readline=check. --- configure.ac | 47 --- 1 files changed, 28 insertions(+), 19 deletions(-) diff --git a/configure.ac b/configure.ac

[libvirt] [PATCH] Fix build for SystemTap 1.0

2010-10-22 Thread Matthias Bolte
With SystemTap 1.0 a part of the generated macros in probes.h expands to: volatile __typeof__(((name))) arg2 = (name); GCC reports an 'invalid initialize' error when name has type char[]. Therfore, add casts to char* to avoid this. --- daemon/libvirtd.c |4 ++-- daemon/remote.c |4

Re: [libvirt] [PATCH] Fix build for SystemTap 1.0

2010-10-22 Thread Eric Blake
On 10/22/2010 05:08 PM, Matthias Bolte wrote: With SystemTap 1.0 a part of the generated macros in probes.h expands to: volatile __typeof__(((name))) arg2 = (name); GCC reports an 'invalid initialize' error when name has type char[]. Therfore, add casts to char* to avoid this. ---

Re: [libvirt] [PATCH] Fix build for SystemTap 1.0

2010-10-22 Thread Justin Clift
On 10/23/2010 10:08 AM, Matthias Bolte wrote: With SystemTap 1.0 a part of the generated macros in probes.h expands to: ACK, compiles fine here on Fedora 13 x86_64, when using --with-dtrace and having systemtap-sdt-devel installed. (1.3-2) -- libvir-list mailing list libvir-list@redhat.com

[libvirt] [PATCH] qemu: work around dash 0.5.5 bug in managed save

2010-10-22 Thread Eric Blake
* configure.ac (VIR_WRAPPER_SHELL): Define to a replacement shell, if /bin/sh is broken on redirection. * src/qemu/qemu_monitor.h (VIR_WRAPPER_SHELL_PREFIX) (VIR_WRAPPER_SHELL_SUFFIX): New macros. * src/qemu/qemu_monitor_text.c (qemuMonitorTextMigrateToFile): Use them. *

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-22 Thread Justin Clift
On 10/23/2010 06:06 AM, Ruben Kerkhof wrote: snip It's getting a bit further, the logs are at http://fpaste.org/DC3R/ It seems to have some problems with libxml2. Daniel, any idea what would cause this libxml2 failure? GEN virt-pki-validate GEN virt-xml-validate.1 GEN

[libvirt] [PATCH] [TCK] network: create networks and check for exected results

2010-10-22 Thread Stefan Berger
Derived from the nwfilter test program, this one works with libvirt's networks. It creates networks from provided xml files and checks for expected configuration in iptables, running processes and virsh output using provided data files with commands to execute and the expected results for after

Re: [libvirt] [PATCH] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-22 Thread Stefan Berger
libvir-list-boun...@redhat.com wrote on 10/22/2010 06:27:30 PM: libvir-list On 10/22/2010 05:19 AM, Stefan Berger wrote: Using automated replacement with sed and editing I have now replaced all occurrences of close() with VIR_(FORCE_)CLOSE() except for one, of course. Some