Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-25 Thread Ruben Kerkhof
On Mon, Oct 25, 2010 at 07:09, Justin Clift jcl...@redhat.com wrote: On 10/25/2010 12:18 PM, Ruben Kerkhof wrote: On Sun, Oct 24, 2010 at 02:46, Justin Clift jcl...@redhat.com wrote: On 10/24/2010 09:33 AM, Ruben Kerkhof wrote: snip None at all, actually. I just started libvirtd on my local

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-25 Thread Ruben Kerkhof
On Mon, Oct 25, 2010 at 10:20, Ruben Kerkhof ru...@rubenkerkhof.com wrote: On Mon, Oct 25, 2010 at 07:09, Justin Clift jcl...@redhat.com wrote: On 10/25/2010 12:18 PM, Ruben Kerkhof wrote: On Sun, Oct 24, 2010 at 02:46, Justin Clift jcl...@redhat.com wrote: On 10/24/2010 09:33 AM, Ruben

Re: [libvirt] [PATCH] configure: adds an option for not using the readline library

2010-10-25 Thread Ruben Kerkhof
On Mon, Oct 25, 2010 at 07:00, Justin Clift jcl...@redhat.com wrote: On 10/25/2010 10:58 AM, Ruben Kerkhof wrote: snip I think this patch is still useful for users not using homebrew. I'm trying to do a (debug) build of libvirt from  a tarball outside of homebrew. In this case the (keg only)

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-25 Thread Daniel P. Berrange
On Mon, Oct 25, 2010 at 10:37:36AM +0200, Ruben Kerkhof wrote: On Mon, Oct 25, 2010 at 10:20, Ruben Kerkhof ru...@rubenkerkhof.com wrote: On Mon, Oct 25, 2010 at 07:09, Justin Clift jcl...@redhat.com wrote: On 10/25/2010 12:18 PM, Ruben Kerkhof wrote: On Sun, Oct 24, 2010 at 02:46, Justin

Re: [libvirt] [libvirt-tck 1/3] Correct typos in documents

2010-10-25 Thread Daniel Veillard
On Mon, Oct 18, 2010 at 05:45:12PM +0100, Daniel P. Berrange wrote: On Mon, Oct 18, 2010 at 07:18:07AM +0800, Osier Yang wrote: * docs/intro.pod * docs/writing-tests.pod --- docs/intro.pod | 10 +- docs/writing-tests.pod |8 2 files changed, 9

Re: [libvirt] [TCK] Add test case for domain hook testing.

2010-10-25 Thread Daniel Veillard
On Fri, Oct 22, 2010 at 06:05:46AM +0800, Osier Yang wrote: The test case will be valid only when the Sys::Virt::TCK connection object is qemu:///system or lxc:///, because currently libvirt only support hooks for QEMU and LXC domain. Also update scripts/hooks/051-daemon-hook.t, replace

Re: [libvirt] [libvirt-tck 1/3] Correct typos in documents

2010-10-25 Thread Osier
Thanks a lot :-) - Osier - Daniel Veillard veill...@redhat.com wrote: On Mon, Oct 18, 2010 at 05:45:12PM +0100, Daniel P. Berrange wrote: On Mon, Oct 18, 2010 at 07:18:07AM +0800, Osier Yang wrote: * docs/intro.pod * docs/writing-tests.pod --- docs/intro.pod | 10

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-25 Thread Ruben Kerkhof
On Mon, Oct 25, 2010 at 10:48, Daniel P. Berrange berra...@redhat.com wrote: NACK, this results in 'path' being a zer-length string, so no data is copied in the next virStrcpyStatic line. The original code is correctly creating a socket in the abstract namespace, ie one which does not appear

[libvirt] [PATCH 1/2] virsh: Add option 'model' for attach-interface

2010-10-25 Thread Osier Yang
Allows to specify the NIC model type when attaching an interface, it's an optional option. --- tools/virsh.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3e37b06..2da9489 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -8292,6

[libvirt] [PATCH 2/2] virsh: update attach-interface docs

2010-10-25 Thread Osier Yang
* tools/virsh.pod (attach-interface): add docs for new option 'model' and missed option 'persistent'. --- tools/virsh.pod |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 61875af..d904800 100644 --- a/tools/virsh.pod +++

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-25 Thread Justin Clift
On 10/25/2010 07:20 PM, Ruben Kerkhof wrote: snip I haven't been able to bootstrap a build from libvirt git yet, mainly gettext issues. What are the gettext errors that happen for you? Thinking you'll need to install a newer gettext that the OSX provided one (as Homebrew does), and then make

Re: [libvirt] [PATCH v2] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-25 Thread Daniel P. Berrange
On Mon, Oct 25, 2010 at 08:13:19AM -0400, Stefan Berger wrote: Index: libvirt-acl/src/libvirt.c @@ -1544,14 +1544,11 @@ cleanup: vethDelete(veths[i]); VIR_FREE(veths[i]); } -if (rc != 0 priv-monitor != -1) { -close(priv-monitor); -

[libvirt] Changing the default for qcow2 creation

2010-10-25 Thread Matthew Booth
I've recently been investigating a severe performance issue I noticed when writing to a qcow2-backed image. When virt-v2v is doing a format conversion from raw to qcow2, it does the following: 1. Create a new qcow2 image 2. Launch a libguestfs appliance (kvm) using the new image 3. Write the

Re: [libvirt] [PATCH v2] bye to close(), welcome to VIR_(FORCE_)CLOSE()

2010-10-25 Thread Stefan Berger
On Mon, 2010-10-25 at 13:44 +0100, Daniel P. Berrange wrote: On Mon, Oct 25, 2010 at 08:13:19AM -0400, Stefan Berger wrote: Index: libvirt-acl/src/libvirt.c @@ -1544,14 +1544,11 @@ cleanup: vethDelete(veths[i]); VIR_FREE(veths[i]); } -if (rc != 0

[libvirt] [PATCH] qemu: Fix detection of drive readonly option

2010-10-25 Thread Jiri Denemark
So far, readonly=on option is used when qemu supports -device. However, there are qemu versions which support readonly option with -drive although they don't have support for -device. --- src/qemu/qemu_conf.c | 12 ++- src/qemu/qemu_conf.h

Re: [libvirt] Changing the default for qcow2 creation

2010-10-25 Thread Richard W.M. Jones
On Mon, Oct 25, 2010 at 02:40:41PM +0100, Matthew Booth wrote: I've recently been investigating a severe performance issue I noticed when writing to a qcow2-backed image. When virt-v2v is doing a format conversion from raw to qcow2, it does the following: 1. Create a new qcow2 image 2.

[libvirt] [PATCH] Fix formatting of network address in iptables helpers

2010-10-25 Thread Daniel P. Berrange
The network address was being set to 192.168.122.0 instead of 192.168.122.0/24. Fix this by removing the unneccessary 'network' field from virNetworkDef and just pass the network address and netmask into the iptables APIs directly. * src/conf/network_conf.h, src/conf/network_conf.c: Remove the

Re: [libvirt] Changing the default for qcow2 creation

2010-10-25 Thread Justin Clift
On 10/26/2010 01:06 AM, Richard W.M. Jones wrote: snip 4. A metadata preallocated qcow2 file:14.5 seconds qemu-img create -f qcow2 -o preallocated=metadata test.img 300M Just tested this on a F13 host, and it didn't like the the preallocated option: $ qemu-img create -f

Re: [libvirt] [PATCH] [TCK] network: create networks and check for exected results

2010-10-25 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 08:06:36PM -0400, Stefan Berger wrote: Derived from the nwfilter test program, this one works with libvirt's networks. It creates networks from provided xml files and checks for expected configuration in iptables, running processes and virsh output using provided data

Re: [libvirt] [PATCH v2 1/2] visrh dump compression support

2010-10-25 Thread Daniel P. Berrange
On Mon, Oct 25, 2010 at 09:04:10AM +0900, KAMEZAWA Hiroyuki wrote: Sorry, email was empty.. == Add dump_image_format[] to qemu.conf and support compressed dump at virsh dump. coredump compression is important for saving disk space in an environment where multiple guest run. (In general,

Re: [libvirt] [PATCH v2 2/2] confirm compression program availability

2010-10-25 Thread Daniel P. Berrange
On Mon, Oct 25, 2010 at 09:05:29AM +0900, KAMEZAWA Hiroyuki wrote: At compression, external programs are used but it is not checked whether the program is available or not. Check it at parsing qemu.conf and find problems in early stage. The problem with doing the error check here is that it

Re: [libvirt] [PATCH v3] qemu: call drive_unplug in DetachPciDiskDevice

2010-10-25 Thread Daniel P. Berrange
On Fri, Oct 22, 2010 at 09:14:22AM -0500, Ryan Harper wrote: Currently libvirt doesn't confirm whether the guest has responded to the disk removal request. In some cases this can leave the guest with continued access to the device while the mgmt layer believes that it has been removed. With

Re: [libvirt] Changing the default for qcow2 creation

2010-10-25 Thread Richard W.M. Jones
On Tue, Oct 26, 2010 at 02:11:22AM +1100, Justin Clift wrote: On 10/26/2010 01:06 AM, Richard W.M. Jones wrote: snip 4. A metadata preallocated qcow2 file: 14.5 seconds qemu-img create -f qcow2 -o preallocated=metadata test.img 300M Just tested this on a F13 host, and it

[libvirt] [PATCH v2] [TCK] network: create networks and check for expected results

2010-10-25 Thread Stefan Berger
V2: - test cases for ipconfig, brctl added - fixed test data after after using iptables with -n Derived from the nwfilter test program, this one works with libvirt's networks. It creates networks from provided xml files and checks for expected configuration in iptables, running processes

Re: [libvirt] [PATCH] Fix formatting of network address in iptables helpers

2010-10-25 Thread Stefan Berger
On 10/25/2010 11:04 AM, Daniel P. Berrange wrote: The network address was being set to 192.168.122.0 instead of 192.168.122.0/24. Fix this by removing the unneccessary 'network' field from virNetworkDef and just pass the network address and netmask into the iptables APIs directly. *

[libvirt] List of available libvirt drivers installed?

2010-10-25 Thread Shi Jin
I am wondering if there is a way to show a list of available libvirt hypervisor drvers installed in an existing libvirt installation. I know based on the version of libvirt, I can find out supported drivers from this matrix: http://libvirt.org/hvsupport.html However, the particular

[libvirt] ping on pending patches

2010-10-25 Thread Eric Blake
I have several pending patches that are probably worth inclusion in 0.8.5; would anyone like to review them? https://www.redhat.com/archives/libvir-list/2010-October/msg00726.html - virsh help text relating to integer arguments

Re: [libvirt] Empty Domain Management docs page?

2010-10-25 Thread Eric Blake
On 10/23/2010 01:59 PM, Justin Clift wrote: Hi all, At the moment, the Domain Management page in the docs is empty: http://libvirt.org/archdomain.html Guessing it's as some kind of placeholder. Ideally, what should the contents of this page be? Maybe an overview of a rough life cycle of

Re: [libvirt] [PATCH] docs: reformated the bindings page html markup to match other pages

2010-10-25 Thread Eric Blake
On 10/23/2010 03:09 PM, Justin Clift wrote: --- Looks the same when processed, but the previous messy HTML got on my nerves while I was looking at other stuff. docs/bindings.html.in | 74 +--- 1 files changed, 51 insertions(+), 23 deletions(-)

Re: [libvirt] [PATCH] docs: added a table of contents to the first 11 docs files

2010-10-25 Thread Eric Blake
On 10/23/2010 03:54 PM, Justin Clift wrote: There are a 58 docs files, so adding an autogeneratec Table Of Contents to them all will take some time. This is the first piece of the work done. --- docs/api.html.in | 17 +++-- docs/apps.html.in | 29

Re: [libvirt] [PATCH] docs: make the location of the xml catalog file a configure option

2010-10-25 Thread Eric Blake
On 10/24/2010 01:39 AM, Justin Clift wrote: The default location for the XML catalog file, /etc/xml/catalog, used when validating the generated html docs, isn't correct for MacOS X. This commit adds an option to the configure script, allowing the default to be overridden:

Re: [libvirt] [PATCHv2] docs: install the generated html files when make install is run

2010-10-25 Thread Eric Blake
On 10/24/2010 03:34 AM, Justin Clift wrote: Previously, only the API docs were installed, rather than the complete documentation set. This commit ensures the complete documentation set is installed. --- docs/Makefile.am | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-)

Re: [libvirt] [PATCH 2/2] virsh: update attach-interface docs

2010-10-25 Thread Eric Blake
On 10/25/2010 06:00 AM, Osier Yang wrote: * tools/virsh.pod (attach-interface): add docs for new option 'model' and missed option 'persistent'. --- tools/virsh.pod |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) ACK series. -- Eric Blake ebl...@redhat.com+1-801-349-2682

Re: [libvirt] Initial working Mac OS X libvirt client build

2010-10-25 Thread Eric Blake
On 10/25/2010 05:19 AM, Ruben Kerkhof wrote: On Mon, Oct 25, 2010 at 10:48, Daniel P. Berrangeberra...@redhat.com wrote: NACK, this results in 'path' being a zer-length string, so no data is copied in the next virStrcpyStatic line. The original code is correctly creating a socket in the

[libvirt] --checksum-fill error on Ubuntu 10.04

2010-10-25 Thread Justin Clift
Hi us, Just noticed an error message when manually starting libvirtd (built from git) on Ubuntu 10.04, while checking something else: iptables v1.4.4: unknown option `--checksum-fill' It shows up in the initial default network setup: 10:40:19.807: error : virRunWithHook:855 : internal

Re: [libvirt] [PATCH v2 1/2] visrh dump compression support

2010-10-25 Thread KAMEZAWA Hiroyuki
On Mon, 25 Oct 2010 16:18:07 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Mon, Oct 25, 2010 at 09:04:10AM +0900, KAMEZAWA Hiroyuki wrote: Sorry, email was empty.. == Add dump_image_format[] to qemu.conf and support compressed dump at virsh dump. coredump compression is

Re: [libvirt] [PATCH v2 2/2] confirm compression program availability

2010-10-25 Thread KAMEZAWA Hiroyuki
On Mon, 25 Oct 2010 16:20:50 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Mon, Oct 25, 2010 at 09:05:29AM +0900, KAMEZAWA Hiroyuki wrote: At compression, external programs are used but it is not checked whether the program is available or not. Check it at parsing qemu.conf and

Re: [libvirt] [PATCHv2] virsh: improve help text where integers are expected

2010-10-25 Thread Stefan Berger
On 10/20/2010 02:30 PM, Eric Blake wrote: * tools/virsh.c (opts_freecell, opts_memtune, opts_vcpupin) (opts_setvcpus, opts_setmaxmem, opts_setmem) (opts_migrate_setmaxdowntime): Use VSH_OT_INT when only an integer is expected. (vshCmddefHelp, vshCmddefGetData): Allow mandatory VSH_OT_INT

Re: [libvirt] [PATCHv2] virsh: fix range of memtune command

2010-10-25 Thread Stefan Berger
On 10/20/2010 03:29 PM, Eric Blake wrote: * tools/virsh.c (cmdMemtune): Use long long for memory sizes. Simplify allocation, and plug memory leak. --- No need to cripple virsh with a 32-bit limit. Change from v1: fix compilation failure, rebase on top of other recent memtune fixes

Re: [libvirt] [PATCH] qemu: work around dash 0.5.5 bug in managed save

2010-10-25 Thread Stefan Berger
On 10/22/2010 07:29 PM, Eric Blake wrote: * configure.ac (VIR_WRAPPER_SHELL): Define to a replacement shell, if /bin/sh is broken on redirection. * src/qemu/qemu_monitor.h (VIR_WRAPPER_SHELL_PREFIX) (VIR_WRAPPER_SHELL_SUFFIX): New macros. * src/qemu/qemu_monitor_text.c

Re: [libvirt] [PATCH] qemu: work around dash 0.5.5 bug in managed save

2010-10-25 Thread Justin Clift
On 10/23/2010 10:29 AM, Eric Blake wrote: * configure.ac (VIR_WRAPPER_SHELL): Define to a replacement shell, if /bin/sh is broken on redirection. * src/qemu/qemu_monitor.h (VIR_WRAPPER_SHELL_PREFIX) (VIR_WRAPPER_SHELL_SUFFIX): New macros. * src/qemu/qemu_monitor_text.c

Re: [libvirt] [PATCH] docs: revamp api_extension example, using vcpu patch series

2010-10-25 Thread Stefan Berger
On 10/20/2010 12:19 PM, Eric Blake wrote: Complete patch is compressed and attached, because it is so large. But the bulk of it consisted mainly of running 'git format-patch -15 b0137887' to pick up the top of my vcpu series, then replacing the contents of docs/api_extension/ with the new

[libvirt] How to start a defined domain

2010-10-25 Thread 黄亮
I've create a domain called vm01 using Virt-Manager, the GUI tool. Now I wanna use libvirt api to control the life cycle of vm01. It went on well with shutdown and reboot, but how to start it became a problem. I was intended to get the virDomainPtr by using virDomainLookupByName api, and then

Re: [libvirt] --checksum-fill error on Ubuntu 10.04

2010-10-25 Thread Osier
caused by network filter driver depends on the newer iptables, there is no --checksum-fill option indeed in older iptables. The following commit log is from iptables git. commit 9d1b11102b53103c00b7fddf4658a4d2bdee1338 Author: Michael S. Tsirkin m...@redhat.com Date: Thu Jul 15 17:23:24 2010

Re: [libvirt] How to start a defined domain

2010-10-25 Thread Osier
- 黄亮 lancerhu...@163.com wrote: I've create a domain called vm01 using Virt-Manager, the GUI tool. Now I wanna use libvirt api to control the life cycle of vm01. It went on well with shutdown and reboot, but how to start it became a problem. I was intended to get the virDomainPtr by

Re: [libvirt] [PATCHv2] virsh: fix range of memtune command

2010-10-25 Thread Nikunj A. Dadhania
On Wed, 20 Oct 2010 13:29:45 -0600, Eric Blake ebl...@redhat.com wrote: * tools/virsh.c (cmdMemtune): Use long long for memory sizes. Simplify allocation, and plug memory leak. --- No need to cripple virsh with a 32-bit limit. Change from v1: fix compilation failure, rebase on top of