Re: [libvirt] --checksum-fill error on Ubuntu 10.04

2010-10-26 Thread Laine Stump
On 10/25/2010 07:43 PM, Justin Clift wrote: Hi us, Just noticed an error message when manually starting libvirtd (built from git) on Ubuntu 10.04, while checking something else: iptables v1.4.4: unknown option `--checksum-fill' It shows up in the initial default network setup: Yes, this

Re: [libvirt] [PATCH] qemu: work around dash 0.5.5 bug in managed save

2010-10-26 Thread Laine Stump
On 10/25/2010 08:28 PM, Justin Clift wrote: virsh # managedsave 1 Domain 1 state saved by libvirt virsh # As a usability thing though, there doesn't seem to be a matching managedrestore command in virsh, and the help managedsave command is bit light on how do we restart a saved domain?:

[libvirt] RFC: Libvirt extensions for QEMU tracing

2010-10-26 Thread Prerna Saxena
Hi, Tracing infrastructure is now a part of upstream QEMU, which allows options to choose different trace backends to handle trace-events of interest. The choice of 'simple' trace backend allows users to dynamically enable/disable trace events for a running qemu instance as well as to set

[libvirt] [PATCH] Fix documentation for virEventAddTimeout()

2010-10-26 Thread Philipp Hahn
Fix copypaste error from virEventAddHandle(). Signed-off-by: Philipp Hahn h...@univention.de --- src/util/event.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/event.h b/src/util/event.h index 4552d1a..68b06c6 100644 --- a/src/util/event.h +++

Re: [libvirt] [PATCH] Fix documentation for virEventAddTimeout()

2010-10-26 Thread Daniel Veillard
On Tue, Oct 26, 2010 at 09:25:17AM +0200, Philipp Hahn wrote: Fix copypaste error from virEventAddHandle(). Signed-off-by: Philipp Hahn h...@univention.de Ah, thanks, applied ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ dan...@veillard.com |

Re: [libvirt] [PATCH 1/2] virsh: Add option 'model' for attach-interface

2010-10-26 Thread Daniel Veillard
On Mon, Oct 25, 2010 at 08:00:23PM +0800, Osier Yang wrote: Allows to specify the NIC model type when attaching an interface, it's an optional option. --- tools/virsh.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) Okay, though we are in feature freeze I consider this a

Re: [libvirt] [PATCH] qemu: Fix detection of drive readonly option

2010-10-26 Thread Jiri Denemark
src/qemu/qemu_conf.c | 12 ++- src/qemu/qemu_conf.h |1 + tests/qemuhelpdata/kvm-83-rhel56 | 141 tests/qemuhelptest.c | 26

Re: [libvirt] [PATCH 1/2] virsh: Add option 'model' for attach-interface

2010-10-26 Thread Osier
- Daniel Veillard veill...@redhat.com wrote: On Mon, Oct 25, 2010 at 08:00:23PM +0800, Osier Yang wrote: Allows to specify the NIC model type when attaching an interface, it's an optional option. --- tools/virsh.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-)

Re: [libvirt] [PATCH v2 2/2] confirm compression program availability

2010-10-26 Thread Daniel P. Berrange
On Tue, Oct 26, 2010 at 08:45:27AM +0900, KAMEZAWA Hiroyuki wrote: On Mon, 25 Oct 2010 16:20:50 +0100 Daniel P. Berrange berra...@redhat.com wrote: On Mon, Oct 25, 2010 at 09:05:29AM +0900, KAMEZAWA Hiroyuki wrote: At compression, external programs are used but it is not checked

Re: [libvirt] [PATCH v2 1/2] visrh dump compression support

2010-10-26 Thread Daniel P. Berrange
On Tue, Oct 26, 2010 at 08:40:46AM +0900, KAMEZAWA Hiroyuki wrote: On Mon, 25 Oct 2010 16:18:07 +0100 Daniel P. Berrange berra...@redhat.com wrote: +} else { + const char *prog = qemudSaveCompressionTypeToString(compress); + const char *args[] = { + prog, +

Re: [libvirt] [PATCH] qemu: Fix detection of drive readonly option

2010-10-26 Thread Daniel P. Berrange
On Mon, Oct 25, 2010 at 03:56:58PM -0600, Eric Blake wrote: On 10/25/2010 07:47 AM, Jiri Denemark wrote: So far, readonly=on option is used when qemu supports -device. However, there are qemu versions which support readonly option with -drive although they don't have support for -device. ---

Re: [libvirt] List of available libvirt drivers installed?

2010-10-26 Thread Daniel P. Berrange
On Mon, Oct 25, 2010 at 11:30:17AM -0700, Shi Jin wrote: I am wondering if there is a way to show a list of available libvirt hypervisor drvers installed in an existing libvirt installation. I know based on the version of libvirt, I can find out supported drivers from this matrix:

Re: [libvirt] RFC: Libvirt extensions for QEMU tracing

2010-10-26 Thread Daniel P. Berrange
On Tue, Oct 26, 2010 at 12:15:30PM +0530, Prerna Saxena wrote: Hi, Tracing infrastructure is now a part of upstream QEMU, which allows options to choose different trace backends to handle trace-events of interest. The choice of 'simple' trace backend allows users to dynamically

[libvirt] [PATCH] xen: Fix domain dump

2010-10-26 Thread Jiri Denemark
Remove redundant 'live' parameter which caused an error from xend: xend.err 'Too many values for live' --- src/xen/xend_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index b90c331..bce911e 100644 ---

[libvirt] [PATCH] Avoid squashing errors during network startup cleanup path

2010-10-26 Thread Daniel P. Berrange
When failing to start a virtual network, we have to cleanup, tearing down any iptables rules. If the iptables rules were not present yet though, this raises an error, which squashes the original error we were handling. * src/network/bridge_driver.c: When failing to start a virtual network,

Re: [libvirt] [PATCH] xen: Fix domain dump

2010-10-26 Thread Stefan Berger
On 10/26/2010 06:02 AM, Jiri Denemark wrote: Remove redundant 'live' parameter which caused an error from xend: xend.err 'Too many values for live' --- src/xen/xend_internal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xend_internal.c

[libvirt] [PATCH] Don't use %.3d format for bus/addr of USB devices.

2010-10-26 Thread Diego Elio Pettenò
When using 0-prefixed numbers, QEmu will interpret them as octal numbers (as C convention says); this means that if you attach a device that has addr 10 (decimal) you're going to attach a different device. --- src/qemu/qemu_conf.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [libvirt] [PATCHv2] virsh: improve help text where integers are expected

2010-10-26 Thread Daniel Veillard
On Wed, Oct 20, 2010 at 12:30:23PM -0600, Eric Blake wrote: * tools/virsh.c (opts_freecell, opts_memtune, opts_vcpupin) (opts_setvcpus, opts_setmaxmem, opts_setmem) (opts_migrate_setmaxdowntime): Use VSH_OT_INT when only an integer is expected. (vshCmddefHelp, vshCmddefGetData): Allow

Re: [libvirt] [PATCH] docs: revamp api_extension example, using vcpu patch series

2010-10-26 Thread Daniel Veillard
On Wed, Oct 20, 2010 at 10:19:07AM -0600, Eric Blake wrote: Complete patch is compressed and attached, because it is so large. But the bulk of it consisted mainly of running 'git format-patch -15 b0137887' to pick up the top of my vcpu series, then replacing the contents of docs/api_extension/

Re: [libvirt] [PATCH] docs: added a table of contents to the first 11 docs files

2010-10-26 Thread Daniel Veillard
On Mon, Oct 25, 2010 at 03:18:47PM -0600, Eric Blake wrote: On 10/23/2010 03:54 PM, Justin Clift wrote: There are a 58 docs files, so adding an autogeneratec Table Of Contents to them all will take some time. This is the first piece of the work done. --- docs/api.html.in | 17

Re: [libvirt] [PATCH] docs: make the location of the xml catalog file a configure option

2010-10-26 Thread Daniel Veillard
On Sun, Oct 24, 2010 at 06:39:03PM +1100, Justin Clift wrote: The default location for the XML catalog file, /etc/xml/catalog, used when validating the generated html docs, isn't correct for MacOS X. Grumpf, how in hell did they break this ? /etc/xml/catalog is the result of a long fight a

Re: [libvirt] [PATCHv2] docs: install the generated html files when make install is run

2010-10-26 Thread Daniel Veillard
On Mon, Oct 25, 2010 at 03:30:49PM -0600, Eric Blake wrote: On 10/24/2010 03:34 AM, Justin Clift wrote: Previously, only the API docs were installed, rather than the complete documentation set. This commit ensures the complete documentation set is installed. --- docs/Makefile.am | 11

Re: [libvirt] [PATCH] qemu: Fix detection of drive readonly option

2010-10-26 Thread Daniel Veillard
On Tue, Oct 26, 2010 at 10:36:15AM +0100, Daniel P. Berrange wrote: On Mon, Oct 25, 2010 at 03:56:58PM -0600, Eric Blake wrote: It feels like we're burning through these flag bits rather quickly: 15 flags added since January of this year. While it doesn't affect your patch, it means that

Re: [libvirt] How to start a defined domain

2010-10-26 Thread Osier
://www.eset.com __ Information from ESET Smart Security, version of virus signature database 5563 (20101026) __ The message was checked by ESET Smart Security. http://www.eset.com -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv2] docs: install the generated html files when make install is run

2010-10-26 Thread Justin Clift
On 10/26/2010 08:30 AM, Eric Blake wrote: On 10/24/2010 03:34 AM, Justin Clift wrote: Previously, only the API docs were installed, rather than the complete documentation set. This commit ensures the complete documentation set is installed. --- docs/Makefile.am | 11 ++- 1

Re: [libvirt] [PATCHv2] docs: install the generated html files when make install is run

2010-10-26 Thread Justin Clift
On 10/27/2010 12:43 AM, Daniel Veillard wrote: snip ACK once you rewrite this as: for f in $(css) $(dot_html) $(gif) $(png); do \ $(INSTALL) -m 0644 $(srcdir)/$$f $(DESTDIR)$(HTML_DIR); done ACK too, but I smell something missing as I don't see any reference to those specific css files

Re: [libvirt] [PATCH] docs: make the location of the xml catalog file a configure option

2010-10-26 Thread Justin Clift
On 10/26/2010 08:24 AM, Eric Blake wrote: On 10/24/2010 01:39 AM, Justin Clift wrote: The default location for the XML catalog file, /etc/xml/catalog, used when validating the generated html docs, isn't correct for MacOS X. snip ACK with two nits: Thanks Eric, pushed. Addressed both nits,

Re: [libvirt] [PATCH] docs: make the location of the xml catalog file a configure option

2010-10-26 Thread Justin Clift
On 10/27/2010 12:39 AM, Daniel Veillard wrote: On Sun, Oct 24, 2010 at 06:39:03PM +1100, Justin Clift wrote: The default location for the XML catalog file, /etc/xml/catalog, used when validating the generated html docs, isn't correct for MacOS X. Grumpf, how in hell did they break this ?

Re: [libvirt] [PATCHv2] virsh: fix range of memtune command

2010-10-26 Thread Eric Blake
On 10/25/2010 11:06 PM, Nikunj A. Dadhania wrote: On Wed, 20 Oct 2010 13:29:45 -0600, Eric Blakeebl...@redhat.com wrote: * tools/virsh.c (cmdMemtune): Use long long for memory sizes. Simplify allocation, and plug memory leak. ACK Thanks; pushed. -- Eric Blake ebl...@redhat.com

Re: [libvirt] [PATCH] qemu: work around dash 0.5.5 bug in managed save

2010-10-26 Thread Eric Blake
On 10/25/2010 06:28 PM, Justin Clift wrote: On 10/23/2010 10:29 AM, Eric Blake wrote: * configure.ac (VIR_WRAPPER_SHELL): Define to a replacement shell, if /bin/sh is broken on redirection. * src/qemu/qemu_monitor.h (VIR_WRAPPER_SHELL_PREFIX) (VIR_WRAPPER_SHELL_SUFFIX): New macros. *

Re: [libvirt] [PATCHv2] virsh: improve help text where integers are expected

2010-10-26 Thread Eric Blake
On 10/25/2010 05:51 PM, Stefan Berger wrote: case VSH_OT_INT: - snprintf(buf, sizeof(buf), _(--%snumber), opt-name); + snprintf(buf, sizeof(buf), + (opt-flag VSH_OFLAG_REQ) ? _([--%s]number) + : _(--%snumber), opt-name); Looks to me like the first string (VSH_OFLAG_REQ set) should not have the

[libvirt] Libvirt.org Docs page (top level)

2010-10-26 Thread Justin Clift
Hi us, The top level libvir.org Docs page is blank: http://libvirt.org/docs.html Looks like it's only purpose is to show the menu on the left hand side, where people can click documentation headings. The completely empty page content though, kind of looks wrong, so I'm thinking we should fit

Re: [libvirt] [PATCH] Don't use %.3d format for bus/addr of USB devices.

2010-10-26 Thread Eric Blake
On 10/26/2010 06:45 AM, Diego Elio Pettenò wrote: When using 0-prefixed numbers, QEmu will interpret them as octal numbers (as C convention says); this means that if you attach a device that has addr 10 (decimal) you're going to attach a different device. --- src/qemu/qemu_conf.c |4 ++--

Re: [libvirt] Libvirt.org Docs page (top level)

2010-10-26 Thread Eric Blake
On 10/26/2010 10:00 AM, Justin Clift wrote: Hi us, The top level libvir.org Docs page is blank: http://libvirt.org/docs.html Looks like it's only purpose is to show the menu on the left hand side, where people can click documentation headings. The completely empty page content though,

[libvirt] [PATCH] build: silence configure warning if ksh is missing

2010-10-26 Thread Eric Blake
* configure.ac (lv_cv_wrapper_shell): Fix logic error if candidate shell is not available. Reported by Matthias Bolte. --- On IRC, Matthias reported a noisy configure run: eblake: checking for shell that supports redirection... ./configure: line 31581: ksh: command not found Worse, if a shell

[libvirt] [PATCHv2] build: fix shell detection bug

2010-10-26 Thread Eric Blake
A missing shell was noisy, and the use of command to decipher a shell's absolute path requires rather than ''. * configure.ac (lv_cv_wrapper_shell): Fix logic errors if candidate shell is not available. Reported by Matthias Bolte. --- configure.ac |4 ++-- 1 files changed, 2 insertions(+),

Re: [libvirt] [PATCH] qemu: Fix detection of drive readonly option

2010-10-26 Thread Eric Blake
On 10/26/2010 07:59 AM, Daniel Veillard wrote: There is a bigger problem in this area. We run 'qemu -help' every time we do any operation on the guest that requires these flags to be known. This is bad because the 'qemu' binary may not be the same qemu binary that we originally booted the guest

[libvirt] cgroups and USB passthrough devices don't work together

2010-10-26 Thread Diego Elio Pettenò
Hi all, beside the problem with USB devices I sent the patch for earlier, there is another problem that I'm not sure how to fix: the QEmu cgroup is _not_ allowed to access the device when adding it to the virtual machine. Basically it'd need a call to virCgroupAllowDevicePath() when adding the

[libvirt] [PATCH] virsh: use - not _ in memtune option names

2010-10-26 Thread Eric Blake
* tools/virsh.c (opts_memtune): All other options in virsh use - for separating words. --- tools/virsh.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index cafd304..b616eef 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2890,13

Re: [libvirt] [PATCH] qemu: Fix detection of drive readonly option

2010-10-26 Thread Daniel P. Berrange
On Tue, Oct 26, 2010 at 11:33:20AM -0600, Eric Blake wrote: On 10/26/2010 07:59 AM, Daniel Veillard wrote: There is a bigger problem in this area. We run 'qemu -help' every time we do any operation on the guest that requires these flags to be known. This is bad because the 'qemu' binary may

Re: [libvirt] [PATCH] docs: revamp api_extension example, using vcpu patch series

2010-10-26 Thread Eric Blake
On 10/25/2010 06:29 PM, Stefan Berger wrote: On 10/20/2010 12:19 PM, Eric Blake wrote: Complete patch is compressed and attached, because it is so large. But the bulk of it consisted mainly of running 'git format-patch -15 b0137887' to pick up the top of my vcpu series, then replacing the

Re: [libvirt] [PATCH] docs: revamp api_extension example, using vcpu patch series

2010-10-26 Thread Eric Blake
On 10/26/2010 01:47 PM, Eric Blake wrote: Now, all that's holding me up from pushing are server-side hooks: Total 20 (delta 6), reused 16 (delta 3) remote: docs/api_extension/0001-Step-1-of-15-add-to-xml.patch:45: space before tab in indent. Followup - Jim helped me temporarily override the

[libvirt] [PATCHv3] build: fix shell detection bug

2010-10-26 Thread Eric Blake
A missing shell was noisy, and the use of command to decipher a shell's absolute path requires rather than ''. * configure.ac (lv_cv_wrapper_shell): Fix logic errors if candidate shell is not available. Define a C string literal, not raw tokens. Reported by Matthias Bolte. --- Fixed in v3: the

[libvirt] [PATCHv2] virsh: use - not _ in memtune option names

2010-10-26 Thread Eric Blake
* tools/virsh.c (opts_memtune): All other options in virsh use - for separating words. --- v2: test correct option names in memtune implementation tools/virsh.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index

Re: [libvirt] [PATCHv3] build: fix shell detection bug

2010-10-26 Thread Matthias Bolte
2010/10/26 Eric Blake ebl...@redhat.com: A missing shell was noisy, and the use of command to decipher a shell's absolute path requires rather than ''. * configure.ac (lv_cv_wrapper_shell): Fix logic errors if candidate shell is not available.  Define a C string literal, not raw tokens.

[libvirt] [PATCH] maint: fix syntax-check failure of previous patch

2010-10-26 Thread Eric Blake
* cfg.mk (sc_prohibit_trailing_blank_lines): Delete; this is adequately covered by maint.mk's sc_prohibit_empty_lines_at_EOF. * .x-sc_prohibit_empty_lines_at_EOF: New file, to exempt raw patches. * Makefile.am (EXTRA_DIST): Include new exemption. --- I'm pushing this under the build-breaker rule,

Re: [libvirt] [PATCHv3] build: fix shell detection bug

2010-10-26 Thread Eric Blake
On 10/26/2010 03:17 PM, Matthias Bolte wrote: if test x$lv_wrapper_shell != x; then -AC_DEFINE_UNQUOTED([VIR_WRAPPER_SHELL], [$lv_wrapper_shell], +AC_DEFINE_UNQUOTED([VIR_WRAPPER_SHELL], [$lv_wrapper_shell], [Define to the absolute path of a shell that does not truncate on

Re: [libvirt] [PATCHv2] virsh: use - not _ in memtune option names

2010-10-26 Thread Eric Blake
On 10/26/2010 03:46 PM, Matthias Bolte wrote: 2010/10/26 Eric Blakeebl...@redhat.com: * tools/virsh.c (opts_memtune): All other options in virsh use - for separating words. --- v2: test correct option names in memtune implementation min_guarantee = -vshCommandOptLongLong(cmd,

Re: [libvirt] [PATCH] [TCK] network: create networks and check for exected results

2010-10-26 Thread Eric Blake
subject line: s/exected/expected/ On 10/22/2010 06:06 PM, Stefan Berger wrote: Derived from the nwfilter test program, this one works with libvirt's networks. It creates networks from provided xml files and checks for expected configuration in iptables, running processes and virsh output using

Re: [libvirt] [PATCH] [TCK] network: create networks and check for exected results

2010-10-26 Thread Stefan Berger
On 10/26/2010 07:08 PM, Eric Blake wrote: Sorry for sounding so depressing; I'm very pleased to see your efforts in providing tests for the code you've written. Even though this test is intended to be skipped on non-Linux, you still have to worry about merely parsing through the test on

[libvirt] [PATCH] qemu: check for vm after starting a job

2010-10-26 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=638285 - when migrating a guest, it was very easy to provoke a race where an application could query block information on a VM that had just been migrated away. Any time qemu code obtains a job lock, it must also check that the VM was not taken down in

Re: [libvirt] --checksum-fill error on Ubuntu 10.04

2010-10-26 Thread Justin Clift
On 10/26/2010 01:41 PM, Osier wrote: snip Could we treat the error message as warnings? or make it only works for newer iptables? Yeah, the error message that we generate is a bit misleading, since Laine says it's effectively not stopping things from working. If you know how to easily fix the

Re: [libvirt] Libvirt.org Docs page (top level)

2010-10-26 Thread Justin Clift
On 10/27/2010 03:21 AM, Eric Blake wrote: snip The completely empty page content though, kind of looks wrong, so I'm thinking we should fit it with something. Initial thought is to have an autogenerated list of all the docs pages, expanded out. Pretty much a table of contents kind of thing.

Re: [libvirt] How to start a defined domain

2010-10-26 Thread 黄亮
Smart Security, version of virus signature database 5563 (20101026) __ The message was checked by ESET Smart Security. http://www.eset.com __ Information from ESET Smart Security, version of virus signature database 5565 (20101026) __ The message was checked by ESET

Re: [libvirt] [PATCH] docs: revamp api_extension example, using vcpu patch series

2010-10-26 Thread Justin Clift
On 10/27/2010 06:54 AM, Eric Blake wrote: Now, all that's holding me up from pushing are server-side hooks: Total 20 (delta 6), reused 16 (delta 3) remote: docs/api_extension/0001-Step-1-of-15-add-to-xml.patch:45: space before tab in indent. Followup - Jim helped me temporarily override the

Re: [libvirt] [PATCH] docs: reformated the bindings page html markup to match other pages

2010-10-26 Thread Justin Clift
On 10/26/2010 08:16 AM, Eric Blake wrote: On 10/23/2010 03:09 PM, Justin Clift wrote: --- Looks the same when processed, but the previous messy HTML got on my nerves while I was looking at other stuff. docs/bindings.html.in | 74 +--- 1

Re: [libvirt] [PATCH] docs: reformated the bindings page html markup to match other pages

2010-10-26 Thread Justin Clift
On 10/27/2010 01:16 PM, Justin Clift wrote: On 10/26/2010 08:16 AM, Eric Blake wrote: On 10/23/2010 03:09 PM, Justin Clift wrote: --- Looks the same when processed, but the previous messy HTML got on my nerves while I was looking at other stuff. docs/bindings.html.in | 74

Re: [libvirt] How to start a defined domain

2010-10-26 Thread 黄亮
. http://www.eset.com __ Information from ESET Smart Security, version of virus signature database 5563 (20101026) __ The message was checked by ESET Smart Security. http://www.eset.com __ Information from ESET Smart Security, version of virus signature

[libvirt] [PATCH] docs: reworded and reordered the bindings page, plus minor tweaks

2010-10-26 Thread Justin Clift
Reordered the bindings into alphabetical order, added a link to the php-libvirt source on Github, plus gave the direct package names needed for Python usage on RHEL/Fedora, and Ubuntu. --- At some point the Windows statement on this page should be reworded or made a bit neater too. Not just yet

Re: [libvirt] [PATCH] docs: added a table of contents to the first 11 docs files

2010-10-26 Thread Justin Clift
On 10/27/2010 12:36 AM, Daniel Veillard wrote: On Mon, Oct 25, 2010 at 03:18:47PM -0600, Eric Blake wrote: On 10/23/2010 03:54 PM, Justin Clift wrote: There are a 58 docs files, so adding an autogeneratec Table Of Contents to them all will take some time. This is the first piece of the work